sufia-models 4.3.1 → 5.0.0.beta1

data/app/models/local_authority.rb

@@ -9,10 +9,10 @@ class LocalAuthority < ActiveRecord::Base
     return unless self.where(name: name).empty?
     authority = self.create(name: name)
     format = opts.fetch(:format, :ntriples)
-    predicate = opts.fetch(:predicate, RDF::SKOS.prefLabel)
+    predicate = opts.fetch(:predicate, ::RDF::SKOS.prefLabel)
     entries = []
     sources.each do |uri|
-      RDF::Reader.open(uri, format: format) do |reader|
+      ::RDF::Reader.open(uri, format: format) do |reader|
         reader.each_statement do |statement|
           if statement.predicate == predicate
             entries << LocalAuthorityEntry.new(local_authority: authority,

data/app/models/proxy_deposit_request.rb

@@ -78,7 +78,7 @@ class ProxyDepositRequest < ActiveRecord::Base
 
   def title
     return 'file not found' if deleted_file?
-    query = ActiveFedora::SolrService.construct_query_for_pids([pid])
+    query = ActiveFedora::SolrQueryBuilder.construct_query_for_ids([pid])
     solr_response = ActiveFedora::SolrService.query(query, raw: true)
     SolrDocument.new(solr_response['response']['docs'].first, solr_response).title
   end

data/app/services/sufia/id_service.rb

@@ -9,11 +9,11 @@ module Sufia
 
     @minter = ::Noid::Minter.new(template: noid_template)
     @pid = $$
-    @namespace = Sufia.config.id_namespace
+    #@namespace = Sufia.config.id_namespace
     @semaphore = Mutex.new
     def self.valid?(identifier)
       # remove the fedora namespace since it's not part of the noid
-      noid = identifier.split(":").last
+      noid = identifier#.split(":").last
       return @minter.valid? noid
     end
     def self.mint
@@ -28,20 +28,20 @@ module Sufia
     protected
 
     def self.next_id
-      pid = ''
+      id = ''
       File.open(Sufia.config.minter_statefile, File::RDWR|File::CREAT, 0644) do |f|
         f.flock(File::LOCK_EX)
         yaml = YAML::load(f.read)
         yaml = {template: noid_template} unless yaml
         minter = ::Noid::Minter.new(yaml)
-        pid = "#{@namespace}:#{minter.mint}"
+        id = minter.mint
         f.rewind
         yaml = YAML::dump(minter.dump)
         f.write yaml
         f.flush
         f.truncate(f.pos)
       end
-      return pid
+      id
     end
   end
 end

data/app/services/sufia/noid.rb

@@ -2,16 +2,14 @@ module Sufia
   module Noid
     extend ActiveSupport::Concern
 
-    module ClassMethods
-      ## This overrides the default behavior, which is to ask Fedora for a pid
-      # @see ActiveFedora::Sharding.assign_pid
-      def assign_pid(_)
-        Sufia::IdService.mint
-      end
+    ## This overrides the default behavior, which is to ask Fedora for a pid
+    # @see ActiveFedora::Sharding.assign_pid
+    def assign_pid
+      Sufia::IdService.mint
     end
 
     def noid
-      Noid.noidify(self.pid)
+      Noid.noidify(id)
     end
 
     # Redefine this for more intuitive keys in Redis
@@ -24,6 +22,11 @@ module Sufia
         String(identifier).split(":").last
       end
 
+      # Create a pairtree like path for the given identifier
+      def treeify(identifier)
+        (identifier.scan(/..?/).first(4) + [identifier]).join('/')
+      end
+
       def namespaceize(identifier)
         return identifier if identifier.include?(':')
         "#{namespace}:#{identifier}"

data/lib/generators/sufia/models/cached_stats_generator.rb

@@ -1,12 +1,30 @@
-require_relative 'abstract_migration_generator'
+# -*- encoding : utf-8 -*-
+require 'rails/generators'
+require 'rails/generators/migration'
+
+class Sufia::Models::CachedStatsGenerator < Rails::Generators::Base
+  include Rails::Generators::Migration
 
-class Sufia::Models::CachedStatsGenerator < Sufia::Models::AbstractMigrationGenerator
   source_root File.expand_path('../templates', __FILE__)
 
   desc """
 This generator adds the ability to cache usage stats to your application:
  1. Creates several database migrations if they do not exist in /db/migrate
        """
+  # Implement the required interface for Rails::Generators::Migration.
+  # taken from http://github.com/rails/rails/blob/master/activerecord/lib/generators/active_record.rb
+  def self.next_migration_number(path)
+    if @prev_migration_nr
+      @prev_migration_nr += 1
+    else
+      if last_migration = Dir[File.join(path, '*.rb')].sort.last
+        @prev_migration_nr = last_migration.sub(File.join(path, '/'), '').to_i + 1
+      else
+        @prev_migration_nr = Time.now.utc.strftime("%Y%m%d%H%M%S").to_i
+      end
+    end
+    @prev_migration_nr.to_s
+  end
 
   def banner
     say_status("warning", "ADDING STATS CACHING-RELATED SUFIA MODELS", :yellow)
@@ -14,6 +32,7 @@ This generator adds the ability to cache usage stats to your application:
 
   # Setup the database migrations
   def copy_migrations
+    # Can't get this any more DRY, because we need this order.
     [
       'create_file_view_stats.rb',
       'create_file_download_stats.rb'
@@ -21,4 +40,14 @@ This generator adds the ability to cache usage stats to your application:
       better_migration_template file
     end
   end
+
+  private
+
+  def better_migration_template(file)
+    begin
+      migration_template "migrations/#{file}", "db/migrate/#{file}"
+    rescue Rails::Generators::Error => e
+      say_status("warning", e.message, :yellow)
+    end
+  end
 end

data/lib/generators/sufia/models/install_generator.rb

@@ -1,7 +1,12 @@
-require_relative 'abstract_migration_generator'
+# -*- encoding : utf-8 -*-
+require 'rails/generators'
+require 'rails/generators/migration'
+
+class Sufia::Models::InstallGenerator < Rails::Generators::Base
+  include Rails::Generators::Migration
 
-class Sufia::Models::InstallGenerator < Sufia::Models::AbstractMigrationGenerator
   source_root File.expand_path('../templates', __FILE__)
+
   argument     :model_name, type: :string , default: "user"
   desc """
 This generator makes the following changes to your application:
@@ -14,15 +19,30 @@ This generator makes the following changes to your application:
  7. Runs full-text generator
  8. Runs proxies generator
  9. Runs cached stats generator
-10. Runs ORCID field generator
-11. Runs user stats generator
        """
+
+  # Implement the required interface for Rails::Generators::Migration.
+  # taken from http://github.com/rails/rails/blob/master/activerecord/lib/generators/active_record.rb
+  def self.next_migration_number(path)
+    if @prev_migration_nr
+      @prev_migration_nr += 1
+    else
+      if last_migration = Dir[File.join(path, '*.rb')].sort.last
+        @prev_migration_nr = last_migration.sub(File.join(path, '/'), '').to_i + 1
+      else
+        @prev_migration_nr = Time.now.utc.strftime("%Y%m%d%H%M%S").to_i
+      end
+    end
+    @prev_migration_nr.to_s
+  end
+
   def banner
     say_status("warning", "GENERATING SUFIA MODELS", :yellow)
   end
 
   # Setup the database migrations
   def copy_migrations
+    # Can't get this any more DRY, because we need this order.
     [
       "acts_as_follower_migration.rb",
       "add_social_to_users.rb",
@@ -94,13 +114,13 @@ This generator makes the following changes to your application:
     generate 'sufia:models:cached_stats'
   end
 
-  # Adds orcid field to user model
-  def orcid_field
-    generate 'sufia:models:orcid_field'
-  end
+  private
 
-  # Adds user stats-related migration & methods
-  def user_stats
-    generate 'sufia:models:user_stats'
+  def better_migration_template(file)
+    begin
+      migration_template "migrations/#{file}", "db/migrate/#{file}"
+    rescue Rails::Generators::Error => e
+      say_status("warning", e.message, :yellow)
+    end
   end
 end

data/lib/generators/sufia/models/proxies_generator.rb

@@ -1,12 +1,30 @@
-require_relative 'abstract_migration_generator'
+# -*- encoding : utf-8 -*-
+require 'rails/generators'
+require 'rails/generators/migration'
+
+class Sufia::Models::ProxiesGenerator < Rails::Generators::Base
+  include Rails::Generators::Migration
 
-class Sufia::Models::ProxiesGenerator < Sufia::Models::AbstractMigrationGenerator
   source_root File.expand_path('../templates', __FILE__)
 
   desc """
 This generator adds proxies and transfers to your application:
  1. Creates several database migrations if they do not exist in /db/migrate
        """
+  # Implement the required interface for Rails::Generators::Migration.
+  # taken from http://github.com/rails/rails/blob/master/activerecord/lib/generators/active_record.rb
+  def self.next_migration_number(path)
+    if @prev_migration_nr
+      @prev_migration_nr += 1
+    else
+      if last_migration = Dir[File.join(path, '*.rb')].sort.last
+        @prev_migration_nr = last_migration.sub(File.join(path, '/'), '').to_i + 1
+      else
+        @prev_migration_nr = Time.now.utc.strftime("%Y%m%d%H%M%S").to_i
+      end
+    end
+    @prev_migration_nr.to_s
+  end
 
   def banner
     say_status("warning", "ADDING PROXY/TRANSFER-RELATED SUFIA MODELS", :yellow)
@@ -14,6 +32,7 @@ This generator adds proxies and transfers to your application:
 
   # Setup the database migrations
   def copy_migrations
+    # Can't get this any more DRY, because we need this order.
     [
       'create_proxy_deposit_rights.rb',
       'create_proxy_deposit_requests.rb'
@@ -21,4 +40,14 @@ This generator adds proxies and transfers to your application:
       better_migration_template file
     end
   end
+
+  private
+
+  def better_migration_template(file)
+    begin
+      migration_template "migrations/#{file}", "db/migrate/#{file}"
+    rescue Rails::Generators::Error => e
+      say_status("warning", e.message, :yellow)
+    end
+  end
 end

data/lib/generators/sufia/models/templates/config/sufia.rb

@@ -93,9 +93,6 @@ Sufia.config do |config|
   # Specify a Google Analytics tracking ID to gather usage statistics
   # config.google_analytics_id = 'UA-99999999-1'
 
-  # Specify a date you wish to start collecting Google Analytic statistics for.
-  # config.analytic_start_date = DateTime.new(2014,9,10)
-
   # Where to store tempfiles, leave blank for the system temp directory (e.g. /tmp)
   # config.temp_file_base = '/home/developer1'
 
@@ -111,6 +108,16 @@ Sufia.config do |config|
   # Specify how many seconds back from the current time that we should show by default of the user's activity on the user's dashboard
   # config.activity_to_show_default_seconds_since_now = 24*60*60
 
+  # Specify a date you wish to start collecting Google Analytic statistics for.
+  # Leaving it blank will set the start date to when ever the file was uploaded by
+  # NOTE: if you have always sent analytics to GA for downloads and page views leave this commented out
+  # config.analytic_start_date = DateTime.new(2014,9,10)
+  #
+  # Method of converting pids into URIs for storage in Fedora
+  # config.translate_uri_to_id = lambda { |uri| uri.to_s.split('/')[-1] }
+  # config.translate_id_to_uri = lambda { |id|
+  #      "#{ActiveFedora.fedora.host}#{ActiveFedora.fedora.base_path}/#{Sufia::Noid.treeify(id)}" }
+
   # If browse-everything has been configured, load the configs.  Otherwise, set to nil.
   begin
     if defined? BrowseEverything

data/lib/generators/sufia/models/upgrade400_generator.rb

@@ -1,8 +1,13 @@
-require_relative 'abstract_migration_generator'
+# -*- encoding : utf-8 -*-
+require 'rails/generators'
+require 'rails/generators/migration'
+
+class Sufia::Models::Upgrade400Generator < Rails::Generators::Base
+  include Rails::Generators::Migration
 
-class Sufia::Models::Upgrade400Generator < Sufia::Models::AbstractMigrationGenerator
   source_root File.expand_path('../templates', __FILE__)
 
+  argument     :model_name, type: :string , default: "user"
   desc """
 This generator for upgrading sufia-models from 3.7.2 to 4.0 makes the following changes to your application:
  1. Creates several database migrations if they do not exist in /db/migrate
@@ -11,12 +16,28 @@ This generator for upgrading sufia-models from 3.7.2 to 4.0 makes the following
  4. Runs full-text generator
        """
 
+  # Implement the required interface for Rails::Generators::Migration.
+  # taken from http://github.com/rails/rails/blob/master/activerecord/lib/generators/active_record.rb
+  def self.next_migration_number(path)
+    if @prev_migration_nr
+      @prev_migration_nr += 1
+    else
+      if last_migration = Dir[File.join(path, '*.rb')].sort.last
+        @prev_migration_nr = last_migration.sub(File.join(path, '/'), '').to_i + 1
+      else
+        @prev_migration_nr = Time.now.utc.strftime("%Y%m%d%H%M%S").to_i
+      end
+    end
+    @prev_migration_nr.to_s
+  end
+
   def banner
     say_status("warning", "UPGRADING SUFIA MODELS", :yellow)
   end
 
   # Setup the database migrations
   def copy_migrations
+    # Can't get this any more DRY, because we need this order.
     [
       'create_tinymce_assets.rb',
       'create_content_blocks.rb',
@@ -51,4 +72,14 @@ This generator for upgrading sufia-models from 3.7.2 to 4.0 makes the following
   def full_text_indexing
     generate "sufia:models:fulltext"
   end
+
+  private
+
+  def better_migration_template(file)
+    begin
+      migration_template "migrations/#{file}", "db/migrate/#{file}"
+    rescue Rails::Generators::Error => e
+      say_status("warning", e.message, :yellow)
+    end
+  end
 end

data/lib/sufia/models/engine.rb

@@ -31,6 +31,10 @@ module Sufia
       # Defaulting analytic start date to when ever the file was uploaded by leaving it blank
       config.analytic_start_date = nil
 
+      config.translate_uri_to_id = lambda { |uri| uri.to_s.split('/')[-1] }
+      config.translate_id_to_uri = lambda { |id|
+        "#{ActiveFedora.fedora.host}#{ActiveFedora.fedora.base_path}/#{Sufia::Noid.treeify(id)}" }
+
       config.autoload_paths += %W(
         #{config.root}/app/models/datastreams
       )
@@ -58,10 +62,15 @@ module Sufia
       end
 
       initializer 'configure' do
-        Hydra::Derivatives.ffmpeg_path    = Sufia.config.ffmpeg_path
-        Hydra::Derivatives.temp_file_base = Sufia.config.temp_file_base
-        Hydra::Derivatives.fits_path      = Sufia.config.fits_path
-        Hydra::Derivatives.enable_ffmpeg  = Sufia.config.enable_ffmpeg
+        Sufia.config.tap do |c|
+          Hydra::Derivatives.ffmpeg_path    = c.ffmpeg_path
+          Hydra::Derivatives.temp_file_base = c.temp_file_base
+          Hydra::Derivatives.fits_path      = c.fits_path
+          Hydra::Derivatives.enable_ffmpeg  = c.enable_ffmpeg
+
+          ActiveFedora::Base.translate_uri_to_id = c.translate_uri_to_id
+          ActiveFedora::Base.translate_id_to_uri = c.translate_id_to_uri
+        end
       end
     end
   end

data/lib/sufia/models/file_content/versions.rb

@@ -1,23 +1,27 @@
 module Sufia
   module FileContent
     module Versions
-      def get_version(version_id)
-        self.versions.select { |v| v.versionID == version_id}.first
+      extend ActiveSupport::Concern
+
+      included do
+        has_many_versions
       end
 
       def latest_version
-        self.versions.first
+        versions.last.label unless versions.empty?
       end
 
       def version_committer(version)
-        vc = VersionCommitter.where(obj_id: version.pid,
-                                    datastream_id: version.dsid,
-                                    version_id: version.versionID)
+        vc = VersionCommitter.where(version_id: version)
         return vc.empty? ? nil : vc.first.committer_login
       end
 
-
+      def save
+        super.tap do |passing|
+          create_version if passing
+        end
+      end
+      
     end
   end
 end
-

data/lib/sufia/models/version.rb

@@ -1,5 +1,5 @@
 module Sufia
   module Models
-    VERSION = "4.3.1"
+    VERSION = "5.0.0.beta1"
   end
 end

data/lib/sufia/permissions/writable.rb

@@ -8,32 +8,50 @@ module Sufia
       include Hydra::AccessControls::Visibility
 
       included do
-        has_metadata "rightsMetadata", type: ParanoidRightsDatastream
         validate :paranoid_permissions
       end
 
       def paranoid_permissions
-        # let the rightsMetadata ds make this determination
-        # - the object instance is passed in for easier access to the props ds
-        rightsMetadata.validate(self)
+        valid = true
+        VALIDATIONS.each do |validation|
+          if validation[:condition].call(self)
+            errors[validation[:key]] ||= []
+            errors[validation[:key]] << validation[:message]
+            valid = false
+          end
+        end
+        return valid
       end
 
-      ## Updates those permissions that are provided to it. Does not replace any permissions unless they are provided
-      def permissions=(params)
-        perm_hash = permission_hash
-        params[:new_user_name].each { |name, access| perm_hash['person'][name] = access } if params[:new_user_name].present?
-        params[:new_group_name].each { |name, access| perm_hash['group'][name] = access } if params[:new_group_name].present?
+      VALIDATIONS = [
+        {key: :edit_users, message: 'Depositor must have edit access', condition: lambda { |obj| !obj.edit_users.include?(obj.depositor) }},
+        {key: :edit_groups, message: 'Public cannot have edit access', condition: lambda { |obj| obj.edit_groups.include?('public') }},
+        {key: :edit_groups, message: 'Registered cannot have edit access', condition: lambda { |obj| obj.edit_groups.include?('registered') }}
+      ]
 
-        params[:user].each { |name, access| perm_hash['person'][name] = access} if params[:user]
-        params[:group].each { |name, access| perm_hash['group'][name] = access if ['read', 'edit'].include?(access)} if params[:group]
 
-        rightsMetadata.update_permissions(perm_hash)
+      def clear_permissions!
+        self.permissions = []
       end
 
-      def permissions
-        perms = super
-        perms.map {|p| { name: p.name, access: p.access, type:p.type } }
-      end
+      ## Updates those permissions that are provided to it. Does not replace any permissions unless they are provided
+      # def permissions=(params)
+      #   raise "Fixme #{params}"
+      #   perm_hash = permission_hash
+      #   params[:new_user_name].each { |name, access| perm_hash['person'][name] = access } if params[:new_user_name].present?
+      #   params[:new_group_name].each { |name, access| perm_hash['group'][name] = access } if params[:new_group_name].present?
+
+      #   params[:user].each { |name, access| perm_hash['person'][name] = access} if params[:user]
+      #   params[:group].each { |name, access| perm_hash['group'][name] = access if ['read', 'edit'].include?(access)} if params[:group]
+
+      #   # rightsMetadata.update_permissions(perm_hash)
+      # end
+
+      # def permissions
+      #   raise "Fixme "
+      #   perms = super
+      #   perms.map {|p| { name: p.name, access: p.access, type:p.type } }
+      # end
 
       private