sudojs-rails 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee9300e874fa0fdcd967acbc29597e642ffd823b
-  data.tar.gz: 200973d4c5bb4f220e06a1d566f060310924b795
+  metadata.gz: 8ce00bbcc867422371ddb22d8105e34d97ac4b5f
+  data.tar.gz: 223bafb13bd62591e3d048c3e0b7de721115f6e9
 SHA512:
-  metadata.gz: 9ba5c7d810fbde242a538aa14f6a8972aed7f9ec8462632a8790f87e7432e6171512d24dfb4bdd26e06d0fc6a63e6b584c70ccc7aca51fd56005c091c672b766
-  data.tar.gz: 5bd6329229084695d1706991b6a5fc9996f20705cc24210e8b6392e10660bbd6ba867f0c996cc9092af5d7f0018f49147bdbf18a0b5ba491d0932a82da9d1c80
+  metadata.gz: 162bf0d1c377bb2b5b1dbcec422d12536f2ad6d43e7bcd3a9f65b703446c030afa50992dcb168dd3e485f3643f51ec39ae9e93895836fc8d1d6f2181245dd3e3
+  data.tar.gz: bc2fcbdc78e33b4d0805af2a601535db81032b043fa97a1ac139946a2879d5b768f9b16e0908f3f2b8de33c568b6814ae972ca1c4bf8a0c5598d538797cf8d59

data/lib/sudojs/version.rb

@@ -1,3 +1,3 @@
 module Sudojs
-  VERSION = '0.5.4'
+  VERSION = '0.5.5'
 end

data/vendor/assets/javascripts/sudojs/sudo.js

@@ -770,16 +770,14 @@ sudo.DataView = function(el, data) {
   sudo.View.call(this, el, data);
   // implements the listener extension
   $.extend(this, sudo.extensions.listener);
-  // dataview's models are observable, make it so if not already
-  if(!this.model.observe) $.extend(this.model, sudo.extensions.observable);
-  // dont autoRender on the setting of events,
-  // add to this to prevent others if needed
-  this.autoRenderBlacklist = {event: true, events: true};
-  // if autorendering, observe your own model
-  // use this ref to unobserve if desired
-  if(this.model.data.autoRender) this.observer = this.model.observe(this.render.bind(this));
-  // only call the initial build if not an autoRender type
-  else this.build();
+  if(this.model.data.autoRender) {
+    // dont autoRender on the setting of events,
+    this.autoRenderBlacklist = {event: true, events: true};
+    // autoRender types observe their own model
+    if(!this.model.observe) $.extend(this.model, sudo.extensions.observable);
+    // you may need to override `build` if you provide a template and the data
+    // isnt hydrated (as that is the expectation)
+  } else this.build();
   if(this.role === 'dataview') this.init();
 };
 // `private`
@@ -790,8 +788,10 @@ sudo.inherit(sudo.View, sudo.DataView);
 // if not an autoRender (which will render on model change), as well as setup the events (in children too)
 sudo.DataView.prototype.addedToParent = function(parent) {
   this.bindEvents();
-  // autoRender Dataviews should only render on model change
+  // non-autoRender types should render now
   if(!this.model.data.autoRender) return this.render();
+  // autoRender Dataviews should only render on model change
+  else this.observer = this.model.observe(this.render.bind(this));
   return this;
 };
 // ###build
@@ -819,6 +819,8 @@ sudo.DataView.prototype.build = function build() {
 sudo.DataView.prototype.removeFromParent = function removeFromParent(keep) {
   this.parent.removeChild(this);
   this.unbindEvents().$el[keep ? 'detach' : 'remove']();
+  // in the case that this.model is 'foreign'
+  if(this.observer) this.model.unobserve(this.observer);
   return this;
 };
 // ###render
@@ -833,15 +835,14 @@ sudo.DataView.prototype.removeFromParent = function removeFromParent(keep) {
 //
 // `returns` {Object} `this`
 sudo.DataView.prototype.render = function render(change) {
-  var d;
   // return early if a `blacklisted` key is set to my model
   if(change && this.autoRenderBlacklist[change.name]) return this;
-  d = this.model.data;
   // has `build` been executed already? If not call it again
   if(!this.built) this.build();
   // if there is no template by this point *you are doing it wrong*
   // erase the flag
   else this.built = false;
+  d = this.model.data;
   if(d.renderTarget) {
     this._normalizedEl_(d.renderTarget)[d.renderMethod || 'append'](this.$el);
     delete d.renderTarget;
@@ -1468,6 +1469,7 @@ sudo.extensions.persistable = {
   //
   // `param` {string} `base` the baseUrl set in this models ajax options
   url: function url(base) {
+    if(!base) return void 0;
     // could possibly be 0...
     if('id' in this.data) {
       return base + (base.charAt(base.length - 1) === '/' ? 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sudojs-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - robrobbins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-08 00:00:00.000000000 Z
+date: 2013-08-24 00:00:00.000000000 Z
 dependencies: []
 description: Install the latest versions of sudo.js and provide generators for fast
   and easy use.