sudo_rails 0.4.2 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e04886523eeb3e505d51589c8c81977f44b18f301c232aae316e31f0381408ab
-  data.tar.gz: 264ee3d57e0dbfe2c32cdf0b74d11d354885e51a4725b994d3c0fa78b03d8d7d
+  metadata.gz: 6ed6d190a51d927747f58d7ce61af01b6dd8ab0edff663969773ebbbebd21b37
+  data.tar.gz: 85f9dc0920bdc8226b36053b06c4304b45b55f90a4735b22faed4334a7a87ad1
 SHA512:
-  metadata.gz: c30d7a962a06ba9919ec3950f12c1c6adae42657e4859e87e99ed7df88c79222399a122cf5feed55e876340315efabe23a232ec7f1ec611473cd44768a79eb7c
-  data.tar.gz: b8f58cda73240aabb8ea75e0e14fd29157384d54a2feeb2b9421f9796f15cd128224e47409fd9c8fca7b236ac38961b65cc7ca61413aa82e1d17c449798c305f
+  metadata.gz: ef19bd450721d754b582ebe425dcdf30e91758089593743ed16fadd2400ac4cb2e898e336000a840fed37ac69124138cf5105953ff2342cdf3b37b45c6295196
+  data.tar.gz: 76a63a6de298a85130286495533149325a752c772bcf0a4d3d33ccb20e9645563397c9dca75f0c9174f46e9924b02d58b89a4de5919067ffd2f00cd2cd540bf7

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright 2019 Marc Anguera Insa @markets
+Copyright 2019-2020 Marc Anguera Insa @markets
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,7 +1,7 @@
 # Sudo Rails
 
 [![Gem](https://img.shields.io/gem/v/sudo_rails.svg?style=flat-square)](https://rubygems.org/gems/sudo_rails)
-[![Build Status](https://travis-ci.org/markets/sudo_rails.svg)](https://travis-ci.org/markets/sudo_rails)
+[![Build Status](https://travis-ci.com/markets/sudo_rails.svg?branch=master)](https://travis-ci.com/markets/sudo_rails)
 [![Maintainability](https://api.codeclimate.com/v1/badges/322350adc7ab052beccb/maintainability)](https://codeclimate.com/github/markets/sudo_rails/maintainability)
 
 > Sudo mode for your Rails controllers
@@ -71,12 +71,20 @@ SudoRails.setup do |config|
 end
 ```
 
+### Sudo sessions
+
+Using the `sudo_session_duration` option you are able to configure the `sudo` session duration (30 minutes by default).
+
+If you set it to `nil`, your `sudo` session won't expire automatically and you will have to do it manually by using the `reset_sudo_session!` helper.
+
 ### Styling
 
 Using the `custom_logo`, `primary_color` and `background_color` options, you can customize the confirmation page. In case you want full control of the styles, you can use your own layout (and consequently your own styles too) using the `layout` option.
 
 See some [examples here](support/images/).
 
+**NOTE** If you are using your own layout, don't forget to render the flash messages in that layout. You can do something like [this](app/views/sudo_rails/_flash_alert.html.erb).
+
 ### Confirmation strategy
 
 You should define how to validate the password using the `confirm_strategy` option. It must be a `lambda`, which will receive 2 arguments: the controller instance (`context`) and the password from the user.

data/app/assets/stylesheets/sudo_rails/application.scss

@@ -2,7 +2,7 @@ body {
   text-align: center;
   font-family: Helvetica, Arial, sans-serif;
   background-color: #ececec;
-  transform: translateY(20%);
+  margin: 0 auto;
 }
 
 a {
@@ -13,6 +13,10 @@ input {
   -webkit-appearance: none;
 }
 
+.sudo-container {
+  transform: translateY(25%);
+}
+
 .sudo-header {
   margin: 2em auto;
 
@@ -54,4 +58,11 @@ input {
 .sudo-tip {
   margin-top: 2em;
   font-size: 14px;
-}
+}
+
+.sudo-alert {
+  background: #000;
+  color: #fff;
+  padding: 10px;
+  font-weight: bold;
+}

data/app/controllers/sudo_rails/application_controller.rb

@@ -3,12 +3,13 @@ module SudoRails
     before_action :sudo_enabled?
 
     def confirm
-      if request.post? && SudoRails.confirm?(self, params[:password])
+      if SudoRails.confirm?(self, params[:password])
         session[:sudo_session] = Time.zone.now.to_s
-        redirect_to params[:target_path]
       else
-        render 'sudo_rails/confirm_form', layout: SudoRails.get_layout
+        flash[:alert] = I18n.t('sudo_rails.invalid_pass', locale: params[:locale])
       end
+
+      redirect_to params[:target_path]
     end
 
     private

data/app/views/layouts/sudo_rails/application.html.erb

@@ -7,6 +7,9 @@
   <%= render 'sudo_rails/inject_custom_styles' if SudoRails.custom_styles? %>
 </head>
 <body>
-  <%= yield %>
+  <%= render 'sudo_rails/flash_alert' %>
+  <div class="sudo-container">
+    <%= yield %>
+  </div>
 </body>
 </html>

data/app/views/sudo_rails/_flash_alert.html.erb

@@ -0,0 +1,5 @@
+<% if flash[:alert].present? %>
+  <div class="sudo-alert">
+    <span><%= flash[:alert] %></span>
+  </div>
+<% end %>

data/app/views/sudo_rails/_inject_custom_styles.html.erb

@@ -4,6 +4,11 @@
       background-color: <%= SudoRails.background_color %>;
       color: <%= SudoRails.color_contrast(SudoRails.background_color) %>;
     }
+
+    .sudo-alert {
+      background-color: <%= SudoRails.color_contrast(SudoRails.background_color) %>;
+      color: <%= SudoRails.background_color %>;
+    }
   <% end %>
 
   <% if SudoRails.primary_color.present? %>
@@ -16,4 +21,4 @@
       color: <%= SudoRails.color_contrast(SudoRails.primary_color) %>;
     }
   <% end %>
-</style>
+</style>

data/app/views/sudo_rails/confirm_form.html.erb

@@ -1,13 +1,14 @@
-<header class='sudo-header'>
+<div class='sudo-header'>
   <% if SudoRails.custom_logo %>
     <%= image_tag SudoRails.custom_logo %>
   <% end %>
 
   <h2><%= t('sudo_rails.page_header') %></h2>
-</header>
+</div>
 
 <div class='sudo-form'>
   <%= form_tag '/sudo_rails/confirm' do |f| %>
+    <%= hidden_field_tag :locale, I18n.locale %>
     <%= hidden_field_tag :target_path, params[:target_path] || request.url %>
     <%= password_field_tag :password, nil, required: true, placeholder: t('sudo_rails.password') %>
     <%= submit_tag t('sudo_rails.button') %>
@@ -18,6 +19,8 @@
   <% end %>
 </div>
 
-<div class='sudo-tip'>
-  <%= t('sudo_rails.tip', session_duration: time_ago_in_words(SudoRails.sudo_session_duration.ago)).html_safe %>
-</div>
+<% unless SudoRails.sudo_session_duration.nil? %>
+  <div class='sudo-tip'>
+    <%= t('sudo_rails.tip', session_duration: time_ago_in_words(SudoRails.sudo_session_duration.ago)).html_safe %>
+  </div>
+<% end %>

data/config/locales/en.yml

@@ -4,6 +4,7 @@ en:
     button: Confirm password
     password: Password
     forgot_pass: Forgot your password?
+    invalid_pass: Invalid password
     tip: |-
       You are entering <b>sudo mode</b>.<br>
       We won’t ask for your password again for <i>%{session_duration}</i>.

data/lib/sudo_rails.rb

@@ -30,6 +30,7 @@ module SudoRails
 
     def valid_sudo_session?(started_at)
       return false unless started_at
+      return true if sudo_session_duration.nil?
 
       DateTime.parse(started_at) + sudo_session_duration > Time.zone.now
     end

data/lib/sudo_rails/engine.rb

@@ -10,7 +10,7 @@ module SudoRails
 
     initializer 'sudo_rails.routes' do |app|
       app.routes.append do
-        match '/sudo_rails/confirm' => 'sudo_rails/application#confirm', via: [:get, :post]
+        post '/sudo_rails/confirm' => 'sudo_rails/application#confirm'
       end
     end
 

data/lib/sudo_rails/version.rb

@@ -1,3 +1,3 @@
 module SudoRails
-  VERSION = "0.4.2"
+  VERSION = "0.6.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sudo_rails
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.6.1
 platform: ruby
 authors:
 - markets
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-03 00:00:00.000000000 Z
+date: 2020-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -65,6 +65,7 @@ files:
 - app/assets/stylesheets/sudo_rails/application.scss
 - app/controllers/sudo_rails/application_controller.rb
 - app/views/layouts/sudo_rails/application.html.erb
+- app/views/sudo_rails/_flash_alert.html.erb
 - app/views/sudo_rails/_inject_custom_styles.html.erb
 - app/views/sudo_rails/confirm_form.html.erb
 - config/locales/en.yml
@@ -94,8 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Sudo mode for Rails