sucker_punch 2.1.2 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b584388415071f977d554aa3d9e8128521c08a3b4299492e349bfbc5dc865f5
-  data.tar.gz: c77e1a8b773e712f2ec67c311e3f00bfe16fbcd8c79afc028c44b879d93c943d
+  metadata.gz: e1edad787473a077f23f2fae95150cdb92e3834a12150fbd4d910fade5692516
+  data.tar.gz: 4ba7b7fa6cf3a1c99706a3bda43b0fd2fc291ae1825a23466b00a5b7a3354003
 SHA512:
-  metadata.gz: 67bb1e1d9b05432f8e868451cfbd846ea29871887ee807fc398067e10e9db2305abdf891c44e9453e822063f7599bb2f7f45535b3440287ecbdf0e7e8e688b9a
-  data.tar.gz: e6e86dccf04e992c61369369e78e6ff7a7ab1239e9713800c7fcda1f62ed7996e451ed0053bfe1b595e6d1dd268c7853cf6aa5da8efcd8e852e2319e4a36c57c
+  metadata.gz: a8184cafe29937ad818920951c3c760e8435b4e35a348e27629053bae1b56e2f44ab412154fb3769e6878034a9351ad5e60fb44d9385bf5bb4f2bf58cc91c71c
+  data.tar.gz: fde16057612312085f59a955e783007b6a0cf0b4ff7d08312963bc0c76b3be2e5d254e5eb1df1625db3c554403485e5df8a1c995ab50b71dda4e1358b00e8d23

data/CHANGES.md

@@ -1,3 +1,7 @@
+3.0.0
+-------
+- Add support for keyword arguments in ruby `>= 3.0`. More details in [release notes](https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/).
+
 2.1.1
 -------
 - Relax versioning constraint of `concurrent-ruby` to make way for 1.1 release

data/lib/sucker_punch/async_syntax.rb

@@ -10,9 +10,8 @@ module SuckerPunch
       @job = job
     end
 
-    def perform(*args)
-      @job.class.perform_async(*args)
+    def perform(*args, **kwargs)
+      @job.class.perform_async(*args, **kwargs)
     end
   end
 end
-

data/lib/sucker_punch/job.rb

@@ -32,17 +32,17 @@ module SuckerPunch
     end
 
     module ClassMethods
-      def perform_async(*args)
+      def perform_async(*args, **kwargs)
         return unless SuckerPunch::RUNNING.true?
         queue = SuckerPunch::Queue.find_or_create(self.to_s, num_workers, num_jobs_max)
-        queue.post(args) { |job_args| __run_perform(*job_args) }
+        queue.post { __run_perform(*args, **kwargs) }
       end
 
-      def perform_in(interval, *args)
+      def perform_in(interval, *args, **kwargs)
         return unless SuckerPunch::RUNNING.true?
         queue = SuckerPunch::Queue.find_or_create(self.to_s, num_workers, num_jobs_max)
         job = Concurrent::ScheduledTask.execute(interval.to_f, args: args, executor: queue) do
-          __run_perform(*args)
+          __run_perform(*args, **kwargs)
         end
         job.pending?
       end
@@ -55,14 +55,20 @@ module SuckerPunch
         self.num_jobs_max = num
       end
 
-      def __run_perform(*args)
+      def __run_perform(*args, **kwargs)
         SuckerPunch::Counter::Busy.new(self.to_s).increment
-        result = self.new.perform(*args)
+
+        result = if RUBY_VERSION >= '2.5'
+                   self.new.perform(*args, **kwargs)
+                 else
+                   self.new.perform(*args, *(kwargs.any? ? [kwargs] : nil))
+                 end
+
         SuckerPunch::Counter::Processed.new(self.to_s).increment
         result
       rescue => ex
         SuckerPunch::Counter::Failed.new(self.to_s).increment
-        SuckerPunch.exception_handler.call(ex, self, args)
+        SuckerPunch.exception_handler.call(ex, self, [*args, **kwargs])
       ensure
         SuckerPunch::Counter::Busy.new(self.to_s).decrement
       end

data/lib/sucker_punch/queue.rb

@@ -24,7 +24,7 @@ module SuckerPunch
             max_threads: num_workers,
             max_queue: num_jobs_max || DEFAULT_MAX_QUEUE_SIZE
           )
-        Concurrent::ThreadPoolExecutor.new(options)
+        Concurrent::ThreadPoolExecutor.new(**options)
       end
 
       new(name, pool)
@@ -165,10 +165,10 @@ module SuckerPunch
       SuckerPunch::Counter::Failed.new(name).value
     end
 
-    def post(*args, &block)
+    def post(*args, **kwargs, &block)
       synchronize do
         if @running
-          @pool.post(*args, &block)
+          @pool.post(*args, **kwargs, &block)
         else
           false
         end
@@ -191,4 +191,3 @@ module SuckerPunch
     end
   end
 end
-

data/lib/sucker_punch/testing.rb

@@ -30,7 +30,7 @@ module SuckerPunch
   end
 
   class Queue
-    def self.find_or_create(name, number_workers = 2, num_jobs_max = nil)
+    def self.find_or_create(name, _number_workers = 2, _num_jobs_max = nil)
       QUEUES.fetch_or_store(name) do
         []
       end

data/lib/sucker_punch/testing/inline.rb

@@ -17,7 +17,7 @@ require 'sucker_punch'
 #
 # Include inline testing lib:
 #
-# require 'sucker_punch/testing/inline"
+# require 'sucker_punch/testing/inline'
 #
 # LogJob.perform_async(1, 2, 3) is now synchronous
 # LogJob.perform_in(1, 2, 3) is now synchronous
@@ -25,12 +25,12 @@ require 'sucker_punch'
 module SuckerPunch
   module Job
     module ClassMethods
-      def perform_async(*args)
-        self.new.perform(*args)
+      def perform_async(*args, **kwargs)
+        self.new.perform(*args, **kwargs)
       end
 
-      def perform_in(_, *args)
-        self.new.perform(*args)
+      def perform_in(_, *args, **kwargs)
+        self.new.perform(*args, **kwargs)
       end
     end
   end

data/lib/sucker_punch/version.rb

@@ -1,3 +1,3 @@
 module SuckerPunch
-  VERSION = "2.1.2"
+  VERSION = "3.0.0"
 end

data/test/sucker_punch/job_test.rb

@@ -182,4 +182,3 @@ module SuckerPunch
     end
   end
 end
-

data/test/sucker_punch/queue_test.rb

@@ -136,9 +136,9 @@ module SuckerPunch
         @signals = []
       end
 
-      def post(*args, &block)
+      def post(*args, **kwargs, &block)
         if block_given?
-          block.call(args)
+          block.call(args, **kwargs)
         end
       end
 

data/test/sucker_punch_test.rb

@@ -41,7 +41,7 @@ class SuckerPunchTest < Minitest::Test
   end
 
   def test_exception_handler_can_be_set
-    SuckerPunch.exception_handler = -> (ex, _, _) { raise "bad stuff" }
+    SuckerPunch.exception_handler = -> (_ex, _, _) { raise "bad stuff" }
     assert_raises(::RuntimeError) { SuckerPunch.exception_handler.call(StandardError.new("bad"), nil, nil) }
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sucker_punch
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 3.0.0
 platform: ruby
 authors:
 - Brandon Hilkert
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-05-16 00:00:00.000000000 Z
+date: 2021-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -123,8 +123,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Sucker Punch is a Ruby asynchronous processing using concurrent-ruby, heavily
   influenced by Sidekiq and girl_friday.