sucker 1.1.4 → 1.2.0

data/lib/sucker/version.rb

@@ -1,3 +1,3 @@
 module Sucker #:nodoc:
-  VERSION = "1.1.4"
+  VERSION = '1.2.0'
 end

data/spec/fixtures/cassette_library/{unit → spec}/sucker/request.yml

@@ -2,7 +2,7 @@
 - !ruby/struct:VCR::HTTPInteraction 
   request: !ruby/struct:VCR::Request 
     method: :get
-    uri: http://ecs.amazonaws.com:80/onca/xml?AWSAccessKeyId=key&AssociateTag=&Service=AWSECommerceService&Signature=KhbhltMa2lob8mGADxdK7GjHHWHAe4sLkbs7h7Xto3M=&Timestamp=2010-12-15T07:14:37Z&Version=2010-09-01
+    uri: http://ecs.amazonaws.com:80/onca/xml?AWSAccessKeyId=key&AssociateTag=&Service=AWSECommerceService&Signature=5sbmkIO1PqtCCUH0Ih9Fx/3q9ER1FuXk2UPFLlISrIQ=&Timestamp=2011-01-17T15:20:03Z&Version=2010-11-01
     body: 
     headers: 
   response: !ruby/struct:VCR::Response 
@@ -11,13 +11,13 @@
       message: OK
     headers: 
       date: 
-      - Wed, 15 Dec 2010 07:14:37 GMT
+      - Mon, 17 Jan 2011 15:20:05 GMT
       server: 
       - Server
       x-amz-id-1: 
-      - 0E8S4ENZ8Q9WBHRS7211
+      - 1218DXHJBXZ5J480J8QM
       x-amz-id-2: 
-      - 4r6BnL5Ix6csd4KWILexsqszhPU99B63G0hcnRHvPww=
+      - SJpoXux3oMHHhZyjDxwhVVy8JrcptMTdzE1nK8SxSm0=
       nncoection: 
       - close
       - close

data/spec/fixtures/cassette_library/spec/sucker/response.yml

@@ -0,0 +1,26 @@
+--- 
+- !ruby/struct:VCR::HTTPInteraction 
+  request: !ruby/struct:VCR::Request 
+    method: :get
+    uri: http://ecs.amazonaws.com:80/onca/xml?AWSAccessKeyId=0ZVSQ33MDFPQS8H2PM02&AssociateTag=&IdType=ASIN&ItemId=0816614024,0143105825&Operation=ItemLookup&Service=AWSECommerceService&Signature=mb2SRZUnxqPRrI4SdOLZqkCmm5HjXE2Urd0PIr/vzWU=&Timestamp=2011-01-17T15:20:11Z&Version=2010-11-01
+    body: 
+    headers: 
+  response: !ruby/struct:VCR::Response 
+    status: !ruby/struct:VCR::ResponseStatus 
+      code: 200
+      message: OK
+    headers: 
+      date: 
+      - Mon, 17 Jan 2011 15:20:12 GMT
+      server: 
+      - Server
+      content-type: 
+      - text/xml;charset=UTF-8
+      vary: 
+      - Accept-Encoding,User-Agent
+      nncoection: 
+      - close
+      transfer-encoding: 
+      - chunked
+    body: "<?xml version=\"1.0\" ?><ItemLookupResponse xmlns=\"http://webservices.amazon.com/AWSECommerceService/2010-11-01\"><OperationRequest><RequestId>c5f72c52-3206-4a9f-a30f-a58e1a5f4445</RequestId><Arguments><Argument Name=\"Operation\" Value=\"ItemLookup\"></Argument><Argument Name=\"Service\" Value=\"AWSECommerceService\"></Argument><Argument Name=\"Signature\" Value=\"mb2SRZUnxqPRrI4SdOLZqkCmm5HjXE2Urd0PIr/vzWU=\"></Argument><Argument Name=\"AssociateTag\"></Argument><Argument Name=\"Version\" Value=\"2010-11-01\"></Argument><Argument Name=\"ItemId\" Value=\"0816614024,0143105825\"></Argument><Argument Name=\"IdType\" Value=\"ASIN\"></Argument><Argument Name=\"AWSAccessKeyId\" Value=\"0ZVSQ33MDFPQS8H2PM02\"></Argument><Argument Name=\"Timestamp\" Value=\"2011-01-17T15:20:11Z\"></Argument></Arguments><RequestProcessingTime>0.0103990000000000</RequestProcessingTime></OperationRequest><Items><Request><IsValid>True</IsValid><ItemLookupRequest><Condition>New</Condition><DeliveryMethod>Ship</DeliveryMethod><IdType>ASIN</IdType><MerchantId>Amazon</MerchantId><OfferPage>1</OfferPage><ItemId>0816614024</ItemId><ItemId>0143105825</ItemId><ResponseGroup>Small</ResponseGroup><ReviewPage>1</ReviewPage><ReviewSort>-SubmissionDate</ReviewSort><VariationPage>All</VariationPage></ItemLookupRequest></Request><Item><ASIN>0816614024</ASIN><DetailPageURL>http://www.amazon.com/Thousand-Plateaus-Schizophrenia-Gilles-Deleuze/dp/0816614024%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D165953%26creativeASIN%3D0816614024</DetailPageURL><ItemLinks><ItemLink><Description>Technical Details</Description><URL>http://www.amazon.com/Thousand-Plateaus-Schizophrenia-Gilles-Deleuze/dp/tech-data/0816614024%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>Add To Baby Registry</Description><URL>http://www.amazon.com/gp/registry/baby/add-item.html%3Fasin.0%3D0816614024%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>Add To Wedding Registry</Description><URL>http://www.amazon.com/gp/registry/wedding/add-item.html%3Fasin.0%3D0816614024%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>Add To Wishlist</Description><URL>http://www.amazon.com/gp/registry/wishlist/add-item.html%3Fasin.0%3D0816614024%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>Tell A Friend</Description><URL>http://www.amazon.com/gp/pdp/taf/0816614024%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>All Customer Reviews</Description><URL>http://www.amazon.com/review/product/0816614024%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink><ItemLink><Description>All Offers</Description><URL>http://www.amazon.com/gp/offer-listing/0816614024%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0816614024</URL></ItemLink></ItemLinks><ItemAttributes><Author>Gilles Deleuze</Author><Creator Role=\"Contributor\">Felix Guattari</Creator><Manufacturer>Univ Of Minnesota Press</Manufacturer><ProductGroup>Book</ProductGroup><Title>Thousand Plateaus: Capitalism and Schizophrenia</Title></ItemAttributes></Item><Item><ASIN>0143105825</ASIN><DetailPageURL>http://www.amazon.com/Anti-Oedipus-Capitalism-Schizophrenia-Penguin-Classics/dp/0143105825%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D165953%26creativeASIN%3D0143105825</DetailPageURL><ItemLinks><ItemLink><Description>Technical Details</Description><URL>http://www.amazon.com/Anti-Oedipus-Capitalism-Schizophrenia-Penguin-Classics/dp/tech-data/0143105825%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>Add To Baby Registry</Description><URL>http://www.amazon.com/gp/registry/baby/add-item.html%3Fasin.0%3D0143105825%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>Add To Wedding Registry</Description><URL>http://www.amazon.com/gp/registry/wedding/add-item.html%3Fasin.0%3D0143105825%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>Add To Wishlist</Description><URL>http://www.amazon.com/gp/registry/wishlist/add-item.html%3Fasin.0%3D0143105825%26SubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>Tell A Friend</Description><URL>http://www.amazon.com/gp/pdp/taf/0143105825%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>All Customer Reviews</Description><URL>http://www.amazon.com/review/product/0143105825%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink><ItemLink><Description>All Offers</Description><URL>http://www.amazon.com/gp/offer-listing/0143105825%3FSubscriptionId%3D0ZVSQ33MDFPQS8H2PM02%26tag%3Dws%26linkCode%3Dxm2%26camp%3D2025%26creative%3D386001%26creativeASIN%3D0143105825</URL></ItemLink></ItemLinks><ItemAttributes><Author>Gilles Deleuze</Author><Author>Felix Guattari</Author><Creator Role=\"Translator\">Robert Hurley</Creator><Creator Role=\"Translator\">Mark Seem</Creator><Creator Role=\"Introduction\">Mark Seem</Creator><Creator Role=\"Translator\">Helen Lane</Creator><Creator Role=\"Preface\">Michel Foucault</Creator><Manufacturer>Penguin Classics</Manufacturer><ProductGroup>Book</ProductGroup><Title>Anti-Oedipus: Capitalism and Schizophrenia (Penguin Classics)</Title></ItemAttributes></Item></Items></ItemLookupResponse>"
+    http_version: "1.1"

data/spec/sucker/parameters_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+module Sucker
+  describe Parameters do
+    let(:parameters) do
+      Parameters.new
+    end
+
+    it "is a Hash" do
+      Parameters.ancestors.should include Hash
+    end
+
+    context "when initialized" do
+      it "sets `Service`" do
+        parameters.should have_key "Service"
+      end
+
+      it "sets `Version`" do
+        parameters.should have_key "Version"
+      end
+
+      it "set `Timestamp`" do
+        parameters.should have_key "Timestamp"
+      end
+    end
+
+    describe "#normalize" do
+      it "casts keys to string" do
+        parameters[:Foo] = 0
+        normalized = parameters.normalize
+
+        normalized.should have_key "Foo"
+        normalized.should_not have_key :foo
+      end
+
+      it "camelizes keys" do
+        parameters["foo_bar"] = 0
+        normalized = parameters.normalize
+
+        normalized.should have_key "FooBar"
+        normalized.should_not have_key "foo_bar"
+      end
+
+      it "casts numeric values to string" do
+        parameters["Foo"] = 1
+        parameters.normalize["Foo"].should eql "1"
+      end
+
+      it "converts array values to string" do
+        parameters["Foo"] = ['bar', 'baz']
+        parameters.normalize["Foo"].should eql 'bar,baz'
+      end
+    end
+
+    describe "#timestamp" do
+      it "generates a timestamp" do
+        parameters.send(:timestamp).should match /^\d+-\d+-\d+T\d+:\d+:\d+Z$/
+      end
+    end
+  end
+end

data/spec/sucker/request_spec.rb

@@ -0,0 +1,276 @@
+require "spec_helper"
+
+module Sucker
+  describe Request do
+    use_vcr_cassette "spec/sucker/request", :record => :new_episodes
+
+    let(:worker) do
+      Sucker.new(
+        :locale => :us,
+        :key    => "key",
+        :secret => "secret")
+    end
+
+    describe "#<<" do
+      it "merges a hash into the existing parameters" do
+        worker << { "foo" => "bar" }
+        worker.parameters["foo"].should eql "bar"
+      end
+    end
+
+    describe "#version=" do
+      it "sets the Amazon API version" do
+        worker.version = "foo"
+        worker.parameters["Version"].should eql "foo"
+      end
+    end
+
+    describe "#associate_tag" do
+      it "returns the associate tag for the current locale" do
+        worker.instance_variable_set(:@associate_tags, { :us => 'foo-bar'})
+
+        worker.associate_tag.should eql 'foo-bar'
+      end
+
+      it "returns blank if no associate tag is set for the current locale" do
+        worker.associate_tag.should be_blank
+      end
+    end
+
+    describe "#associate_tag=" do
+      it "sets the associate tag for the current locale" do
+        worker.associate_tag = "foo-bar"
+        associate_tags = worker.instance_variable_get(:@associate_tags)
+
+        associate_tags.keys.size.should eql 1
+        associate_tags[:us].should eql 'foo-bar'
+        worker.associate_tag.should eql 'foo-bar'
+      end
+    end
+
+    describe "#associate_tags=" do
+      it "sets associate tags for the locales" do
+        tags = {
+          :us => 'foo',
+          :uk => 'bar',
+          :de => 'baz',
+          :ca => 'foo',
+          :fr => 'bar',
+          :jp => 'baz' }
+        worker.associate_tags = tags
+
+        worker.instance_variable_get(:@associate_tags).should eql tags
+      end
+    end
+
+    describe "#curl_opts" do
+      it "returns options for curl" do
+        worker.curl_opts.should be_an_instance_of Hash
+      end
+
+      context "when given a block" do
+
+        it "yields options for curl" do
+          worker.curl_opts { |c| c.interface = "eth1" }
+
+          worker.curl_opts[:interface].should eql "eth1"
+        end
+      end
+    end
+
+    describe "#get" do
+      context "when no argument is passed" do
+        it "returns a response" do
+          worker.get.class.ancestors.should include Response
+        end
+
+        it "sets options on curl" do
+          easy = mock
+          easy.should_receive(:interface=).once.with("eth1")
+          Curl::Easy.stub!(:perform).and_yield(easy)
+          Response.should_receive(:new).once
+
+          worker.curl_opts { |c| c.interface = 'eth1' }
+          worker.get
+        end
+      end
+
+      context "when one argument is passed" do
+        context "when the argument is is `:all`" do
+          it "queries all locales" do
+            locales = worker.send(:locales)
+            worker.should_receive(:get_multi).with(locales)
+            worker.get(:all)
+          end
+        end
+
+        context "when the argument is not `:all`" do
+          it "sets current locale to to the argument" do
+            worker.should_receive(:locale=).with(:uk)
+            worker.get(:uk)
+          end
+
+          it "calls itself with no argument" do
+            worker.class.send :alias_method, :get_original, :get
+            worker.should_receive(:get).with(no_args())
+            worker.get_original(:uk)
+          end
+        end
+      end
+
+      context "when multiple arguments are passed" do
+        it "queries multiple locales" do
+          worker.should_receive(:get_multi).with([:us, :uk])
+          worker.get(:us, :uk)
+        end
+      end
+    end
+
+    describe "#key" do
+      it "returns the Amazon AWS access key for the current locale" do
+        worker.instance_variable_set(:@keys, { :us => 'foo' })
+
+        worker.key.should eql 'foo'
+      end
+
+      it "raises an argument error if key is missing" do
+        worker.instance_variable_get(:@keys)[:us] = nil
+        expect do
+          worker.key
+        end.to raise_error 'AWS access key missing'
+      end
+    end
+
+    describe "#key=" do
+      it "sets a global Amazon AWS access key" do
+        worker.key = "foo"
+        keys = worker.instance_variable_get(:@keys)
+
+        keys.size.should eql Request::HOSTS.size
+        keys.values.uniq.should eql ["foo"]
+      end
+    end
+
+    describe "#keys=" do
+      it "sets distinct Amazon AWS access keys for the locales" do
+        keys = {
+          :us => 'foo',
+          :uk => 'bar',
+          :de => 'baz',
+          :ca => 'foo',
+          :fr => 'bar',
+          :jp => 'baz' }
+        worker.keys = keys
+
+        worker.instance_variable_get(:@keys).should eql keys
+      end
+    end
+
+    describe "#locale" do
+      it "returns the current locale" do
+        worker.locale.should eql :us
+      end
+
+      it "raises an argument error if locale is not set" do
+        worker.instance_variable_set(:@locale, nil)
+        expect do
+          worker.locale
+        end.to raise_error 'Locale not set'
+      end
+    end
+
+    describe "#locale=" do
+      it "sets the current locale" do
+        worker.locale= :uk
+        worker.locale.should eql :uk
+      end
+
+      it "raises an argument error if locale is invalid" do
+        expect do
+          worker.locale= :br
+        end.to raise_error 'Invalid locale'
+      end
+    end
+
+    # private
+
+    describe "#build_query" do
+      let(:query) do
+        worker.send(:build_query)
+      end
+
+      it "canonicalizes query" do
+        query.should match /Service=([^&]+)&Timestamp=([^&]+)&Version=([^&]+)/
+      end
+
+      it "includes a timestamp" do
+        query.should include 'Timestamp'
+      end
+
+      it "sorts query" do
+        worker.parameters["A"] = "foo"
+        query.should match /^A=foo/
+      end
+    end
+
+    describe "#build_signed_query" do
+      let(:query) { worker.send(:build_signed_query) }
+
+      it "includes the key for the current locale" do
+        worker.key = 'foo'
+        query.should include 'AWSAccessKeyId=foo'
+      end
+
+      it "includes the associate tag for the current locale" do
+        worker.associate_tag = 'foo'
+        query.should include 'AssociateTag=foo'
+      end
+
+      it "returns a signed query string" do
+        query = worker.send :build_signed_query
+        query.should include 'Signature='
+      end
+    end
+
+    describe "#escape" do
+      it "URL-encodes a string" do
+        worker.send(:escape, 'foo,bar').should eql "foo%2Cbar"
+      end
+    end
+
+    describe "#get_multi" do
+      it "returns an array of responses" do
+        responses = worker.send(:get_multi, [:us, :uk])
+
+        responses.should be_an_instance_of Array
+        responses.each { |resp| resp.should be_an_instance_of Response }
+      end
+
+      context "when given a block" do
+        it "yields responses" do
+          locales = worker.send(:locales)
+          count = 0
+          worker.send(:get_multi, locales) do |resp|
+            resp.should be_an_instance_of Response
+            count += 1
+          end
+
+          count.should eql locales.size
+        end
+      end
+    end
+
+    describe "#host" do
+      it "returns a host" do
+        worker.locale = "fr"
+        worker.send(:host).should eql "ecs.amazonaws.fr"
+      end
+    end
+
+    describe "#uri" do
+      it "returns the URI with which to query Amazon" do
+        worker.send(:uri).should be_an_instance_of URI::HTTP
+      end
+    end
+  end
+end

data/spec/{unit/sucker → sucker}/response_spec.rb

@@ -2,10 +2,8 @@
 require "spec_helper"
 
 module Sucker
-
   describe Response do
-
-    use_vcr_cassette "unit/sucker/response", :record => :new_episodes
+    use_vcr_cassette "spec/sucker/response", :record => :new_episodes
 
     let(:asins) { ["0816614024", "0143105825"] }
 
@@ -17,13 +15,11 @@ module Sucker
       worker << {
           "Operation"     => "ItemLookup",
           "IdType"        => "ASIN",
-          "ResponseGroup" => ["ItemAttributes", "OfferFull"],
           "ItemId"        => asins }
       worker.get
     end
 
     describe ".new" do
-
       it "initializes the response body" do
         response.body.should be_an_instance_of String
       end
@@ -39,43 +35,10 @@ module Sucker
       it "initializes the request URI" do
         response.uri.should be_an_instance_of String
       end
-
-    end
-
-    describe "#xml" do
-
-      it "returns a Nokogiri document" do
-        response.xml.should be_an_instance_of Nokogiri::XML::Document
-      end
-
-    end
-
-    describe "#find" do
-
-      context "when there are matches" do
-
-        it "returns an array of matching nodes" do
-          node = response.find("ItemAttributes")
-          node.map { |book| book["ISBN"] }.should eql asins
-        end
-
-      end
-
-      context "when there are no matches" do
-
-        it "returns an empty array" do
-          node = response.find("Foo")
-          node.should eql []
-        end
-
-      end
-
     end
 
     describe "#each" do
-
       context "when a block is given" do
-
         it "yields each match to a block" do
           has_yielded = false
 
@@ -86,51 +49,70 @@ module Sucker
 
           has_yielded.should be_true
         end
-
       end
 
       context "when no block is given" do
-
         it "raises error" do
           expect do
             response.each("ItemAttributes")
           end.to raise_error(LocalJumpError)
         end
+      end
+    end
+
+    context "when response contains errors" do
+      before do
+        response.body = "<?xml version=\"1.0\" ?><ItemLookupResponse xmlns=\"http://webservices.amazon.com/AWSECommerceService/2010-09-01\"><Errors><Error>foo</Error><Error>bar</Error></Errors>"
+      end
 
+      describe "#errors" do
+        it "returns an array of errors" do
+          response.errors.count.should eql 2
+        end
       end
 
+      describe "#has_errors?" do
+        it "returns true if the response has errors" do
+          response.should have_errors
+        end
+      end
     end
 
+    describe "#find" do
+      context "when there are matches" do
 
-    describe "#map" do
+        it "returns an array of matching nodes" do
+          response.find("ASIN").should eql asins
+        end
+      end
 
-      context "when a block is given" do
+      context "when there are no matches" do
+        it "returns an empty array" do
+          node = response.find("Foo")
+          node.should eql []
+        end
+      end
+    end
 
+    describe "#map" do
+      context "when a block is given" do
         it "yields each match to a block and maps returned values" do
-          # Collect EANs
-          eans = response.map("ItemAttributes") { |item| item["EAN"] }
+          titles = response.map("ItemAttributes") { |item| item["Title"] }
 
-          eans.should be_an_instance_of Array
-          eans.each { |ean| ean.match(/^[0-9]{13}$/).should be_true }
+          titles.count.should eql 2
         end
-
       end
 
       context "when no block is given" do
-
         it "raises error" do
           expect do
             response.map("ItemAttributes")
           end.to raise_error(LocalJumpError)
         end
-
       end
-
     end
 
-
     describe "#to_hash" do
-
       it "returns a hash" do
         response.to_hash.should be_an_instance_of Hash
       end
@@ -154,30 +136,27 @@ module Sucker
         response.body = "<Title>スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則</Title>"
         response.to_hash["Title"].should eql "スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則"
       end
-
     end
 
     describe "#valid?" do
-
       context "when HTTP status is OK" do
-
         it "returns true" do
           response.should be_valid
         end
-
       end
 
       context "when HTTP status is not OK" do
-
         it "returns false" do
           response.code = 403
           response.should_not be_valid
         end
-
       end
-
     end
 
+    describe "#xml" do
+      it "returns a Nokogiri document" do
+        response.xml.should be_an_instance_of Nokogiri::XML::Document
+      end
+    end
   end
-
 end