sucker 0.9.2 → 1.0.0.beta.1

data/spec/unit/sucker/request_spec.rb

@@ -1,9 +1,12 @@
+# encoding: utf-8
 require "spec_helper"
 
 module Sucker
   describe Request do
-    before do
-      @worker = Sucker.new(
+    use_vcr_cassette "unit/sucker/request", :record => :new_episodes
+
+    let(:worker) do
+      Sucker.new(
         :locale => "us",
         :key    => "key",
         :secret => "secret")
@@ -13,113 +16,122 @@ module Sucker
       it "sets default parameters" do
         default_parameters = {
           "Service" => "AWSECommerceService",
-          "Version" => Sucker::AMAZON_API_VERSION }
-        @worker.parameters.should include default_parameters
+          "Version" => Sucker::CURRENT_AMAZON_API_VERSION }
+        worker.parameters.should include default_parameters
       end
     end
 
     context "#<<" do
       it "merges a hash into the parameters" do
-        @worker << { "foo" => "bar" }
-        @worker.parameters["foo"].should eql "bar"
+        worker << { "foo" => "bar" }
+        worker.parameters["foo"].should eql "bar"
+      end
+    end
+
+    context "api_version" do
+      it "has a default value" do
+        worker.api_version.should_not be_nil
+      end
+    end
+
+    context "#api_version=" do
+      it "sets the Amazon API version" do
+        worker.api_version = "foo"
+        worker.api_version.should eql "foo"
       end
     end
 
     context "#associate_tag=" do
       it "sets the associate tag in the parameters" do
-        @worker.associate_tag = "foo"
-        @worker.parameters["AssociateTag"].should eql "foo"
+        worker.associate_tag = "foo"
+        worker.parameters["AssociateTag"].should eql "foo"
       end
     end
 
     context "#curl" do
       it "returns a cURL object" do
-        @worker.curl.should be_an_instance_of Curl::Easy
+        worker.curl.should be_an_instance_of Curl::Easy
       end
 
       it "configures the cURL object" do
-        @worker.curl.interface.should be_nil
+        worker.curl.interface.should be_nil
 
-        @worker.curl do |curl|
+        worker.curl do |curl|
           curl.interface = "eth1"
         end
 
-        @worker.curl.interface.should eql "eth1"
+        worker.curl.interface.should eql "eth1"
       end
     end
 
     context "#get" do
-      before do
-        Sucker.stub(@worker)
-      end
-
       it "returns a Response object" do
-        @worker.get.class.ancestors.should include Sucker::Response
+        worker.get.class.ancestors.should include Sucker::Response
       end
     end
 
     context "#key=" do
       it "sets the Amazon AWS access key in the parameters" do
-        @worker.key = "foo"
-        @worker.parameters["AWSAccessKeyId"].should eql "foo"
+        worker.key = "foo"
+        worker.parameters["AWSAccessKeyId"].should eql "foo"
       end
     end
 
     context "private methods" do
       context "#build_query" do
         it "canonicalizes parameters" do
-          query = @worker.send(:build_query)
+          query = worker.send(:build_query)
           query.should match /Service=([^&]+)&Timestamp=([^&]+)&Version=([^&]+)/
         end
 
         it "sorts parameters" do
-          @worker.parameters["AAA"] = "foo"
-          query = @worker.send(:build_query)
+          worker.parameters["AAA"] = "foo"
+          query = worker.send(:build_query)
           query.should match /^AAA=foo/
         end
 
         it "converts a parameter whose value is an array to a string" do
-          @worker.parameters["Foo"] = ["bar", "baz"]
-          query = @worker.send(:build_query)
+          worker.parameters["Foo"] = ["bar", "baz"]
+          query = worker.send(:build_query)
           query.should match /Foo=bar%2Cbaz/
         end
 
         it "handles integer parameter values" do
-          @worker.parameters["Foo"] = 1
-          query = @worker.send(:build_query)
+          worker.parameters["Foo"] = 1
+          query = worker.send(:build_query)
           query.should match /Foo=1/
         end
 
         it "handles floating-point parameter values" do
-          @worker.parameters["Foo"] = 1.0
-          query = @worker.send(:build_query)
+          worker.parameters["Foo"] = 1.0
+          query = worker.send(:build_query)
           query.should match /Foo=1/
         end
       end
 
       context "#host" do
         it "returns a host" do
-          @worker.locale = "fr"
-          @worker.send(:host).should eql "ecs.amazonaws.fr"
+          worker.locale = "fr"
+          worker.send(:host).should eql "ecs.amazonaws.fr"
         end
       end
 
       context "#build_signed_query" do
         it "returns a signed query string" do
-          query = @worker.send :build_signed_query
+          query = worker.send :build_signed_query
           query.should match /&Signature=.*/
         end
       end
 
       context "#timestamp" do
         it "returns a timestamp" do
-          @worker.send(:timestamp)["Timestamp"].should match /^\d+-\d+-\d+T\d+:\d+:\d+Z$/
+          worker.send(:timestamp)["Timestamp"].should match /^\d+-\d+-\d+T\d+:\d+:\d+Z$/
         end
       end
 
       context "#uri" do
         it "returns the URI with which to query Amazon" do
-          @worker.send(:uri).should be_an_instance_of URI::HTTP
+          worker.send(:uri).should be_an_instance_of URI::HTTP
         end
       end
     end

data/spec/unit/sucker/response_spec.rb

@@ -3,8 +3,11 @@ require "spec_helper"
 
 module Sucker
   describe Response do
-    before do
-      @asins = ["0816614024", "0143105825"]
+    use_vcr_cassette "unit/sucker/response", :record => :new_episodes
+
+    let(:asins) { ["0816614024", "0143105825"] }
+
+    let(:response) do
       worker = Sucker.new(
         :locale => "us",
         :key    => amazon["key"],
@@ -13,76 +16,76 @@ module Sucker
           "Operation"     => "ItemLookup",
           "IdType"        => "ASIN",
           "ResponseGroup" => ["ItemAttributes", "OfferFull"],
-          "ItemId"        => @asins }
-      @response = worker.get
+          "ItemId"        => asins }
+      worker.get
     end
 
     context ".new" do
       it "sets the response body" do
-        @response.body.should be_an_instance_of String
+        response.body.should be_an_instance_of String
       end
 
       it "sets the response code" do
-        @response.code.should == 200
+        response.code.should == 200
       end
 
       it "sets the response time" do
-        @response.time.should be_an_instance_of Float
+        response.time.should be_an_instance_of Float
       end
     end
 
     context "#xml" do
       it "returns a Nokogiri document" do
-        @response.xml.should be_an_instance_of Nokogiri::XML::Document
+        response.xml.should be_an_instance_of Nokogiri::XML::Document
       end
     end
 
     context "#node" do
       it "returns a collection of hashified nodes" do
-        response = @response.node("ItemAttributes")
-        response.map { |book| book["ISBN"] }.should eql @asins
+        node = response.node("ItemAttributes")
+        node.map { |book| book["ISBN"] }.should eql asins
       end
 
       it "returns an empty array if there are no matches" do
-        response = @response.node("Foo")
-        response.should eql []
+        node = response.node("Foo")
+        node.should eql []
       end
     end
 
     context "#to_hash" do
       it "returns a hash" do
-        @response.to_hash.should be_an_instance_of Hash
+        response.to_hash.should be_an_instance_of Hash
       end
 
       it "converts a content hash to string" do
-        @response.body = "<book><title>A Thousand Plateaus</title></book>"
-        @response.to_hash["book"]["title"].should be_an_instance_of String
+        response.body = "<book><title>A Thousand Plateaus</title></book>"
+        response.to_hash["book"]["title"].should be_an_instance_of String
       end
 
       it "renders French" do
-        @response.body = "<Title>L'archéologie du savoir</Title>"
-        @response.to_hash["Title"].should eql "L'archéologie du savoir"
+        response.body = "<Title>L'archéologie du savoir</Title>"
+        response.to_hash["Title"].should eql "L'archéologie du savoir"
       end
 
       it "renders German" do
-        @response.body = "<Title>Kafka: Für eine kleine Literatur</Title>"
-        @response.to_hash["Title"].should eql "Kafka: Für eine kleine Literatur"
+        response.body = "<Title>Kafka: Für eine kleine Literatur</Title>"
+        response.to_hash["Title"].should eql "Kafka: Für eine kleine Literatur"
       end
 
       it "renders Japanese" do
-        @response.body = "<Title>スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則</Title>"
-        @response.to_hash["Title"].should eql "スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則"
+        response.body = "<Title>スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則</Title>"
+        response.to_hash["Title"].should eql "スティーブ・ジョブズ 驚異のプレゼン―人々を惹きつける18の法則"
       end
     end
 
     context "#valid?" do
       it "returns true if the HTTP status is OK" do
-        @response.should be_valid
+        response.should be_valid
       end
 
       it "returns false if the HTTP status is not OK" do
-        @response.code = 403
-        @response.should_not be_valid
+        response.code = 403
+        response.should_not be_valid
       end
     end
   end

data/spec/unit/sucker_spec.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require "spec_helper"
 
 describe Sucker do

metadata

@@ -1,12 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  hash: 62196353
+  prerelease: true
   segments: 
+  - 1
+  - 0
   - 0
-  - 9
-  - 2
-  version: 0.9.2
+  - beta
+  - 1
+  version: 1.0.0.beta.1
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -15,123 +18,170 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-06 00:00:00 +01:00
+date: 2010-10-14 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
+  prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 2
         - 3
         - 2
         version: 2.3.2
   type: :runtime
-  prerelease: false
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: nokogiri
+  prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 1
         - 4
         - 0
         version: 1.4.0
   type: :runtime
-  prerelease: false
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: curb
+  prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         - 7
         - 0
         version: 0.7.0
   type: :runtime
-  prerelease: false
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: rake
+  prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
+        hash: 49
         segments: 
         - 0
-        version: "0"
+        - 8
+        - 7
+        version: 0.8.7
   type: :development
-  prerelease: false
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   name: rdiscount
+  prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
+        hash: 5
         segments: 
-        - 0
-        version: "0"
+        - 1
+        - 6
+        - 5
+        version: 1.6.5
   type: :development
-  prerelease: false
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
   name: rspec
+  prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - "="
+    - - ~>
       - !ruby/object:Gem::Version 
+        hash: 15
         segments: 
         - 2
         - 0
         - 0
-        - rc
-        version: 2.0.0.rc
+        version: 2.0.0
   type: :development
-  prerelease: false
   version_requirements: *id006
 - !ruby/object:Gem::Dependency 
   name: throttler
+  prerelease: false
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
+        hash: 21
         segments: 
         - 0
-        version: "0"
+        - 2
+        - 1
+        version: 0.2.1
   type: :development
-  prerelease: false
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
   name: sdoc-helpers
+  prerelease: false
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
+        hash: 19
         segments: 
         - 0
-        version: "0"
+        - 1
+        - 4
+        version: 0.1.4
   type: :development
-  prerelease: false
   version_requirements: *id008
-description: A Ruby wrapper to the Amazon Product Advertising API
+- !ruby/object:Gem::Dependency 
+  name: vcr
+  prerelease: false
+  requirement: &id009 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 31
+        segments: 
+        - 1
+        - 2
+        - 0
+        version: 1.2.0
+  type: :development
+  version_requirements: *id009
+- !ruby/object:Gem::Dependency 
+  name: webmock
+  prerelease: false
+  requirement: &id010 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 4
+        - 0
+        version: 1.4.0
+  type: :development
+  version_requirements: *id010
+description: A minimal Ruby wrapper to the Amazon Product Advertising API
 email: 
 - code@papercavalier.com
 executables: []
@@ -143,12 +193,24 @@ extra_rdoc_files: []
 files: 
 - lib/sucker/request.rb
 - lib/sucker/response.rb
-- lib/sucker/stub.rb
 - lib/sucker/version.rb
 - lib/sucker.rb
 - LICENSE
 - README.markdown
 - spec/fixtures/asins.txt
+- spec/fixtures/cassette_library/integration/errors.yml
+- spec/fixtures/cassette_library/integration/france.yml
+- spec/fixtures/cassette_library/integration/images.yml
+- spec/fixtures/cassette_library/integration/item_lookup/multiple.yml
+- spec/fixtures/cassette_library/integration/item_lookup/single.yml
+- spec/fixtures/cassette_library/integration/item_search.yml
+- spec/fixtures/cassette_library/integration/japan.yml
+- spec/fixtures/cassette_library/integration/related_items/child.yml
+- spec/fixtures/cassette_library/integration/related_items/parent.yml
+- spec/fixtures/cassette_library/integration/seller_listings_search.yml
+- spec/fixtures/cassette_library/integration/twenty_items.yml
+- spec/fixtures/cassette_library/unit/sucker/request.yml
+- spec/fixtures/cassette_library/unit/sucker/response.yml
 - spec/integration/errors_spec.rb
 - spec/integration/france_spec.rb
 - spec/integration/images_spec.rb
@@ -159,21 +221,21 @@ files:
 - spec/integration/seller_listing_search_spec.rb
 - spec/integration/twenty_items_in_one_request_spec.rb
 - spec/spec_helper.rb
+- spec/support/amazon.yml
 - spec/support/amazon.yml.example
 - spec/support/amazon_credentials.rb
 - spec/support/asins.rb
-- spec/support/sucker.rb
+- spec/support/vcr.rb
 - spec/unit/sucker/request_spec.rb
 - spec/unit/sucker/response_spec.rb
-- spec/unit/sucker/stub_spec.rb
 - spec/unit/sucker_spec.rb
 has_rdoc: true
 homepage: http://gloss.papercavalier.com/sucker
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -181,29 +243,43 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -55576138892431507
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version 
+      hash: 25
       segments: 
       - 1
       - 3
-      - 7
-      version: 1.3.7
+      - 1
+      version: 1.3.1
 requirements: []
 
-rubyforge_project: 
+rubyforge_project: sucker
 rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: A Ruby wrapper to the Amazon Product Advertising API
 test_files: 
 - spec/fixtures/asins.txt
+- spec/fixtures/cassette_library/integration/errors.yml
+- spec/fixtures/cassette_library/integration/france.yml
+- spec/fixtures/cassette_library/integration/images.yml
+- spec/fixtures/cassette_library/integration/item_lookup/multiple.yml
+- spec/fixtures/cassette_library/integration/item_lookup/single.yml
+- spec/fixtures/cassette_library/integration/item_search.yml
+- spec/fixtures/cassette_library/integration/japan.yml
+- spec/fixtures/cassette_library/integration/related_items/child.yml
+- spec/fixtures/cassette_library/integration/related_items/parent.yml
+- spec/fixtures/cassette_library/integration/seller_listings_search.yml
+- spec/fixtures/cassette_library/integration/twenty_items.yml
+- spec/fixtures/cassette_library/unit/sucker/request.yml
+- spec/fixtures/cassette_library/unit/sucker/response.yml
 - spec/integration/errors_spec.rb
 - spec/integration/france_spec.rb
 - spec/integration/images_spec.rb
@@ -214,11 +290,11 @@ test_files:
 - spec/integration/seller_listing_search_spec.rb
 - spec/integration/twenty_items_in_one_request_spec.rb
 - spec/spec_helper.rb
+- spec/support/amazon.yml
 - spec/support/amazon.yml.example
 - spec/support/amazon_credentials.rb
 - spec/support/asins.rb
-- spec/support/sucker.rb
+- spec/support/vcr.rb
 - spec/unit/sucker/request_spec.rb
 - spec/unit/sucker/response_spec.rb
-- spec/unit/sucker/stub_spec.rb
 - spec/unit/sucker_spec.rb

data/lib/sucker/stub.rb

@@ -1,45 +0,0 @@
-# encoding: utf-8
-module Sucker
-
-  # Stubs Sucker::Response to run specs offline.
-  class MockResponse < Response
-    def initialize(mock_response_body)
-      self.body = mock_response_body
-      self.code = 200
-      self.time = 0.1
-    end
-  end
-
-  class << self
-    attr_accessor :fixtures_path
-
-    # Records a request on first run and fakes subsequently
-    def stub(request)
-      request.instance_eval do
-        self.class.send :define_method, :fixture do
-          values = parameters.
-            reject { |k, v| %w{AWSAccessKeyId Service}.include? k }.
-            values.
-            flatten.
-            join
-          filename = Digest::MD5.hexdigest(host + values)
-          "#{Sucker.fixtures_path}/#{filename}.xml"
-        end
-
-        self.class.send :define_method, :get do
-          if File.exists?(fixture)
-            MockResponse.new(File.new(fixture, "r").read)
-          else
-            curl.url = uri.to_s
-            curl.perform
-            response = Response.new(curl)
-
-            File.open(fixture, "w") { |f| f.write response.body }
-
-            response
-          end
-        end
-      end
-    end
-  end
-end

data/spec/support/sucker.rb

@@ -1,3 +0,0 @@
-require "sucker/stub"
-
-Sucker.fixtures_path = File.dirname(__FILE__) + "/../fixtures"