sucker 0.6.0 → 0.6.1

data/README.md

@@ -63,8 +63,3 @@ Notes
 * The unit specs should run out of the box after you `bundle install`, but the integration specs require you to create [an amazon.yml file with valid credentials](http://github.com/papercavalier/sucker/blob/master/spec/support/amazon.yml.example) in `spec/support`.
 
 * Version 0.6.0 now has Active Support's Nokogiri-based `to_hash` under the hood. After some meddling, it does what it's supposed to do and is blazing fast. Fix up your code accordingly.
-
-                              user     system      total        real
-    Crack                 0.830000   0.010000   0.840000 (  0.871951)
-    SimpleXml             2.470000   0.050000   2.520000 (  2.560045)
-    AS + Nokogiri         0.440000   0.010000   0.450000 (  0.450201)

data/lib/sucker.rb

@@ -1,6 +1,7 @@
+require "active_support/xml_mini/nokogiri"
 require "cgi"
 require "curb"
-require "active_support/xml_mini/nokogiri"
+require 'digest/md5'
 require "sucker/request"
 require "sucker/response"
 

data/lib/sucker/stub.rb

@@ -14,12 +14,7 @@ module Sucker
     def stub(request)
       request.instance_eval do
         self.class.send :define_method, :fixture do
-          filename = parameters.
-            values.
-            flatten.
-            join.
-            gsub(/(?:[aeiou13579]|[^\w])+/i, '')[0, 251]
-
+          filename = Digest::MD5.hexdigest(parameters.values.flatten.join)
           "#{Sucker.fixtures_path}/#{filename}.xml"
         end
 

data/spec/benchmark/to_hash_implementations.rb

@@ -4,13 +4,13 @@ require "benchmark"
 require "crack/xml"
 require "xmlsimple"
 
-@worker = Sucker.new(
+worker = Sucker.new(
   :locale => "us",
   :key    => amazon["key"],
   :secret => amazon["secret"])
 
 # Prep worker
-@worker << {
+worker << {
   "Operation"                       => "ItemLookup",
   "ItemLookup.Shared.IdType"        => "ASIN",
   "ItemLookup.Shared.Condition"     => "All",
@@ -18,20 +18,20 @@ require "xmlsimple"
   "ItemLookup.Shared.ResponseGroup" => "OfferFull" }
 
 # Push twenty ASINs to worker
-@asins = %w{
+asins = %w{
   0816614024 0143105825 0485113600 0816616779 0942299078
   0816614008 144006654X 0486400360 0486417670 087220474X
   0486454398 0268018359 1604246014 184467598X 0312427182
   1844674282 0745640974 0745646441 0826489540 1844672972 }
-@worker << {
-  "ItemLookup.1.ItemId" => @asins[0, 10],
-  "ItemLookup.2.ItemId" => @asins[10, 10] }
+worker << {
+  "ItemLookup.1.ItemId" => asins[0, 10],
+  "ItemLookup.2.ItemId" => asins[10, 10] }
 
-Sucker.stub(@worker)
+Sucker.stub(worker)
 
-response = @worker.get
+response = worker.get
 
-Benchmark.bm(20) do |x|
+Benchmark.bm(100) do |x|
   x.report("Crack") { Crack::XML.parse(response.body) }
   x.report("SimpleXml") { XmlSimple.xml_in(response.body, { "ForceArray" => false }) }
   x.report("AS + Nokogiri")  { response.to_h }

data/spec/integration/japan_spec.rb

@@ -9,8 +9,9 @@ module Sucker
         :secret => amazon["secret"])
 
       @worker << {
-        "Operation"   => "ItemLookup",
-        "IdType"      => "ASIN" }
+        "Operation"     => "ItemLookup",
+        "IdType"        => "ASIN",
+        "ResponseGroup" => ["ItemAttributes", "OfferFull"] }
 
       Sucker.stub(@worker)
     end

data/spec/unit/sucker/stub_spec.rb

@@ -42,31 +42,8 @@ module Sucker
 
       context "defines:" do
         context "#fixture" do
-          it "ignores odd numbers" do
-            @worker << { "Foo" => "13579" }
-            @worker.fixture.should_not match /[^\/]*[13579][^\/]*xml$/
-          end
-
-          it "does not ignore odd numbers" do
-            @worker << { "Foo" => "24680" }
-            (0..8).step(2) do |odd_no|
-              @worker.fixture.should match Regexp.new(odd_no.to_s)
-            end
-          end
-
-          it "ignores vowels" do
-            @worker << { "Foo" => "aeiou" }
-            @worker.fixture.should_not match /[^\/]*[aeiou][^\/]*xml$/
-          end
-
-          it "does not ignore consonants" do
-            @worker << { "Foo" =>  ("a".."z").to_a.join }
-            @worker.fixture.should include(("a".."z").to_a.join.gsub(/[aeiou]/, ""))
-          end
-
-          it "ignores non-alphanumeric characters" do
-            @worker << { "Foo" => ";+*&!~" }
-            @worker.fixture.should_not match /[;+*&!~]/
+          it "generates a path for the fixture" do
+            @worker.fixture.should match /.*\/[0-9a-f]{32}\.xml$/
           end
         end
       end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 5
   prerelease: false
   segments: 
   - 0
   - 6
-  - 0
-  version: 0.6.0
+  - 1
+  version: 0.6.1
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-02 00:00:00 +01:00
+date: 2010-08-03 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency