sucker 0.4.0 → 0.5.0

data/README.md

@@ -1,7 +1,7 @@
 Sucker
 ======
 
-Sucker is a thin Ruby wrapper to the [Amazon Product Advertising API](https://affiliate-program.amazon.co.uk/gp/advertising/api/detail/main.html). It runs on Curb and Crack and supports __everything__ in the API.
+Sucker is a thin Ruby wrapper to the [Amazon Product Advertising API](https://affiliate-program.amazon.co.uk/gp/advertising/api/detail/main.html). It runs on Curb and XmlSimple and supports __everything__ in the API.
 
 ![Sucker](http://upload.wikimedia.org/wikipedia/en/7/71/Vacuum_cleaner_1910.JPG)
 
@@ -33,7 +33,7 @@ Hit Amazon and do something with the response.
     p response.time
     p response.body
     
-    response.to_h["ItemLookupResponse"]["Items"]["Item"].each { ... }
+    response.to_h["Items"]["Item"].each { ... }
 
 Hit Amazon again.
 
@@ -41,25 +41,27 @@ Hit Amazon again.
       "ItemId"  => 10.more.asins }
     response = worker.get
 
-For more examples, check the integration specs.
+Check the integration specs for more examples.
 
 Testing
 -------
 
 To fake web requests, I do the following:
 
-In a file such as `spec/support/sucker.rb`, I prep things:
+In a file such as `spec/support/sucker.rb`, I prep:
 
     require "sucker/stub"
     Sucker.fixtures_path = File.dirname(__FILE__) + "/../fixtures"
 
-Then, in the spec, I set up a worker and stub the worker:
+In the spec, I set up a worker and then stub it:
 
     Sucker.stub(@worker)
 
 The first time you run the spec, the worker will perform the actual web request and cache the response. Subsequent requests are then mocked with the cached response.
 
-Specs
+Notes
 -----
 
-The unit specs should run out of the box after you `bundle install`, but the integration specs require you to create [an amazon.yml file with valid credentials](http://github.com/papercavalier/sucker/blob/master/spec/support/amazon.yml.example) in the spec/support folder.
+* The unit specs should run out of the box after you `bundle install`, but the integration specs require you to create [an amazon.yml file with valid credentials](http://github.com/papercavalier/sucker/blob/master/spec/support/amazon.yml.example) in `spec/support`.
+
+* Version 0.5.0 replaces Crack with XmlSimple, which results in a slightly different hash output. Fix up your code accordingly.

data/lib/sucker.rb

@@ -1,8 +1,8 @@
 require "cgi"
-require "crack/xml"
 require "curb"
 require "sucker/request"
 require "sucker/response"
+require "xmlsimple"
 
 # = Sucker
 # Sucker is a thin Ruby wrapper to the Amazon Product Advertising API.

data/lib/sucker/request.rb

@@ -64,7 +64,7 @@ module Sucker
         merge(timestamp).
         sort.
         collect do |k, v|
-          "#{CGI.escape(k)}=" + CGI.escape(v.is_a?(Array) ? v.join(",") : v)
+          "#{k}=" + CGI.escape(v.is_a?(Array) ? v.join(",") : v)
         end.
         join("&")
     end

data/lib/sucker/response.rb

@@ -11,7 +11,7 @@ module Sucker
     end
 
     def to_h
-      Crack::XML.parse(body)
+      XmlSimple.xml_in(body, { "ForceArray" => false })
     end
   end
 end

data/spec/integration/item_lookup_spec.rb

@@ -23,7 +23,7 @@ module Sucker
     context "single item" do
       before do
         @worker << { "ItemId" => "0816614024" }
-        @item = @worker.get.to_h["ItemLookupResponse"]["Items"]["Item"]
+        @item = @worker.get.to_h["Items"]["Item"]
       end
 
       it "returns an item" do
@@ -43,7 +43,7 @@ module Sucker
     context "multiple items" do
       before do
         @worker << { "ItemId" => ["0816614024", "0143105825"] }
-        @items = @worker.get.to_h["ItemLookupResponse"]["Items"]["Item"]
+        @items = @worker.get.to_h["Items"]["Item"]
       end
 
       it "returns two items" do

data/spec/integration/japan_spec.rb

@@ -18,10 +18,10 @@ module Sucker
     context "single item" do
       before do
         @worker << { "ItemId" => "0816614024" }
-        @item = @worker.get.to_h["ItemLookupResponse"]["Items"]["Item"]
+        @item = @worker.get.to_h["Items"]["Item"]
       end
 
-      it "returns an item" do
+      it "returns an array of items" do
         @item.should be_an_instance_of Hash
       end
     end

data/spec/integration/seller_listing_search_spec.rb

@@ -16,7 +16,7 @@ module Sucker
 
       Sucker.stub(@worker)
 
-      @listings = @worker.get.to_h["SellerListingSearchResponse"]["SellerListings"]
+      @listings = @worker.get.to_h["SellerListings"]
     end
 
     it "returns page count" do

data/spec/integration/twenty_items_in_one_request_spec.rb

@@ -28,7 +28,7 @@ module Sucker
 
       Sucker.stub(@worker)
 
-      @items = @worker.get.to_h["ItemLookupResponse"]["Items"].map { |items| items["Item"] }.flatten!
+      @items = @worker.get.to_h["Items"].map { |items| items["Item"] }.flatten!
     end
 
     it "returns 20 items" do

data/spec/unit/sucker/response_spec.rb

@@ -5,7 +5,7 @@ module Sucker
     before do
       curl = Sucker.new.curl
       curl.stub(:get).and_return(nil)
-      curl.stub!(:body_str).and_return("foo")
+      curl.stub!(:body_str).and_return("<foo bar='baz' />")
       curl.stub!(:response_code).and_return(200)
       curl.stub!(:total_time).and_return(1.0)
       @response = Response.new(curl)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 11
   prerelease: false
   segments: 
   - 0
-  - 4
+  - 5
   - 0
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -16,24 +16,24 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-30 00:00:00 +01:00
+date: 2010-07-31 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   prerelease: false
   type: :runtime
-  name: crack
+  name: xml-simple
   version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - "="
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 11
+        hash: 15
         segments: 
-        - 0
         - 1
-        - 8
-        version: 0.1.8
+        - 0
+        - 12
+        version: 1.0.12
   requirement: *id001
 - !ruby/object:Gem::Dependency 
   prerelease: false
@@ -42,7 +42,7 @@ dependencies:
   version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - "="
+    - - ">="
       - !ruby/object:Gem::Version 
         hash: 105
         segments: