sucker 0.2.1 → 0.2.2

data/lib/sucker/request.rb

@@ -10,6 +10,7 @@ module Sucker
       :ca  => 'ecs.amazonaws.ca',
       :fr  => 'ecs.amazonaws.fr',
       :jp  => 'ecs.amazonaws.jp' }
+    PATH = "/onca/xml"
 
     # The Amazon locale to query
     attr_accessor :locale
@@ -69,25 +70,18 @@ module Sucker
         join("&")
     end
 
-    def digest
-      OpenSSL::Digest::Digest.new("sha256")
-    end
-
     def host
       HOSTS[locale.to_sym]
     end
 
-    def path
-      "/onca/xml"
-    end
-
     # Returns a signed and timestamped query string
-    def sign_query
+    def build_signed_query
       timestamp_parameters
 
       query = build_query
 
-      string = ["GET", host, path, query].join("\n")
+      digest = OpenSSL::Digest::Digest.new("sha256")
+      string = ["GET", host, PATH, query].join("\n")
       hmac = OpenSSL::HMAC.digest(digest, secret, string)
 
       query + "&Signature=" + CGI.escape([hmac].pack("m").chomp)
@@ -96,8 +90,8 @@ module Sucker
     def uri
       URI::HTTP.build(
         :host   => host,
-        :path   => path,
-        :query  => sign_query)
+        :path   => PATH,
+        :query  => build_signed_query)
     end
 
     def timestamp_parameters

data/lib/sucker.rb

@@ -4,8 +4,7 @@ require "curb"
 require "sucker/request"
 
 module Sucker
-  VERSION             = "0.2.0".freeze
-  AMAZON_API_VERSION  = "2009-11-01".freeze
+  AMAZON_API_VERSION  = "2009-11-01"
 
   def self.new(args={})
     Sucker::Request.new(args)

data/spec/integration/japan_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+
+module Sucker
+  describe "Japan" do
+    before do
+      @worker = Sucker.new(
+        :locale => "jp",
+        :key    => amazon["key"],
+        :secret => amazon["secret"])
+
+      @worker << {
+        "Operation"   => "ItemLookup",
+        "IdType"      => "ASIN" }
+    end
+
+    context "single item" do
+      before do
+        @worker << { "ItemId" => "0816614024" }
+        @item = @worker.get["ItemLookupResponse"]["Items"]["Item"]
+      end
+
+      it "returns an item" do
+        @item.should be_an_instance_of Hash
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -3,6 +3,8 @@ unless defined?(Bundler)
   require "bundler/setup"
 end
 
+require "rspec"
+
 require File.expand_path("../../lib/sucker", __FILE__)
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each{ |f| require f }

data/spec/unit/sucker/request_spec.rb

@@ -54,6 +54,13 @@ module Sucker
       end
     end
 
+    context "#key=" do
+      it "sets the Amazon AWS access key in the parameters" do
+        @worker.key = "key"
+        @worker.parameters["AWSAccessKeyId"].should eql "key"
+      end
+    end
+
     context "private methods" do
       context "#build_query" do
         it "canonicalizes parameters" do
@@ -74,19 +81,6 @@ module Sucker
         end
       end
 
-      context "#digest" do
-        it "returns a digest object" do
-          @worker.send(:digest).should be_an_instance_of OpenSSL::Digest::Digest
-        end
-      end
-
-      context "#key=" do
-        it "sets the Amazon AWS access key in the parameters" do
-          @worker.key = "key"
-          @worker.parameters["AWSAccessKeyId"].should eql "key"
-        end
-      end
-
       context "#host" do
         it "returns a host" do
           @worker.locale = "us"
@@ -94,17 +88,11 @@ module Sucker
         end
       end
 
-      context "#path" do
-        it "returns a path" do
-          @worker.send(:path).should eql "/onca/xml"
-        end
-      end
-
-      context "#sign_query" do
+      context "#build_signed_query" do
         it "returns a signed query string" do
           @worker.secret = "secret"
           @worker.locale = "us"
-          query = @worker.send :sign_query
+          query = @worker.send :build_signed_query
           query.should match /&Signature=.*/
         end
       end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -67,6 +67,7 @@ files:
 - lib/sucker/request.rb
 - README.md
 - spec/integration/item_lookup_spec.rb
+- spec/integration/japan_spec.rb
 - spec/integration/seller_listing_search_spec.rb
 - spec/spec_helper.rb
 - spec/support/amazon_credentials.rb
@@ -109,6 +110,7 @@ specification_version: 3
 summary: A thin Ruby wrapper to the Amazon Product Advertising API
 test_files: 
 - spec/integration/item_lookup_spec.rb
+- spec/integration/japan_spec.rb
 - spec/integration/seller_listing_search_spec.rb
 - spec/spec_helper.rb
 - spec/support/amazon_credentials.rb