subtitle_converter 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 685a9eaefbcb8091dba91d86aa9909b9f38fa2bc
-  data.tar.gz: f8ee8b7c0be0be9dd4d0d19bed3f4e2983428ccf
+  metadata.gz: 191363dc27d70fda96cacb9df2c059f1e31a47fa
+  data.tar.gz: fb017b62cf4898b54d36929c868c0ee64f11e9f2
 SHA512:
-  metadata.gz: c329fee4d3006fe70bab24dc85725b3fc41cf55647deb6f9970d539a7ebb07dfd6a417ecf1037f3693997ea402aee2fc885478a7c681e9d6f902b42c1fe2236c
-  data.tar.gz: 1d8719e7c9e2ad734d13acb21cd44400f5df6dac1449df818bce61eeccd68d26a9f2f32247c650535b5504f108a1906cac318281543307390ae343b490064a9d
+  metadata.gz: 3f623e35c1d7a8cbb8b49be1f19a8f1a663fb3d6bfb54e295776a52bd44777974fc594030ae021de4c0fd579b2e43f39fe9116f24f180bd06a34036e62929f18
+  data.tar.gz: 087ba6ef0a6911ebc94d53fa573e5b4e066743877f03758bf7cfee8dd273f849b836899ddf0c45430f3319b8441774d22ac3a77c2d3fb8ee60832b1afb468978

data/README.md

@@ -14,4 +14,4 @@ http://wiki.videolan.org/SubRip
 
 *** Installation
 
-gem install subtitle_convertor
+gem install subtitle_converter

data/lib/subtitle_converter/stl_reader.rb

@@ -1,29 +1,26 @@
 # encoding: utf-8
 
 class STLReader
+
   attr_reader :stl_sub_title_lines
+
   def initialize
     @stl_sub_title_lines = []
   end
 
   def import_stl_content(file_name)
-    begin
-      file =File.open(file_name, "r")
-      parse_srt_content(file)
-      file.close
-    rescue SystemCallError
-      puts "File not found"
-    end
+    content = File.read(file_name)
+    parse_stl_content(content)
   end
 
-  private
-  def parse_srt_content(file)
-    @stl_sub_title_lines = file.select{|line|
+  def parse_stl_content(content)
+
+    @stl_sub_title_lines = content.lines.select { |line|
       line =~ /\d{2}(:[0-5]\d){3}\s+,\s+\d{2}(:[0-5]\d){3}\s+,\s+.*/
-    }.map{|line|
+    }.map { |line|
       line.gsub!(", \t", ",\t")
       line.gsub!("\t ,", "\t,")
       line.split("\t,\t").map(&:strip).join("#")
     }
   end
-end
+end

data/lib/subtitle_converter/sub_rib_writer.rb

@@ -24,7 +24,7 @@ class SubRibWriter
   end
 
   def to_file(filename)
-    file = File.open filename, "w" do |file|
+    File.open filename, "w" do |file|
       subrib_sub_title_lines.each do |line|
         file.puts line
       end

data/lib/subtitle_converter/subtitle_convertor.rb

@@ -1,22 +1,22 @@
 # encoding: utf-8
 
 class SubtitleConvertor
-  
+
   def from(filename)
     @reader = STLReader.new
     @reader.import_stl_content(filename)
     self
   end
-  
+
   def to(filename)
     @writer = SubRibWriter.new
     @output_file = filename
     self
   end
-  
+
   def convert
     @writer.parse_stl_lines(@reader.stl_sub_title_lines)
     @writer.to_file(@output_file)
   end
-  
-end
+
+end

data/lib/subtitle_converter/version.rb

@@ -1,4 +1,4 @@
 
 module SubtitleConverterVersion
-  VERSION = "0.0.3"
-end
+  VERSION = "0.0.4"
+end

data/spec/assets/IDEO_subtitles_en.txt

@@ -151,4 +151,4 @@ $TapeOffset			=	TRUE
 00:07:56:18	,	00:08:00:25	,	a belief that chaos can be constructive and teamwork
 00:08:00:26	,	00:08:02:26	,	a great deal of teamwork
 00:08:02:27	,	00:08:07:08	,	And these are the recipe for how innovation takes place
-00:08:07:09	,	00:08:11:24	,	This is Jack Smith for Nightline, Palo Alto, California
+00:08:07:09	,	00:08:11:24	,	This is Jack Smith for Nightline, Palo Alto, California

data/spec/stl_reader_spec.rb

@@ -2,10 +2,13 @@
 require 'subtitle_converter'
 
 describe STLReader do
+
   describe "read stl file and read it content into memory" do
+
     let(:stl_reader) { STLReader.new }
+
     let(:data)    {
-      "00:00:03:15\t,\t00:00:05:26\t,\tTonight, The Deep Dive.\r
+      "00:00:03:15\t,\t00:00:05:26\t,\tTonight, The Deep Dive.
        00:00:05:27\t,\t00:00:10:01\t,\tOne company's secret weapon for innovation"
     }
 
@@ -14,14 +17,9 @@ describe STLReader do
     ]}
 
     it "should open STL file and import content to 'srt_sub_title_lines'" do
-      File.stub(:open).with("file_name","r") { StringIO.new(data) }
+      File.stub(:read).with("file_name") { data }
       stl_reader.import_stl_content("file_name")
       stl_reader.stl_sub_title_lines.should eq(result)
     end
-
-    it "should inform 'file not found' in case target file doesn't exist" do
-      stl_reader.should_receive(:puts).with("File not found")
-      stl_reader.import_stl_content("not_existing_file")
-    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: subtitle_converter
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Twin Panichsombat