subroutine 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e18f4755b49b956d0e5abd733989f3feedd348b3
-  data.tar.gz: da11b405e0ca016dc7be52304163fc8587b8f029
+SHA256:
+  metadata.gz: 37b6c047ab472cc0e240f78a2fe4998b5a5eb7b1316e2ee16eebe0e335db2986
+  data.tar.gz: ad505a2fd476b71972bce1426f7235b2f5e6577a258a696771c1fb105b744063
 SHA512:
-  metadata.gz: 3872c222ed0500c93392ab1d59b6f50372936d8f9f0d057c7f06b6d063e62cc4275b05216cd43faed9cd6b3a9278ce6a7c0813cecaa732710cbfdd51d2264cd3
-  data.tar.gz: ccba571c511e97061fbc4211f797d0dbf3f207955f3c001501fa3086371c6fd80643c2e3922b8eb6ffcfb582b600f1b71bb20774f92a4a21e5d4b7e54d0512f3
+  metadata.gz: 0b05231e05c2e1eb6153f489b25e24b5499d2bf6fdb2ef7cbd2e814dc3ffa50f50966d49fb21f3a0b71158856574e89fab59a01b330d76152767a084b7622877
+  data.tar.gz: dbde52dda2095ee0f29b7c7ca35e5305d45e698120ed2f0d3ffd51612e8cf21bf9bd0b82fa1a1d1dfcae708bf3e4a337856108d554d096d6c42253828b73fe1c

data/.ruby-gemset

@@ -0,0 +1 @@
+subroutine

data/.ruby-version

@@ -0,0 +1 @@
+2.5.1

data/.travis.yml

@@ -4,9 +4,10 @@ sudo: false
 rvm:
   - 2.0.0
   - 2.1.1
+  - 2.2.3
+  - 2.5.1
   - jruby
 
 gemfile:
-  - gemfiles/am40.gemfile
   - gemfiles/am41.gemfile
-  - gemfiles/am42.gemfile
+  - gemfiles/am42.gemfile

data/lib/subroutine/op.rb

@@ -187,7 +187,8 @@ module Subroutine
       rescue Exception => e
         if e.respond_to?(:record)
           inherit_errors(e.record) unless e.record == self
-          raise ::Subroutine::Failure.new(self)
+          new_e = ::Subroutine::Failure.new(self)
+          raise new_e, new_e.message, e.backtrace
         else
           raise
         end

data/lib/subroutine/version.rb

@@ -2,7 +2,7 @@ module Subroutine
 
   MAJOR = 0
   MINOR = 6
-  PATCH = 2
+  PATCH = 3
   PRE   = nil
 
   VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join('.')

data/test/subroutine/base_test.rb

@@ -266,5 +266,18 @@ module Subroutine
       refute op.submit
     end
 
+    def test_it_does_not_omit_the_backtrace_from_the_original_error
+      op = ::ErrorTraceOp.new
+      begin
+        op.submit!
+      rescue Exception => e
+        found = e.backtrace.detect do |msg|
+          msg =~ /test\/support\/ops\.rb:[\d]+.+foo/
+        end
+
+        refute_nil found, "Expected backtrace to include original caller of foo"
+      end
+    end
+
   end
 end

data/test/support/ops.rb

@@ -273,3 +273,30 @@ class NoOutputNoSuccessOp < ::Subroutine::Op
     errors.add(:foo, "bar")
   end
 end
+
+class ErrorTraceOp < ::Subroutine::Op
+
+  class SomeObject
+    include ::ActiveModel::Model
+    include ::ActiveModel::Validations::Callbacks
+
+    def foo
+      errors.add(:base, "Failure of things")
+      raise Subroutine::Failure.new(self)
+    end
+
+    def bar
+      foo
+    end
+  end
+
+  class SubOp < ::Subroutine::Op
+    def perform
+      SomeObject.new.bar
+    end
+  end
+
+  def perform
+    SubOp.submit!
+  end
+end

data/test/test_helper.rb

@@ -3,10 +3,10 @@ require 'minitest/autorun'
 require 'minitest/unit'
 
 require 'minitest/reporters'
-require 'mocha/mini_test'
+require 'mocha/minitest'
 
 Minitest::Reporters.use!([Minitest::Reporters::DefaultReporter.new])
 
-class TestCase < (MiniTest::Unit::TestCase rescue ::MiniTest::Test); end
+class TestCase < ::Minitest::Test; end
 
 require_relative 'support/ops'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subroutine
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Mike Nelson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-11 00:00:00.000000000 Z
+date: 2018-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -102,6 +102,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".ruby-gemset"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -150,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Feature-driven operation objects.