subroutine 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 481c515ae237b913f46e2d14a675158516d83ab2
-  data.tar.gz: d57eb792cba74077af2c4dcbc4f500a941931808
+  metadata.gz: e7c6319f48d838f3994441f16a3688c7b0394ef7
+  data.tar.gz: 00631d11cdd531f528a861704cc1d486192f5e7f
 SHA512:
-  metadata.gz: 7deb258fb423207af9997ca3900554492c0038ea891f81e0af696b367c4a6953ec58405977115ce42a07ac56cc34a689860b0ac56524b139a7560356e42a07fb
-  data.tar.gz: 32b8ca20632f2bcaba78b1fac42478d0589ccdc3c04eb4a08eb4eba018215610ce23c2fc1667fcd89494e2edfad69268cfcc7538d8fbae458e3b7d8cd507868b
+  metadata.gz: b5c74968c39618e10977a8345a38b6bd817b12cfd9ac5331667ef70ed6f4228074b7c10f14f2ee86fb833b18072948d32cc0d87a2668af1133bccca32d9177a2
+  data.tar.gz: 2fc2619896094a171c49a14e89136952637cf1e1d1d46eea1a4e2dbcd629968316490409916e6fe745607ff7af66f481babc099eb2bfff54787463a12b5f0941

data/README.md

@@ -390,7 +390,26 @@ class BaseOp < ::Subroutine::Op
 end
 ```
 
-## Todo
+## Subroutine::Factory
 
-1. Enable ActiveModel 3.0-3.2 users by removing the ActiveModel::Model dependency.
-2. Demo app?
+There is a separate gem [subroutine-factory](https://github.com/mnelson/subroutine-factory) which enables you to easily utilize factories and operations to produce
+test data. It's a great replacement to FactoryGirl, as it ensures the data entering your DB is getting there via a real
+world operation.
+
+```ruby
+# support/factories/signups.rb
+Subroutine::Factory.define :signup do
+  op ::SignupOp
+
+  inputs :email, sequence{|n| "foo{n}@example.com" }
+  inputs :password, "password123"
+
+  # by default, the op will be returned when the factory is used.
+  # this `output` returns the value of the accessor on the resulting op
+  output :user
+end
+
+# signup_test.rb
+user = Subroutine::Factory.create :signup
+user = Subroutine::Factory.create :signup, email: "foo@bar.com"
+```

data/lib/subroutine/filtered_errors.rb

@@ -0,0 +1,10 @@
+module Subroutine
+  class FilteredErrors < SimpleDelegator
+
+    def add(*args)
+      return if __getobj__.instance_variable_get('@base')._error_ignores[args[0].to_sym]
+      __getobj__.add(*args)
+    end
+
+  end
+end

data/lib/subroutine/op.rb

@@ -3,6 +3,7 @@ require 'active_model'
 
 require "subroutine/failure"
 require "subroutine/type_caster"
+require "subroutine/filtered_errors"
 
 module Subroutine
 
@@ -40,6 +41,12 @@ module Subroutine
 
       alias_method :fields, :field
 
+      def ignore_error(*field_names)
+        field_names.each do |f|
+          _ignore_errors(f)
+        end
+      end
+      alias_method :ignore_errors, :ignore_error
 
       def inputs_from(*ops)
         ops.each do |op|
@@ -53,6 +60,7 @@ module Subroutine
         super
         child._fields = self._fields.dup
         child._error_map = self._error_map.dup
+        child._error_ignores = self._error_ignores.dup
       end
 
 
@@ -80,6 +88,10 @@ module Subroutine
           end
         end
 
+        if options[:ignore_errors]
+          _ignore_errors(field_name)
+        end
+
         class_eval <<-EV, __FILE__, __LINE__ + 1
 
           def #{field_name}=(v)
@@ -103,6 +115,10 @@ module Subroutine
 
       end
 
+      def _ignore_errors(field_name)
+        self._error_ignores[field_name.to_sym] = true
+      end
+
     end
 
 
@@ -112,6 +128,9 @@ module Subroutine
     class_attribute :_error_map
     self._error_map = {}
 
+    class_attribute :_error_ignores
+    self._error_ignores = {}
+
     attr_reader :original_params
     attr_reader :params
 
@@ -121,6 +140,9 @@ module Subroutine
       @params           = {}
     end
 
+    def errors
+      @filtered_errors ||= Subroutine::FilteredErrors.new(super)
+    end
 
     def submit!
       unless submit

data/lib/subroutine/version.rb

@@ -2,7 +2,7 @@ module Subroutine
 
   MAJOR = 0
   MINOR = 1
-  PATCH = 2
+  PATCH = 3
   PRE   = nil
 
   VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join('.')

data/test/subroutine/base_test.rb

@@ -131,5 +131,18 @@ module Subroutine
 
     end
 
+    def test_it_ignores_specific_errors
+      op = ::WhateverSignupOp.submit
+      assert_equal [], op.errors[:whatever]
+    end
+
+    def test_it_does_not_inherit_ignored_errors
+      op = ::WhateverSignupOp.new
+      other = ::SignupOp.new
+      other.errors.add(:whatever, "fail")
+      op.send(:inherit_errors, other)
+      assert_equal [], op.errors[:whatever]
+    end
+
   end
 end

data/test/support/ops.rb

@@ -57,6 +57,10 @@ class SignupOp < ::Subroutine::Op
     ::User
   end
 end
+class WhateverSignupOp < ::SignupOp
+  string :whatever, ignore_errors: true
+  validates :whatever, presence: true
+end
 
 class AdminSignupOp < ::SignupOp
 
@@ -73,8 +77,8 @@ end
 class BusinessSignupOp < ::Subroutine::Op
 
   string :business_name
-  inputs_from ::SignupOp
 
+  inputs_from ::SignupOp
 end
 
 class DefaultsOp < ::Subroutine::Op

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subroutine
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Mike Nelson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-08 00:00:00.000000000 Z
+date: 2015-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -101,6 +101,7 @@ files:
 - gemfiles/am42.gemfile
 - lib/subroutine.rb
 - lib/subroutine/failure.rb
+- lib/subroutine/filtered_errors.rb
 - lib/subroutine/op.rb
 - lib/subroutine/type_caster.rb
 - lib/subroutine/version.rb