subprocess 1.0.0 → 1.1.0

data/README.md

@@ -1,6 +1,8 @@
 Subprocess
 ==========
 
+![Jacques Cousteau Submarine](http://i.imgur.com/lmej24F.jpg)
+
 A port of Python's excellent subprocess module to Ruby.
 
 Many thanks to [Bram Swenson][bram], the author of the old [subprocess][old]

data/lib/subprocess.rb

@@ -98,7 +98,6 @@ module Subprocess
   # @return [String] Text interpretation
   #
   def self.status_to_s(status, convert_high_exit=true)
-
     # use an array just in case we somehow get a status with all the bits set
     parts = []
     if status.exited?
@@ -109,17 +108,15 @@ module Subprocess
         sig_num = status.exitstatus - 128
 
         # sigh, why is ruby so silly
-        begin
+        if Signal.respond_to?(:signame)
           # ruby 2.0 way
           sig_name = Signal.signame(sig_num)
-        rescue NoMethodError
-          begin
-            # ruby 1.9 way
-            sig_name = Signal.list.key(sig_num)
-          rescue NoMethodError
-            # ruby 1.8 way
-            sig_name = Signal.list.index(sig_num)
-          end
+        elsif Signal.list.respond_to?(:key)
+          # ruby 1.9 way
+          sig_name = Signal.list.key(sig_num)
+        else
+          # ruby 1.8 way
+          sig_name = Signal.list.index(sig_num)
         end
 
         if sig_name
@@ -198,7 +195,8 @@ module Subprocess
     # Create a new process.
     #
     # @param [Array<String>] cmd The command to run and its arguments (in the
-    #   style of an `argv` array).
+    #   style of an `argv` array). Unlike Python's subprocess module, `cmd`
+    #   cannnot be a String.
     #
     # @option opts [IO, Fixnum, String, Subprocess::PIPE, nil] :stdin The `IO`,
     #   file descriptor number, or file name to use for the process's standard
@@ -236,6 +234,8 @@ module Subprocess
     #   in conjunction with {Subprocess::check_call}.
     # @yieldparam process [Process] The process that was just spawned.
     def initialize(cmd, opts={}, &blk)
+      raise ArgumentError, "cmd must be an Array" unless Array === cmd
+
       @command = cmd
 
       # Figure out what file descriptors we should pass on to the child (and
@@ -369,6 +369,9 @@ module Subprocess
       begin
         e = Marshal.load(control_r)
         e = "Unknown Failure" unless e.is_a?(Exception) || e.is_a?(String)
+        # Because we're throwing an exception and not returning a
+        # Process, we need to make sure the child gets reaped
+        wait
         raise e
       rescue EOFError # Nothing to read? Great!
       ensure
@@ -509,18 +512,21 @@ module Subprocess
     end
 
     private
-    # Return a pair of values (child, ext), which are how the given file
-    # descriptor should appear to the child and the external world. ext is only
-    # non-nil in the case of a pipe (in fact, we just return a list of length
-    # one, since ruby will unpack nils from missing list items).
+    # Return a pair of values (child, mine), which are how the given file
+    # descriptor should appear to the child and to this process, respectively.
+    # "mine" is only non-nil in the case of a pipe (in fact, we just return a
+    # list of length one, since ruby will unpack nils from missing list items).
+    #
+    # If you pass either an IO or an Integer (i.e., a raw file descriptor), a
+    # private copy of it will be made using `#dup`.
     def parse_fd(fd, mode)
-      ret = case fd
+      fds = case fd
       when PIPE
         IO.pipe
       when IO
-        [fd]
+        [fd.dup]
       when Integer
-        [IO.new(fd, mode)]
+        [IO.new(fd, mode).dup]
       when String
         [File.open(fd, mode)]
       when nil
@@ -529,7 +535,7 @@ module Subprocess
         raise ArgumentError
       end
 
-      mode == 'r' ? ret : ret.reverse
+      mode == 'r' ? fds : fds.reverse
     end
 
     def mark_fd_cloexec(fd)

data/lib/subprocess/version.rb

@@ -1,3 +1,3 @@
 module Subprocess
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: subprocess
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-19 00:00:00.000000000 Z
+date: 2014-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -74,8 +74,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/subprocess.rb
 - lib/subprocess/version.rb
+- lib/subprocess.rb
 - README.md
 homepage: https://github.com/stripe/subprocess
 licenses:
@@ -90,18 +90,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 84211792966870882
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 84211792966870882
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -109,3 +103,4 @@ signing_key:
 specification_version: 3
 summary: A port of Python's subprocess module to Ruby
 test_files: []
+has_rdoc: