subflag-rails 0.6.4 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e50478370bd25d61af6b4ba0e0d6c67544e5d0ae2403b50495584f16f549e3e6
-  data.tar.gz: 54e5cc2ef88f6053e71aa23fa7c380350f2cddc93fd3f92e75b5e6a13e6934bb
+  metadata.gz: 44e409a1256b7345aeac0b7331b0f62f0d3567a3264ecbf0b545c45536c4394e
+  data.tar.gz: 2ee8e1d0ed08753557fc1116855c56c9479870560c754b208295f9953ace4ae6
 SHA512:
-  metadata.gz: 96240398a0e33351f4a977e02fa0259637c37b5f1b576504fea0486ff96ecc62af1da1f874f1139c400ce082b796661c8e1bdea4ec357e328bc7c9021289733d
-  data.tar.gz: e42adc498fa3dffe58a0945a1c3c240a2d90509e02aef9d21c4c91f117a4358ffb620a4b0fc0e31c9827e7826275b5b7233d5dee3f6904c3284a39e809250620
+  metadata.gz: f75bc923804895371719e8ac2290440ecd75071232ca2b78905c5c13564908a9990e7122995b0bb8a0ca311a5d5f31b6e1e2d94831e86d8136b3f50bb6f5ac4f
+  data.tar.gz: 5a661e0587dc7c22373684a22a4ca753910378b36ca923dd4db6aabdc95d1cffa9254a5c00a22d90301d7cacb1733520ae09e2657b56d2ddac9784cea6c85506

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.6.6] - 2026-07-30
+
+### Fixed
+
+- **`prefetch_all` / `subflag_prefetch` returned untargeted base values for the `active_record` backend**: `prefetch_from_active_record` now calls `flag.evaluate(context:)` instead of `flag.typed_value`, so prefetched values match what `subflag_enabled?` / `Subflag.flags(...).x?` return for flags with `targeting_rules` or percentage rollouts ([#1](https://github.com/subflag/sdk/issues/1))
+- **Prefetch/request cache was effectively unhittable whenever a `user:`/`context:` was passed**: cache keys were derived from `EvaluationContext#hash`, which is identity-based (the class overrides `==` but not `hash`), so separately-built contexts with identical fields never matched. Cache keys now derive from `EvaluationContext#fields.hash`, which is content-based.
+
 ## [0.6.4] - 2026-01-23
 
 ### Changed

data/lib/subflag/rails/backends/active_record_provider.rb

@@ -32,7 +32,7 @@ module Subflag
       #
       class ActiveRecordProvider
         def metadata
-          { name: "Subflag ActiveRecord Provider" }
+          OpenFeature::SDK::Provider::ProviderMetadata.new(name: "Subflag ActiveRecord Provider")
         end
 
         def init; end
@@ -72,7 +72,7 @@ module Subflag
           end
 
           # Convert OpenFeature context to hash for targeting evaluation
-          context = context_to_hash(evaluation_context)
+          context = ContextBuilder.to_hash(evaluation_context)
           value = flag.evaluate(context: context, expected_type: expected_type)
 
           # Determine if targeting matched
@@ -80,26 +80,6 @@ module Subflag
           resolution(value, reason: reason, variant: "default")
         end
 
-        def context_to_hash(evaluation_context)
-          return nil if evaluation_context.nil?
-
-          # OpenFeature::SDK::EvaluationContext stores fields as instance variables
-          # We need to extract them into a hash for our targeting engine
-          if evaluation_context.respond_to?(:to_h)
-            evaluation_context.to_h
-          elsif evaluation_context.respond_to?(:fields)
-            evaluation_context.fields
-          else
-            # Fallback: extract instance variables
-            hash = {}
-            evaluation_context.instance_variables.each do |var|
-              key = var.to_s.delete("@")
-              hash[key] = evaluation_context.instance_variable_get(var)
-            end
-            hash
-          end
-        end
-
         def resolution(value, reason:, variant: nil)
           OpenFeature::SDK::Provider::ResolutionDetails.new(
             value: value,

data/lib/subflag/rails/backends/memory_provider.rb

@@ -26,7 +26,7 @@ module Subflag
         end
 
         def metadata
-          { name: "Subflag Memory Provider" }
+          OpenFeature::SDK::Provider::ProviderMetadata.new(name: "Subflag Memory Provider")
         end
 
         def init; end

data/lib/subflag/rails/client.rb

@@ -132,7 +132,7 @@ module Subflag
       # Prefetch flags from Subflag Cloud API
       def prefetch_from_subflag_api(user:, context:)
         ctx = ContextBuilder.build(user: user, context: context)
-        context_hash = ctx ? ctx.hash : "no_context"
+        context_hash = context_cache_key(ctx)
 
         # Use Rails.cache for cross-request caching if enabled
         if configuration.rails_cache_enabled?
@@ -189,29 +189,44 @@ module Subflag
         return [] unless RequestCache.enabled?
 
         ctx = ContextBuilder.build(user: user, context: context)
-        context_hash = ctx ? ctx.hash : "no_context"
+        context_hash = context_cache_key(ctx)
+        context_data = ContextBuilder.to_hash(ctx)
 
         prefetched = []
 
         Subflag::Rails::Flag.enabled.find_each do |flag|
+          value = flag.evaluate(context: context_data)
+          reason = flag.targeting_rules.present? && context_data.present? ? "TARGETING_MATCH" : "STATIC"
+
           prefetch_key = "subflag:prefetch:#{flag.key}:#{context_hash}"
           RequestCache.current_cache[prefetch_key] = PrefetchedFlag.new(
             flag_key: flag.key,
-            value: flag.typed_value,
-            reason: "STATIC",
+            value: value,
+            reason: reason,
             variant: "default"
           )
-          prefetched << { flag_key: flag.key, value: flag.typed_value }
+          prefetched << { flag_key: flag.key, value: value }
         end
 
         prefetched
       end
 
       def build_cache_key(flag_key, ctx, type)
-        context_hash = ctx ? ctx.hash : "no_context"
+        context_hash = context_cache_key(ctx)
         "subflag:#{flag_key}:#{context_hash}:#{type}"
       end
 
+      # A stable cache-key fragment for an evaluation context.
+      #
+      # OpenFeature::SDK::EvaluationContext overrides #== but not #hash, so its
+      # default Object#hash is identity-based and differs across separately-built
+      # instances with identical fields. #fields is a plain Hash, whose #hash IS
+      # content-based, so two contexts built from the same user/context data
+      # produce the same cache key.
+      def context_cache_key(ctx)
+        ctx ? ctx.fields.hash : "no_context"
+      end
+
       def openfeature_client
         @openfeature_client ||= OpenFeature::SDK.build_client
       end
@@ -303,7 +318,7 @@ module Subflag
       def get_prefetched_value(flag_key, ctx, expected_type)
         return nil unless RequestCache.enabled?
 
-        context_hash = ctx ? ctx.hash : "no_context"
+        context_hash = context_cache_key(ctx)
         prefetch_key = "subflag:prefetch:#{flag_key}:#{context_hash}"
         result = RequestCache.current_cache[prefetch_key]
 
@@ -317,7 +332,7 @@ module Subflag
       def get_prefetched_result(flag_key, ctx)
         return nil unless RequestCache.enabled?
 
-        context_hash = ctx ? ctx.hash : "no_context"
+        context_hash = context_cache_key(ctx)
         prefetch_key = "subflag:prefetch:#{flag_key}:#{context_hash}"
         RequestCache.current_cache[prefetch_key]
       end

data/lib/subflag/rails/context_builder.rb

@@ -13,6 +13,28 @@ module Subflag
         new(user: user, context: context).build
       end
 
+      # Convert an OpenFeature EvaluationContext (or nil) into a plain Hash
+      # suitable for Flag#evaluate / TargetingEngine.
+      #
+      # @param evaluation_context [OpenFeature::SDK::EvaluationContext, nil]
+      # @return [Hash, nil]
+      def self.to_hash(evaluation_context)
+        return nil if evaluation_context.nil?
+
+        if evaluation_context.respond_to?(:to_h)
+          evaluation_context.to_h
+        elsif evaluation_context.respond_to?(:fields)
+          evaluation_context.fields
+        else
+          hash = {}
+          evaluation_context.instance_variables.each do |var|
+            key = var.to_s.delete("@")
+            hash[key] = evaluation_context.instance_variable_get(var)
+          end
+          hash
+        end
+      end
+
       def initialize(user: nil, context: nil)
         @user = user
         @context = context || {}

data/lib/subflag/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Subflag
   module Rails
-    VERSION = "0.6.4"
+    VERSION = "0.6.6"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subflag-rails
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.6
 platform: ruby
 authors:
 - Subflag
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-01-23 00:00:00.000000000 Z
+date: 2026-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: openfeature-sdk