styled_inputs 0.1.0 → 0.1.1

data/CHANGELOG.rdoc

@@ -1,5 +1,10 @@
 == master
 
+== 0.1.1 / 2008-12-28
+
+* Don't style hidden inputs
+* Fix input styling not always being included on classes directly including ActionView::Helpers::TagHelper
+
 == 0.1.0 / 2008-12-14
 
 * Remove the PluginAWeek namespace

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/contrib/sshpublisher'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'styled_inputs'
-  s.version           = '0.1.0'
+  s.version           = '0.1.1'
   s.platform          = Gem::Platform::RUBY
   s.summary           = 'Adds automated styling of input fields with css classes'
   

data/lib/styled_inputs.rb

@@ -24,23 +24,4 @@ require 'styled_inputs/extensions/instance_tag'
 #   text_field_tag('name', :class => 'selected')        # => <input class="text selected" id="name" name="name" type="text" />
 #   text_field_tag('name', :class => 'selected shadow') # => <input class="text selected shadow" id="name" name="name" type="text" />
 module StyledInputs
-  # Appends the input type to the value currently stored in the html options
-  # for the tag.
-  def styled_input(name, options = nil)
-    options = (options || {}).stringify_keys
-    
-    if name.to_s == 'input' && options.include?('type')
-      options['class'] = (options['class'].to_s + " #{options['type']}").strip
-    end
-    
-    options
-  end
-end
-
-ActionController::Base.class_eval do
-  helper StyledInputs
-end
-
-ActionView::Helpers::InstanceTag.class_eval do
-  include StyledInputs
 end

data/lib/styled_inputs/extensions/instance_tag.rb

@@ -1,22 +1,6 @@
-module StyledInputs
-  module Extensions #:nodoc:
-    # Adds support for hooking calls to +tag+ for form fields
-    module InstanceTag
-      def self.included(base) #:nodoc:
-        base.class_eval do
-          alias_method_chain :tag, :styled_inputs
-        end
-      end
-      
-      # Ensure that the options are updated for input tags before generating
-      # the html for the tag
-      def tag_with_styled_inputs(name, options, *args) #:nodoc:
-        tag_without_styled_inputs(name, styled_input(name, options), *args)
-      end
-    end
-  end
-end
-
+# ActiveRecordHelper chains InstanceTag's +tag+ implementation.  As a result,
+# in order to add styled inputs, that re-implementation needs to be chained
+# again.
 ActionView::Helpers::InstanceTag.class_eval do
-  include StyledInputs::Extensions::InstanceTag
+  alias_method_chain :tag, :styled_inputs
 end

data/lib/styled_inputs/extensions/tag_helper.rb

@@ -1,22 +1,19 @@
-module StyledInputs
-  module Extensions #:nodoc:
-    # Adds support for hooking calls to +tag+
-    module TagHelper
-      def self.included(base) #:nodoc:
-        base.class_eval do
-          alias_method_chain :tag, :styled_inputs
-        end
-      end
-      
-      # Ensure that the options are updated for input tags before generating
-      # the html for the tag
-      def tag_with_styled_inputs(name, options = nil, *args) #:nodoc:
-        tag_without_styled_inputs(name, styled_input(name, options), *args)
-      end
-    end
-  end
-end
-
+# The TagHelper module is re-opened directly instead of including additional
+# modules in order for the chained behavior to be applied to other, unanticipated
+# classes that include ActionView::Helpers::TagHelper directly.
 ActionView::Helpers::TagHelper.class_eval do
-  include StyledInputs::Extensions::TagHelper
+  # Appends the input type to the value currently stored in the html options
+  # for the tag.
+  def styled_input(name, options = nil)
+    options = (options || {}).stringify_keys
+    options['class'] = "#{options['class']} #{options['type']}".strip if name.to_s == 'input' && options.include?('type') && options['type'] != 'hidden'
+    options
+  end
+  
+  # Ensure that the options are updated for input tags before generating
+  # the html for the tag
+  def tag_with_styled_inputs(name, options = nil, *args) #:nodoc:
+    tag_without_styled_inputs(name, styled_input(name, options), *args)
+  end
+  alias_method_chain :tag, :styled_inputs
 end

data/test/helpers/date_helper_test.rb

@@ -0,0 +1,17 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class DateHelperTest < ActionView::TestCase
+  def test_should_not_style_hidden_date_fields_if_using_hidden
+    assert_equal '<input id="date_year" name="date[year]" type="hidden" value="1980" />', select_year(1980, :use_hidden => true).strip
+  end
+  
+  def test_should_not_style_hidden_date_fields_if_not_using_hidden
+    expected = <<-end_str
+<select id="date_year" name="date[year]">
+<option selected="selected" value="1980">1980</option>
+<option value="1981">1981</option>
+</select>
+end_str
+    assert_equal expected, select_year(1980, :start_year => 1980, :end_year => 1981)
+  end
+end

data/test/helpers/form_helper_test.rb

@@ -8,8 +8,6 @@ class FormHelperTest < ActionView::TestCase
                   :secret
   end
   
-  tests StyledInputs
-  
   def setup
     @person = Person.new
   end
@@ -22,8 +20,8 @@ class FormHelperTest < ActionView::TestCase
     assert_equal '<input class="password" id="person_secret" name="person[secret]" size="30" type="password" />', password_field(:person, :secret)
   end
   
-  def test_should_style_hidden_field
-    assert_equal '<input class="hidden" id="person_name" name="person[name]" type="hidden" />', hidden_field(:person, :name)
+  def test_should_not_style_hidden_field
+    assert_equal '<input id="person_name" name="person[name]" type="hidden" />', hidden_field(:person, :name)
   end
   
   def test_should_style_file_field
@@ -33,7 +31,7 @@ class FormHelperTest < ActionView::TestCase
   def test_should_style_check_box
     expected =
       '<input class="checkbox" id="person_agree" name="person[agree]" type="checkbox" value="1" />' +
-      '<input class="hidden" name="person[agree]" type="hidden" value="0" />'
+      '<input name="person[agree]" type="hidden" value="0" />'
     assert_equal expected, check_box(:person, :agree)
   end
   

data/test/helpers/form_tag_helper_test.rb

@@ -1,14 +1,12 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
 class FormTagHelperTest < ActionView::TestCase
-  tests StyledInputs
-  
   def test_should_style_text_field_tag
     assert_equal '<input class="text" id="name" name="name" type="text" />', text_field_tag('name')
   end
   
-  def test_should_style_hidden_field_tag
-    assert_equal '<input class="hidden" id="name" name="name" type="hidden" />', hidden_field_tag('name')
+  def test_should_not_style_hidden_field_tag
+    assert_equal '<input id="name" name="name" type="hidden" />', hidden_field_tag('name')
   end
   
   def test_should_style_file_field_tag

data/test/helpers/styled_inputs_test.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
 class StyledInputsTest < ActionView::TestCase
-  tests StyledInputs
-  
   def test_should_not_style_input_if_tag_is_not_input
     expected = {}
     assert_equal expected, styled_input('td', expected)

data/test/helpers/tag_helper_test.rb

@@ -1,8 +1,6 @@
 require File.dirname(__FILE__) + '/../test_helper'
 
 class TagHelperTest < ActionView::TestCase
-  tests StyledInputs
-  
   def test_should_allow_no_options_to_be_specified
     assert_equal '<br />', tag('br')
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: styled_inputs
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-12-14 00:00:00 -05:00
+date: 2008-12-28 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -32,6 +32,7 @@ files:
 - test/helpers/tag_helper_test.rb
 - test/helpers/styled_inputs_test.rb
 - test/helpers/form_helper_test.rb
+- test/helpers/date_helper_test.rb
 - test/helpers/form_tag_helper_test.rb
 - CHANGELOG.rdoc
 - init.rb
@@ -68,4 +69,5 @@ test_files:
 - test/helpers/tag_helper_test.rb
 - test/helpers/styled_inputs_test.rb
 - test/helpers/form_helper_test.rb
+- test/helpers/date_helper_test.rb
 - test/helpers/form_tag_helper_test.rb