stupidedi 1.2.20 → 1.3.21

data/lib/stupidedi/versions/functional_groups/005010/element_types/date_val.rb

@@ -90,7 +90,7 @@ module Stupidedi
                   end
                 end
 
-                ansi.element("DT.invalid#{id}") << "(#{ansi.invalid(@value.inspect)})"
+                ansi.element("DT.invalid#{id}") + "(#{ansi.invalid(@value.inspect)})"
               end
 
               # @return [String]

data/lib/stupidedi/versions/functional_groups/005010/element_types/fixnum_val.rb

@@ -100,7 +100,7 @@ module Stupidedi
                   end
                 end
 
-                ansi.element("Nn.invalid#{id}") << "(#{ansi.invalid(@value.inspect)})"
+                ansi.element("Nn.invalid#{id}") + "(#{ansi.invalid(@value.inspect)})"
               end
 
               # @return [String]

data/lib/stupidedi/versions/functional_groups/005010/element_types/float_val.rb

@@ -89,7 +89,7 @@ module Stupidedi
                   end
                 end
 
-                ansi.element(" R.invalid#{id}") << "(#{ansi.invalid(@value.inspect)})"
+                ansi.element(" R.invalid#{id}") + "(#{ansi.invalid(@value.inspect)})"
               end
 
               # @return [String]

data/lib/stupidedi/versions/functional_groups/005010/element_types/string_val.rb

@@ -79,7 +79,7 @@ module Stupidedi
                   end
                 end
 
-                ansi.element("AN.invalid#{id}") << "(#{ansi.invalid(@value.inspect)})"
+                ansi.element("AN.invalid#{id}") + "(#{ansi.invalid(@value.inspect)})"
               end
 
               # @return [String]

data/lib/stupidedi/versions/functional_groups/005010/element_types/time_val.rb

@@ -76,7 +76,7 @@ module Stupidedi
                   end
                 end
 
-                ansi.element("TM.invalid#{id}") << "(#{ansi.invalid(@value.inspect)})"
+                ansi.element("TM.invalid#{id}") + "(#{ansi.invalid(@value.inspect)})"
               end
 
               # @return [String]

data/lib/stupidedi/versions/interchanges/00200/element_defs.rb

@@ -98,7 +98,7 @@ module Stupidedi
 
             def inspect
               id = definition.try{|d| ansi.bold("[#{d.id}]") }
-              ansi.element("SeparatorElementVal.value#{id}") << "(#{@value || "nil"})"
+              ansi.element("SeparatorElementVal.value#{id}") + "(#{@value || "nil"})"
             end
           end
 

data/lib/stupidedi/versions/interchanges/00300/element_defs.rb

@@ -98,7 +98,7 @@ module Stupidedi
 
             def inspect
               id = definition.try{|d| ansi.bold("[#{d.id}]") }
-              ansi.element("SeparatorElementVal.value#{id}") << "(#{@value || "nil"})"
+              ansi.element("SeparatorElementVal.value#{id}") + "(#{@value || "nil"})"
             end
           end
 

data/lib/stupidedi/versions/interchanges/00400/element_defs.rb

@@ -98,7 +98,7 @@ module Stupidedi
 
             def inspect
               id = definition.try{|d| ansi.bold("[#{d.id}]") }
-              ansi.element("SeparatorElementVal.value#{id}") << "(#{@value || "nil"})"
+              ansi.element("SeparatorElementVal.value#{id}") + "(#{@value || "nil"})"
             end
           end
 

data/lib/stupidedi/versions/interchanges/00401/element_defs.rb

@@ -99,7 +99,7 @@ module Stupidedi
 
             def inspect
               id = definition.try{|d| ansi.bold("[#{d.id}]") }
-              ansi.element("SeparatorElementVal.value#{id}") << "(#{@value || "nil"})"
+              ansi.element("SeparatorElementVal.value#{id}") + "(#{@value || "nil"})"
             end
           end
 

data/spec/examples/integration/navigating_spec.rb

@@ -49,6 +49,50 @@ describe "Navigating" do
     end
   end
 
+  context "repeatable segments" do
+    specify "can be iterated" do
+      expect(lambda do
+        payment.flatmap do |m|
+          m.iterate(:ISA) do |isa|
+            raise "didn't expect a second ISA segment"
+          end
+        end
+      end).not_to raise_error
+    end
+
+    specify "can be iterated" do
+      expect(lambda do
+        payment.flatmap do |m|
+          m.iterate(:GS) do |gs|
+            expect(gs.segment.tap do |segment|
+              expect(segment.node.id).to eq(:GS)
+            end).to be_defined
+
+            gs.iterate(:ST) do |st|
+              expect(st.segment.tap do |segment|
+                expect(segment.node.id).to eq(:ST)
+              end).to be_defined
+            end
+          end
+        end
+      end).not_to raise_error
+    end
+  end
+
+  context "non-repeatable segments" do
+    specify "cannot be iterated" do
+      expect(lambda do
+        payment.flatmap do |m|
+          m.iterate(:GS) do |gs|
+            gs.iterate(:ST) do |st|
+              st.iterate(:BHT)
+            end
+          end
+        end
+      end).to raise_error("BHT segment is not repeatable")
+    end
+  end
+
   describe "error handling" do
     context "accessing an undefined element" do
       it "raises an exception" do

data/spec/examples/integration/nondeterminism_spec.rb

@@ -0,0 +1,165 @@
+require "spec_helper"
+require "pp"
+
+describe "Non-determinism" do
+  include NavigationMatchers
+
+  let(:strict)  { Stupidedi::Builder::BuilderDsl.build(config, true)  }
+  let(:relaxed) { Stupidedi::Builder::BuilderDsl.build(config, false) }
+
+  let(:config) do
+    Stupidedi::Config.default.customize do |c|
+      c.transaction_set.customize do |x|
+        x.register("005010", "BE", "999") { schema }
+      end
+    end
+  end
+
+  let(:schema) do
+    d = Stupidedi::Schema
+    r = Stupidedi::Versions::FunctionalGroups::FiftyTen::SegmentReqs
+    s = Stupidedi::Versions::FunctionalGroups::FiftyTen::SegmentDefs
+
+    d::TransactionSetDef.build("BE", "000", "Example of Ambiguous Grammar",
+      d::TableDef.header("Table 1",
+        s::ST.use(10, r::Mandatory, d::RepeatCount.bounded(1))),
+      d::TableDef.detail("Table 2",
+        d::LoopDef.build("Loop 1", d::RepeatCount.bounded(1),
+          s::N1.use(20, r::Mandatory, d::RepeatCount.bounded(1)),
+          s::N3.use(30, r::Optional,  d::RepeatCount.bounded(1))),
+        d::LoopDef.build("Loop 2", d::RepeatCount.bounded(1),
+          s::N1.use(40, r::Mandatory, d::RepeatCount.bounded(1)),
+          s::N4.use(50, r::Optional,  d::RepeatCount.bounded(1)))),
+      d::TableDef.summary("Table 3",
+        s::SE.use(60, r::Mandatory, d::RepeatCount.bounded(1))))
+  end
+
+  let(:nondet_zero) { Fixtures.parse_("GH-129/1.txt") }
+  let(:nondet_five) { Fixtures.parse_("GH-129/1.txt") }
+  let(:nondet_nine) { Fixtures.parse_("GH-129/1.txt") }
+
+  def prelude(dsl)
+    dsl.ISA("00", "", "00", "", "ZZ", "_", "ZZ", "_",
+            Time.now.utc, Time.now.utc, "", "00501",
+            123456789, "1", "T", "")
+
+    dsl.GS("BE", "SENDER ID", "RECEIVER ID",
+           Time.now.utc, Time.now.utc, "1", "X", "005010")
+
+    dsl.ST("999", "0000", "005010")
+  end
+
+  context "generating an ambiguous segment" do
+    context "when strict" do
+      it "throws an exception" do
+        expect(lambda do
+          prelude(strict)
+            .N1("6Y", "BOB BELCHER")
+            .N1("6Y", "NON DETERMINISM") # could be Loop 1 or Loop 2
+        end).to raise_error \
+          "non-deterministic machine state: N1 Party Identification, N1 Party Identification"
+      end
+    end
+
+    context "when non-strict" do
+      it "does not throw an exception" do
+        expect(lambda do
+          prelude(relaxed)
+            .N1("6Y", "BOB BELCHER")
+            .N1("6Y", "NON DETERMINISM") # could be Loop 1 or Loop 2
+        end).not_to raise_error
+      end
+
+      context "with later unambiguous input" do
+        it "does not discard invalid trees" do
+          expect(prelude(relaxed)
+            .N1("6Y", "BOB BELCHER")
+            .N1("6Y", "NON DETERMINISM") # could be Loop 1 or Loop 2
+            .N3("OCEAN AVENUE")          # could only be Loop 1
+            .machine.active.length
+          ).to eq(2)
+        end
+
+        it "does not discard invalid trees" do
+          expect(prelude(relaxed)
+            .N1("6Y", "BOB BELCHER")
+            .N1("6Y", "NON DETERMINISM") # could be Loop 1 or Loop 2
+            .N4("UNKNOWN CITY")          # could only be Loop 2
+            .machine.active.length
+          ).to eq(2)
+        end
+      end
+    end
+  end
+
+  context "reading" do
+    def read(suffix, nondeterminism: 1)
+      input =
+        ["ISA*00*..........*01*SECRET....*ZZ*SUBMITTERS.ID..*ZZ*RECEIVERS.ID...*030101*1253*^*00501*000000905*1*T*:~",
+         "GS*BE*SENDER ID*RECEIVER ID*19991231*0802*1*x*005010~",
+         "ST*999*0000*005010~",
+         "N1*6Y*LINDA BELCHER~",
+         suffix].join("\n")
+
+      machine = Stupidedi::Builder::StateMachine.build(config)
+      machine.read(Stupidedi::Reader.build(input), nondeterminism: nondeterminism)
+    end
+
+    context "when nondenterminism = 1" do
+      it "ordinary input suceeds" do
+        machine, result = read("N3*OCEAN AVENUE~", nondeterminism: 1)
+
+        result.should_not be_fatal
+        result.reason.should eq("reached end of input without finding a segment identifier")
+        machine.should be_deterministic
+      end
+
+      it "ambiguous input causes a failure result" do
+        machine, result = read("N1*6Y*NON DETERMINISM~...", nondeterminism: 1)
+
+        result.should be_fatal # no usable parse tree
+        result.reason.should eq("too much non-determinism: N1 Party Identification, N1 Party Identification")
+        result.remainder.should eq("...")
+        machine.should_not be_deterministic
+      end
+    end
+
+    context "when nondenterminism = 2" do
+      it "acceptably ambiguous input succeeds" do
+        machine, result = read("N1*6Y*NON DETERMINISM~...", nondeterminism: 2)
+
+        result.should_not be_fatal # we have a usable parse tree, despite trailing garbage
+        result.remainder.should eq("...")
+        machine.should_not be_deterministic
+        machine.active.length.should eq(2)
+      end
+
+      it "too much ambiguity causes a failure" do
+        machine, result = read(
+          "N1*6Y*NON DETERMINISM~" \
+          "N1*6Y*THIS IS TOO MUCH~...", nondeterminism: 2)
+
+        result.should be_fatal # no useable parse tree
+        result.remainder.should eq("...")
+        machine.should_not be_deterministic
+        machine.active.length.should eq(1 + 2)
+      end
+    end
+
+    context "when nondenterminism = 3" do
+      it "too much ambiguity causes a failure" do
+        machine, result = read(
+          "N1*6Y*NON DETERMINISM~" \
+          "N1*6Y*BLAH BLAH BLAH~" \
+          "N1*6Y*THIS IS TOO MUCH~" \
+          "N1*6Y*NOT GONNA SEE THIS~...", nondeterminism: 3)
+
+        result.should be_fatal # no useable parse tree
+        result.remainder.should eq("N1*6Y*NOT GONNA SEE THIS~...")
+        machine.should_not be_deterministic
+        machine.active.length.should eq(1 + 2*2)
+      end
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stupidedi
 version: !ruby/object:Gem::Version
-  version: 1.2.20
+  version: 1.3.21
 platform: ruby
 authors:
 - Kyle Putnam/Isi Robayna
@@ -49,6 +49,7 @@ files:
 - README.md
 - Rakefile
 - bin/edi-ed
+- bin/edi-obfuscate
 - bin/edi-pp
 - doc/Generating.md
 - doc/Navigating.md
@@ -973,6 +974,7 @@ files:
 - lib/stupidedi/zipper/root_cursor.rb
 - spec/examples/integration/generating_spec.rb
 - spec/examples/integration/navigating_spec.rb
+- spec/examples/integration/nondeterminism_spec.rb
 - spec/examples/integration/parsing/005010/X091A1-HP835_spec.rb
 - spec/examples/integration/parsing/005010/X212-HR276_spec.rb
 - spec/examples/integration/parsing/005010/X221-HP835_spec.rb
@@ -1211,7 +1213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Parse, generate, validate ASC X12 EDI