stupidedi 1.1.0 → 1.2.1

data/lib/stupidedi/contrib/004010/transaction_set_defs/SW945.rb

@@ -0,0 +1,43 @@
+module Stupidedi
+  module Contrib
+    module FortyTen
+      module TransactionSetDefs
+        d = Schema
+        r = SegmentReqs
+        s = SegmentDefs
+
+        SW945 = d::TransactionSetDef.build("SW", "945",
+          "Warehouse Shipping Advice",
+
+          d::TableDef.header("Table 1 - Header",
+            s:: ST.use( 10, r::Mandatory, d::RepeatCount.bounded(1)),
+            s::W06.use( 20, r::Mandatory, d::RepeatCount.bounded(1)),
+
+            d::LoopDef.build("N1", d::RepeatCount.bounded(10),
+              s:: N1.use( 40, r::Mandatory, d::RepeatCount.bounded(1)),
+              s:: N3.use( 60, r::Optional,  d::RepeatCount.bounded(1)),
+              s:: N4.use( 70, r::Optional,  d::RepeatCount.bounded(1))),
+
+            s:: N9.use( 90, r::Optional,  d::RepeatCount.bounded(10)),
+            s::G62.use(110, r::Optional,  d::RepeatCount.bounded(5)),
+            s::NTE.use(120, r::Optional,  d::RepeatCount.bounded(20)),
+            s::W27.use(130, r::Optional,  d::RepeatCount.bounded(1))),
+
+          d::TableDef.header("Table 2 - Detail",
+            d::LoopDef.build("LX", d::RepeatCount.bounded(9999),
+              s:: LX.use(  5, r::Mandatory, d::RepeatCount.bounded(1)),
+              s::MAN.use( 10, r::Mandatory, d::RepeatCount.bounded(1))),
+
+            d::LoopDef.build("W12", d::RepeatCount.bounded(9999),
+              s::W12.use( 20, r::Mandatory, d::RepeatCount.bounded(1)),
+              s::G69.use( 30, r::Optional,  d::RepeatCount.bounded(5)),
+              s:: N9.use( 40, r::Optional,  d::RepeatCount.bounded(200)))),
+
+          d::TableDef.header("Table 3 - Summary",
+            s::W03.use( 10, r::Mandatory, d::RepeatCount.bounded(1)),
+            s:: SE.use( 30, r::Mandatory, d::RepeatCount.bounded(1))))
+
+      end
+    end
+  end
+end

data/lib/stupidedi/editor.rb

@@ -13,12 +13,15 @@ module Stupidedi
     autoload :ResultSet,    "stupidedi/editor/result_set"
 
     autoload :AbstractEd,         "stupidedi/editor/abstract_ed"
+    autoload :FourOhOneEd,        "stupidedi/editor/00401"
+    autoload :FortyTenEd,         "stupidedi/editor/004010"
     autoload :FiveOhOneEd,        "stupidedi/editor/00501"
     autoload :FiftyTenEd,         "stupidedi/editor/005010"
     autoload :TransactionSetEd,   "stupidedi/editor/transaction_set_ed"
     autoload :TransmissionEd,     "stupidedi/editor/transmission_ed"
 
-    autoload :X221, "stupidedi/editor/X221-HP835"
+    autoload :X12,  "stupidedi/editor/X12"
+#    autoload :X221, "stupidedi/editor/X221-HP835"
     autoload :X222, "stupidedi/editor/X222-HC837"
 
     # TA1

data/lib/stupidedi/editor/00401.rb

@@ -0,0 +1,341 @@
+module Stupidedi
+  module Editor
+
+    #
+    # Critiques (edits) interchanges (ISA/IEA) with version "00401", then
+    # selects the appropriate editor, according to the config, and edits
+    # each functional group (GS/GE)
+    #
+    class FourOhOneEd < AbstractEd
+
+      # @return [Config]
+      attr_reader :config
+
+      # @return [Time]
+      attr_reader :received
+
+      def initialize(config, received)
+        @config, @received =
+          config, received
+      end
+
+      # @return [ResultSet]
+      def critique(isa, acc)
+        # 000: No error
+
+        # 002: This Standard as Noted in the Control Standards Identifier is Not Supported
+        #   Check for InvalidEnvelope
+
+        # 003: This Version of the Controls is Not Supported
+        #   Check for InvalidEnvelope
+
+        # 004: The Segment Terminator is Invalid
+        #   We couldn't have produced a parse tree, StreamReader#next_segment
+        #   would have returned an Either.failure<Result.failure>
+
+        # 009: Unknown Interchange Receiver ID
+        #   This isn't for Stupidedi to decide
+
+        # 016: Invalid Interchange Standards Identifier Value
+        #   Check for InvalidEnvelope
+
+        # 022: Invalid Control Characters
+        #   What does this mean? TokenReader ignores control characters anyway,
+        #   so there will be no evidence of this in the parse tree
+
+        # 025: Duplicate Interchange Control Numbers
+        #   Need to critique the parent, TransmissionVal
+
+        # 028: Invalid Date in Deferred Delivery Request
+        # 029: Invalid Time in Deferred Delivery Request
+        # 030: Invalid Delivery Time Code in Deferred Delivery Request
+        # 031: Invalid Grade of Service
+        #   It seems these elements should not be sent to a trading partner,
+        #   they are used internally to schedule a delivery. Not sure what to do
+        #   about validating them in a general way...
+
+        acc.tap { critique_isa(isa, received, acc) }
+      end
+
+    private
+
+      def critique_isa(isa, received, acc)
+        # Authorization Information Qualifier
+        edit(:ISA01) do
+          isa.element(1).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "010", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "010", "is not an allowed value")
+            end
+          end
+        end
+
+        # Authorization Information
+        edit(:ISA02) do
+          isa.element(2).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "011", "must be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ta105(e, "R", "011", "is not a valid string")
+            end
+          end
+        end
+
+        # Security Information Qualifier
+        edit(:ISA03) do
+          isa.element(3).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "012", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "012", "is not an allowed value")
+            end
+          end
+        end
+
+        # Security Information
+        edit(:ISA04) do
+          isa.element(4).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "013", "must be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ta105(e, "R", "013", "is not a valid string")
+            end
+          end
+        end
+
+        # Interchange ID Qualifier
+        edit(:ISA05) do
+          isa.element(5).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "005", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "005", "is not an allowed value")
+            end
+          end
+        end
+
+        # Interchange Sender ID
+        edit(:ISA06) do
+          isa.element(6).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "006", "must be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ta105(e, "R", "006", "is not a valid string")
+            end
+          end
+        end
+
+        # Interchange ID Qualifier
+        edit(:ISA07) do
+          isa.element(7).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "007", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "007", "is not an allowed value")
+            end
+          end
+        end
+
+        # Interchange Receiver ID
+        edit(:ISA08) do
+          isa.element(8).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "008", "must be present")
+            end
+          end
+        end
+
+        # Interchange Date
+        edit(:ISA09) do
+          isa.element(9).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "014", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "014", "is not a valid date")
+            else
+              # Convert to a proper 4-digit year, by making the assumption
+              # that the date is less than 30 years old. Note we have to use
+              # Object#send to work around an incorrectly declared private
+              # method that wasn't fixed until after Ruby 1.8
+              date = e.node.oldest(received.send(:to_date) << 12*30)
+
+              if date > received.utc.send(:to_date)
+                acc.ta105(e, "R", "014", "must not be a future date")
+              end
+            end
+          end
+        end
+
+        # Interchange Time
+        edit(:ISA10) do
+          isa.element(10).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "015", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "015", "is not a valid time")
+            else
+              isa.element(9).reject{|f| f.node.invalid? }.tap do |f|
+                date = f.node.oldest(received.send(:to_date) << 12*30)
+
+                if e.node.to_time(date) > received.utc
+                  acc.ta105(e, "R", "015", "must not be a future time")
+                end
+              end
+            end
+          end
+        end
+
+        # Interchange Standards Identifier
+        edit(:ISA11) do
+          isa.element(11).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "026", "must be present")
+            end
+          end
+        end
+
+        # Interchange Version ID
+        edit(:ISA12) do
+          isa.element(12).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "026", "must be present")
+            end
+          end
+        end
+
+        # Interchange Control Number
+        edit(:ISA13) do
+          isa.element(13).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "018", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "018", "must be numeric")
+            elsif e.node <= 0
+              acc.ta105(e, "R", "018", "must be positive")
+            end
+          end
+        end
+
+        # Acknowledgment Requested
+        edit(:ISA14) do
+          isa.element(14).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "019", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "019", "is not an allowed value")
+            end
+          end
+        end
+
+        # Interchange Usage Indicator
+        edit(:ISA15) do
+          isa.element(15).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "020", "must be present")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "020", "is not an allowed value")
+            end
+          end
+        end
+
+        # Component Element Separator
+        edit(:ISA16) do
+          isa.element(16).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "027", "must be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ta105(e, "R", "027", "is not a valid string")
+            else
+              isa.element(11).tap do |f|
+                if e.node == f.node
+                  acc.ta105(e, "R", "027", "must be distinct from repetition separator")
+                end
+              end
+            end
+          end
+        end
+
+        m, gs06s = isa.find!(:GS), Hash.new{|h,k| h[k] = [] }
+        # Collect all the GS06 elements within this interchange
+        while m.defined?
+          m = m.flatmap do |gs|
+            edit_gs(gs, acc)
+
+            gs.element(6).tap{|e| gs06s[e.node.to_s] << e }
+            gs.find!(:GS)
+          end
+        end
+
+        # Group Control Number
+        edit(:GS06) do
+          gs06s.each do |number, dupes|
+            next if number.blank?
+            dupes.tail.each do |e|
+              acc.ak905(e, "R", "19", "must be unique within interchange")
+            end
+          end
+        end
+
+        edit(:IEA) do
+          isa.find(:IEA).tap do |iea|
+            edit_iea(iea, isa, gs06s.length, acc)
+          end.explain do
+            isa.segment.tap{|s| acc.ta105(s, "R", "023", "missing IEA segment") }
+          end
+        end
+      end
+
+      def edit_iea(iea, isa, gs_count, acc)
+        # @todo: acc.ta105(s, "024", "only one IEA segment is allowed")
+
+        # Number of Included Functional Groups
+        edit(:IEA01) do
+          iea.element(1).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "021", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "021", "must be numeric")
+            elsif e.node != gs_count
+              acc.ta105(e, "R", "021", "must equal the number of functional groups")
+            end
+          end
+        end
+
+        # Interchange Control Number
+        edit(:IEA02) do
+          iea.element(2).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "001", "must be present")
+            else
+              isa.element(13).reject{|f| e.node == f.node }.tap do
+                acc.ta105(e, "R", "001", "must match interchange header control number")
+              end
+            end
+          end
+        end
+      end
+
+      #
+      # @see FortyTenEd#critique
+      #
+      def edit_gs(gs, acc)
+        gs.segment.tap do |x|
+          unless x.node.invalid?
+            envelope_def = x.node.definition.parent.parent
+
+            # Invoke the version-specific functional group editor
+            if config.editor.defined_at?(envelope_def)
+              editor = config.editor.at(envelope_def)
+              editor.new(config, received).critique(gs, acc)
+            end
+          else
+            # Probably "unknown interchange version '...'"
+            acc.ak905(x, "R", "2", x.node.reason)
+          end
+        end
+      end
+    end
+
+  end
+end

data/lib/stupidedi/editor/004010.rb

@@ -0,0 +1,452 @@
+module Stupidedi
+  module Editor
+
+    #
+    # Critiques (edits) a "004010" functional groups (GS/GE), then selects the
+    # appropriate editor, according to the config, and edits each transaction
+    # set (ST/SE)
+    #
+    class FortyTenEd < AbstractEd
+
+      # @return [Config]
+      attr_reader :config
+
+      # @return [Time]
+      attr_reader :received
+
+      def initialize(config, received)
+        @config, @received =
+          config, received
+      end
+
+      def critique(gs, acc)
+        acc.tap { critique_gs(gs, acc) }
+      end
+
+    private
+
+      def critique_gs(gs, acc)
+        # Functional Group Code
+        edit(:GS01) do
+          gs.element(1).tap do |e|
+            if e.node.blank?
+              if e.node.usage.required?
+                acc.ak905(e, "R", "1", "must be present")
+              end
+            elsif e.node.usage.forbidden?
+              acc.ak905(e, "R", "1", "must not be present")
+            else
+              # @todo: The allowed value depends on the child transaction set,
+              # but the GS segment is not declared in the transaction set def.
+              # Furthermore, the functional group may contain many transaction
+              # sets, so we need to check it once we get to the ST segment...
+            end
+          end
+        end
+
+        # Application Sender's Code
+        edit(:GS02) do
+          gs.element(2).tap do |e|
+            if e.node.blank?
+              if e.node.usage.required?
+                acc.ak905(e, "R", "14", "must be present")
+              end
+            elsif e.node.usage.forbidden?
+              acc.ak905(e, "R", "14", "must not be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ak905(e, "R", "14", "is not a valid string")
+            end
+          end
+        end
+
+        # Application Receiver's Code
+        edit(:GS03) do
+          gs.element(3).tap do |e|
+            if e.node.blank?
+              acc.ak905(e, "R", "13", "must be present")
+            elsif e.node.invalid? or not config.editor.an?(e.node)
+              acc.ak905(e, "R", "13", "is not a valid string")
+            end
+          end
+        end
+
+        # Date
+        edit(:GS04) do
+          gs.element(4).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "024", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "024", "is not a valid date")
+            elsif e.node > received.utc.send(:to_date)
+              acc.ta105(e, "R", "024", "must not be a future date")
+            end
+          end
+        end
+
+        # Time
+        edit(:GS05) do
+          gs.element(5).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "024", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "024", "is not a valid time")
+            else
+              gs.element(4).reject{|f| f.node.invalid? }.tap do |f|
+                if e.node.to_time(f.node) > received.utc
+                  acc.ta105(e, "R", "024", "must not be a future date")
+                end
+              end
+            end
+          end
+        end
+
+        # Group Control Number
+        edit(:GS06) do
+          gs.element(6).tap do |e|
+            if e.node.blank?
+              acc.ak905(e, "R", "6", "must be present")
+            elsif e.node.invalid?
+              acc.ak905(e, "R", "6", "is not a valid string")
+            elsif e.node < 0
+              acc.ak905(e, "R", "6", "must be positive")
+            elsif e.node > 999_999_999
+              acc.ak905(e, "R", "6", "is too long")
+            end
+          end
+        end
+
+        # Responsible Agency Code
+        edit(:GS07) do
+          gs.element(7).tap do |e|
+            if e.node.blank?
+              acc.ta105(e, "R", "024", "must be present")
+            elsif e.node.invalid?
+              acc.ta105(e, "R", "024", "is not a valid string")
+            elsif not e.node.allowed?
+              acc.ta105(e, "R", "024", "is not an allowed value")
+            end
+          end
+        end
+
+        # Version/Release/Industry Identifier Code
+        edit(:GS08) do
+          gs.element(8).tap do |e|
+            if e.node.blank?
+              acc.ak905(e, "R", "2", "must be present")
+            end
+          end
+        end
+
+        st, st02s = gs.find!(:ST), Hash.new{|h,k| h[k] = [] }
+        # Collect all the ST02 elements within this functional group
+        while st.defined?
+          st = st.flatmap do |st|
+            critique_st(st, acc)
+
+            st.element(2).
+              tap{|e| st02s[e.node.to_s] << e }.
+              explain do
+                # The #element method failed because this was an invalid ST
+                # segment. To workaround that, we can get the SegmentTok and
+                # select the ST02 ElementTok (zero-based index)
+                st.segment.tap do |s|
+                  elements = s.node.segment_tok.element_toks
+                  st02s[elements.at(1).value] << s
+                end
+              end
+
+            st.find!(:ST)
+          end
+        end
+
+        edit(:ST) do
+          if st02s.empty?
+            gs.segment.tap{|s| acc.ik502(s, "R", "1", "missing ST segment") }
+          end
+        end
+
+        edit(:ST02) do
+          st02s.each do |number, es|
+            next if number.blank?
+            es.tail.each do |e|
+              acc.ik502(e, "R", "23", "must be unique within functional group")
+            end
+          end
+        end
+
+        edit(:GE) do
+          gs.find(:GE).tap do |ge|
+            critique_ge(ge, gs, st02s.length, acc)
+          end.explain do
+            gs.segment.tap{|s| acc.ak905(s, "R", "3", "missing GE segment") }
+          end
+        end
+      end
+
+      def critique_ge(ge, gs, st_count, acc)
+        # Number of Transaction Sets Included
+        edit(:GE01) do
+          ge.element(1).tap do |e|
+            if e.node.empty?
+              acc.ak905(e, "R", "5", "must be present")
+            elsif e.node.invalid?
+              acc.ak905(e, "R", "5", "must be numeric")
+            elsif e.node != st_count
+              acc.ak905(e, "R", "5", "must equal the number of transactions")
+            end
+          end
+        end
+
+        # Group Control Number
+        edit(:GE02) do
+          ge.element(2).tap do |e|
+            if e.node.empty?
+              acc.ak905(e, "R", "4", "must be present")
+            else
+              gs.element(6).reject{|f| e.node == f.node }.tap do |f|
+                acc.ak905(e, "R", "4", "must match functional group header control number")
+              end
+            end
+          end
+        end
+      end
+
+      def critique_st(st, acc)
+        st.segment.tap do |x|
+          unless x.node.invalid?
+            # Invoke a general transaction set editor, which will later
+            # dispatch to a guide-specific transaction set editor
+            editor = TransactionSetEd.new(config, received)
+            editor.critique(st, acc)
+          else
+            acc.ik502(x, "R", "I6", x.node.reason)
+            return
+          end
+        end
+
+        # Transaction Set Identifier Code
+        edit(:ST01) do
+          st.element(1).tap do |e|
+            if e.node.blank?
+              if e.node.usage.required?
+                acc.ik502(e, "R", "6", "must be present")
+              end
+            elsif e.node.usage.forbidden?
+              acc.ik502(e, "R", "6", "must not be present")
+            elsif e.node.invalid?
+              acc.ik502(e, "R", "6", "is not a valid identifier")
+            elsif not e.node.allowed?
+              acc.ik502(e, "R", "6", "is not an allowed value")
+            end
+          end
+        end
+
+        # Transaction Set Control Number
+        edit(:ST02) do
+          st.element(2).tap do |e|
+            if e.node.blank?
+              if e.node.usage.required?
+                acc.ik502(e, "R", "7", "must be present")
+              elsif e.node.usage.forbidden?
+                acc.ik502(e, "R", "7", "must not be present")
+              elsif e.node.invalid?
+                acc.ik502(e, "R", "7", "is not a valid string")
+              end
+            end
+          end
+        end
+
+        edit(:SE) do
+          st.find(:SE).tap do |se|
+            critique_se(se, st, acc)
+          end.explain do
+            st.segment.tap{|s| acc.ik502(s, "R", "2", "missing SE segment") }
+          end
+        end
+      end
+
+      def critique_se(se, st, acc)
+        # Number of Included Segments
+        edit(:SE01) do
+          se.element(1).tap do |e|
+            if e.node.empty?
+              if e.node.usage.required?
+                acc.ik502(e, "R", "4", "must be present")
+              end
+            elsif e.node.usage.forbidden?
+              acc.ik502(e, "R", "4", "must not be present")
+            elsif e.node.invalid?
+              acc.ik502(e, "R", "4", "must be numeric")
+            else
+              st.distance(se).tap do |d|
+                unless e.node == d + 1
+                  acc.ik502(e, "R", "4", "must equal the transaction segment count")
+                end
+              end
+            end
+          end
+        end
+
+        # Transaction Set Control Number
+        edit(:SE02) do
+          se.element(2).tap do |e|
+            if e.node.empty?
+              if e.node.usage.required?
+                acc.ik502(e, "R", "3", "must be present")
+              end
+            elsif e.node.usage.forbidden?
+              acc.ik502(e, "R", "3", "must not be present")
+            elsif e.node.invalid?
+              acc.ik502(e, "R", "3", "is not a valid string")
+            else
+              st.element(2).reject{|f| f.node == e.node }.tap do
+                acc.ik502(e, "R", "3", "must equal transaction header control number")
+              end
+            end
+          end
+        end
+      end
+
+      def critique_nm1(nm1, acc)
+        edit(:NM1) do
+          # Organization/last name
+          nm1.element(3).tap do |e|
+            if e.node.blank? and e.node.usage.optional?
+              acc.warn(e, "optional element is not present")
+            end
+          end
+
+          # Non-person entity
+          if nm1.element(2).select{|e| e.node == "2" }.defined?
+            # First name
+            nm1.element(4).tap do |e|
+              if e.node.present? and e.node.usage.optional?
+                acc.stc01(e, "T", "A8", "505", "must not be present when NM102 is 2")
+              end
+            end
+
+            # Middle name
+            nm1.element(5).tap do |e|
+              if e.node.present? and e.node.usage.optional?
+                acc.stc01(e, "T", "A8", "514", "must not be present when NM102 is 2")
+              end
+            end
+
+            # Prefix name
+            nm1.element(6).tap do |e|
+              if e.node.present? and e.node.usage.optional?
+                acc.stc01(e, "T", "A8", "125", "must not be present when NM102 is 2")
+              end
+            end
+
+            # Suffix name
+            nm1.element(7).tap do |e|
+              if e.node.present? and e.node.usage.optional?
+                acc.stc01(e, "T", "A8", "125", "must not be present when NM102 is 2")
+              end
+            end
+          end
+
+          # Person
+          if nm1.element(2).select{|e| e.node == "1" }.defined?
+            # First name
+            nm1.element(4).tap do |e|
+              if e.node.blank? and e.node.usage.optional?
+                acc.warn(e, "optional element is not present")
+              end
+            end
+
+            # Middle name
+            nm1.element(5).tap do |e|
+              if e.node.blank? and e.node.usage.optional?
+                acc.warn(e, "optional element is not present")
+              end
+            end
+
+            # Prefix name
+            nm1.element(6).tap do |e|
+              if e.node.blank? and e.node.usage.optional?
+                acc.warn(e, "optional element is not present")
+              end
+            end
+
+            # Suffix name
+            nm1.element(7).tap do |e|
+              if e.node.blank? and e.node.usage.optional?
+                acc.warn(e, "optional element is not present")
+              end
+            end
+          end
+        end
+      end
+
+      def critique_n3(n3, acc)
+        edit(:N3) do
+          n3.element(2).tap do |e|
+            if e.node.usage.optional?
+              unless n3.element(1).relect(&:blank?).defined?
+                # Second address line (N302) shouldn't be present if the
+                # first (N301) isn't also present
+                acc.warn(e, "second address line present without first line")
+              end
+            end
+          end
+        end
+      end
+
+      def critique_n4(n4, acc)
+        edit(:N4) do
+          usa_canada =
+            n4.element(2).select(&:present?).defined? ||
+            n4.element(4).select(&:blank?).defined?   ||
+            n4.element(4).select{|e| e.node == "US" }.defined? ||
+            n4.element(7).select(&:blank?).defined?
+
+          # State or Province Code
+          n4.element(2).tap do |e|
+            if usa_canada
+              if e.node.blank? and e.node.situational?
+                # Required
+              end
+            else
+              if e.node.present? and e.node.situational?
+                # Forbidden
+              end
+            end
+          end
+
+          # Postal Code
+          n4.element(3).tap do |e|
+            if usa_canada
+              # US zipcodes must be 9-digits
+            end
+          end
+
+          # Country Code
+          n4.element(4).tap do |e|
+            if usa_canada
+              if e.node.present? and e.node.situational?
+                # Forbidden
+              end
+            else
+              # Country codes 2-digit from ISO 3166
+            end
+          end
+
+          # Country Subdivision Code
+          n4.element(7).tap do |e|
+            if usa_canada
+              if e.node.present? and e.node.situational?
+                # Forbidden
+              end
+            else
+              # Country subdivision codes from ISO 3166
+            end
+          end
+        end
+      end
+
+    end
+
+  end
+end