stuff_to_do_plugin 0.4.0

data/spec/controllers/stuff_to_do_controller_save_time_entries_spec.rb

@@ -0,0 +1,56 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe StuffToDoController, '#save_time_entries' do
+  include Redmine::I18n
+  integrate_views
+  
+  before(:each) do
+    @current_user = mock_model(User, :admin? => false, :logged? => true, :language => :en, :memberships => [], :anonymous? => false, :name => "A Test User", :projects => Project, :allowed_to? => true)
+    @current_user.stub!(:time_grid_issues).and_return(Issue)
+    User.stub!(:current).and_return(@current_user)
+
+    @project = mock_model(Project)
+    @issue = mock('issue', :project => @project)
+  end
+
+  def do_request(params={})
+    post :save_time_entry, {:format => 'js', :time_entry => []}.merge(params)
+  end
+
+  def make_time_entry_hash
+    {:comments => 'Test comment', :issue_id => '100', :activity_id => '1', :spent_on => '2009-08-05', :hours => '1'}
+  end
+
+  def make_time_entry_mock(entry)
+    TimeEntry.should_receive(:new).with(entry.stringify_keys).and_return do
+      te = mock_model(TimeEntry)
+      te.stub!(:issue).and_return(@issue) # So it can get the project
+      te.should_receive(:project=).with(@project)
+      te.stub!(:project).and_return(@project)
+      te.should_receive(:user=).with(User.current)
+      te.stub!(:comments).and_return(entry[:comments])
+      yield te if block_given?
+      te
+    end
+  end
+
+  describe 'with a successful save' do
+    before(:each) do
+      controller.stub!(:save_time_entry_from_time_grid).and_return(true)
+    end
+    
+    it_should_behave_like 'get_time_grid_data'
+  end
+  
+  describe 'with a failed save' do
+    it 'should render the error messages as a string' do
+      do_request
+      response.should_not be_success
+      response.body.should match(/project/i)
+      response.body.should match(/activity/i)
+      response.body.should match(/comment/i)
+      response.body.should match(/date/i)
+      response.body.should match(/hours/i)
+    end
+  end
+end

data/spec/controllers/stuff_to_do_private_methods_spec.rb

@@ -0,0 +1,82 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe StuffToDoController, '#filters_for_view (private)' do
+  it 'should return a StuffToDoFilter' do
+    controller.send(:filters_for_view).should be_an_instance_of(StuffToDoFilter)
+  end
+
+  it 'should include all the Users in users' do
+    @user1 = mock_model(User)
+    @user2 = mock_model(User)
+    users = [@user1, @user2]
+    User.should_receive(:active).and_return(users)
+
+    filters = controller.send(:filters_for_view)
+    filters.users.should include(@user1)
+    filters.users.should include(@user2)
+  end
+
+  it 'should include all the IssuePriorities in priorities' do
+    @priority1 = mock_model(IssuePriority)
+    @priority2 = mock_model(IssuePriority)
+    priorities = [@priority1, @priority2]
+    IssuePriority.should_receive(:all).and_return(priorities)
+
+    filters = controller.send(:filters_for_view)
+    filters.priorities.should include(@priority1)
+    filters.priorities.should include(@priority2)
+  end
+
+  it 'should include all the IssueStatuses in statuses' do
+    @status1 = mock_model(IssueStatus)
+    @status2 = mock_model(IssueStatus)
+    statuses = [@status1, @status2]
+    IssueStatus.should_receive(:find).with(:all).and_return(statuses)
+
+    filters = controller.send(:filters_for_view)
+    filters.statuses.should include(@status1)
+    filters.statuses.should include(@status2)
+  end
+
+end
+
+describe StuffToDoController, '#save_time_entry_from_time_grid (private)' do
+  before(:each) do
+    @user = mock_model(User)
+    User.stub!(:current).and_return(@user)
+    @project = mock_model(Project)
+    User.current.stub!(:allowed_to?).and_return(true)
+    
+    @time_entry = TimeEntry.new(:comments => 'A comment for validation')
+    @time_entry.stub!(:project).and_return(@project)
+    @time_entry.stub!(:valid?).and_return(true)
+    @time_entry.stub!(:save).and_return(true)
+  end
+  
+  it 'should check if a TimeEntry is valid' do
+    @time_entry.should_receive(:valid?).and_return(true)
+    controller.send(:save_time_entry_from_time_grid, @time_entry)
+  end
+
+  it 'should add an error if comments are blank' do
+    @time_entry.stub!(:valid?).and_return(true)
+    @time_entry.should_receive(:comments).at_least(:once).and_return('')
+    controller.send(:save_time_entry_from_time_grid, @time_entry)
+
+    @time_entry.errors.should have(1).error_on(:comments)
+  end
+
+  it 'should check if the user is allowed to log_time to the project' do
+    User.current.should_receive(:allowed_to?).with(:log_time, @project).and_return(true)
+    @time_entry.should_receive(:project).and_return(@project)
+    @time_entry.should_receive(:save).and_return(true)
+    
+    controller.send(:save_time_entry_from_time_grid, @time_entry)
+  end
+
+  it 'should save a valid TimeEntry' do
+    @time_entry.should_receive(:save).and_return(true)
+    controller.send(:save_time_entry_from_time_grid, @time_entry)
+  end
+
+end

data/spec/lib/stuff_to_do_issue_patch_spec.rb

@@ -0,0 +1,60 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe Issue, "associations" do
+  it 'should have a habtm time_grid_users' do
+    Issue.should have_association(:time_grid_users, :has_and_belongs_to_many)
+  end
+end
+
+describe Issue, 'after_save' do
+  it 'should include update_next_issues' do
+    callbacks = Issue.after_save
+    callbacks.should_not be_nil
+    
+    callbacks.should satisfy do |callbacks|
+      found = false
+      callbacks.each do |callback|
+        found = true if callback.method == :update_next_issues
+      end
+      found
+    end
+  end
+end
+
+describe Issue, 'update_next_issues' do
+  before(:each) do
+    @issue = Issue.new
+    @issue.stub!(:reload)
+    @issue.stub!(:closed?).and_return(false)
+    StuffToDo.stub!(:remove_stale_assignments)
+  end
+  
+  it 'should reload the issue to clear the cache holding its status' do
+    @issue.should_receive(:reload)
+    @issue.stub!(:closed?).and_return(true)
+    @issue.update_next_issues
+  end
+  
+  it 'should call StuffToDo#remove_associations_to if the issue is closed' do
+    @issue.should_receive(:closed?).and_return(true)
+    StuffToDo.should_receive(:remove_associations_to).with(@issue)
+    @issue.update_next_issues
+  end
+
+  it 'should not call StuffToDo#remove_associations_to if the issue is open' do
+    @issue.should_receive(:closed?).and_return(false)
+    StuffToDo.should_not_receive(:remove_associations_to)
+    @issue.update_next_issues
+  end
+
+  it 'should return true for the callbacks' do
+    StuffToDo.stub!(:remove_associations_to)
+
+    @issue.update_next_issues.should be_true
+  end
+  
+  it 'should call StuffToDo#remove_stale_assignments' do
+    StuffToDo.should_receive(:remove_stale_assignments).with(@issue)
+    @issue.update_next_issues
+  end
+end

data/spec/lib/stuff_to_do_project_patch_spec.rb

@@ -0,0 +1,50 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe Project, 'associations' do
+  it 'should have many stuff_to_dos as "stuff"' do
+    Project.should have_association(:stuff_to_dos, :has_many)
+  end
+end
+
+describe Project, 'after_save' do
+  it 'should include update_stuff_to_do' do
+    callbacks = Project.after_save
+    callbacks.should_not be_nil
+    
+    callbacks.should satisfy do |callbacks|
+      found = false
+      callbacks.each do |callback|
+        found = true if callback.method == :update_stuff_to_do
+      end
+      found
+    end
+  end
+end
+
+describe Project, 'update_stuff_to_do' do
+  before(:each) do
+    # Can't use a mock here due to a Rails/RSpec conflict
+    # https://rails.lighthouseapp.com/projects/8994/tickets/404-named_scope-bashes-critical-methods
+    #
+    @project = Project.new
+    @project.status = Project::STATUS_ACTIVE
+    @project.is_public = true
+  end
+  
+  it 'should call StuffToDo#remove_associations_to if the project is not active' do
+    @project.status = Project::STATUS_ARCHIVED
+    StuffToDo.should_receive(:remove_associations_to).with(@project)
+    @project.update_stuff_to_do
+  end
+
+  it 'should not call StuffToDo#remove_associations_to if the project is active' do
+    StuffToDo.should_not_receive(:remove_associations_to)
+    @project.update_stuff_to_do
+  end
+
+  it 'should return true for the callbacks' do
+    StuffToDo.stub!(:remove_associations_to)
+
+    @project.update_stuff_to_do.should be_true
+  end
+end

data/spec/lib/stuff_to_do_user_patch_spec.rb

@@ -0,0 +1,8 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe User, "associations" do
+  it 'should have a habtm time_grid_issues' do
+    User.should have_association(:time_grid_issues, :has_and_belongs_to_many)
+  end
+end
+

data/spec/models/stuff_to_do_filter_spec.rb

@@ -0,0 +1,3 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+# TODO

data/spec/models/stuff_to_do_mailer_spec.rb

@@ -0,0 +1,42 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe StuffToDoMailer, 'recommended_below_threshold' do
+
+  before(:each) do
+    @settings = {'email_to' => 'user1@example.com,user2@example.com', 'threshold' => '5'}
+    Setting.stub!(:plugin_stuff_to_do_plugin).and_return(@settings)
+    Setting.stub!(:host_name).and_return('example.com')
+    Setting.stub!(:protocol).and_return('https')
+    @user = mock_model(User, :name => "Example User", :id => 100)
+    @next_item_count = 2
+
+    @mail = StuffToDoMailer.create_recommended_below_threshold(@user, @next_item_count)
+  end
+  
+  it 'should send to the users specified in the Settings' do
+    @mail.bcc.should have(2).things
+    @mail.bcc.should include("user1@example.com")
+    @mail.bcc.should include("user2@example.com")
+  end
+
+  it 'should use the subject of "Whats Recommended is below the threshold"' do
+    @mail.subject.should match(/What's Recommended is below the threshold/i)
+  end
+  
+  it 'should have the user name in the body' do
+    @mail.encoded.should match(/#{ @user.name }/)
+  end
+
+  it 'should say the threshold amount in the body' do
+    @mail.encoded.should match(/threshold of 5/)
+  end
+
+  it 'should say the number of StuffToDos for the user in the body' do
+    @mail.encoded.should match(/only 2 recommended items left/)
+  end
+  
+  it 'should have a link to the users stuff_to_do page in the body' do
+    # '=3D' is the encoded version of '='
+    @mail.encoded.should include("https://example.com/stuff_to_do?user_id=3D#{@user.id}")
+  end
+end

data/spec/models/stuff_to_do_spec.rb

@@ -0,0 +1,426 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+module StuffToDoSpecHelper
+  def issue_factory(number, fields = { })
+    issues = []
+    number.times do |issue_number|
+      issues << mock_model(Issue, { :id => issue_number }.merge(fields))
+    end
+    
+    return issues
+  end
+
+  def project_factory(number, fields = {})
+    projects = []
+    number.times do |project_number|
+      projects << mock_model(Project, { :id => project_number }.merge(fields))
+    end
+    
+    return projects
+  end
+  
+  def next_issues_from_issues(issues, number_of_next_issues = nil)
+    number_of_next_issues ||= issues.size
+    
+    next_issues = []
+    issues.each do |issue|
+      next if next_issues.size >= number_of_next_issues
+      next_issues << mock_model(StuffToDo, :stuff => issue)
+    end
+    
+    return next_issues
+  end
+end
+
+describe StuffToDo, 'associations' do
+  it 'should belong to a polymorphic "stuff"' do
+    StuffToDo.should have_association(:stuff, :belongs_to)
+  end
+
+  it 'should belong to a user' do
+    StuffToDo.should have_association(:user, :belongs_to)
+  end
+end
+
+describe StuffToDo, '#available with no filter' do
+
+  before(:each) do
+    @user = mock_model(User)
+  end
+
+  it 'should find nothing' do
+    StuffToDo.available(@user).should be_empty
+  end
+end
+
+describe StuffToDo, '#available for user' do
+  include StuffToDoSpecHelper
+
+  before(:each) do
+    @user = mock_model(User)
+    @find_options = { :conditions => ['1=1 AND (issue_statuses.is_closed = ?) AND (projects.status = ?) AND (assigned_to_id = ?)',false, 1, @user.id ], :include => [:status, :priority, :project], :order => 'issues.created_on DESC'}
+  end
+  
+  it 'should find all assigned issues for the user' do
+    issues = issue_factory(10, { :assigned_to => @user })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.available(@user, @user).should eql(issues)
+  end
+
+  it 'should not include issues that are StuffToDos' do
+    issues = issue_factory(10, { :assigned_to => @user })
+    # Add in half the issues as StuffToDos
+    next_issues = next_issues_from_issues(issues, issues.size / 2)
+    
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.should_receive(:find).with(:all, { :conditions => { :user_id => @user.id }}).and_return(next_issues)
+    StuffToDo.available(@user, @user).should eql(issues - next_issues.collect(&:stuff))
+  end
+  
+  it 'should only include open issues' do
+    issues = issue_factory(10, { :assigned_to => @user })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    available = StuffToDo.available(@user, @user)
+    available.should have(10).items
+    available.should eql(issues)
+  end
+end
+
+describe StuffToDo, '#available for status' do
+  include StuffToDoSpecHelper
+
+  before(:each) do
+    @user = mock_model(User)
+    @status = mock_model(IssueStatus)
+    @find_options = { :conditions => ['1=1 AND (issue_statuses.is_closed = ?) AND (projects.status = ?) AND (issue_statuses.id = (?))', false, 1, @status.id ], :include => [:status, :priority, :project], :order => 'issues.created_on DESC'}
+  end
+  
+  it 'should find all issues with the status' do
+    issues = issue_factory(10, { :status => @status })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.available(@user, @status).should eql(issues)
+  end
+
+  it 'should not include issues that are StuffToDos' do
+    issues = issue_factory(10, { :status => @status })
+    # Add in half the issues as StuffToDos
+    next_issues = next_issues_from_issues(issues, issues.size / 2)
+    
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.should_receive(:find).with(:all, { :conditions => { :user_id => @user.id }}).and_return(next_issues)
+    StuffToDo.available(@user, @status).should eql(issues - next_issues.collect(&:stuff))
+  end
+  
+  it 'should only include open issues' do
+    issues = issue_factory(10, { :status => @status })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    available = StuffToDo.available(@user, @status)
+    available.should have(10).items
+    available.should eql(issues)
+  end
+end
+
+describe StuffToDo, '#available for priority' do
+  include StuffToDoSpecHelper
+
+  before(:each) do
+    @user = mock_model(User)
+    @priority = mock_model(Enumeration, :opt => 'IPRI')
+    @find_options = { :conditions => ['1=1 AND (issue_statuses.is_closed = ?) AND (projects.status = ?) AND (enumerations.id = (?))', false, 1, @priority.id ], :include => [:status, :priority, :project], :order => 'issues.created_on DESC'}
+  end
+
+  it 'should find all issues with the priority' do
+    issues = issue_factory(10, { :priority => @priority })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.available(@user, @priority).should eql(issues)
+  end
+
+  it 'should not include issues that are StuffToDos' do
+    issues = issue_factory(10, { :priority => @priority })
+    # Add in half the issues as StuffToDos
+    next_issues = next_issues_from_issues(issues, issues.size / 2)
+    
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    StuffToDo.should_receive(:find).with(:all, { :conditions => { :user_id => @user.id }}).and_return(next_issues)
+    StuffToDo.available(@user, @priority).should eql(issues - next_issues.collect(&:stuff))
+  end
+  
+  it 'should only include open issues' do
+    issues = issue_factory(10, { :priority => @priority })
+
+    Issue.should_receive(:find).with(:all, @find_options).and_return(issues)
+    available = StuffToDo.available(@user, @priority)
+    available.should have(10).items
+    available.should eql(issues)
+  end
+end
+
+describe StuffToDo, '#available for project' do
+  include StuffToDoSpecHelper
+
+  before(:each) do
+    @user = mock_model(User)
+    @priority = mock_model(Enumeration, :opt => 'IPRI')
+  end
+
+  it 'should find all active projects visible to the user' do
+    issues = issue_factory(10, { :priority => @priority })
+    projects = project_factory(10)
+    projects.should_receive(:sort).and_return(projects) # No need to test the sort order
+    
+    Project.should_receive(:active).and_return(Project)
+    Project.should_receive(:visible).and_return(projects)
+
+    StuffToDo.available(@user, Project.new).should eql(projects)
+  end
+
+  it 'should not include projects that are StuffToDos already' do
+    projects = project_factory(10)
+    projects.stub!(:sort).and_return(projects) # No need to test the sort order
+    # Add in half the issues as StuffToDos
+    stuff_to_dos = next_issues_from_issues(projects, projects.size / 2)
+
+    Project.should_receive(:active).and_return(Project)
+    Project.should_receive(:visible).and_return(projects)
+    StuffToDo.should_receive(:find).with(:all, { :conditions => { :user_id => @user.id }}).and_return(stuff_to_dos)
+    
+    StuffToDo.available(@user, Project.new).should eql(projects - stuff_to_dos.collect(&:stuff))
+  end
+end
+
+describe StuffToDo, '#remove_associations_to' do
+  before(:each) do
+    @issue = mock_model(Issue)
+    @issue.stub!(:closed?).and_return(true)
+    @project = mock_model(Project)
+    @project.stub!(:active).and_return(false)
+  end
+  
+  it 'should delete all StuffToDos for a closed issue' do
+    next_issue_one = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => nil)
+    next_issue_one.should_receive(:destroy).and_return(true)
+    next_issue_two = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => nil)
+    next_issue_two.should_receive(:destroy).and_return(true)
+    next_issues = [next_issue_one, next_issue_two]
+    @issue.should_receive(:stuff_to_dos).and_return(next_issues)
+
+    StuffToDo.remove_associations_to(@issue)
+  end
+
+  it 'should delete all StuffToDos for a archived project' do
+    next_issue_one = mock_model(StuffToDo, :stuff_id => @project.id, :user_id => nil)
+    next_issue_one.should_receive(:destroy).and_return(true)
+    next_issue_two = mock_model(StuffToDo, :stuff_id => @project.id, :user_id => nil)
+    next_issue_two.should_receive(:destroy).and_return(true)
+    next_issues = [next_issue_one, next_issue_two]
+    @project.should_receive(:stuff_to_dos).and_return(next_issues)
+
+    StuffToDo.remove_associations_to(@project)
+  end
+end
+
+describe StuffToDo, '#remove_associations_to' do
+  before(:each) do
+    @issue = mock_model(Issue)
+    @issue.stub!(:closed?).and_return(true)
+
+    @user = mock_model(User)
+    @next_issue_one = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user.id)
+    @next_issue_one.should_receive(:destroy).and_return(true)
+    @next_issue_two = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user.id)
+    @next_issue_two.should_receive(:destroy).and_return(true)
+    @next_issues = [@next_issue_one, @next_issue_two]
+    @issue.stub!(:stuff_to_dos).and_return(@next_issues)
+    @number_of_next_issues = 4
+    StuffToDo.stub!(:count).with(:conditions => { :user_id => @user.id }).and_return(@number_of_next_issues)
+  end
+  
+  it 'should deliver a StuffToDoMailer notification if the StuffToDos are below the threshold' do
+    Setting.should_receive(:plugin_stuff_to_do_plugin).and_return({'threshold' => @number_of_next_issues + 1 })
+    User.should_receive(:find_by_id).with(@user.id).and_return(@user)
+    StuffToDoMailer.should_receive(:deliver_recommended_below_threshold).with(@user, 4)
+    StuffToDo.remove_associations_to(@issue)
+  end
+
+  it 'should deliver a StuffToDoMailer notification if the StuffToDos are at the threshold' do
+    Setting.should_receive(:plugin_stuff_to_do_plugin).and_return({'threshold' => @number_of_next_issues })
+    User.should_receive(:find_by_id).with(@user.id).and_return(@user)
+    StuffToDoMailer.should_receive(:deliver_recommended_below_threshold).with(@user, 4)
+    StuffToDo.remove_associations_to(@issue)
+  end
+
+  it 'should not deliver any StuffToDoMailer notification if the StuffToDos are above the threshold' do
+    Setting.should_receive(:plugin_stuff_to_do_plugin).and_return({'threshold' => @number_of_next_issues - 1 })
+    StuffToDoMailer.should_not_receive(:deliver_recommended_below_threshold)
+    StuffToDo.remove_associations_to(@issue)
+  end
+  
+end
+
+describe StuffToDo, '#remove_stale_assignments' do
+  it 'should destroy all StuffToDos for an issue except for the currently assigned user' do
+    @user = mock_model(User)
+    @user2 = mock_model(User)
+    @user3 = mock_model(User)
+    
+    @issue = mock_model(Issue, :assigned_to_id => @user.id)
+
+    @next_issue_one = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user2.id)
+    @next_issue_two = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user3.id)
+    @next_issues = [@next_issue_one, @next_issue_two]
+    
+    StuffToDo.should_receive(:destroy_all).with(['stuff_id = (?) AND user_id NOT IN (?)', @issue.id, @issue.assigned_to_id]).and_return(@next_issues)
+
+    StuffToDo.remove_stale_assignments(@issue)
+  end
+
+  it 'should destroy all StuffToDos for an issue if the currently assigned user is blank' do
+    @user = mock_model(User)
+    @user2 = mock_model(User)
+    @user3 = mock_model(User)
+    
+    @issue = mock_model(Issue, :assigned_to_id => nil)
+
+    @next_issue_one = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user2.id)
+    @next_issue_two = mock_model(StuffToDo, :stuff_id => @issue.id, :user_id => @user3.id)
+    @next_issues = [@next_issue_one, @next_issue_two]
+
+    StuffToDo.should_receive(:destroy_all).with(['stuff_id = (?)', @issue.id]).and_return(@next_issues)
+
+    StuffToDo.remove_stale_assignments(@issue)
+  end
+
+end
+
+
+describe StuffToDo, '#reorder_list' do
+  it 'should require a user_id' do
+    lambda { 
+      StuffToDo.reorder_list
+    }.should raise_error
+    
+  end
+
+  it 'should require an array of  ids' do
+    user = mock_model(User)
+    lambda { 
+      StuffToDo.reorder_list(user)
+    }.should raise_error
+  end
+  
+  it 'should find all the Stuff To Do items' do
+    user = mock_model(User)
+    ids = ["598", "709", "746", "1492", "1491", "820", "1094", "1095"]
+    stuff_to_dos = []
+    ids.each do |id|
+      stuff_to_dos << mock_model(StuffToDo, :stuff_id => id, :insert_at => true)
+    end
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+  end
+
+  
+  it 'should save the positions of the stuff to do items to the database' do
+    user = mock_model(User)
+    ids = ["598", "709", "746", "1492", "1491", "820", "1094", "1095"]
+    stuff_to_dos = []
+    ids.each_with_index do |id, array_position|
+      stuff_to_do = mock_model(StuffToDo, :stuff_id => id, :id => id)
+      stuff_to_do.should_receive(:insert_at).with(array_position + 1)
+      stuff_to_dos << stuff_to_do
+    end
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+    
+  end
+  
+  it 'should add new StuffToDo that are in the list but not in the database' do
+    user = mock_model(User)
+    ids = ["598", "709", "746", "1492", "1491", "820", "1094", "1095"]
+    stuff_to_dos = []
+    ids.each_with_index do |id, array_position|
+      stuff_to_dos << mock_model(StuffToDo, :stuff_id => id, :insert_at => true) unless id == "820"
+    end
+
+    stuff_to_do_for_820 = StuffToDo.new
+    stuff_to_do_for_820.should_receive(:stuff_id=).with(820)
+    stuff_to_do_for_820.should_receive(:user_id=).with(user.id)
+    stuff_to_do_for_820.should_receive(:save).and_return(true)
+    position = ids.index("820") + 1
+    stuff_to_do_for_820.should_receive(:insert_at).with(position)
+    StuffToDo.should_receive(:new).and_return(stuff_to_do_for_820)
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+  end
+  
+  it 'should support adding new Project StuffToDo items' do
+    user = mock_model(User)
+    ids = ["598", "709", "746", "1492", "1491", "820", "1094", "1095"]
+    stuff_to_dos = []
+    ids.each_with_index do |id, array_position|
+      stuff_to_do = mock_model(StuffToDo, :stuff_id => id, :id => id)
+      stuff_to_do.should_receive(:insert_at).with(array_position + 1)
+      stuff_to_dos << stuff_to_do
+    end
+
+    # Project 42
+    ids << "project42"
+    new_project_stuff_to_do = mock_model(StuffToDo, :user_id => user.id, :insert_at => ids.size)
+    new_project_stuff_to_do.should_receive(:stuff_id=).with(42)
+    new_project_stuff_to_do.should_receive(:stuff_type=).with('Project')
+    new_project_stuff_to_do.should_receive(:user_id=).with(user.id)
+    new_project_stuff_to_do.should_receive(:save).and_return(true)
+    StuffToDo.should_receive(:new).and_return(new_project_stuff_to_do)
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+    
+  end
+  
+  it 'should destroy any StuffToDos that are not in the list' do
+    user = mock_model(User)
+    ids = ["598", "709", "746", "1492", "1491", "820", "1094", "1095"]
+    stuff_to_dos = []
+    ids.each_with_index do |id, array_position|
+      stuff_to_dos << mock_model(StuffToDo, :stuff_id => id, :insert_at => true)
+    end
+
+    extra_stuff_to_do = mock_model(StuffToDo, :stuff_id => 999)
+    extra_stuff_to_do.should_receive(:destroy).and_return(true)
+    StuffToDo.should_receive(:find_by_user_id_and_stuff_id).with(user.id, extra_stuff_to_do.stuff_id).and_return(extra_stuff_to_do)
+    stuff_to_dos << extra_stuff_to_do
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+
+  end
+  
+  it 'should destroy all StuffToDos if the list is empty' do
+    user = mock_model(User)
+    ids = nil
+    stuff_to_dos = []
+
+    extra_stuff_to_do = mock_model(StuffToDo, :stuff_id => 999)
+    extra_stuff_to_do.should_receive(:destroy).and_return(true)
+    StuffToDo.should_receive(:find_by_user_id_and_stuff_id).with(user.id, extra_stuff_to_do.stuff_id).and_return(extra_stuff_to_do)
+    stuff_to_dos << extra_stuff_to_do
+    
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Issue').and_return(stuff_to_dos)
+    StuffToDo.should_receive(:find_all_by_user_id_and_stuff_type).with(user.id, 'Project').and_return([])
+    StuffToDo.reorder_list(user, ids)
+    
+  end
+end