studio_api 3.1.1 → 3.1.2

data/VERSION

@@ -1 +1 @@
-3.1.1
+3.1.2

data/lib/studio_api/connection.rb

@@ -63,7 +63,7 @@ module StudioApi
       @password = password
       self.uri = uri
       self.proxy = options[:proxy] #nil as default is OK
-      @timeout = options[:timeout].to_i || 45
+      @timeout = (options[:timeout] || 45).to_i
       @ssl = options[:ssl] || { :verify_mode => OpenSSL::SSL::VERIFY_NONE } # don't verify as default
     end
 

data/lib/studio_api/running_build.rb

@@ -22,19 +22,6 @@ module StudioApi
 
     alias_method :cancel, :destroy
 
-    def save
-      response = super
-    rescue ActiveResource::BadRequest => e
-      tree = XmlSimple.xml_in(e.response.body)
-      code = tree["code"][0]
-      if code == "image_already_exists"
-        message = tree["message"][0]
-        raise ImageAlreadyExists.new message
-      else
-        raise e
-      end
-    end
-
 private
     #overwrite create as studio doesn't interact well with enclosed parameters
     def create
@@ -46,6 +33,15 @@ private
       connection.post(request_str,"",self.class.headers).tap do |response|
         load_attributes_from_response response
       end
+    rescue ActiveResource::BadRequest => e
+      tree = XmlSimple.xml_in(e.response.body)
+      code = tree["code"][0]
+      if code == "image_already_exists"
+        message = tree["message"][0]
+        raise ImageAlreadyExists.new message
+      else
+        raise e
+      end
     end
   end
 

data/rubygem-studio_api.changes

@@ -1,3 +1,9 @@
+Mon Jul 18 11:33:38 CEST 2011  Flavio Castelli <flavio@castelli.name>
+
+- ensure the timeout value is properly set.
+  See https://github.com/jreidinger/studio_api/issues/3
+  for more details.
+
 Fri May 14:30:55 CEST 2011  Flavio Castelli <flavio@castelli.name>
 
 - code refactorying of the unit tests

data/test/connection_test.rb

@@ -18,4 +18,8 @@ class ConnectionTest < Test::Unit::TestCase
     @connection.api_version #test caching, if it again call, then mocha raise exception
   end
 
+  def test_default_timeout
+    assert_equal 45, @connection.timeout
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: studio_api
 version: !ruby/object:Gem::Version 
-  hash: 1
+  hash: 7
   prerelease: 
   segments: 
   - 3
   - 1
-  - 1
-  version: 3.1.1
+  - 2
+  version: 3.1.2
 platform: ruby
 authors: 
 - Josef Reidinger
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-06 00:00:00 +02:00
+date: 2011-07-18 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -184,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: studio_api
-rubygems_version: 1.6.2
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: Intuitive ruby bindings to Studio Api Interface.