studio-engine 0.69.3 → 0.69.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ade07348f1d55403ac332ea2a030b8af81ff8b9b8d4a49b637326eb40168847
-  data.tar.gz: e5ee5053749871945628e8f522fffee01569e0ae3052016b9388c79b98be59d4
+  metadata.gz: 12d0b8a6c255a4f9e18d6a3a588abefdd7dd5d54a3801deb9b52eb99da2d78fe
+  data.tar.gz: 3467bf1af09d79805053d721c1d0d6028fd0c5b0f806c94d6a2cdc7864f048f1
 SHA512:
-  metadata.gz: baf91b4f29446f4cc53ef15890ba67e9691046c769af46ac3beec04f9ad530ad3f67ee9d4d686d85d37ed3b0f7e78c1e453eec0476e4146eaa97bbd8fdf4fd68
-  data.tar.gz: 5ae6368f5e8c1ba95081f8608acc3193e3b82436e42e6a2cef059a6e979fb1b025da56058f980bc544f7d0add642d2972d7aefcc5b37c1fda22ca65c71c269cf
+  metadata.gz: 3fd8ea14026738113f2348ea267b2cde306afa6a37d1b37dbf23e426013cb632be62164413e64516893f913e9f8a1618559ef326187e328001d6effceffe4187
+  data.tar.gz: 1498813d632e019fc574a6467e87fa73965f0e018001c845cac52a22d21443cfad8426e50a94ec9d37e874a6f1d059770dd97696665141853fb2a9c458b97242

data/CHANGELOG.md

@@ -55,6 +55,34 @@ The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This pro
 
 ### Fixed
 
+- **Onboarding no longer stores a two-word answer as the whole first name.**
+  `Studio::OnboardingController#first_name` writes with `update_columns`, which
+  skips callbacks — so the host's `before_save :set_name_parts` never ran and
+  someone answering "Ada Lovelace" landed `first_name = "Ada Lovelace"`,
+  `last_name` NULL. It never self-healed either: `set_name_parts` is gated on
+  `name_changed?`, and no later save sees a name change. The derivation now
+  comes to the writer instead — a new pure primitive, **`Studio::NameParts.from`**
+  (`lib/studio/name_parts.rb`), carrying the same rule the host callback runs,
+  including the deliberate OMISSION of `last_name` for a one-word name so a
+  surname already on file survives a first-name prompt.
+  **`update_columns` STAYS**, and the fix does not touch it: `Sluggable`'s
+  `before_save :set_slug` is UNGATED and mcritchie-studio's `User#name_slug` is
+  built from `name`, so a full save here would re-point the slug the account
+  answers on — on a uniquely-indexed column, at every signup.
+  `test/integration/onboarding_name_parts_test.rb` carries that as a live
+  control (`update!` moves `pat-pat@example.com` → `ada-lovelace-pat@…`), not as
+  a claim. `last_name` is written only where the column exists: the engine's own
+  standard-columns migration does not carry it, so mcritchie-industries,
+  moms-app and acquisition-studio would otherwise have taken a
+  `MissingAttributeError` 500 on every hyphen-free two-word answer
+  (`test/integration/onboarding_thin_host_test.rb`).
+  NO DATA REPAIR SHIPS: measured 2026-09-05 across both production databases
+  (mcritchie-studio 5 users, turf-monster 43) and both QA ones, **zero rows**
+  carry a space in `first_name`. Repairing rows whose halves merely disagree
+  with `name` would be data loss — `/profile` writes those columns directly —
+  and a fossil repair belongs to the consuming app that owns its `users` table,
+  not to the gem.
+
 - **Knowledge layer hardening** — the five findings from the 0.67.0 reviews:
   upload keys carry a random suffix (same-named uploads in the same second no
   longer overwrite the first object before the unique index can refuse);

data/app/controllers/studio/onboarding_controller.rb

@@ -42,17 +42,35 @@ module Studio
       end
 
       rescue_and_log(target: current_user) do
-        # update_columns, not update!: this runs seconds after signup, on an
-        # account that may be mid-onboarding, and a validation failure elsewhere
-        # on the record (a grandfathered reserved username, say) must not block a
-        # first name. It also steps around any host before_save that DERIVES
-        # first_name FROM name — turf's set_name_parts does exactly that, and
-        # writing through it would discard the value we were just handed.
-        attrs = { first_name: value }
+        # update_columns, not update!, for THREE reasons — all still true:
+        #
+        #   1. This runs seconds after signup, on an account that may be
+        #      mid-onboarding, and a validation failure elsewhere on the record
+        #      (a grandfathered reserved username, say) must not block a name.
+        #   2. It steps around any host before_save that DERIVES first_name FROM
+        #      name — set_name_parts does exactly that — which would discard the
+        #      value we were just handed.
+        #   3. THE SLUG. Sluggable's `before_save :set_slug` is UNGATED, and
+        #      mcritchie-studio's User#name_slug is built from `name`. A full
+        #      save right after this writes `name` would therefore re-point the
+        #      slug the account answers on — a URL change, on a column carrying
+        #      a unique index, for every signup. That is the constraint this
+        #      endpoint has always been protecting; it is not a shortcut.
+        #
+        # WHAT SKIPPING CALLBACKS USED TO COST. Because set_name_parts never
+        # ran, `first_name` got the WHOLE typed value: someone answering "Ada
+        # Lovelace" landed first_name="Ada Lovelace", last_name NULL — and it
+        # never self-healed, because set_name_parts is gated on `name_changed?`
+        # and no later save sees a name change. So the derivation comes to the
+        # writer instead: Studio::NameParts is the same rule the callback runs.
+        attrs = name_columns(value)
         attrs[:name] = value if current_user.name.blank?
         current_user.update_columns(attrs)
 
-        render json: { ok: true, first_name: value, next: remaining_steps }
+        # The STORED first name, not the typed string — they differ for exactly
+        # the case above, and a response that disagreed with the row would be
+        # the same bug wearing a different hat.
+        render json: { ok: true, first_name: attrs[:first_name], next: remaining_steps }
       end
     end
 
@@ -68,6 +86,19 @@ module Studio
 
     private
 
+    # The name halves to write, derived exactly as the host's set_name_parts
+    # would derive them from the same string.
+    #
+    # `last_name` is dropped for a host that has no such column —
+    # mcritchie-industries' users table is eight columns wide and update_columns
+    # on an absent column raises. Same respond_to? guard /profile already
+    # carries for the same reason.
+    def name_columns(value)
+      parts = Studio::NameParts.from(value)
+      parts.delete(:last_name) unless current_user.respond_to?(:last_name)
+      parts
+    end
+
     # What is left AFTER this write. The host's resolver decides; the engine's
     # default is "nothing further", which is the right answer for an app whose
     # only onboarding ask is the name.

data/lib/studio/name_parts.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+module Studio
+  # The two halves of a person's name, derived from the one string they typed.
+  #
+  # WHY THIS IS A PRIMITIVE AND NOT THREE LINES IN A CONTROLLER. Every Studio
+  # host derives `first_name`/`last_name` from `name` in a `before_save`
+  # (`set_name_parts` — byte-identical in mcritchie-studio and turf-monster), so
+  # any writer that steps around callbacks owes the SAME derivation or the row
+  # lands split differently depending on which door it came through. The engine
+  # has exactly such a writer: Studio::OnboardingController writes with
+  # `update_columns`, and it does so for a reason worth keeping (see there).
+  # Parity is the whole requirement, so the rule lives in one named, tested
+  # place instead of being retyped at each door.
+  #
+  # PURE ON PURPOSE — no record, no columns, no ActiveRecord. That is what lets
+  # the engine's pure-Ruby unit lane exercise it directly, and what lets a host
+  # callback delegate to it later without inheriting anything.
+  #
+  # `last_name` is OMITTED, not nil, for a one-word name. That is parity, not
+  # tidiness: the host callback has always left an existing last name standing
+  # (`self.last_name = parts.last if parts.size > 1`), so a hash that nulled it
+  # would make the callback-free writer disagree with the callback in the
+  # opposite direction — someone with a last name on file would lose it by
+  # answering a first-name prompt. Whether that carry-over is itself the right
+  # rule is a separate question from this one; matching it is this file's job.
+  #
+  # Mirrors mcritchie-studio's `User.name_parts`, which the hub extracted for its
+  # own callback-free writers (seeds and the identity migrations). The engine
+  # cannot call that one — it ships to hosts that do not define it, and
+  # mcritchie-industries has no `first_name` column at all — so it carries its
+  # own copy of a rule both must agree on. test/lib/studio/name_parts_test.rb
+  # pins the parity for every shape of name.
+  module NameParts
+    module_function
+
+    # A hash ready for `update_columns` / `assign_attributes`.
+    #
+    #   Studio::NameParts.from("Ada Lovelace")     # => { first_name: "Ada", last_name: "Lovelace" }
+    #   Studio::NameParts.from("Ada")              # => { first_name: "Ada" }
+    #   Studio::NameParts.from("Ada B. Lovelace")  # => { first_name: "Ada", last_name: "Lovelace" }
+    #   Studio::NameParts.from("")                 # => { first_name: nil }
+    def from(name)
+      words = name.to_s.strip.split(" ")
+      parts = { first_name: words.first }
+      parts[:last_name] = words.last if words.size > 1
+      parts
+    end
+  end
+end

data/lib/studio/version.rb

@@ -1,3 +1,3 @@
 module Studio
-  VERSION = "0.69.3"
+  VERSION = "0.69.4"
 end

data/lib/studio.rb

@@ -14,6 +14,7 @@ require "studio/profile_image"
 require "studio/oauth_identity"
 require "studio/newsletter"
 require "studio/username_generator"
+require "studio/name_parts"
 require "studio/s3"
 require "studio/image_cache"
 require "studio/link_token"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: studio-engine
 version: !ruby/object:Gem::Version
-  version: 0.69.3
+  version: 0.69.4
 platform: ruby
 authors:
 - Alex McRitchie
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-09-03 00:00:00.000000000 Z
+date: 2026-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -576,6 +576,7 @@ files:
 - lib/studio/link_token.rb
 - lib/studio/log_rotation.rb
 - lib/studio/mail_transport.rb
+- lib/studio/name_parts.rb
 - lib/studio/newsletter.rb
 - lib/studio/oauth_identity.rb
 - lib/studio/profile_image.rb