studio-engine 0.67.1 → 0.67.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69e6eab8f9186157077a967e6fd21a6b075a94245969f26a42b57bf5154e59f0
-  data.tar.gz: d88f16a0143527684b091c40c0fd33dfc561661381fdcdc32ac08d09fa27119b
+  metadata.gz: 79895e24dd5ade937ec8c0b4afacd84605ad495530a4c37f94e053a2c1040170
+  data.tar.gz: 0f1716ef07d10fc5388ea15853767f6c7e8911e076e280a096a8424a494eba9c
 SHA512:
-  metadata.gz: de70d91aedcb0d23734ddde03e24272df70a982eea531583247608451f5da7bf86f485857cdc6ceeefaedf91319d318e56254d6e90c702be91b4317f0d34af68
-  data.tar.gz: 507a127ab69e870f0f82c0cfff93b5ca2d68b5241c4925eb58fae838ff78821a219614c31c2952fd7fe197b2f2c7eb2e906bfd3feff5ff3d9e973e8cdce15e78
+  metadata.gz: 7c6e391302c996753b399019f2baeded267820a69d1f7451fe7ff68f82609fc625cc477cbdebb6127f74d0d5ed3a326ed4357d02c24b595e0fd1c213c3605895
+  data.tar.gz: 26bda400a871f3998a7baa64c72f43ed71a2d6d4ff177e02c4c6ae76d9bff65438e0bb33d48564802ea982bc2f628631906fc25e0a24167ec11d38796908310d

data/CHANGELOG.md

@@ -4,6 +4,21 @@ The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This pro
 
 ## Unreleased
 
+### Fixed
+
+- **Knowledge layer hardening** — the five findings from the 0.67.0 reviews:
+  upload keys carry a random suffix (same-named uploads in the same second no
+  longer overwrite the first object before the unique index can refuse);
+  `normalize_path` drops dot segments (`a/../b` → `a/b` — the S3 key mirrors
+  the path, and a `..` reads as traversal to every scanner); `access_for`
+  normalizes the queried agent the way writes normalize keys (a capitalized
+  `Studio.knowledge_agents` roster entry no longer reads `none`); the inbox
+  badge counts before the status filter (filtering to `filed` no longer zeroes
+  it); chip styles moved to one shared partial (`_chip_styles`); and reference
+  migrations are now written omakase-rubocop-compatible, with the convention
+  noted in the migration header (consumer copies are linted by the consumer's
+  rubocop — measured on the Industries adoption ship).
+
 ### Added
 
 - **Knowledge layer primitive** — `Studio::KnowledgeDoc` + `/admin/knowledge`:

data/app/controllers/studio/knowledge_docs_controller.rb

@@ -25,11 +25,14 @@ module Studio
 
       scope = Studio::KnowledgeDoc.order(created_at: :desc)
       scope = scope.for_entity(@entity) if @entity
-      scope = scope.where(status: @status) if @status
 
-      @entities   = Studio::KnowledgeDoc.distinct.pluck(:entity).sort
+      @entities = Studio::KnowledgeDoc.distinct.pluck(:entity).sort
+      # Counted BEFORE the status filter: the badge answers "what waits for
+      # triage in this entity", and filtering to status=filed must not zero it.
       @inbox_size = scope.inbox.count
 
+      scope = scope.where(status: @status) if @status
+
       if @view == "folders"
         @folders = scope.folders_under(@folder)
         @docs    = scope.in_folder(@folder)

data/app/models/studio/knowledge_doc.rb

@@ -93,8 +93,13 @@ module Studio
       end
 
       # "/a//b/" -> "a/b". Nil-safe; the empty string is the root folder.
+      # Dot segments are dropped ("a/../b" -> "a/b"): harmless server-side, but
+      # the S3 key mirrors the path and a ".." reads as traversal to every
+      # scanner and human who ever greps the bucket.
       def normalize_path(value)
-        value.to_s.strip.squeeze("/").delete_prefix("/").delete_suffix("/")
+        value.to_s.strip.squeeze("/").split("/")
+             .reject { |segment| segment.empty? || segment == "." || segment == ".." }
+             .join("/")
       end
 
       def default_title(file)
@@ -105,8 +110,11 @@ module Studio
 
     # --- access ---------------------------------------------------------------
 
+    # The queried agent is normalized the same way written keys are, so a
+    # capitalized Studio.knowledge_agents roster entry reads its real level
+    # instead of silently defaulting to "none".
     def access_for(agent)
-      level = access.is_a?(Hash) ? access[agent.to_s] : nil
+      level = access.is_a?(Hash) ? access[agent.to_s.strip.downcase] : nil
       ACCESS_LEVELS.include?(level) ? level : "none"
     end
 
@@ -133,9 +141,13 @@ module Studio
       content_type = file.respond_to?(:content_type) ? file.content_type : nil
       body = file.respond_to?(:read) ? file.read : file.to_s
 
+      # The random suffix is load-bearing: the timestamp is second-granularity,
+      # so two same-named uploads in one second would otherwise write the same
+      # key — the second S3 PUT overwrites the first object BEFORE the unique
+      # index rejects the second row (found in PR #251 review, twice over).
       key = [
         "knowledge", entity, path.presence,
-        "#{Time.current.strftime('%Y%m%d%H%M%S')}-#{self.class.sanitize_filename(filename)}"
+        "#{Time.current.strftime('%Y%m%d%H%M%S')}-#{SecureRandom.hex(4)}-#{self.class.sanitize_filename(filename)}"
       ].compact.join("/")
 
       Studio::S3.upload(key: key, body: body, content_type: content_type)

data/app/views/studio/knowledge_docs/_browser.html.erb

@@ -11,12 +11,8 @@
     Styling note: gem-specific looks live in the scoped <style> below because a
     host's Tailwind build may not scan this gem's views (same reasoning as the
     geo grid). Layout leans on utilities every host already ships. %>
+<%= render "studio/knowledge_docs/chip_styles" %>
 <style>
-  .knowledge-chip { display: inline-block; padding: 0 .5rem; border-radius: 9999px;
-    font-size: .7rem; line-height: 1.4rem; border: 1px solid transparent; white-space: nowrap; }
-  .knowledge-chip-full  { background: rgb(16 185 129 / .12); border-color: rgb(16 185 129 / .4); color: rgb(5 150 105); }
-  .knowledge-chip-aware { background: rgb(245 158 11 / .12); border-color: rgb(245 158 11 / .4); color: rgb(180 83 9); }
-  .knowledge-chip-none  { background: rgb(148 163 184 / .12); border-color: rgb(148 163 184 / .4); color: rgb(100 116 139); }
   .knowledge-status { font-size: .7rem; padding: 0 .45rem; border-radius: .25rem; border: 1px solid rgb(148 163 184 / .5); }
   .knowledge-status-inbox      { border-color: rgb(245 158 11 / .6); color: rgb(180 83 9); }
   .knowledge-status-superseded { text-decoration: line-through; opacity: .6; }

data/app/views/studio/knowledge_docs/_chip_styles.html.erb

@@ -0,0 +1,10 @@
+<%# The access-chip look, shared by the browser and the show page — one
+    definition so the two can never drift. Scoped <style> rather than utility
+    classes because a host's Tailwind build may not scan this gem's views. %>
+<style>
+  .knowledge-chip { display: inline-block; padding: 0 .5rem; border-radius: 9999px;
+    font-size: .7rem; line-height: 1.4rem; border: 1px solid transparent; white-space: nowrap; }
+  .knowledge-chip-full  { background: rgb(16 185 129 / .12); border-color: rgb(16 185 129 / .4); color: rgb(5 150 105); }
+  .knowledge-chip-aware { background: rgb(245 158 11 / .12); border-color: rgb(245 158 11 / .4); color: rgb(180 83 9); }
+  .knowledge-chip-none  { background: rgb(148 163 184 / .12); border-color: rgb(148 163 184 / .4); color: rgb(100 116 139); }
+</style>

data/app/views/studio/knowledge_docs/show.html.erb

@@ -1,12 +1,6 @@
 <%# /admin/knowledge/:id — one document: metadata, access, download, and the
     triage form that files it out of the inbox. %>
-<style>
-  .knowledge-chip { display: inline-block; padding: 0 .5rem; border-radius: 9999px;
-    font-size: .7rem; line-height: 1.4rem; border: 1px solid transparent; white-space: nowrap; }
-  .knowledge-chip-full  { background: rgb(16 185 129 / .12); border-color: rgb(16 185 129 / .4); color: rgb(5 150 105); }
-  .knowledge-chip-aware { background: rgb(245 158 11 / .12); border-color: rgb(245 158 11 / .4); color: rgb(180 83 9); }
-  .knowledge-chip-none  { background: rgb(148 163 184 / .12); border-color: rgb(148 163 184 / .4); color: rgb(100 116 139); }
-</style>
+<%= render "studio/knowledge_docs/chip_styles" %>
 
 <div class="mb-4 text-sm">
   <%= link_to "← Knowledge", admin_knowledge_path(folder: @doc.path.presence) %>
@@ -29,7 +23,7 @@
   <div><dt class="opacity-60">Document date</dt><dd><%= @doc.document_date&.iso8601 || "—" %></dd></div>
   <div><dt class="opacity-60">Uploaded</dt><dd><%= @doc.created_at&.to_date&.iso8601 %> by <%= @doc.uploaded_by.presence || "—" %></dd></div>
   <div><dt class="opacity-60">Source</dt><dd><%= @doc.source_note.presence || "—" %></dd></div>
-  <div><dt class="opacity-60">File</dt><dd><%= @doc.file? ? "#{@doc.mime_type.presence || 'file'} · #{number_to_human_size(@doc.byte_size) if @doc.byte_size}" : "metadata only" %></dd></div>
+  <div><dt class="opacity-60">File</dt><dd><%= @doc.file? ? [ @doc.mime_type.presence || "file", (number_to_human_size(@doc.byte_size) if @doc.byte_size) ].compact.join(" · ") : "metadata only" %></dd></div>
   <div class="md:col-span-2"><dt class="opacity-60">Access</dt><dd><%= render "studio/knowledge_docs/access_chips", doc: @doc %></dd></div>
 </dl>
 

data/db/migrate/20260901000001_create_studio_knowledge_docs.rb

@@ -3,6 +3,11 @@
 # (`bin/rails studio_engine:install:migrations && bin/rails db:migrate`) so the
 # table is created in the app's database. Do not hand-copy — a hand copy
 # collides with the installed copy on `class CreateStudioKnowledgeDocs`.
+#
+# STYLE NOTE: reference migrations are written omakase-rubocop-compatible
+# (spaces inside array brackets) because the installed copy is linted by the
+# CONSUMER's rubocop, not this gem's — an engine-styled copy fails the
+# consumer's cert untouched (measured on the Industries adoption ship).
 class CreateStudioKnowledgeDocs < ActiveRecord::Migration[7.2]
   def change
     create_table :studio_knowledge_docs do |t|
@@ -41,8 +46,8 @@ class CreateStudioKnowledgeDocs < ActiveRecord::Migration[7.2]
       t.timestamps
     end
 
-    add_index :studio_knowledge_docs, [:entity, :status]
-    add_index :studio_knowledge_docs, [:entity, :path]
+    add_index :studio_knowledge_docs, [ :entity, :status ]
+    add_index :studio_knowledge_docs, [ :entity, :path ]
     add_index :studio_knowledge_docs, :s3_key, unique: true
     add_index :studio_knowledge_docs, :superseded_by_id
   end

data/lib/studio/version.rb

@@ -1,3 +1,3 @@
 module Studio
-  VERSION = "0.67.1"
+  VERSION = "0.67.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: studio-engine
 version: !ruby/object:Gem::Version
-  version: 0.67.1
+  version: 0.67.2
 platform: ruby
 authors:
 - Alex McRitchie
@@ -440,6 +440,7 @@ files:
 - app/views/studio/geo_settings/edit.html.erb
 - app/views/studio/knowledge_docs/_access_chips.html.erb
 - app/views/studio/knowledge_docs/_browser.html.erb
+- app/views/studio/knowledge_docs/_chip_styles.html.erb
 - app/views/studio/knowledge_docs/_doc_row.html.erb
 - app/views/studio/knowledge_docs/_upload_form.html.erb
 - app/views/studio/knowledge_docs/index.html.erb