stronger_parameters 2.9.1 → 2.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 54219a64d62205a5f7b5225701e1063f00f6154f
-  data.tar.gz: fcd54cba013965daeef08f4a6e3a8d857f38f2ba
+SHA256:
+  metadata.gz: cb22b1fb5c98209fe81621c7f50152b17f2b0d5458d72c654da4b860d51059f0
+  data.tar.gz: ff6231049acb0905983ca99936e7e53c7122b8003dcb1c9fb04a77cb72bc9af8
 SHA512:
-  metadata.gz: 4f1af4bd2b056774b5e0650744ca036adda1e5c63c0a4c02241e498ef1b36396a3cf01bf4aa7dbe62ac791d31182f3f3ab41771e65df963fef8b6b8f7ef16bb7
-  data.tar.gz: b245fe4a9da12687ba89a49fa6f5912c2e3d5285298529a5059f4cd596d491ffe5b71cb13e575d80966e2e2ff22564e5a0c04eff45bffe0bfe5a8bdd8e02d79a
+  metadata.gz: a92756b7818f80ac3b68cf18e11ebcbd0e1ca7b5a3ca43b9e9864b10770c3a613597e8bde50c22d2709485977c9c35fbd1026c607c03ed3452c20b56b729739a
+  data.tar.gz: 1d41ef873c24d42fa8bf5b54a1612d424d5353049725b25b1e4678baaebb244f3e54415ba1d5a26deddb9f3d659c2482fe6ad93ef89e4cc090e95dabbe3ebb7e

data/lib/stronger_parameters.rb

@@ -4,3 +4,4 @@ require 'action_pack'
 require 'strong_parameters' if ActionPack::VERSION::MAJOR == 3
 require 'stronger_parameters/parameters'
 require 'stronger_parameters/constraints'
+require 'stronger_parameters/controller_support/permitted_parameters'

data/lib/stronger_parameters/constraints/comparison_constraints.rb

@@ -9,6 +9,10 @@ module StrongerParameters
       @limit = limit
     end
 
+    def value(*)
+      raise NotImplementedError
+    end
+
     def ==(other)
       super && limit == other.limit
     end

data/lib/stronger_parameters/constraints/date_time_constraint.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:disable Style/DateTime
 require 'stronger_parameters/constraint'
 
 module StrongerParameters
@@ -14,3 +15,4 @@ module StrongerParameters
     end
   end
 end
+# rubocop:enable Style/DateTime

data/lib/stronger_parameters/constraints/hash_constraint.rb

@@ -10,15 +10,14 @@ module StrongerParameters
     end
 
     def value(v)
-      if v.is_a?(Hash)
-        return ActionController::Parameters.new(v).permit! if constraints.nil?
-        return ActionController::Parameters.new(v).permit(constraints)
-      elsif ActionPack::VERSION::MAJOR >= 5 && v.is_a?(ActionController::Parameters)
-        return v.permit! if constraints.nil?
-        return v.permit(constraints)
-      end
+      return InvalidValue.new(v, "must be a hash") if !v.is_a?(Hash) && !v.is_a?(ActionController::Parameters)
 
-      InvalidValue.new(v, "must be a hash")
+      v = ActionController::Parameters.new(v) if v.is_a?(Hash)
+      if constraints.nil?
+        v.permit!
+      else
+        v.permit(constraints)
+      end
     end
 
     def merge(other)

data/lib/stronger_parameters/constraints/string_constraint.rb

@@ -27,7 +27,7 @@ module StrongerParameters
     end
 
     def ==(other)
-      super && maximum_length == other.maximum_length
+      super && maximum_length == other.maximum_length && minimum_length == other.minimum_length
     end
   end
 end

data/lib/stronger_parameters/controller_support/permitted_parameters.rb

@@ -54,11 +54,11 @@ module StrongerParameters
 
         def permitted_parameters_for(action)
           unless for_action = permit_parameters[action]
-            location = instance_method(action).source_location
-            raise(
-              KeyError,
-              "Action #{action} for #{self} does not have any permitted parameters (#{location.join(":")})"
-            )
+            # NOTE: there is no easy way to test this, so make sure to test with
+            # a real rails controller if you make changes.
+            message = "Action #{action} for #{self} does not have any permitted parameters"
+            message += " (#{instance_method(action).source_location.join(":")})" if method_defined?(action)
+            raise(KeyError, message)
           end
           return :skip if for_action == :skip
 

data/lib/stronger_parameters/errors.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module StrongerParameters
   class InvalidValue
-    attr_accessor :value, :message
+    attr_reader :value, :message
 
     def initialize(value, message)
       @value = value
@@ -10,7 +10,7 @@ module StrongerParameters
   end
 
   class InvalidParameter < StandardError
-    attr_accessor :key, :value
+    attr_reader :key, :value
 
     def initialize(invalid_value, key)
       @value = invalid_value.value

data/lib/stronger_parameters/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module StrongerParameters
-  VERSION = '2.9.1'
+  VERSION = '2.10.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stronger_parameters
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.10.0
 platform: ruby
 authors:
 - Mick Staugaard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-25 00:00:00.000000000 Z
+date: 2018-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -220,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Type checking and type casting of parameters for Action Pack