stronger_parameters 2.12.1 → 2.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49ff0e22a205c3fa4f63f7eb67d4b03d99712581737de01a07a6a7f7b5170a8c
-  data.tar.gz: c0754ea977e118cad81cbccb13b437e133718c4bc10a5267395021865eca2fc4
+  metadata.gz: ce9ec4b63f79317aa849950dcb6431c4fd0c3a5515abc3eb88aaa170f5680355
+  data.tar.gz: 85cc4373897928267c81214cdf1ca1207a705ee93f32cc647be65c02c0dcbb56
 SHA512:
-  metadata.gz: a35e1e69c80a3dcf8ac80fa9fd954a2c41bc6fe86d1025c4156e41904c5a2b1302d048d3c92a01b5dbd2110b72e21aa1c2a58082ed3e0818aaf03c52dddc200f
-  data.tar.gz: 4f7418f01c05f3d777d09d32bec2423446395932b949e8e11b01f6dd0f0d058da16b2bda08fbad84588b0d6214f823aae3ed9420710b84bf6025ab15ec8316f5
+  metadata.gz: 3f4bd6274fdf4a44431fbb1cf87e93ba2393c2d0e78c65d3fe6fe4afdde77f1abd6a7ff24e87216cb622ed43795f1900a10f825915f1bcb04f62ef5bd62eca2d
+  data.tar.gz: 97d87e0b66db0f5c125b136385b379f72c4af95e17599c1a3f270ea0268af2f27d3532831b83f84b233492131962f9782ef35513963d1dde53ad73ad89e7e818

data/README.md

@@ -1,5 +1,5 @@
 # stronger_parameters
-[![Build Status](https://travis-ci.org/zendesk/stronger_parameters.svg?branch=master)](https://travis-ci.org/zendesk/stronger_parameters)
+![CI](https://github.com/zendesk/stronger_parameters/workflows/CI/badge.svg)
 
 This is an extension of `strong_parameters` with added type checking and conversion.
 

data/lib/stronger_parameters/constraints/boolean_constraint.rb

@@ -7,6 +7,8 @@ module StrongerParameters
     FALSE_VALUES = [false, 'false', '0', 0].freeze
 
     def value(v)
+      v = v.downcase if v.is_a? String
+
       return true if TRUE_VALUES.include?(v)
 
       return false if FALSE_VALUES.include?(v)

data/lib/stronger_parameters/constraints/integer_constraint.rb

@@ -6,7 +6,7 @@ module StrongerParameters
     def value(v)
       if v.is_a?(Integer)
         return v
-      elsif v.is_a?(String) && v =~ /\A-?\d+\Z/
+      elsif v.is_a?(String) && v.strip =~ /\A-?\d+\Z/
         return v.to_i
       end
 

data/lib/stronger_parameters/controller_support/permitted_parameters.rb

@@ -6,8 +6,7 @@ module StrongerParameters
     module PermittedParameters
       def self.included(klass)
         klass.extend ClassMethods
-        method = (klass.respond_to?(:before_action) ? :before_action : :before_filter)
-        klass.public_send method, :permit_parameters
+        klass.before_action :permit_parameters
       end
 
       def self.sugar(value)
@@ -15,9 +14,7 @@ module StrongerParameters
         when Array
           ActionController::Parameters.array(*value.map { |v| sugar(v) })
         when Hash
-          constraints = value.each_with_object({}) do |(key, v), memo|
-            memo[key] = sugar(v)
-          end
+          constraints = value.transform_values { |v| sugar(v) }
           ActionController::Parameters.map(constraints)
         else
           value
@@ -63,8 +60,7 @@ module StrongerParameters
           return :skip if for_action == :skip
 
           # FYI: we should be able to call sugar on the result of deep_merge, but it breaks tests
-          permit_parameters[:all].deep_merge(for_action).
-            each_with_object({}) { |(k, v), a| a[k] = PermittedParameters.sugar(v) }
+          permit_parameters[:all].deep_merge(for_action).transform_values { |v| PermittedParameters.sugar(v) }
         end
 
         private
@@ -94,7 +90,7 @@ module StrongerParameters
 
         return if log_unpermitted
 
-        (ActionPack::VERSION::MAJOR >= 5 ? params.send(:parameters) : params).replace(permitted_params)
+        params.send(:parameters).replace(permitted_params)
         params.permit!
         request.params.replace(permitted_params)
 
@@ -132,7 +128,7 @@ module StrongerParameters
       end
 
       def flat_keys(hash)
-        hash = hash.send(:parameters) if ActionPack::VERSION::MAJOR >= 5 && hash.is_a?(ActionController::Parameters)
+        hash = hash.send(:parameters) if hash.is_a?(ActionController::Parameters)
         hash.flat_map { |k, v| v.is_a?(Hash) ? flat_keys(v).map { |x| "#{k}.#{x}" }.push(k) : k }
       end
     end

data/lib/stronger_parameters/parameters.rb

@@ -1,12 +1,8 @@
 # frozen_string_literal: true
 require 'action_pack'
 
-if ActionPack::VERSION::MAJOR == 3
-  require 'action_controller/parameters'
-else
-  require 'action_controller/base'
-  require 'action_controller/metal/strong_parameters'
-end
+require 'action_controller/base'
+require 'action_controller/metal/strong_parameters'
 
 require 'stronger_parameters/constraints'
 require 'stronger_parameters/errors'
@@ -113,7 +109,7 @@ module StrongerParameters
       end
 
       def datetime_iso8601
-        DateTimeIso8601Constraint.new
+        DateTimeIso8601Constraint.new # uncovered
       end
 
       def file
@@ -143,9 +139,8 @@ module StrongerParameters
 
       hash_filter_without_stronger_parameters(params, other_filter)
 
-      stronger_filter.keys.each do |key|
+      stronger_filter.each_key do |key|
         value = fetch(key, nil)
-        result = nil
 
         if value.nil? && self.class.allow_nil_for_everything
           params[key] = nil if key?(key)
@@ -159,7 +154,7 @@ module StrongerParameters
         elsif constraint.required?
           result = InvalidValue.new(nil, 'must be present')
         else
-          next
+          next # uncovered
         end
 
         if result.is_a?(InvalidValue)
@@ -195,12 +190,11 @@ module StrongerParameters
       # TODO: this is not consistent with the behavior of raising ActionController::UnpermittedParameters
       # should have the same render vs raise behavior in test/dev ... see permitted_parameters_test.rb
       rescue_from(StrongerParameters::InvalidParameter) do |e|
-        type = (ActiveSupport::VERSION::MAJOR < 5 ? :text : :plain)
-        render type => e.message, :status => :bad_request
+        render plain: e.message, status: :bad_request # uncovered
       end
     end
   end
 end
 
-ActionController::Parameters.send :include, StrongerParameters::Parameters
-ActionController::Base.send :include, StrongerParameters::ControllerSupport
+ActionController::Parameters.include StrongerParameters::Parameters
+ActionController::Base.include StrongerParameters::ControllerSupport

data/lib/stronger_parameters/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module StrongerParameters
-  VERSION = '2.12.1'
+  VERSION = '2.16.0'
 end

data/lib/stronger_parameters.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 require 'stronger_parameters/version'
 require 'action_pack'
-require 'strong_parameters' if ActionPack::VERSION::MAJOR == 3
 require 'stronger_parameters/parameters'
 require 'stronger_parameters/constraints'
 require 'stronger_parameters/controller_support/permitted_parameters'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stronger_parameters
 version: !ruby/object:Gem::Version
-  version: 2.12.1
+  version: 2.16.0
 platform: ruby
 authors:
 - Mick Staugaard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-19 00:00:00.000000000 Z
+date: 2022-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest-rails
   requirement: !ruby/object:Gem::Requirement
@@ -67,21 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest-around
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest-rg
+  name: maxitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: wwtd
+  name: bump
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bump
+  name: single_cov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: single_cov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: forking_test_runner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -170,20 +142,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
 description: 
 email:
 - mick@zendesk.com
@@ -218,7 +190,8 @@ files:
 homepage: https://github.com/zendesk/stronger_parameters
 licenses:
 - Apache License Version 2.0
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -227,14 +200,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Type checking and type casting of parameters for Action Pack