strong_versions 0.4.0 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f73f7623edb5e3a662b18ea78cd67822dfdbcc81bd6eb0e9332e80bd1eda57c6
-  data.tar.gz: 9ed40edc5e76826e6458848fadd2b92a5b9f0985cefa0a3e56943c176e32edbb
+  metadata.gz: 4e3d02b2717fbfdc7da2e7cc0d83b495e01bc6b31efae98f635abae1cf8bf837
+  data.tar.gz: fb28b5ddd0a45c7ca56306bcfd58013824c9949bcd723a324dde98431f0b197c
 SHA512:
-  metadata.gz: 17fc0b16150395edf3d57daed7893803fd012311620285ad3a57df5330cfb28b1c1eebde904ece4484c5651c203dc27eeeb34f4699d79e6d443954020da23f81
-  data.tar.gz: 67d7d4dd885f70cf4877e72180311545606abc33d8191039c95c9afdcc2d2ef8a081222ab4fa56207e23e7830fa9adda0269444c093d8983e4c227119f9fe82a
+  metadata.gz: c4482cf23782277e84fdbf1a3a3e9d998c5cac84202d3c21be563dc4eeb21cdd5c6ba54490ff4f2e81d85899cde8eed32e28879e3a0f861871a1cd5a45b51491
+  data.tar.gz: fccdb21e6f7b58966a4f6dcee95ae6c176ae7be7b5380f820b660235f7a56f80163414475e9a4799d50d369f1ab73ddd354da98ba9aba83db03eb74c82f1cce3

data/.rubocop.yml

@@ -11,4 +11,52 @@ Style/FormatStringToken:
     - 'lib/strong_versions/terminal.rb'
 AllCops:
   Exclude:
-    - 'bin/**/*'
+    - 'bin/rake'
+    - 'bin/console'
+    - 'bin/rspec'
+    - 'bin/rubocop'
+    - 'bin/setup'
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Style/AccessorGrouping:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true

data/Makefile

@@ -1,6 +1,5 @@
 .PHONY: test
 test:
-	@bin/rspec
-	@bundle exec bin/strong_versions
-	@bin/rubocop
-	@bin/rubocop bin/strong_versions
+	@bundle exec rspec
+	@bundle exec strong_versions
+	@bundle exec rubocop

data/README.md

@@ -1,11 +1,5 @@
 # StrongVersions
 
-```
-The right thing to guide us
-Is right here inside us
-               --Nickelback
-```
-
 # Overview
 
 _StrongVersions_ enforces a strict policy on your `Gemfile` requirements:
@@ -13,13 +7,13 @@ _StrongVersions_ enforces a strict policy on your `Gemfile` requirements:
 * The pessimistic `~>` operator must be used for all gem requirement definitions.
 * If the gem version is greater than 1, the requirement format must be `major.minor`, e.g. `'~> 2.5`'
 * If the gem version is less than 1, the requirement format must be `major.minor.patch`, e.g. `'~> 0.8.9'`
-* An upper bound can be specified as long as a valid pessimistic version is also specified, e.g. `'~> 8.4', '< 8.6.7' # Bug introduced in 8.6.7`
+* A lower/upper bound can be specified as long as a valid pessimistic version is also specified, e.g. `'~> 8.4', '< 8.6.7'`
 * All gems with a `path` or `git` source are ignored, e.g. `path: '/path/to/gem'`, `git: 'https://github.com/bobf/strong_versions'`
 * All gems specified in the [ignore list](#ignore) are ignored.
 
-Any gems that do not satisfy these rules will be included in included in the _StrongVersions_ output with details on why they did not meet the standard.
+Any gems that do not satisfy these rules will be included in the _StrongVersions_ output with details on why they did not meet the standard.
 
-The benefit of applying this standard is that, if all gems follow [Semantic Versioning](https://semver.org/) always be relatively safe to run `bundle update` to upgrade to the latest compatible versions of all dependencies. Running `bundle update` often brings advantages both in terms of bug fixes and security updates.
+When all gems in a `Gemfile` follow this convention it SHOULD always be safe to run `bundle update` (assuming all gems adhere to [Semantic Versioning](https://semver.org/)).
 
 ![StrongVersions](doc/images/strong-versions-example.png)
 
@@ -28,7 +22,7 @@ The benefit of applying this standard is that, if all gems follow [Semantic Vers
 Add the gem to your `Gemfile`
 
 ```ruby
-gem 'strong_versions', '~> 0.4.0'
+gem 'strong_versions', '~> 0.4.5'
 ```
 
 And rebuild your bundle:
@@ -37,11 +31,6 @@ And rebuild your bundle:
 $ bundle install
 ```
 
-Or install yourself:
-```bash
-$ gem install strong_versions -v '0.4.0'
-```
-
 ## Usage
 
 _StrongVersions_ is invoked with a provided executable:
@@ -54,7 +43,7 @@ The executable will output all non-passing gems and will return an exit code of
 
 ![StrongVersions](doc/images/ci-pipeline.png)
 
-If you are feeling brave, auto-correct is available:
+Auto-correct is available with the `-a/--auto-correct` option:
 ```bash
 $ bundle exec strong_versions -a
 ```
@@ -69,6 +58,7 @@ ignore:
   - rails
 ```
 
+Gems in the ignore list will not be updated when using the `-a/--auto-correct` option.
 ## Contributing
 
 Fork and create a pull request.

data/bin/strong_versions

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
+require 'bundler/setup'
 require 'optparse'
 require 'shellwords'
 
@@ -12,11 +13,11 @@ options = {}
 OptionParser.new do |opts|
   opts.banner = 'Usage: strong_versions [options]'
 
-  opts.on('-a', '--auto-correct', 'Auto-correct (use with caution)') do |_v|
+  opts.on('-a', '--auto-correct', 'Auto-correct (use with caution)') do
     options[:auto_correct] = true
   end
 
-  opts.on('--no-auto-correct', 'Disable auto-correct') do |_v|
+  opts.on('--no-auto-correct', 'Disable auto-correct') do
     options[:auto_correct] = false
   end
 end.parse!
@@ -33,11 +34,12 @@ validated = StrongVersions::Dependencies.new(dependencies).validate!(
   auto_correct: options[:auto_correct]
 )
 
+exit 0 if validated
+
 if options[:auto_correct]
   # Re-evaluate
   args = original_args.map { |arg| Shellwords.escape(arg) }.join(' ')
   exec "#{$PROGRAM_NAME} #{args} --no-auto-correct"
 end
 
-exit 0 if validated
 exit 1

data/bin/strong_versions.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'optparse'
 
 require 'strong_versions'
 
 options = {}
 OptionParser.new do |opts|
-  opts.banner = "Usage: strong_versions [options]"
+  opts.banner = 'Usage: strong_versions [options]'
 
-  opts.on("-a", "--auto-correct", "Auto-correct (use with caution)") do |v|
+  opts.on('-a', '--auto-correct', 'Auto-correct (use with caution)') do |_v|
     options[:auto_correct] = true
   end
 end.parse!
@@ -24,12 +26,13 @@ validated = StrongVersions::Dependencies.new(dependencies).validate!(
 )
 
 revalidated = false
-revalidated = StrongVersions::Dependencies.new(dependencies).validate!(
-  except: config.exceptions,
-  on_failure: 'warn',
-  auto_correct: false
-) if options[:auto_correct]
+if options[:auto_correct]
+  revalidated = StrongVersions::Dependencies.new(dependencies).validate!(
+    except: config.exceptions,
+    on_failure: 'warn',
+    auto_correct: false
+  )
+end
 
-exit 0 if validated or revalidated
+exit 0 if validated || revalidated
 exit 1
-

data/lib/strong_versions.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'pathname'
 require 'yaml'
 
 require 'i18n'
@@ -10,8 +11,9 @@ require 'strong_versions/dependency'
 require 'strong_versions/dependency_finder'
 require 'strong_versions/dependencies'
 require 'strong_versions/errors'
-require 'strong_versions/suggestion'
 require 'strong_versions/terminal'
+require 'strong_versions/gem_version'
+require 'strong_versions/regexes'
 require 'strong_versions/version'
 
 module StrongVersions

data/lib/strong_versions/dependencies.rb

@@ -17,7 +17,7 @@ module StrongVersions
         return true
       end
 
-      return update_gemfile if auto_correct
+      return update_definitions(options.fetch(:except, [])) if auto_correct
 
       raise_or_warn(options.fetch(:on_failure, 'raise'))
       summary
@@ -45,38 +45,47 @@ module StrongVersions
       @terminal.summary(@dependencies.size, @invalid_gems.size)
     end
 
-    def update_gemfile
-      updated = 0
-      @dependencies.each do |dependency|
-        next unless dependency.updatable?
+    def updatable_dependencies(except)
+      @dependencies.reject { |dependency| except.include?(dependency.name) }
+                   .select(&:updatable?)
+    end
 
-        updated += 1 if update_dependency(dependency)
+    def update_definitions(except)
+      @terminal.update_summary(update(:gemfile, except) + update(:gemspec, except))
+    end
+
+    def update(subject, except)
+      updatable_dependencies(except).reduce(0) do |count, dependency|
+        update_dependency(subject, dependency) ? count : count + 1
       end
-      @terminal.update_summary(updated)
     end
 
-    def update_dependency(dependency)
-      path = dependency.gemfile
+    def update_dependency(subject, dependency)
+      path = dependency.public_send(subject)
+      return if path.nil?
+
       content = File.read(path)
-      update = replace_gem_definition(dependency, content)
+      update = replace_gem_definition(subject, dependency, content)
       return false if content == update
 
       File.write(path, update)
-      @terminal.gem_update(path, dependency)
+      @terminal.gem_update(path, dependency, subject)
       true
     end
 
-    def replace_gem_definition(dependency, content)
-      regex = gem_regex(dependency.name)
+    def replace_gem_definition(subject, dependency, content)
+      regex = gem_regex(subject, dependency.name)
       match = content.match(regex)
       return content unless match
 
+      # For gemspec, indent includes the `spec.` or `s.` prefix.
       indent = match.captures.first
-      content.gsub(regex, "#{indent}#{dependency.suggested_definition}")
+      definition = dependency.suggested_definition(subject)
+      content.gsub(regex, "#{indent}#{definition}")
     end
 
-    def gem_regex(name)
-      /^(\s*)gem\s+['"]#{name}['"].*$/
+    def gem_regex(subject, name)
+      Regexes.public_send(subject, name)
     end
 
     def raise_or_warn(on_failure)

data/lib/strong_versions/dependency.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 module StrongVersions
+  # rubocop:disable Metrics/ClassLength
   class Dependency
     attr_reader :name, :errors
 
@@ -13,37 +14,73 @@ module StrongVersions
       versions.each { |operator, version| validate_version(operator, version) }
     end
 
+    def to_s
+      "#<StrongVersions::Dependency name=#{@dependency.name}>"
+    end
+
     def gemfile
       Pathname.new(@dependency.gemfile) if @dependency.respond_to?(:gemfile)
     end
 
+    def gemspec
+      Pathname.new(gemspec_path) unless gemspec_path.nil?
+    end
+
     def valid?
       @errors.empty?
     end
 
-    def suggestion
-      Suggestion.new(lockfile_version)
+    def suggested_version
+      GemVersion.new(GemVersion.new(lockfile_version).version_string)
     end
 
-    def suggested_definition
+    def suggested_definition(subject = :gemfile)
       guards = guard_versions.map { |op, version| "'#{op} #{version}'" }
-      "gem '#{@name}', #{[suggestion, *guards].join(', ')}"
+      constraints = [suggested_version.suggestion, *guards].join(', ')
+      send(:"suggested_#{subject}_definition", constraints)
     end
 
     def definition
       versions.map do |operator, version|
-        next t('version_not_specified') if operator == '>=' && version == '0'
+        next t('version_not_specified') if operator == '>=' && version.zero?
 
         "'#{operator} #{version}'"
       end.join(', ')
     end
 
     def updatable?
-      gemfile && !suggestion.missing? && !path_source?
+      !valid? && !suggested_version.missing? && !path_source?
     end
 
     private
 
+    def gemspec_path
+      _spec, path = gemspec_dependency
+      path
+    end
+
+    def gemspec_spec
+      spec, _path = gemspec_dependency
+      spec
+    end
+
+    def gemspec_dependency
+      DependencyFinder.new.gemspec_dependencies.each do |path, specs|
+        specs.each do |spec|
+          return [spec, path] if spec.name == @dependency.name
+        end
+      end
+      nil
+    end
+
+    def suggested_gemspec_definition(constraints)
+      "add_#{gemspec_spec.type}_dependency '#{@name}', #{constraints}"
+    end
+
+    def suggested_gemfile_definition(constraints)
+      "gem '#{@name}', #{constraints}"
+    end
+
     def versions
       @dependency.requirements_list.map { |version| parse_version(version) }
     end
@@ -54,13 +91,13 @@ module StrongVersions
 
     def parse_version(requirement)
       operator, version_obj = Gem::Requirement.parse(requirement)
-      [operator, version(version_obj)]
+      [operator, GemVersion.new(version_obj)]
     end
 
     def lockfile_version
       @lockfile_version ||= begin
         gem_spec = @lockfile.specs.find { |spec| spec.name == @name }
-        gem_spec.nil? ? nil : version(gem_spec.version)
+        gem_spec.nil? ? nil : gem_spec.version
       end
     end
 
@@ -68,19 +105,11 @@ module StrongVersions
       Bundler::LockfileParser.new(Bundler.read_file(Bundler.default_lockfile))
     end
 
-    def version(version_obj)
-      # Ruby >= 2.3.0: `version_obj` is a `Gem::Version`
-      return version_obj.version if version_obj.respond_to?(:version)
-
-      # Ruby < 2.3.0: `version_obj` is a `String`
-      version_obj
-    end
-
     def validate_version(operator, version)
       return if path_source?
       return if any_valid?
 
-      check_pessimistic(operator)
+      check_pessimistic(operator) unless version.zero?
       check_valid_version(version)
     end
 
@@ -91,41 +120,34 @@ module StrongVersions
     end
 
     def check_valid_version(version)
-      return if valid_version?(version)
+      return if version.valid?
 
-      value = version == '0' ? t('version_not_specified') : version
+      value = version.zero? ? t('version_not_specified') : version
       @errors << { type: :version, value: value }
     end
 
     def redundant?(operator, version)
-      return false unless operator.start_with?('>') || pessimistic?(operator)
+      return true if pessimistic?(operator)
+      return false if guard_needed?(operator, version)
 
-      multiply_version(version) <= multiply_version(suggestion.version)
+      true
     end
 
-    def multiply_version(version)
-      # Support extremely precise versions e.g. '1.2.3.4.5.6.7.8.9'
-      components = version.split('.').map(&:to_i)
-      components += [0] * (10 - components.size)
-      components.reverse.each_with_index.map do |component, index|
-        component * 10.pow(index + 1)
-      end.sum
+    def guard_needed?(operator, version)
+      return false unless %w[< <= > >=].include?(operator)
+      return true if %(< <=).include?(operator) && suggested_version < version
+      return true if %(> >=).include?(operator) && suggested_version < version
+
+      false
     end
 
     def pessimistic?(operator)
       operator == '~>'
     end
 
-    def valid_version?(version)
-      return true if version =~ /^[1-9][0-9]*\.\d+$/ # major.minor, e.g. "2.5"
-      return true if version =~ /^0\.\d+\.\d+$/ # 0.minor.patch, e.g. "0.1.8"
-
-      false
-    end
-
     def any_valid?
       versions.any? do |operator, version|
-        pessimistic?(operator) && valid_version?(version)
+        pessimistic?(operator) && version.valid?
       end
     end
 
@@ -139,4 +161,5 @@ module StrongVersions
       I18n.t("strong_versions.#{name}")
     end
   end
+  # rubocop:enable Metrics/ClassLength
 end

data/lib/strong_versions/dependency_finder.rb

@@ -6,6 +6,12 @@ module StrongVersions
       development + runtime
     end
 
+    def gemspec_dependencies
+      Hash[gemspecs.compact.map do |gemspec|
+        [gemspec.loaded_from, dependencies]
+      end]
+    end
+
     private
 
     def development

data/lib/strong_versions/gem_version.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+
+module StrongVersions
+  class GemVersion
+    def initialize(version)
+      @version = normalize(version) || ''
+      @parts = @version&.split('.')
+    end
+
+    def to_s
+      @version
+    end
+
+    def zero?
+      @version == '0'
+    end
+
+    def suggestion
+      return '' if version_string.empty?
+
+      "'~> #{version_string}'"
+    end
+
+    def version_string
+      return '' unless standard?
+
+      major, minor, patch = @parts
+      return "#{major}.#{minor}" if stable?
+      return "#{major}.#{minor}.#{patch}" if unstable?
+
+      raise 'Unexpected condition met'
+    end
+
+    def <(other)
+      numeric < other.numeric
+    end
+
+    def <=(other)
+      numeric <= other.numeric
+    end
+
+    def >(other)
+      numeric > other.numeric
+    end
+
+    def >=(other)
+      numeric >= other.numeric
+    end
+
+    def numeric
+      # Support extremely precise versions e.g. '1.2.3.4.5.6.7.8.9'
+      components = @version.split('.').map(&:to_i)
+      components += [0] * (10 - components.size)
+      components.reverse.each_with_index.map do |component, index|
+        component * 10.pow(index + 1)
+      end.sum
+    end
+
+    def valid?
+      return true if @version =~ /^[1-9][0-9]*\.\d+$/ # major.minor, e.g. "2.5"
+      return true if @version =~ /^0\.\d+\.\d+$/ # 0.minor.patch, e.g. "0.1.8"
+
+      false
+    end
+
+    def missing?
+      return false if stable?
+      return false if unstable?
+
+      true
+    end
+
+    private
+
+    def normalize(version)
+      # Ruby >= 2.3.0: `version_obj` is a `Gem::Version`
+      return version.version.to_s if version.respond_to?(:version)
+
+      # Ruby < 2.3.0: `version_obj` is a `String`
+      version
+    end
+
+    def unstable?
+      standard? && @parts.first.to_i.zero?
+    end
+
+    def stable?
+      standard? && @parts.first.to_i >= 1
+    end
+
+    def standard?(parts = @parts)
+      return false if parts.nil?
+      return false unless numeric?
+      return true if [2, 3, 4].include?(parts.size)
+      return true if parts.size == 3
+
+      false
+    end
+
+    def numeric?
+      @parts.all? { |part| part =~ /\A[0-9]+\Z/ }
+    end
+  end
+end

data/lib/strong_versions/regexes.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module StrongVersions
+  module Regexes
+    class << self
+      def gemfile(name)
+        /^(\s*)gem\s+['"]#{name}['"].*$/
+      end
+
+      def gemspec(name)
+        /^(\s*[A-Za-z]+\.)add_[a-z_]*_?dependency\s*\(?\s*['"]#{name}['"].*$/
+      end
+    end
+  end
+end

data/lib/strong_versions/terminal.rb

@@ -10,14 +10,14 @@ module StrongVersions
       puts(color(string, :bright, :red))
     end
 
-    def gem_update(path, gem)
+    def gem_update(path, gem, subject)
       relpath = path.relative_path_from(Pathname.new(Dir.pwd))
       output = [
-        color("[#{relpath}] ", :cyan),
-        color(gem.suggested_definition, :green),
-        color(' (was: ', :default),
-        color(gem.definition, :red),
-        color(')', :default)
+        color('[', :cyan),
+        color(relpath.to_s, :green),
+        color('] ', :cyan),
+        color('updated: ', :default),
+        color(gem.suggested_definition(subject), :green)
       ].join
       puts(output)
     end
@@ -77,10 +77,9 @@ module StrongVersions
         type = t("errors.#{error[:type]}")
         color(
           '  %{type} %{example}, found: %{found}',
-          :default,
-          type: [type, :default],
-          example: example(error[:type]),
-          found: [error[:value], :red]
+          :default, type: [type, :default],
+                    example: example(error[:type]),
+                    found: [error[:value], :red]
         )
       end
     end
@@ -92,10 +91,11 @@ module StrongVersions
     end
 
     def suggestion_definition(gem)
-      unidentified = gem.suggestion.to_s.empty?
+      version = gem.suggested_version.suggestion
+      unidentified = version.empty?
       return [t('no-suggestion'), :yellow] if unidentified
 
-      [gem.suggestion.to_s, :green]
+      [version, :green]
     end
 
     def name_and_definition(gem)

data/lib/strong_versions/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StrongVersions
-  VERSION = '0.4.0'
+  VERSION = '0.4.5'
 end

data/strong_versions.gemspec

@@ -28,14 +28,13 @@ Gem::Specification.new do |spec|
   # stop supporting Rails 4 we need to support I18n 0.x and 1.x. At some point,
   # I will do a release that is locked to '~> 1.0' and Rails 4 users can use
   # an older version of the gem but we are not quite there yet.
-  spec.add_dependency 'i18n', '>= 0.5.0'
+  spec.add_runtime_dependency 'i18n', '>= 0.5'
   spec.add_dependency 'paint', '~> 2.0'
 
-  spec.add_development_dependency 'betterp', '~> 0.1.2'
   spec.add_development_dependency 'bundler', '~> 1.16'
-  spec.add_development_dependency 'byebug', '~> 10.0'
+  spec.add_development_dependency 'devpack', '~> 0.1.1'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-its', '~> 1.2'
-  spec.add_development_dependency 'rubocop', '~> 0.60.0'
+  spec.add_development_dependency 'rubocop', '~> 0.87.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strong_versions
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.5
 platform: ruby
 authors:
 - Bob Farrell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-25 00:00:00.000000000 Z
+date: 2020-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: paint
   requirement: !ruby/object:Gem::Requirement
@@ -38,20 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: betterp
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -67,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: devpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.1.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.87.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.87.1
 description: Ensure your gems are appropriately versioned
 email:
 - oss@bob.frl
@@ -171,7 +157,8 @@ files:
 - lib/strong_versions/dependency.rb
 - lib/strong_versions/dependency_finder.rb
 - lib/strong_versions/errors.rb
-- lib/strong_versions/suggestion.rb
+- lib/strong_versions/gem_version.rb
+- lib/strong_versions/regexes.rb
 - lib/strong_versions/terminal.rb
 - lib/strong_versions/version.rb
 - strong_versions.gemspec

data/lib/strong_versions/suggestion.rb

@@ -1,59 +0,0 @@
-# frozen_string_literal: true
-
-module StrongVersions
-  class Suggestion
-    def initialize(version)
-      return if version.nil?
-
-      @parts = version.split('.')
-      # Treat '4.3.2.1' as '4.3.2'
-      @parts.pop if standard?(@parts.first(3)) && @parts.size == 4
-    end
-
-    def to_s
-      return version.to_s if version.nil?
-
-      "'~> #{version}'"
-    end
-
-    def version
-      return nil unless standard?
-
-      major, minor, patch = @parts
-      return "#{major}.#{minor}" if stable?
-      return "#{major}.#{minor}.#{patch}" if unstable?
-
-      raise 'Unexpected condition met'
-    end
-
-    def missing?
-      return false if stable?
-      return false if unstable?
-
-      true
-    end
-
-    private
-
-    def unstable?
-      standard? && @parts.first.to_i.zero?
-    end
-
-    def stable?
-      standard? && @parts.first.to_i >= 1
-    end
-
-    def standard?(parts = @parts)
-      return false if parts.nil?
-      return false unless numeric?
-      return true if [2, 3].include?(parts.size)
-      return true if parts.size == 3 && unstable?
-
-      false
-    end
-
-    def numeric?
-      @parts.all? { |part| part =~ /\A[0-9]+\Z/ }
-    end
-  end
-end