strong_presenter 0.2.1 → 0.2.2

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # StrongPresenter Changelog
 
+## 0.2.2
+- remove arguments from permission checking - complex and potentially very inefficient
+- extract permissions into separate gem
+
 ## 0.2.1
 
 - Bug fix: `presents` with nested associations

data/lib/strong_presenter.rb

@@ -11,13 +11,13 @@ require 'active_support/core_ext/hash/keys'
 require 'active_support/core_ext/hash/reverse_merge'
 require 'active_support/core_ext/name_error'
 
+require "strong_attributes"
+
 require "strong_presenter/version"
 require "strong_presenter/view_helpers"
 require "strong_presenter/helper_proxy"
 require "strong_presenter/view_context"
 require "strong_presenter/delegation"
-require "strong_presenter/permissions"
-require "strong_presenter/permissible"
 require "strong_presenter/associable"
 require "strong_presenter/inferrer"
 require "strong_presenter/presenter"

data/lib/strong_presenter/associable.rb

@@ -3,7 +3,7 @@ module StrongPresenter
   # Methods for defining presenter associations
   module Associable
     extend ActiveSupport::Concern
-    include StrongPresenter::Permissible
+    include StrongAttributes::Permissible
 
     module ClassMethods
       #   Automatically wraps multiple associations.
@@ -57,7 +57,6 @@ module StrongPresenter
     end
 
     # Permits given attributes, with propagation to associations.
-    # @param (see StrongPresenter::Permissible#permit!)
     def permit! *attribute_paths
       super
       attribute_paths.each do |path| # propagate permit to associations

data/lib/strong_presenter/collection_presenter.rb

@@ -2,8 +2,8 @@ module StrongPresenter
   class CollectionPresenter
     include Enumerable
     include StrongPresenter::ViewHelpers
-    include StrongPresenter::Permissible
     include StrongPresenter::Delegation
+    include StrongAttributes::Permissible
 
     array_methods = Array.instance_methods - Object.instance_methods
     delegate :==, :as_json, *array_methods, to: :collection
@@ -23,7 +23,6 @@ module StrongPresenter
     end
 
     # Permits given attributes, with propagation to collection items.
-    # @param (see StrongPresenter::Permissible#permit!)
     def permit! *attribute_paths
       super
       @collection.each { |presenter| presenter.permit! *attribute_paths } unless @collection.nil?

data/lib/strong_presenter/presenter.rb

@@ -1,9 +1,9 @@
 module StrongPresenter
   class Presenter
     include StrongPresenter::ViewHelpers
-    include StrongPresenter::Permissible
     include StrongPresenter::Associable
     include StrongPresenter::Delegation
+    include StrongAttributes::Displayable
 
     include ActiveModel::Serialization
     include ActiveModel::Serializers::JSON
@@ -25,85 +25,6 @@ module StrongPresenter
       yield self if block_given?
     end
 
-    # Performs mass presentation - if it is allowed, subject to `permit`. To permit all without checking, call `permit!` first.
-    #
-    # Presents and returns the result of each field in the argument list. If a block is given, then each result
-    # is passed to the block. Each field is presented by calling the method on the presenter.
-    #
-    #   user_presenter.presents :username, :email # returns [user_presenter.username, user_presenter.email]
-    #
-    # Or with two arguments, the name of the field is passed first:
-    #
-    #   <ul>
-    #     <% user_presenter.presents :username, :email, :address do |field, value| %>
-    #       <li><%= field.capitalize %>: <% value %></li>     
-    #     <% end %>
-    #   </ul>
-    #
-    # If only the presented value is desired, use `each`:
-    #
-    #   <% user_presenter.presents(:username, :email).each do |value| %>
-    #     <td><%= value %></td>
-    #   <% end %>
-    #
-    # A field can have arguments in an array:
-    #
-    #   user_presenter.presents :username, [:notifications, :unread] # returns [user_presenter.username, user_presenter.notifications(:unread)]
-    #
-    # Notice that this interface allows you to concisely put authorization logic in the controller, with a dumb view layer:
-    #
-    #   # app/controllers/users_controller.rb
-    #   class UsersController < ApplicationController
-    #     def visible_params
-    #       @visible_params ||= begin
-    #         field = [:username]
-    #         field << :email if can? :read_email, @user
-    #         field << :edit_link if can? :edit, @user
-    #       end
-    #     end
-    #     def show
-    #       @users_presenter = UserPresenter.wrap_each(User.all).permit!
-    #     end
-    #   end
-    #
-    #   # app/views/users/show.html.erb
-    #   <table>
-    #     <tr>
-    #       <% visible_params.each do |field| %>
-    #         <th><%= field %></th>
-    #       <% end %>
-    #     </tr>
-    #     <% @users_presenter.each do |user_presenter| %>
-    #       <tr>
-    #         <% user_presenter.presents(*visible_params).each do |value| %>
-    #           <td><%= value %></td>
-    #         <% end %>
-    #       </tr>
-    #     <% end %>
-    #   </table>
-    #
-    def presents *attributes
-      select_permitted(*attributes).map do |args|
-        args = Array(args)
-        obj = self # drill into associations
-        while (args.size > 1) && obj.class.respond_to?(:presenter_associations, true) && obj.class.send(:presenter_associations).include?(args[0]) do
-          obj = obj.public_send args.slice!(0)
-        end
-        value = obj.public_send *args # call final method with args
-        yield args[0], value if block_given?
-        value
-      end
-    end
-
-    # Same as presents, but for a single attribute. The differences are:
-    #   - the return value is not in an Array
-    #   - passes the value only (without attribute key as the 1st argument) to a block
-    def present field
-      presents field do |key, value|
-        yield value if block_given?
-      end.first
-    end
-
     delegate :to_s
 
     # In case object is nil

data/lib/strong_presenter/version.rb

@@ -1,3 +1,3 @@
 module StrongPresenter
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/strong_presenter/associable_spec.rb

@@ -37,7 +37,7 @@ module StrongPresenter
       end
 
       it 'presents nested assocations' do
-        @product_presenter.permit! :**
+        @product_presenter.permit! [:manufacturer, :source, :name]
         expect(@product_presenter.present [:manufacturer, :source, :name]).to eq "Presented Factory"
       end
 
@@ -273,12 +273,6 @@ module StrongPresenter
         expect(@product_presenter.subproducts[0].presents(:name, :price, :description)).to eq ["Sub A", 8]
       end
 
-      it 'propagates double wildcard' do
-        @product_presenter.subproducts[0].permit! :price
-        @product_presenter.permit! :**
-        expect(@product_presenter.subproducts[0].presents(:name, "price", :description)).to eq ["Sub A", 8, "Small"]
-      end
-
       it 'does not propagate single wildcard' do
         @product_presenter.subproducts[0].permit! :price
         @product_presenter.permit! :*

data/strong_presenter.gemspec

@@ -11,6 +11,7 @@ Gem::Specification.new do |gem|
   gem.description   = %q{strong_presenter adds a layer of presentation logic to your application, and gives you strong_parameters-like logic to determine which attributes are visible}
   gem.summary       = %q{strong_presenter adds a layer of presentation logic to your application, and gives you strong_parameters-like logic to determine which attributes are visible}
   gem.homepage      = "https://github.com/ronalchn/strong_presenter"
+  gem.license       = "MPLv2"
 
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@@ -21,6 +22,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'actionpack', '>= 3.0'
   gem.add_dependency 'request_store', '~> 1.0.3'
   gem.add_dependency 'activemodel', '>= 3.0'
+  gem.add_dependency 'strong_attributes', '~> 0.0.2'
 
   gem.add_development_dependency 'ammeter'
   gem.add_development_dependency 'rake', '>= 0.9.2'

metadata

@@ -1,197 +1,170 @@
 --- !ruby/object:Gem::Specification
 name: strong_presenter
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
+  prerelease: 
 platform: ruby
 authors:
 - Ronald Chan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-25 00:00:00.000000000 Z
+date: 2013-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16202200 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '3.0'
+  version_requirements: *16202200
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16200920 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '3.0'
+  version_requirements: *16200920
 - !ruby/object:Gem::Dependency
   name: request_store
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16199520 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.0.3
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.0.3
+  version_requirements: *16199520
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16197540 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  version_requirements: *16197540
+- !ruby/object:Gem::Dependency
+  name: strong_attributes
+  requirement: &16195400 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 0.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: *16195400
 - !ruby/object:Gem::Dependency
   name: ammeter
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16219680 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *16219680
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16218340 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.9.2
+  version_requirements: *16218340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16216400 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.12'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.12'
+  version_requirements: *16216400
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16214640 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 2.12.1
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 2.12.1
+  version_requirements: *16214640
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16213900 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.12'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.12'
+  version_requirements: *16213900
 - !ruby/object:Gem::Dependency
   name: minitest-rails
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16237840 !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.2'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.2'
+  version_requirements: *16237840
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16236820 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *16236820
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16235320 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *16235320
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &16234500 !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '3.0'
+  version_requirements: *16234500
 description: strong_presenter adds a layer of presentation logic to your application,
   and gives you strong_parameters-like logic to determine which attributes are visible
 email:
@@ -233,8 +206,6 @@ files:
 - lib/strong_presenter/factory.rb
 - lib/strong_presenter/helper_proxy.rb
 - lib/strong_presenter/inferrer.rb
-- lib/strong_presenter/permissible.rb
-- lib/strong_presenter/permissions.rb
 - lib/strong_presenter/presenter.rb
 - lib/strong_presenter/presenter_association.rb
 - lib/strong_presenter/presenter_helper_constructor.rb
@@ -323,8 +294,6 @@ files:
 - spec/strong_presenter/controller_additions_spec.rb
 - spec/strong_presenter/delegation_spec.rb
 - spec/strong_presenter/helper_proxy_spec.rb
-- spec/strong_presenter/permissible_spec.rb
-- spec/strong_presenter/permissions_spec.rb
 - spec/strong_presenter/presenter_spec.rb
 - spec/strong_presenter/simplecov_spec.rb
 - spec/strong_presenter/view_context/build_strategy_spec.rb
@@ -337,27 +306,29 @@ files:
 - spec/support/shared_examples/view_helpers.rb
 - strong_presenter.gemspec
 homepage: https://github.com/ronalchn/strong_presenter
-licenses: []
-metadata: {}
+licenses:
+- MPLv2
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.17
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: strong_presenter adds a layer of presentation logic to your application,
   and gives you strong_parameters-like logic to determine which attributes are visible
 test_files:
@@ -436,8 +407,6 @@ test_files:
 - spec/strong_presenter/controller_additions_spec.rb
 - spec/strong_presenter/delegation_spec.rb
 - spec/strong_presenter/helper_proxy_spec.rb
-- spec/strong_presenter/permissible_spec.rb
-- spec/strong_presenter/permissions_spec.rb
 - spec/strong_presenter/presenter_spec.rb
 - spec/strong_presenter/simplecov_spec.rb
 - spec/strong_presenter/view_context/build_strategy_spec.rb
@@ -448,3 +417,4 @@ test_files:
 - spec/support/models.rb
 - spec/support/schema.rb
 - spec/support/shared_examples/view_helpers.rb
+has_rdoc: 

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 6444649230265391d72546b3298782db1383abc4
-  data.tar.gz: 8ed272da88fb418034afe94c7fa8b20ee52139f5
-SHA512:
-  metadata.gz: 4a5aef2eea1880590b28c89643e7900df4a19862bbcb9da51077f17dae5b476fb2dec9b1c220e74b1a22ae1f011cb0911b1aec626dee12c91f881e1252316715
-  data.tar.gz: eae1b941dcd897be3ff945636f327d0b2832541df05d6c93c10f461d7bdea334a199313ec54f2c9ef5ececda6d4f90e827e06b8d561a4982dc393480f5755a1e

data/lib/strong_presenter/permissible.rb

@@ -1,50 +0,0 @@
-module StrongPresenter
-  module Permissible
-    extend ActiveSupport::Concern
-
-    # Permits given attributes. May be invoked multiple times.
-    #
-    # @example Each argument represents a single attribute:
-    #   ArticlePresenter.new(@article).permit(:heading, :article)
-    #
-    # @example Attribute paths can be specified using symbol arrays. If an author name is normally accessed using @article.author.name:
-    #   ArticlePresenter.new(@article).permit([:author, :name])
-    #
-    # @param [[Symbols*]*] attribute_paths
-    #   the attributes to permit. An array of symbols represents an attribute path.
-    # @return [self]
-    def permit! *attribute_paths
-      permitted_attributes.permit *attribute_paths
-      self
-    end
-
-    # Permits all presenter attributes for presents, present & filter methods.
-    def permit_all!
-      permitted_attributes.permit_all!
-      self
-    end
-
-    # Selects the attributes given which have been permitted - an array of attributes
-    # @param [Array<Symbols>*] attribute_paths
-    #   the attribute paths to check. The attribute paths may also have arguments.
-    # @return [Array<Array<Symbol>>] attribute (paths)
-    def select_permitted *attribute_paths
-      permitted_attributes.select_permitted *attribute_paths
-    end
-
-    protected
-    def permitted_attributes
-      @permitted_attributes ||= StrongPresenter::Permissions.new
-    end
-
-    # Links presenter to permissions group of given presenter.
-    # @param [Presenter] parent_presenter
-    # @param [Array<Symbol>] relative_path
-    #   The prefix prepended before every permission check relative to parent presenter.
-    def link_permissions parent_presenter, relative_path = []
-      @permitted_attributes = StrongPresenter::Permissions.new(parent_presenter.permitted_attributes, relative_path)
-    end
-
-  end
-end
-

data/lib/strong_presenter/permissions.rb

@@ -1,141 +0,0 @@
-module StrongPresenter
-  # @private
-  #
-  #   Storage format:
-  #     Each attribute path is stored as an array of objects, usually strings in a Set. For indifferent access, 
-  #     all symbols are converted to strings.
-  #   
-  #     Arguments can also be part of permissions control. They are simply additional elements in the attribute path array,
-  #     and need not be strings or symbols. Permitting a string or symbol argument automatically permits both.
-  #
-  #     When checking if paths with tainted strings/elements are permitted, only exact matches are allowed
-  class Permissions
-
-    def prefix_path
-      @prefix_path || []
-    end
-
-    # Initialize, optionally with link to permitted paths, and the prefix to that (with copy on write semantics)
-    def initialize(permissions = nil, prefix_path = [])
-      unless permissions.nil?
-        @permitted_paths = permissions.permitted_paths
-        @prefix_path = permissions.prefix_path + canonicalize(prefix_path) # copy on write
-      end
-    end
-
-    # Checks whether everything is permitted. Considers :*, which permits all methods
-    # but not association methods to be complete.
-    # @return [Boolean]
-    def complete?
-      permitted? prefix_path + [:*]
-    end
-
-    # Permits wildcard method, but not association methods.
-    # @return self
-    def permit_all!
-      copy_on_write!
-      permitted_paths << [:*]
-      self
-    end
-
-    # Checks if the attribute path is permitted. This is the case if
-    # any array prefix has been permitted.
-    # @param [Object, Array<Object>] prefix_path
-    # @param [Object, Array<Object>] attribute_path
-    # @return [Boolean]
-    def permitted? attribute_path
-      attribute_path = canonicalize(attribute_path)
-      return true if permitted_paths.include? prefix_path + attribute_path # exact match
-      !path_tainted?(attribute_path) and permitted_by_wildcard?(prefix_path + attribute_path)  # wildcard match only if not tainted
-    end
-
-    # Selects the attribute paths which are permitted.
-    # @param [Array] prefix_path
-    #   namespace in which each of the given attribute paths are in
-    # @param [[Object, Array<Object>]*] *attribute_paths
-    #   each attribute path is a symbol or array of symbols
-    # @return [Array<Object, Array<Object>>] array of attribute paths permitted
-    def select_permitted *attribute_paths
-      attribute_paths.select { |attribute_path| permitted?(attribute_path) }
-    end
-
-    # Rejects the attribute paths which are permitted. Opposite of select_permitted.
-    # Returns the attribute paths which are not permitted.
-    #
-    # @param [Array] prefix_path
-    #   namespace in which each of the given attribute paths are in
-    # @param [[Object, Array<Object>]*] *attribute_paths
-    #   each attribute path is an object(string) or array
-    # @return [Array<Object, Array<Object>>] array of attribute paths remaining
-    def reject_permitted *attribute_paths
-      attribute_paths.reject { |attribute_path| permitted?(attribute_path) }
-    end
-
-    # Permits some attribute paths
-    #
-    # @param [Array] prefix_path
-    #   path to prepend to each attribute path
-    # @param [[Object, Array]*] *attribute_paths
-    def permit *attribute_paths
-      copy_on_write!
-      attribute_paths = attribute_paths.map{|path|canonicalize(path).taint} # exact match
-      reject_permitted(*attribute_paths).each do |attribute_path| # don't permit if already permitted
-        permitted_paths << attribute_path # prefix_path = [] because of copy on write
-      end
-      self
-    end
-
-    protected
-
-    def permitted_paths
-      @permitted_paths ||= Set.new
-    end
-
-    private
-    # Is this still referencing another objects permissions?
-    def reference?
-      !@prefix_path.nil?
-    end
-
-    # Make a copy if this still references something else, since we are planning on writing soon
-    def copy_on_write!
-      if prefix_path == []
-        @permitted_paths = permitted_paths.dup
-      elsif reference?
-        @permitted_paths, old_set = Set.new, permitted_paths
-        old_set.each do |path|
-          @permitted_paths << path[prefix_path.size...path.size] if path[0...prefix_path.size] == prefix_path
-        end
-      end
-      @prefix_path = nil
-    end
-
-    def path_tainted? attribute_path
-      attribute_path.tainted? or attribute_path.any? { |element| element.tainted? }
-    end
-
-    # Caution: Will mutate path
-    def permitted_by_wildcard? path
-      unless path.empty?
-        path[-1] = :*
-        return true if permitted_paths.include? path
-      end
-      until path.empty?
-        path[-1] = :**
-        return true if permitted_paths.include? path
-        path.pop
-      end
-      false
-    end
-
-    # Converts symbols to strings (except for wildcard symbol)
-    def canonicalize array
-      array = Array(array)
-      canonical_array = array.map{|e|e.is_a?(Symbol) ? e.to_s : e}
-      canonical_array[-1] = array.last if [:*, :**].include? array.last
-      canonical_array.taint if array.tainted?
-      canonical_array
-    end
-
-  end
-end

data/spec/strong_presenter/permissible_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-module StrongPresenter
-  describe Permissible do
-    it "selects permitted attributes" do
-      object = Model.new
-      presenter = Presenter.new(object)
-      
-      presenter.permit! :a, :b, :c
-      permitted = presenter.select_permitted :a, :c, :z
-      expect(permitted).to include(:a, :c)
-      expect(permitted).to_not include(:b, :z)
-    end
-
-    it "permits all if permit_all!" do
-      object = Model.new
-      presenter = Presenter.new(object)
-
-      presenter.permit_all!
-      permitted = presenter.select_permitted :a, :b, :c
-      expect(permitted).to include(:a, :b, :c)
-    end
-  end
-end

data/spec/strong_presenter/permissions_spec.rb

@@ -1,202 +0,0 @@
-require 'spec_helper'
-
-module StrongPresenter
-  describe Permissions do
-    describe "#complete?" do
-      it 'is initially incomplete' do
-        expect(Permissions.new.complete?).to be false
-      end
-    end
-
-    describe "#permit_all!" do
-      it 'completes the object' do
-        expect(Permissions.new.permit_all!.complete?).to be true
-      end
-    end
-
-    describe "#permit" do
-      it 'permits an attribute' do
-        expect(Permissions.new.permit(:attr).permitted?(:attr)).to be true
-      end
-
-      it 'permits with arrays of symbols' do
-        expect(Permissions.new.permit([:attr, :array]).permitted?([:attr, :array])).to be true
-      end
-
-      it 'permits multiple at once' do
-        permissions = Permissions.new.permit([:another, :array], [:attr, :array], :attr2, :attr3)
-        expect(permissions.permitted?(:attr2)).to be true
-        expect(permissions.permitted?([:attr, :array])).to be true
-      end
-
-      it 'does not mutate arguments' do
-        attrpaths = [[:attr, :path], :s]
-        Permissions.new.permit(attrpathsarg = attrpaths.dup)
-
-        expect(attrpathsarg).to eq attrpaths
-      end
-
-      it 'permits specific path after wildcard' do
-        permissions = Permissions.new.permit([:prefix, :*])
-        expect(permissions.permitted?([:prefix, "specific".taint])).to be false
-        permissions.permit([:prefix, :specific])
-        expect(permissions.permitted?([:prefix, "specific".taint])).to be true
-      end
-    end
-
-    describe "#permitted?" do
-      context 'with some attributes permitted' do
-        before(:all) do
-          @permissions = Permissions.new.permit([:another, :array], [:attr, :array], :attr2, :attr3, [:a, :wildcard, :*], [:wild, :**])
-        end
-
-        it 'permits single wildcard' do
-          expect(@permissions.permitted?([:a, :wildcard, :irrelevant])).to be true
-        end
-
-        it 'permits full wildcard' do
-          expect(@permissions.permitted?([:wild, :wildcard, :irrelevant])).to be true
-          expect(@permissions.permitted?([:wild, :irrelevant])).to be true
-        end
-
-        it 'does not permit un-prefixed path' do
-          permissions = Permissions.new(@permissions, :attr)
-          expect(permissions.permitted?(:attr2)).to be false
-          expect(permissions.permitted?([:wild, :irrelevant])).to be false
-        end
-
-        it 'permits with prefix' do
-          permissions = Permissions.new(@permissions, :attr)
-          expect(permissions.permitted?(:array)).to be true
-        end
-
-        it 'does not permit other attributes' do
-          expect(@permissions.permitted?([:attr4, :irrelevant])).to be false
-        end
-
-        it 'does not permit shortened paths' do
-          expect(@permissions.permitted?(:attr)).to be false
-        end
-
-        it 'does not mutate arguments' do
-          attrpaths = [[:attr, :path], :s, [:array, :attr2]]
-
-          @permissions.permitted?(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-
-          prefix = [:prefix]
-          @permissions.permitted?(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-        end
-
-        it 'is indifferent to strings' do
-          expect(@permissions.permitted?(["attr","array"])).to be true
-          expect(@permissions.permitted?("a/wildcard/irrelevant".split("/"))).to be true
-        end
-
-        it 'does not permit single wildcard if tainted' do
-          expect(@permissions.permitted?([:a, :wildcard, "irrelevant".taint])).to be false
-        end
-
-        it 'does not permit full wildcard if tainted' do
-          expect(@permissions.permitted?(["wild".taint, :wildcard, :irrelevant])).to be false
-          expect(@permissions.permitted?(["wild", "irrelevant"].taint)).to be false
-          expect(@permissions.permitted?("a/wildcard/irrelevant".taint.split("/"))).to be false
-        end
-      end
-
-      context 'with permit all' do
-        it 'all methods are true' do
-          permissions = Permissions.new.permit_all!
-          expect(permissions.permitted?(:a)).to be true
-          expect(permissions.permitted?(:b)).to be true
-        end
-
-        it 'association methods are false' do
-          permissions = Permissions.new.permit_all!
-          expect(permissions.permitted?([:a,:a])).to be false
-        end
-      end
-    end
-    describe "#select_permitted" do
-      context 'with some attributes permitted' do
-        before(:all) do
-          @permissions = Permissions.new.permit([:another, :array], [:attr, :array, :*], :attr2, :attr3)
-          @permissions.permit([], [:attr, :arrays], :attr2, :attr3)
-        end
-
-        it 'can select something which is permitted' do
-          expect(@permissions.select_permitted(:attr2)).to eq [:attr2]
-          expect(@permissions.select_permitted([:attr, :array, :irrelevant])).to eq [[:attr, :array, :irrelevant]]
-          expect(@permissions.select_permitted([:another, :array])).to eq [[:another, :array]]
-        end
-
-        it 'does not select wildcard path without wildcard' do
-          expect(@permissions.select_permitted([:attr, :array])).to be_empty
-        end
-
-        it 'can select multiple permitted attributes' do
-          attribute_paths = [[:attr2], :attr3, [:another, :array], [:attr, :array, :method]]
-          permitted = @permissions.select_permitted(*attribute_paths)
-          attribute_paths.each do |attribute_path|
-            expect(permitted).to include attribute_path
-          end
-        end
-
-        it 'selects only permitted attributes in the original order' do
-          permitted_paths = [:attr2, :attr3, [:attr, :arrays], [:attr, :array, :meth], [:attr3]]
-          unpermitted_paths = [:attr4, :attr5, [:attrk, :irrelevant], [:attr, :ar], [:attr, :arrays, :more]]
-          attribute_paths = (unpermitted_paths + permitted_paths).shuffle
-          expect(@permissions.select_permitted(*attribute_paths)).to eq((attribute_paths & permitted_paths))
-        end
-
-        it 'does not mutate arguments' do
-          attrpaths = [[:attr, :path], :s, [:array, :attr2]]
-
-          @permissions.select_permitted(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-
-          attrpaths = [[:attr, :array, :meth], :s, [:array, :attr2]]
-          @permissions.select_permitted(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-        end
-      end
-
-      context 'with permit all' do
-        it 'everything is selected' do
-          permissions = Permissions.new.permit_all!
-          attribute_paths = [:attr2, :attr3, :attr2, :attr, :array]
-          permitted = permissions.select_permitted([:prefix, :array], *attribute_paths)
-          expect(permitted).to eq(attribute_paths)
-        end
-      end
-    end
-    describe "#reject_permitted" do
-      context 'with some attributes permitted' do
-        before(:all) do
-          @permissions = Permissions.new.permit([:another, :array], [:attr, :array, :*], :attr2, :attr3)
-          @permissions.permit([], [:attr, :arrays], :attr2, :attr3)
-        end
-
-        it 'selects only unpermitted attributes in the original order' do
-          permitted_paths = [:attr2, :attr3, [:attr, :arrays], [:attr, :array, :meth], [:attr3]]
-          unpermitted_paths = [:attr4, :attr5, [:attrk, :irrelevant], [:attr, :ar], [:attr, :arrays, :more]]
-          attribute_paths = (unpermitted_paths + permitted_paths).shuffle
-          expect(@permissions.reject_permitted(*attribute_paths)).to eq((attribute_paths & unpermitted_paths))
-        end
-
-        it 'does not mutate arguments' do
-          attrpaths = [[:attr, :path], :s, [:array, :attr2]]
-
-          @permissions.reject_permitted(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-
-          attrpaths = [[:attr, :array, :meth], :s, [:array, :attr2]]
-          @permissions.reject_permitted(attrpathsarg = attrpaths.dup)
-          expect(attrpathsarg).to eq attrpaths
-        end
-      end
-    end
-  end
-end
-