strong_presenter 0.0.1 → 0.1.0

data/spec/dummy/test/presenters/minitest/spec_type_test.rb

@@ -0,0 +1,52 @@
+require 'minitest_helper'
+
+def it_is_a_presenter_test
+  it "is a presenter test" do
+    assert_kind_of StrongPresenter::TestCase, self
+  end
+end
+
+def it_is_not_a_presenter_test
+  it "is not a presenter test" do
+    refute_kind_of StrongPresenter::TestCase, self
+  end
+end
+
+ProductPresenter = Class.new(StrongPresenter::Presenter)
+ProductsPresenter = Class.new(StrongPresenter::CollectionPresenter)
+
+describe ProductPresenter do
+  it_is_a_presenter_test
+end
+
+describe ProductsPresenter do
+  it_is_a_presenter_test
+end
+
+describe "ProductPresenter" do
+  it_is_a_presenter_test
+end
+
+describe "AnyPresenter" do
+  it_is_a_presenter_test
+end
+
+describe "Any presenter" do
+  it_is_a_presenter_test
+end
+
+describe "AnyPresenterTest" do
+  it_is_a_presenter_test
+end
+
+describe "Any presenter test" do
+  it_is_a_presenter_test
+end
+
+describe Object do
+  it_is_not_a_presenter_test
+end
+
+describe "Nope" do
+  it_is_not_a_presenter_test
+end

data/spec/dummy/test/presenters/minitest/view_context_test.rb

@@ -0,0 +1,24 @@
+require 'minitest_helper'
+
+def it_does_not_leak_view_context
+  2.times do
+    it "has an independent view context" do
+      refute_equal :leaked, StrongPresenter::ViewContext.current
+      StrongPresenter::ViewContext.current = :leaked
+    end
+  end
+end
+
+describe "A presenter test" do
+  it_does_not_leak_view_context
+end
+
+describe "A controller test" do
+  tests Class.new(ActionController::Base)
+
+  it_does_not_leak_view_context
+end
+
+describe "A mailer test" do
+  it_does_not_leak_view_context
+end

data/spec/dummy/test/presenters/test_unit/devise_test.rb

@@ -0,0 +1,64 @@
+require 'test_helper'
+
+if defined?(Devise)
+  class DeviseTest < StrongPresenter::TestCase
+    def test_sign_in_a_real_user
+      user = User.new
+      sign_in user
+
+      assert_same user, helper.current_user
+    end
+
+    def test_sign_in_a_mock_user
+      user = Object.new
+      sign_in :user, user
+
+      assert_same user, helper.current_user
+    end
+
+    def test_sign_in_a_real_admin
+      admin = Admin.new
+      sign_in admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    def test_sign_in_a_mock_admin
+      admin = Object.new
+      sign_in :admin, admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    def test_sign_out_a_real_user
+      user = User.new
+      sign_in user
+      sign_out user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_sign_out_a_mock_user
+      user = Object.new
+      sign_in :user, user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_sign_out_without_a_user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_backwards_compatibility
+      user = Object.new
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      assert_same user, helper.current_user
+    end
+  end
+end

data/spec/dummy/test/presenters/test_unit/helpers_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+
+class HelpersTest < StrongPresenter::TestCase
+  def test_access_helpers_through_helper
+    assert_equal "<p>Help!</p>", helper.content_tag(:p, "Help!")
+  end
+
+  def test_access_helpers_through_helpers
+    assert_equal "<p>Help!</p>", helpers.content_tag(:p, "Help!")
+  end
+
+  def test_access_helpers_through_h
+    assert_equal "<p>Help!</p>", h.content_tag(:p, "Help!")
+  end
+
+  def test_same_helper_object_as_presenters
+    presenter = StrongPresenter::Presenter.new(Object.new)
+
+    assert_same presenter.helpers, helpers
+  end
+end

data/spec/dummy/test/presenters/test_unit/view_context_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+def it_does_not_leak_view_context
+  2.times do |n|
+    define_method("test_has_independent_view_context_#{n}") do
+      #refute_equal :leaked, StrongPresenter::ViewContext.current
+      #StrongPresenter::ViewContext.current = :leaked
+    end
+  end
+end
+
+class PresenterTest < StrongPresenter::TestCase
+  #it_does_not_leak_view_context
+end
+
+class ControllerTest < ActionController::TestCase
+  tests Class.new(ActionController::Base)
+
+  #it_does_not_leak_view_context
+end
+
+class MailerTest < ActionMailer::TestCase
+  #it_does_not_leak_view_context
+end

data/spec/dummy/test/test_helper.rb

@@ -0,0 +1,13 @@
+begin
+  require 'simplecov'
+  SimpleCov.start do
+    root '../../'
+    command_name 'spec:integration:test:test'
+    add_filter 'spec'
+  end
+rescue LoadError
+end
+
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../../config/environment', __FILE__)
+require 'rails/test_help'

data/spec/generators/presenters/presenter_generator_spec.rb

@@ -0,0 +1,131 @@
+require 'spec_helper'
+require 'rails'
+require 'ammeter/init'
+require 'generators/rails/presenter_generator'
+
+describe Rails::Generators::PresenterGenerator do
+  destination File.expand_path("../tmp", __FILE__)
+
+  before { prepare_destination }
+  after(:all) { FileUtils.rm_rf destination_root }
+
+  describe "the generated presenter" do
+    subject { file("app/presenters/your_model_presenter.rb") }
+
+    describe "naming" do
+      before { run_generator %w(YourModel) }
+
+      it { should contain "class YourModelPresenter" }
+    end
+
+    describe "namespacing" do
+      subject { file("app/presenters/namespace/your_model_presenter.rb") }
+      before { run_generator %w(Namespace::YourModel) }
+
+      it { should contain "class Namespace::YourModelPresenter" }
+    end
+
+    describe "inheritance" do
+      context "by default" do
+        before { run_generator %w(YourModel) }
+
+        it { should contain "class YourModelPresenter < StrongPresenter::Presenter" }
+      end
+
+      context "with the --parent option" do
+        before { run_generator %w(YourModel --parent=FooPresenter) }
+
+        it { should contain "class YourModelPresenter < FooPresenter" }
+      end
+
+      context "with an ApplicationPresenter" do
+        before do
+          Object.any_instance.stub(:require).with("application_presenter").and_return do
+            stub_const "ApplicationPresenter", Class.new
+          end
+        end
+
+        before { run_generator %w(YourModel) }
+
+        it { should contain "class YourModelPresenter < ApplicationPresenter" }
+      end
+    end
+  end
+
+  context "with -t=rspec" do
+    describe "the generated spec" do
+      subject { file("spec/presenters/your_model_presenter_spec.rb") }
+
+      describe "naming" do
+        before { run_generator %w(YourModel -t=rspec) }
+
+        it { should contain "describe YourModelPresenter" }
+      end
+
+      describe "namespacing" do
+        subject { file("spec/presenters/namespace/your_model_presenter_spec.rb") }
+        before { run_generator %w(Namespace::YourModel -t=rspec) }
+
+        it { should contain "describe Namespace::YourModelPresenter" }
+      end
+    end
+  end
+
+  context "with -t=test_unit" do
+    describe "the generated test" do
+      subject { file("test/presenters/your_model_presenter_test.rb") }
+
+      describe "naming" do
+        before { run_generator %w(YourModel -t=test_unit) }
+
+        it { should contain "class YourModelPresenterTest < StrongPresenter::TestCase" }
+      end
+
+      describe "namespacing" do
+        subject { file("test/presenters/namespace/your_model_presenter_test.rb") }
+        before { run_generator %w(Namespace::YourModel -t=test_unit) }
+
+        it { should contain "class Namespace::YourModelPresenterTest < StrongPresenter::TestCase" }
+      end
+    end
+  end
+
+  context "with -t=mini_test" do
+    describe "the generated test" do
+      subject { file("test/presenters/your_model_presenter_test.rb") }
+
+      describe "naming" do
+        before { run_generator %w(YourModel -t=mini_test) }
+
+        it { should contain "class YourModelPresenterTest < StrongPresenter::TestCase" }
+      end
+
+      describe "namespacing" do
+        subject { file("test/presenters/namespace/your_model_presenter_test.rb") }
+        before { run_generator %w(Namespace::YourModel -t=mini_test) }
+
+        it { should contain "class Namespace::YourModelPresenterTest < StrongPresenter::TestCase" }
+      end
+    end
+  end
+
+  context "with -t=mini_test --spec" do
+    describe "the generated test" do
+      subject { file("test/presenters/your_model_presenter_test.rb") }
+
+      describe "naming" do
+        before { run_generator %w(YourModel -t=mini_test --spec) }
+
+        it { should contain "describe YourModelPresenter" }
+      end
+
+      describe "namespacing" do
+        subject { file("test/presenters/namespace/your_model_presenter_test.rb") }
+        before { run_generator %w(Namespace::YourModel -t=mini_test --spec) }
+
+        it { should contain "describe Namespace::YourModelPresenter" }
+      end
+    end
+  end
+
+end

data/spec/generators/simplecov_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+SimpleCov.command_name 'spec:generators' if defined? SimpleCov
+
+

data/spec/integration/integration_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+require 'support/dummy_app'
+require 'support/matchers/have_text'
+
+app = DummyApp.new(ENV["RAILS_ENV"])
+spec_types = {
+  view: ["/posts/1", "PostsController"],
+  mailer: ["/posts/1/mail", "PostMailer"]
+}
+
+app.start_server do
+  spec_types.each do |type, (path, controller)|
+    page = app.get(path)
+
+    describe "in a #{type}" do
+      it "runs in the correct environment" do
+        expect(page).to have_text(app.environment).in("#environment")
+      end
+
+      it "uses the correct view context controller" do
+        expect(page).to have_text(controller).in("#controller")
+      end
+
+      it "can use built-in helpers" do
+        expect(page).to have_text("Once upon a...").in("#truncated")
+      end
+
+      it "can use built-in private helpers" do
+        # Nokogiri unescapes text!
+        expect(page).to have_text("<script>danger</script>").in("#html_escaped")
+      end
+
+      it "can use user-defined helpers from app/helpers" do
+        expect(page).to have_text("Hello, world!").in("#hello_world")
+      end
+
+      it "can use user-defined helpers from the controller" do
+        expect(page).to have_text("Goodnight, moon!").in("#goodnight_moon")
+      end
+
+      it "can be passed to path helpers" do
+        expect(page).to have_text("/en/posts/1").in("#path_with_presenter")
+      end
+
+      it "can use path helpers with a model" do
+        expect(page).to have_text("/en/posts/1").in("#path_with_model")
+      end
+
+      it "can use path helpers with an id" do
+        expect(page).to have_text("/en/posts/1").in("#path_with_id")
+      end
+
+      it "can be passed to url helpers" do
+        expect(page).to have_text("http://www.example.com:12345/en/posts/1").in("#url_with_presenter")
+      end
+
+      it "can use url helpers with a model" do
+        expect(page).to have_text("http://www.example.com:12345/en/posts/1").in("#url_with_model")
+      end
+
+      it "can use url helpers with an id" do
+        expect(page).to have_text("http://www.example.com:12345/en/posts/1").in("#url_with_id")
+      end
+
+      it "can use presents method" do
+        expect(page).to have_text("I am permitted").in("#permit_to_present")
+      end
+
+      it "can use present method" do
+        expect(page).to have_text("BOO!").in("#peekaboo")
+      end
+
+      if type != :mailer
+        it "does not show unpermitted attributes through presents" do
+          expect(page).to_not have_text("Top Secret").in("#unpermitted")
+        end
+      end
+
+    end
+  end
+end

data/spec/integration/simplecov_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+SimpleCov.command_name "spec:integration:#{ENV['RAILS_ENV']}" if defined? SimpleCov
+

data/spec/spec_helper.rb

@@ -0,0 +1,47 @@
+begin
+  require 'simplecov'
+  SimpleCov.start do
+    add_filter 'spec'
+  end
+rescue LoadError
+end
+
+require 'bundler/setup'
+require 'strong_presenter'
+require 'rails/version'
+require 'action_controller'
+require 'action_controller/test_case'
+require 'support/models'
+
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) {|c| c.syntax = :expect}
+  config.order = :random
+end
+
+class Model; end
+
+class Product < Model; end
+class ProductPresenter < StrongPresenter::Presenter; end
+class ProductsPresenter < StrongPresenter::CollectionPresenter; end
+
+class OtherPresenter < StrongPresenter::Presenter; end
+
+module Namespaced
+  class Product < Model; end
+  class ProductPresenter < StrongPresenter::Presenter; end
+
+  class OtherPresenter < StrongPresenter::Presenter; end
+end
+
+class WheelPresenter < StrongPresenter::Presenter; end
+class CarPresenter < StrongPresenter::Presenter; end
+
+# After each example, revert changes made to the class
+def protect_class(klass)
+  before { stub_const klass.name, Class.new(klass) }
+end
+
+def protect_module(mod)
+  before { stub_const mod.name, mod.dup }
+end

data/spec/strong_presenter/associable_spec.rb

@@ -0,0 +1,122 @@
+require 'spec_helper'
+
+module StrongPresenter
+  describe Associable do
+    context 'with Presenter' do
+      protect_class Product
+      protect_class ProductPresenter
+
+      before(:each) do
+        class Manufacturer < Model
+          def name; "Factory"; end
+        end
+        class ManufacturerPresenter < StrongPresenter::Presenter
+          def name(*args); "Presented #{object.name}#{(args+[""])[0]}"; end
+        end
+        Product.send(:define_method, :manufacturer) { @manufacturer ||= Manufacturer.new }
+        Product.send(:define_method, :name) { "Product" }
+        ProductPresenter.presents_association :manufacturer
+
+        @product_presenter = ProductPresenter.new(Product.new)
+      end
+
+      it 'presents association' do
+        expect(@product_presenter.manufacturer.class).to be ManufacturerPresenter
+        expect(@product_presenter.manufacturer.name).to eq "Presented Factory"
+      end
+
+      it 'does not allow presenting without permit' do
+        expect(@product_presenter.presents :manufacturer).to be_empty
+        expect(@product_presenter.presents [:manufacturer, :name]).to be_empty
+        @product_presenter.permit :name
+        expect(@product_presenter.presents [:manufacturer, :name]).to be_empty
+      end
+
+      it 'does not allow presenting from association' do
+        expect(@product_presenter.manufacturer.presents :name).to be_empty
+      end
+
+      context 'with association permitted' do
+        before(:each) do
+          @product_presenter.permit :manufacturer
+        end
+
+        it 'allows presenting association' do
+          expect(@product_presenter.present(:manufacturer).class).to be ManufacturerPresenter
+        end
+
+        it 'allows presenting association attributes' do
+          expect(@product_presenter.present [:manufacturer, :name]).to eq "Presented Factory"
+        end
+
+        it 'allows presenting association attributes with arguments' do
+          expect(@product_presenter.present [:manufacturer, :name, " arg"]).to eq "Presented Factory arg"
+        end
+
+        it 'allows presenting from association' do
+          expect(@product_presenter.manufacturer.present :name).to eq "Presented Factory"
+        end
+      end
+
+      it 'rejects full path from association' do
+        @product_presenter.permit [:manufacturer, :name]
+        expect(@product_presenter.manufacturer.presents [:manufacturer, :name]).to be_empty
+      end
+    end
+
+    context 'with CollectionPresenter' do
+      protect_class Product
+      protect_class ProductPresenter
+      before(:each) do
+        Product.send(:define_method, :initialize) { |name| @name = name }
+        Product.send(:attr_reader, :name)
+        ProductPresenter.send(:define_method, :name) { object.name }
+        class ProductList < Model
+          attr_accessor :products
+          def initialize; @products = [Product.new("X"), Product.new("Y"), Product.new("Z")]; end
+        end
+        class ProductListPresenter < StrongPresenter::Presenter
+          presents_associations :products
+        end
+
+        @presenter = ProductListPresenter.new(ProductList.new)
+      end
+
+      it 'presents collection' do
+        expect(@presenter.products).to be_a StrongPresenter::CollectionPresenter
+      end
+
+      it 'allows accessing collection elements' do
+        expect(@presenter.products[2].class).to be ProductPresenter
+        expect(@presenter.products[2].name).to eq "Z"
+      end
+    end
+
+    describe "with ActiveRecord::Base objects" do
+      protect_class WheelPresenter
+      protect_class CarPresenter
+      it 'infers collection presenter from association class' do
+        CarPresenter.presents_association :wheels
+
+        car = Car.new
+        car.wheels << Wheel.new
+        presenter = CarPresenter.new(car)
+        expect(presenter.wheels.class).to be WheelPresenter::Collection
+      end
+
+      it 'infers presenter of polymorphic association repeatedly' do
+        WheelPresenter.presents_association :vehicle
+
+        wheel = Wheel.new
+        wheel.vehicle = Car.new
+        presenter = WheelPresenter.new(wheel)
+        expect(presenter.vehicle.class).to be CarPresenter
+
+        # if presenter.vehicle is cached, the next example will be incorrect
+        wheel.vehicle = Wheel.new
+        expect(presenter.vehicle.class).to be WheelPresenter
+      end
+    end
+  end
+end
+

data/spec/strong_presenter/collection_presenter_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+module StrongPresenter
+  describe CollectionPresenter do
+    describe "#initialize" do
+      it "sets the collection" do
+        collection = [Model.new, Model.new]
+        collection_presenter = CollectionPresenter.new(collection, :with => Presenter)
+
+        expect(collection_presenter.send :object).to be collection
+        expect(collection_presenter[0].send :object).to be collection[0]
+      end
+      it "wraps with given presenter" do
+        collection = [Product.new, Product.new]
+        products_presenter = CollectionPresenter.new(collection, :with => ProductPresenter)
+
+        expect(products_presenter[0].class).to be ProductPresenter
+      end
+    end
+    describe "Permissible" do
+      it "permits on items" do
+        collection = [Model.new, Model.new]
+        collection_presenter = CollectionPresenter.new(collection, :with => Presenter)
+
+        expect(collection_presenter[0].filter :z).to be_empty
+
+        collection_presenter.permit :a, :b, :c
+        permitted = collection_presenter[0].filter :a, :c, :z
+        expect(permitted).to include(:a, :c)
+        expect(permitted).to_not include(:b, :z)
+      end
+    end
+  end
+end

data/spec/strong_presenter/delegation_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module StrongPresenter
+  describe Delegation do
+    protect_class(Product)
+    protect_class(ProductPresenter)
+
+    it '#delegate to object by default' do
+      ProductPresenter.delegate :stuff
+      Product.send(:define_method, :stuff) {"stuffed"}
+      expect(ProductPresenter.new(Product.new).stuff).to eq "stuffed"
+    end
+
+    it 'can #delegate elsewhere' do
+      ProductPresenter.send(:define_method, :elsewhere) {[3,4,5]}
+      ProductPresenter.delegate :array, :to => :elsewhere
+      expect(ProductPresenter.new(Product.new).elsewhere.size).to eq 3
+    end
+  end
+end

data/spec/strong_presenter/permissible_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module StrongPresenter
+  describe Permissible do
+    it "filters permitted attributes" do
+      object = Model.new
+      presenter = Presenter.new(object)
+      
+      presenter.permit :a, :b, :c
+      permitted = presenter.filter :a, :c, :z
+      expect(permitted).to include(:a, :c)
+      expect(permitted).to_not include(:b, :z)
+    end
+
+    it "permits all if permit!" do
+      object = Model.new
+      presenter = Presenter.new(object)
+
+      presenter.permit!
+      permitted = presenter.filter :a, :b, :c
+      expect(permitted).to include(:a, :b, :c)
+    end
+  end
+end