strong_migrations 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d290d3cb9db86b312fcdeb417aa4b24838f9135df9526dff1e525e12484ae160
-  data.tar.gz: e169be188a233de23f961b4aefe3997e71666a37fcc581d3cc95973b20b1642e
+  metadata.gz: 971d5d1eabb91dc04c72cc99a24f8b92f1b0d31d8d28369577f48c283b8d8624
+  data.tar.gz: '08a413578f564ada7f9768aeaf469719ca051e4c37057be6324e593c73fb3144'
 SHA512:
-  metadata.gz: 61adf361956734e8944d8dea110ee77b22db8e24cde13085a5b90f35b09f684632b33ab040632f4dc0656853f12d1255204e6736881656a50a462e041f1e56f1
-  data.tar.gz: 7f0d1650bbb8e16e062c24defe37fec194d0f98ccd458d21db39d7664ffa51c8340a017d6ce8c1ace8018ba86da7795df881dfb19d31d578a41870ad82d55a52
+  metadata.gz: b8ca27268e166609ec8253ce686c6fe9cbe6d7c4b298f8c80ce7f1690e76a2c997fad2806cce52c9765f6ee92e7e389fdf6c830d3ca8ebb0241574adc02c4b57
+  data.tar.gz: 18731d2b1bdd12698d6b860a470249a24ea12aaa0b5b74b6510d41527ef2126c46b27ef4aa7c7adb1437bd7a006d0bb7c46490d24ec15720009723e5b0d8eca4

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.5.0 (2025-07-27)
+
+- Added check for `rename_schema`
+- Made `auto_analyze` apply to `add_reference`
+
 ## 2.4.0 (2025-06-23)
 
 - Added `remove_invalid_indexes` option to install generator

data/README.md

@@ -80,6 +80,7 @@ Postgres-specific checks:
 - [adding a json column](#adding-a-json-column)
 - [setting NOT NULL on an existing column](#setting-not-null-on-an-existing-column)
 - [adding a column with a volatile default value](#adding-a-column-with-a-volatile-default-value)
+- [renaming a schema](#renaming-a-schema)
 
 Config-specific checks:
 
@@ -658,6 +659,31 @@ end
 
 Then [backfill the data](#backfilling-data).
 
+### Renaming a schema
+
+#### Bad
+
+Renaming a schema that’s in use will cause errors in your application.
+
+```ruby
+class RenameUsersToCustomers < ActiveRecord::Migration[8.1]
+  def change
+    rename_schema :users, :customers
+  end
+end
+```
+
+#### Good
+
+A safer approach is to:
+
+1. Create a new schema
+2. Write to both schemas
+3. Backfill data from the old schema to the new schema
+4. Move reads from the old schema to the new schema
+5. Stop writing to the old schema
+6. Drop the old schema
+
 ### Changing the default value of a column
 
 #### Bad

data/lib/strong_migrations/checker.rb

@@ -79,6 +79,8 @@ module StrongMigrations
           check_remove_index(*args)
         when :rename_column
           check_rename_column
+        when :rename_schema
+          check_rename_schema
         when :rename_table
           check_rename_table
         when :validate_check_constraint
@@ -111,7 +113,7 @@ module StrongMigrations
         end
 
       # outdated statistics + a new index can hurt performance of existing queries
-      if StrongMigrations.auto_analyze && direction == :up && method == :add_index
+      if StrongMigrations.auto_analyze && direction == :up && adds_index?(method, *args)
         adapter.analyze_table(args[0])
       end
 
@@ -256,6 +258,18 @@ module StrongMigrations
       end
     end
 
+    def adds_index?(method, *args)
+      case method
+      when :add_index
+        true
+      when :add_reference, :add_belongs_to
+        options = args.extract_options!
+        !!options.fetch(:index, true)
+      else
+        false
+      end
+    end
+
     # REINDEX INDEX CONCURRENTLY leaves a new invalid index if it fails, so use remove_index instead
     def remove_invalid_index_if_needed(*args)
       options = args.extract_options!

data/lib/strong_migrations/checks.rb

@@ -384,6 +384,10 @@ module StrongMigrations
       raise_error :rename_column
     end
 
+    def check_rename_schema
+      raise_error :rename_schema
+    end
+
     def check_rename_table
       raise_error :rename_table
     end

data/lib/strong_migrations/error_messages.rb

@@ -102,6 +102,17 @@ in your application. A safer approach is to:
 5. Stop writing to the old column
 6. Drop the old column",
 
+    rename_schema:
+"Renaming a schema that's in use will cause errors
+in your application. A safer approach is to:
+
+1. Create a new schema
+2. Write to both schemas
+3. Backfill data from the old schema to the new schema
+4. Move reads from the old schema to the new schema
+5. Stop writing to the old schema
+6. Drop the old schema",
+
     rename_table:
 "Renaming a table that's in use will cause errors
 in your application. A safer approach is to:

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "2.4.0"
+  VERSION = "2.5.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Andrew Kane
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Catch unsafe migrations in development
 test_files: []