strong_migrations 2.2.1 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a78b56711a718210a3d14c82a4c30734c0b653827c1a2bdcc7617c27a7eed0e5
-  data.tar.gz: 9ef73e9cd8783a34d330c3517d98df50266427bd10bd92656cc528753aceb045
+  metadata.gz: d290d3cb9db86b312fcdeb417aa4b24838f9135df9526dff1e525e12484ae160
+  data.tar.gz: e169be188a233de23f961b4aefe3997e71666a37fcc581d3cc95973b20b1642e
 SHA512:
-  metadata.gz: 0ece935c993dad2d316d183be938db27a9595cac2d0880f5fcd3f516965440bda73da9e8ad5239269451b991b04a897de03b8f0ed11b30400074daf30fa353b7
-  data.tar.gz: c8a18a098a6356daae4bf6bb827fa7f11c0a37e8b88712083af88f4eeb0f8dcda7f893491f1a044cc2399afc8147c31c3b07bf46a2155b972c78bb2aebbd479e
+  metadata.gz: 61adf361956734e8944d8dea110ee77b22db8e24cde13085a5b90f35b09f684632b33ab040632f4dc0656853f12d1255204e6736881656a50a462e041f1e56f1
+  data.tar.gz: 7f0d1650bbb8e16e062c24defe37fec194d0f98ccd458d21db39d7664ffa51c8340a017d6ce8c1ace8018ba86da7795df881dfb19d31d578a41870ad82d55a52

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 2.4.0 (2025-06-23)
+
+- Added `remove_invalid_indexes` option to install generator
+- Added experimental `transaction_timeout` option
+- Dropped support for Ruby < 3.2 and Active Record < 7.1
+
+## 2.3.0 (2025-04-03)
+
+- Added check for `change_column` for columns with check constraints with Postgres
+
 ## 2.2.1 (2025-03-21)
 
 - Added support for `change_column_null` with default value with `safe_by_default` option

data/README.md

@@ -882,8 +882,6 @@ To automatically remove the invalid index when the migration runs again, use:
 StrongMigrations.remove_invalid_indexes = true
 ```
 
-Note: This feature is experimental.
-
 ## Lock Timeout Retries
 
 Note: This feature is experimental.

data/lib/generators/strong_migrations/templates/initializer.rb.tt

@@ -20,6 +20,9 @@ StrongMigrations.auto_analyze = true
 #   end
 # end<% if postgresql? %>
 
+# Remove invalid indexes when rerunning migrations
+# StrongMigrations.remove_invalid_indexes = true
+
 # Make some operations safe by default
 # See https://github.com/ankane/strong_migrations#safe-by-default
 # StrongMigrations.safe_by_default = true<% end %>

data/lib/strong_migrations/adapters/abstract_adapter.rb

@@ -16,6 +16,10 @@ module StrongMigrations
         # do nothing
       end
 
+      def set_transaction_timeout(timeout)
+        # do nothing
+      end
+
       def set_lock_timeout(timeout)
         # do nothing
       end

data/lib/strong_migrations/adapters/postgresql_adapter.rb

@@ -23,6 +23,11 @@ module StrongMigrations
         set_timeout("statement_timeout", timeout)
       end
 
+      def set_transaction_timeout(timeout)
+        # TODO make sure true version supports it as well?
+        set_timeout("transaction_timeout", timeout) if server_version >= Gem::Version.new("17")
+      end
+
       def set_lock_timeout(timeout)
         set_timeout("lock_timeout", timeout)
       end
@@ -127,21 +132,6 @@ module StrongMigrations
         safe
       end
 
-      # TODO remove when Active Record < 7.1 is no longer supported
-      def index_invalid?(table_name, index_name)
-        query = <<~SQL
-          SELECT
-            indisvalid
-          FROM
-            pg_index
-          WHERE
-            indrelid = to_regclass(#{connection.quote(connection.quote_table_name(table_name))}) AND
-            indexrelid = to_regclass(#{connection.quote(connection.quote_table_name(index_name))}) AND
-            indisvalid = false
-        SQL
-        select_all(query.squish).any?
-      end
-
       def writes_blocked?
         query = <<~SQL
           SELECT
@@ -177,6 +167,11 @@ module StrongMigrations
         63
       end
 
+      def constraints(table, column)
+        # TODO improve column check
+        connection.check_constraints(table).select { |c| /\b#{Regexp.escape(column.to_s)}\b/.match?(c.expression) }
+      end
+
       private
 
       def set_timeout(setting, timeout)

data/lib/strong_migrations/checker.rb

@@ -181,6 +181,9 @@ module StrongMigrations
       if StrongMigrations.statement_timeout
         adapter.set_statement_timeout(StrongMigrations.statement_timeout)
       end
+      if StrongMigrations.transaction_timeout
+        adapter.set_transaction_timeout(StrongMigrations.transaction_timeout)
+      end
       if StrongMigrations.lock_timeout
         adapter.set_lock_timeout(StrongMigrations.lock_timeout)
       end
@@ -264,9 +267,6 @@ module StrongMigrations
       table, columns = args
       index_name = options.fetch(:name, connection.index_name(table, columns))
 
-      # valid option is ignored for Active Record < 7.1, so check name as well
-      return if ar_version < 7.1 && !adapter.index_invalid?(table, index_name)
-
       @migration.say("Attempting to remove invalid index")
       without_retries do
         # TODO pass index schema for extra safety?

data/lib/strong_migrations/checks.rb

@@ -210,6 +210,32 @@ module StrongMigrations
       end
 
       raise_error :change_column, rewrite_blocks: adapter.rewrite_blocks unless safe
+
+      # constraints must be rechecked
+      # Postgres recommends dropping constraints before and adding them back
+      # https://www.postgresql.org/docs/current/ddl-alter.html#DDL-ALTER-COLUMN-TYPE
+      if postgresql?
+        constraints = adapter.constraints(table, column)
+        if constraints.any?
+          change_commands = []
+          constraints.each do |c|
+            change_commands << command_str(:remove_check_constraint, [table, c.expression, {name: c.name}])
+          end
+          change_commands << command_str(:change_column, args + [options])
+          constraints.each do |c|
+            change_commands << command_str(:add_check_constraint, [table, c.expression, {name: c.name, validate: false}])
+          end
+
+          validate_commands = []
+          constraints.each do |c|
+            validate_commands << command_str(:validate_check_constraint, [table, {name: c.name}])
+          end
+
+          raise_error :change_column_constraint,
+            change_column_code: change_commands.join("\n    "),
+            validate_constraint_code: validate_commands.join("\n    ")
+        end
+      end
     end
 
     def check_change_column_default(*args)

data/lib/strong_migrations/error_messages.rb

@@ -60,6 +60,22 @@ while the entire table is rewritten. A safer approach is to:
     change_column_with_not_null:
 "Changing the type is safe, but setting NOT NULL is not.",
 
+    change_column_constraint: "Changing the type of a column that has check constraints blocks reads and writes
+while every row is checked. Drop the check constraints on the column before
+changing the type and add them back afterwards.
+
+class %{migration_name} < ActiveRecord::Migration%{migration_suffix}
+  def change
+    %{change_column_code}
+  end
+end
+
+class Validate%{migration_name} < ActiveRecord::Migration%{migration_suffix}
+  def change
+    %{validate_constraint_code}
+  end
+end",
+
     remove_column: "Active Record caches attributes, which causes problems
 when removing columns. Be sure to ignore the column%{column_suffix}:
 

data/lib/strong_migrations/migration.rb

@@ -7,10 +7,7 @@ module StrongMigrations
     end
 
     def method_missing(method, *args)
-      return super if is_a?(ActiveRecord::Schema)
-
-      # Active Record 7.0.2+ versioned schema
-      return super if defined?(ActiveRecord::Schema::Definition) && is_a?(ActiveRecord::Schema::Definition)
+      return super if is_a?(ActiveRecord::Schema) || is_a?(ActiveRecord::Schema::Definition)
 
       catch(:safe) do
         strong_migrations_checker.perform(method, *args) do

data/lib/strong_migrations/migrator.rb

@@ -4,7 +4,7 @@ module StrongMigrations
       return super unless StrongMigrations.lock_timeout_retries > 0 && use_transaction?(migration)
 
       # handle MigrationProxy class
-      migration = migration.send(:migration) if migration.respond_to?(:migration, true)
+      migration = migration.send(:migration) if !migration.is_a?(ActiveRecord::Migration) && migration.respond_to?(:migration, true)
 
       checker = migration.send(:strong_migrations_checker)
       return super if checker.skip?

data/lib/strong_migrations/safe_methods.rb

@@ -46,8 +46,6 @@ module StrongMigrations
     def safe_add_foreign_key(from_table, to_table, *args, **options)
       @migration.reversible do |dir|
         dir.up do
-          # validate option is unintentionally ignored for Active Record < 7.1
-          # https://github.com/rails/rails/pull/45896
           if !connection.foreign_key_exists?(from_table, to_table, **options.merge(validate: false))
             @migration.add_foreign_key(from_table, to_table, *args, **options.merge(validate: false))
           end

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "2.2.1"
+  VERSION = "2.4.0"
 end

data/lib/strong_migrations.rb

@@ -29,7 +29,7 @@ module StrongMigrations
       :target_postgresql_version, :target_mysql_version, :target_mariadb_version,
       :enabled_checks, :lock_timeout, :statement_timeout, :check_down, :target_version,
       :safe_by_default, :target_sql_mode, :lock_timeout_retries, :lock_timeout_retry_delay,
-      :alphabetize_schema, :skipped_databases, :remove_invalid_indexes
+      :alphabetize_schema, :skipped_databases, :remove_invalid_indexes, :transaction_timeout
     attr_writer :lock_timeout_limit
   end
   self.auto_analyze = false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.4.0
 platform: ruby
 authors:
 - Andrew Kane
@@ -9,7 +9,7 @@ authors:
 - David Waller
 bindir: bin
 cert_chain: []
-date: 2025-03-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.1'
 email:
 - andrew@ankane.org
 - bob.remeika@gmail.com
@@ -65,14 +65,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Catch unsafe migrations in development
 test_files: []