strong_migrations 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c90bd33b534a7c37e59499e81b9c61e7d67a45bc849fd9dfe4d58285631438bf
-  data.tar.gz: 3771261014091caf3c28369db3ae4f97a1434d92b3207b351bf92c839caaec70
+  metadata.gz: e155e036c26788c7c9fa7f513131422b784b895fe1cbfdfc8052ad1f5233cd6c
+  data.tar.gz: 5fe21cada2e29c433313c686332d96c67e2c55d057fd6c68839fe1993307c0f8
 SHA512:
-  metadata.gz: aaa494cbbf0545df8795a5243d80f150e3be939507ab9379c20eb8b7cd68d5fde29c86cce63fffb005e3cd6ff5c858d084eb335bc7c911cccb4da751cfbbac32
-  data.tar.gz: b4833b425a23328795f14a6bcd94a4d06e11da5272976dfbeaaebcc469454b685058bc65c109561c513bc2434acf9119ecbae8b135b3c6d020d5ada607e86a38
+  metadata.gz: 7f40abaf84f10ce6ce7255d083b3ec0940c2f7380705857767b0cde56b23802dcf844c27251c634006559dfb4489b799ab3758bf9928b6cb57b6bceb1bf051ec
+  data.tar.gz: c283b8b93715a4aabd2c0e8dc15b022e45ebfbe3bb52fccc037b9c95d3b2279d6002b78354cab8600cf2972f96a6966af0fd80aa9b58cde53343b5035d8bc59c

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.2.0 (2025-02-01)
+
+- Fixed constraint name for long table and column names with `change_column_null`
+- Dropped support for Active Record < 7
+
 ## 2.1.0 (2024-11-08)
 
 - Added `skip_database` method

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013 Bob Remeika and David Waller, 2015-2024 Andrew Kane
+Copyright (c) 2013 Bob Remeika and David Waller, 2015-2025 Andrew Kane
 
 MIT License
 

data/README.md

@@ -43,7 +43,7 @@ end
 
 Deploy the code, then wrap this step in a safety_assured { ... } block.
 
-class RemoveColumn < ActiveRecord::Migration[7.2]
+class RemoveColumn < ActiveRecord::Migration[8.0]
   def change
     safety_assured { remove_column :users, :name }
   end
@@ -98,7 +98,7 @@ You can also add [custom checks](#custom-checks) or [disable specific checks](#d
 Active Record caches database columns at runtime, so if you drop a column, it can cause exceptions until your app reboots.
 
 ```ruby
-class RemoveSomeColumnFromUsers < ActiveRecord::Migration[7.2]
+class RemoveSomeColumnFromUsers < ActiveRecord::Migration[8.0]
   def change
     remove_column :users, :some_column
   end
@@ -119,7 +119,7 @@ end
 3. Write a migration to remove the column (wrap in `safety_assured` block)
 
   ```ruby
-  class RemoveSomeColumnFromUsers < ActiveRecord::Migration[7.2]
+  class RemoveSomeColumnFromUsers < ActiveRecord::Migration[8.0]
     def change
       safety_assured { remove_column :users, :some_column }
     end
@@ -136,7 +136,7 @@ end
 Changing the type of a column causes the entire table to be rewritten. During this time, reads and writes are blocked in Postgres, and writes are blocked in MySQL and MariaDB.
 
 ```ruby
-class ChangeSomeColumnType < ActiveRecord::Migration[7.2]
+class ChangeSomeColumnType < ActiveRecord::Migration[8.0]
   def change
     change_column :users, :some_column, :new_type
   end
@@ -182,7 +182,7 @@ A safer approach is to:
 Renaming a column that’s in use will cause errors in your application.
 
 ```ruby
-class RenameSomeColumn < ActiveRecord::Migration[7.2]
+class RenameSomeColumn < ActiveRecord::Migration[8.0]
   def change
     rename_column :users, :some_column, :new_name
   end
@@ -207,7 +207,7 @@ A safer approach is to:
 Renaming a table that’s in use will cause errors in your application.
 
 ```ruby
-class RenameUsersToCustomers < ActiveRecord::Migration[7.2]
+class RenameUsersToCustomers < ActiveRecord::Migration[8.0]
   def change
     rename_table :users, :customers
   end
@@ -232,7 +232,7 @@ A safer approach is to:
 The `force` option can drop an existing table.
 
 ```ruby
-class CreateUsers < ActiveRecord::Migration[7.2]
+class CreateUsers < ActiveRecord::Migration[8.0]
   def change
     create_table :users, force: true do |t|
       # ...
@@ -246,7 +246,7 @@ end
 Create tables without the `force` option.
 
 ```ruby
-class CreateUsers < ActiveRecord::Migration[7.2]
+class CreateUsers < ActiveRecord::Migration[8.0]
   def change
     create_table :users do |t|
       # ...
@@ -264,7 +264,7 @@ If you intend to drop an existing table, run `drop_table` first.
 Adding an auto-incrementing column (`serial`/`bigserial` in Postgres and `AUTO_INCREMENT` in MySQL and MariaDB) causes the entire table to be rewritten. During this time, reads and writes are blocked in Postgres, and writes are blocked in MySQL and MariaDB.
 
 ```ruby
-class AddIdToCitiesUsers < ActiveRecord::Migration[7.2]
+class AddIdToCitiesUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :cities_users, :id, :primary_key
   end
@@ -284,7 +284,7 @@ Create a new table and migrate the data with the same steps as [renaming a table
 Adding a stored generated column causes the entire table to be rewritten. During this time, reads and writes are blocked in Postgres, and writes are blocked in MySQL and MariaDB.
 
 ```ruby
-class AddSomeColumnToUsers < ActiveRecord::Migration[7.2]
+class AddSomeColumnToUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :users, :some_column, :virtual, type: :string, as: "...", stored: true
   end
@@ -304,7 +304,7 @@ Add a non-generated column and use callbacks or triggers instead (or a virtual g
 Adding a check constraint blocks reads and writes in Postgres and blocks writes in MySQL and MariaDB while every row is checked.
 
 ```ruby
-class AddCheckConstraint < ActiveRecord::Migration[7.2]
+class AddCheckConstraint < ActiveRecord::Migration[8.0]
   def change
     add_check_constraint :users, "price > 0", name: "price_check"
   end
@@ -316,7 +316,7 @@ end
 Add the check constraint without validating existing rows:
 
 ```ruby
-class AddCheckConstraint < ActiveRecord::Migration[7.2]
+class AddCheckConstraint < ActiveRecord::Migration[8.0]
   def change
     add_check_constraint :users, "price > 0", name: "price_check", validate: false
   end
@@ -326,7 +326,7 @@ end
 Then validate them in a separate migration.
 
 ```ruby
-class ValidateCheckConstraint < ActiveRecord::Migration[7.2]
+class ValidateCheckConstraint < ActiveRecord::Migration[8.0]
   def change
     validate_check_constraint :users, name: "price_check"
   end
@@ -342,7 +342,7 @@ end
 Strong Migrations can’t ensure safety for raw SQL statements. Make really sure that what you’re doing is safe, then use:
 
 ```ruby
-class ExecuteSQL < ActiveRecord::Migration[7.2]
+class ExecuteSQL < ActiveRecord::Migration[8.0]
   def change
     safety_assured { execute "..." }
   end
@@ -358,7 +358,7 @@ Note: Strong Migrations does not detect dangerous backfills.
 Active Record creates a transaction around each migration, and backfilling in the same transaction that alters a table keeps the table locked for the [duration of the backfill](https://wework.github.io/data/2015/11/05/add-columns-with-default-values-to-large-tables-in-rails-postgres/).
 
 ```ruby
-class AddSomeColumnToUsers < ActiveRecord::Migration[7.2]
+class AddSomeColumnToUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :users, :some_column, :text
     User.update_all some_column: "default_value"
@@ -373,7 +373,7 @@ Also, running a single query to update data can cause issues for large tables.
 There are three keys to backfilling safely: batching, throttling, and running it outside a transaction. Use the Rails console or a separate migration with `disable_ddl_transaction!`.
 
 ```ruby
-class BackfillSomeColumn < ActiveRecord::Migration[7.2]
+class BackfillSomeColumn < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def up
@@ -396,7 +396,7 @@ Note: If backfilling with a method other than `update_all`, use `User.reset_colu
 In Postgres, adding an index non-concurrently blocks writes.
 
 ```ruby
-class AddSomeIndexToUsers < ActiveRecord::Migration[7.2]
+class AddSomeIndexToUsers < ActiveRecord::Migration[8.0]
   def change
     add_index :users, :some_column
   end
@@ -408,7 +408,7 @@ end
 Add indexes concurrently.
 
 ```ruby
-class AddSomeIndexToUsers < ActiveRecord::Migration[7.2]
+class AddSomeIndexToUsers < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def change
@@ -434,7 +434,7 @@ rails g index table column
 Rails adds an index non-concurrently to references by default, which blocks writes in Postgres.
 
 ```ruby
-class AddReferenceToUsers < ActiveRecord::Migration[7.2]
+class AddReferenceToUsers < ActiveRecord::Migration[8.0]
   def change
     add_reference :users, :city
   end
@@ -446,7 +446,7 @@ end
 Make sure the index is added concurrently.
 
 ```ruby
-class AddReferenceToUsers < ActiveRecord::Migration[7.2]
+class AddReferenceToUsers < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def change
@@ -464,7 +464,7 @@ end
 In Postgres, adding a foreign key blocks writes on both tables.
 
 ```ruby
-class AddForeignKeyOnUsers < ActiveRecord::Migration[7.2]
+class AddForeignKeyOnUsers < ActiveRecord::Migration[8.0]
   def change
     add_foreign_key :users, :orders
   end
@@ -474,7 +474,7 @@ end
 or
 
 ```ruby
-class AddReferenceToUsers < ActiveRecord::Migration[7.2]
+class AddReferenceToUsers < ActiveRecord::Migration[8.0]
   def change
     add_reference :users, :order, foreign_key: true
   end
@@ -486,7 +486,7 @@ end
 Add the foreign key without validating existing rows:
 
 ```ruby
-class AddForeignKeyOnUsers < ActiveRecord::Migration[7.2]
+class AddForeignKeyOnUsers < ActiveRecord::Migration[8.0]
   def change
     add_foreign_key :users, :orders, validate: false
   end
@@ -496,7 +496,7 @@ end
 Then validate them in a separate migration.
 
 ```ruby
-class ValidateForeignKeyOnUsers < ActiveRecord::Migration[7.2]
+class ValidateForeignKeyOnUsers < ActiveRecord::Migration[8.0]
   def change
     validate_foreign_key :users, :orders
   end
@@ -510,7 +510,7 @@ end
 In Postgres, adding a unique constraint creates a unique index, which blocks reads and writes.
 
 ```ruby
-class AddUniqueConstraint < ActiveRecord::Migration[7.2]
+class AddUniqueConstraint < ActiveRecord::Migration[8.0]
   def change
     add_unique_constraint :users, :some_column
   end
@@ -522,7 +522,7 @@ end
 Create a unique index concurrently, then use it for the constraint.
 
 ```ruby
-class AddUniqueConstraint < ActiveRecord::Migration[7.2]
+class AddUniqueConstraint < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def up
@@ -543,7 +543,7 @@ end
 In Postgres, adding an exclusion constraint blocks reads and writes while every row is checked.
 
 ```ruby
-class AddExclusionConstraint < ActiveRecord::Migration[7.2]
+class AddExclusionConstraint < ActiveRecord::Migration[8.0]
   def change
     add_exclusion_constraint :users, "number WITH =", using: :gist
   end
@@ -561,7 +561,7 @@ end
 In Postgres, there’s no equality operator for the `json` column type, which can cause errors for existing `SELECT DISTINCT` queries in your application.
 
 ```ruby
-class AddPropertiesToUsers < ActiveRecord::Migration[7.2]
+class AddPropertiesToUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :users, :properties, :json
   end
@@ -573,7 +573,7 @@ end
 Use `jsonb` instead.
 
 ```ruby
-class AddPropertiesToUsers < ActiveRecord::Migration[7.2]
+class AddPropertiesToUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :users, :properties, :jsonb
   end
@@ -589,7 +589,7 @@ end
 In Postgres, setting `NOT NULL` on an existing column blocks reads and writes while every row is checked.
 
 ```ruby
-class SetSomeColumnNotNull < ActiveRecord::Migration[7.2]
+class SetSomeColumnNotNull < ActiveRecord::Migration[8.0]
   def change
     change_column_null :users, :some_column, false
   end
@@ -601,7 +601,7 @@ end
 Instead, add a check constraint.
 
 ```ruby
-class SetSomeColumnNotNull < ActiveRecord::Migration[7.2]
+class SetSomeColumnNotNull < ActiveRecord::Migration[8.0]
   def change
     add_check_constraint :users, "some_column IS NOT NULL", name: "users_some_column_null", validate: false
   end
@@ -611,7 +611,7 @@ end
 Then validate it in a separate migration. Once the check constraint is validated, you can safely set `NOT NULL` on the column and drop the check constraint.
 
 ```ruby
-class ValidateSomeColumnNotNull < ActiveRecord::Migration[7.2]
+class ValidateSomeColumnNotNull < ActiveRecord::Migration[8.0]
   def up
     validate_check_constraint :users, name: "users_some_column_null"
     change_column_null :users, :some_column, false
@@ -632,7 +632,7 @@ end
 Adding a column with a volatile default value to an existing table causes the entire table to be rewritten. During this time, reads and writes are blocked.
 
 ```ruby
-class AddSomeColumnToUsers < ActiveRecord::Migration[7.2]
+class AddSomeColumnToUsers < ActiveRecord::Migration[8.0]
   def change
     add_column :users, :some_column, :uuid, default: "gen_random_uuid()"
   end
@@ -644,7 +644,7 @@ end
 Instead, add the column without a default value, then change the default.
 
 ```ruby
-class AddSomeColumnToUsers < ActiveRecord::Migration[7.2]
+class AddSomeColumnToUsers < ActiveRecord::Migration[8.0]
   def up
     add_column :users, :some_column, :uuid
     change_column_default :users, :some_column, from: nil, to: "gen_random_uuid()"
@@ -695,7 +695,7 @@ config.active_record.partial_inserts = false
 Adding a non-unique index with more than three columns rarely improves performance.
 
 ```ruby
-class AddSomeIndexToUsers < ActiveRecord::Migration[7.2]
+class AddSomeIndexToUsers < ActiveRecord::Migration[8.0]
   def change
     add_index :users, [:a, :b, :c, :d]
   end
@@ -707,7 +707,7 @@ end
 Instead, start an index with columns that narrow down the results the most.
 
 ```ruby
-class AddSomeIndexToUsers < ActiveRecord::Migration[7.2]
+class AddSomeIndexToUsers < ActiveRecord::Migration[8.0]
   def change
     add_index :users, [:d, :b]
   end
@@ -721,7 +721,7 @@ For Postgres, be sure to add them concurrently.
 To mark a step in the migration as safe, despite using a method that might otherwise be dangerous, wrap it in a `safety_assured` block.
 
 ```ruby
-class MySafeMigration < ActiveRecord::Migration[7.2]
+class MySafeMigration < ActiveRecord::Migration[8.0]
   def change
     safety_assured { remove_column :users, :some_column }
   end
@@ -910,7 +910,7 @@ StrongMigrations.lock_timeout_retry_delay = 10.seconds
 To mark migrations as safe that were created before installing this gem, create an initializer with:
 
 ```ruby
-StrongMigrations.start_after = 20230101000000
+StrongMigrations.start_after = 20250101000000
 ```
 
 Use the version from your latest migration.

data/lib/strong_migrations/adapters/abstract_adapter.rb

@@ -40,6 +40,9 @@ module StrongMigrations
         ["primary_key"]
       end
 
+      def max_constraint_name_length
+      end
+
       private
 
       def connection

data/lib/strong_migrations/adapters/mysql_adapter.rb

@@ -92,6 +92,10 @@ module StrongMigrations
         "writes"
       end
 
+      def max_constraint_name_length
+        64
+      end
+
       private
 
       # do not memoize

data/lib/strong_migrations/adapters/postgresql_adapter.rb

@@ -173,6 +173,10 @@ module StrongMigrations
         ["primary_key", "serial", "bigserial"]
       end
 
+      def max_constraint_name_length
+        63
+      end
+
       private
 
       def set_timeout(setting, timeout)
@@ -210,15 +214,9 @@ module StrongMigrations
       end
 
       def datetime_type
-        key =
-          if ActiveRecord::VERSION::MAJOR >= 7
-            # https://github.com/rails/rails/pull/41084
-            # no need to support custom datetime_types
-            connection.class.datetime_type
-          else
-            # https://github.com/rails/rails/issues/21126#issuecomment-327895275
-            :datetime
-          end
+        # https://github.com/rails/rails/pull/41084
+        # no need to support custom datetime_types
+        key = connection.class.datetime_type
 
         # could be timestamp, timestamp without time zone, timestamp with time zone, etc
         connection.class.const_get(:NATIVE_DATABASE_TYPES).fetch(key).fetch(:name)

data/lib/strong_migrations/checks.rb

@@ -216,11 +216,11 @@ module StrongMigrations
       table, column, _default_or_changes = args
 
       # just check ActiveRecord::Base, even though can override on model
-      partial_inserts = ar_version >= 7 ? ActiveRecord::Base.partial_inserts : ActiveRecord::Base.partial_writes
+      partial_inserts = ActiveRecord::Base.partial_inserts
 
       if partial_inserts && !new_column?(table, column)
         raise_error :change_column_default,
-          config: ar_version >= 7 ? "partial_inserts" : "partial_writes"
+          config: "partial_inserts"
       end
     end
 
@@ -232,10 +232,20 @@ module StrongMigrations
           safe = constraints.any? { |c| c.options[:validate] && (c.expression == "#{column} IS NOT NULL" || c.expression == "#{connection.quote_column_name(column)} IS NOT NULL") }
 
           unless safe
+            expression = "#{quote_column_if_needed(column)} IS NOT NULL"
+
             # match https://github.com/nullobject/rein
             constraint_name = "#{table}_#{column}_null"
+            if adapter.max_constraint_name_length && constraint_name.bytesize > adapter.max_constraint_name_length
+              constraint_name = connection.check_constraint_options(table, expression, {})[:name]
+
+              # avoid collision with Active Record naming for safe_by_default
+              if StrongMigrations.safe_by_default
+                constraint_name = constraint_name.sub("rails", "strong_migrations")
+              end
+            end
 
-            add_args = [table, "#{quote_column_if_needed(column)} IS NOT NULL", {name: constraint_name, validate: false}]
+            add_args = [table, expression, {name: constraint_name, validate: false}]
             validate_args = [table, {name: constraint_name}]
             change_args = [table, column, null]
             remove_args = [table, {name: constraint_name}]

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Andrew Kane
 - Bob Remeika
 - David Waller
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-09 00:00:00.000000000 Z
+date: 2025-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,15 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
-description:
+        version: '7'
 email:
 - andrew@ankane.org
 - bob.remeika@gmail.com
@@ -60,7 +58,6 @@ homepage: https://github.com/ankane/strong_migrations
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -75,8 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Catch unsafe migrations in development
 test_files: []