strong_migrations 1.6.0 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23737504a1d3beb08bf2412b161b8e59a8a620b4f4d993f11fe931e7f1772452
-  data.tar.gz: 993dc5f9d78cba148540a22772c18ed115ea6ae8075dd209cc3a869cc2a647a4
+  metadata.gz: 0a79294494eac7a9d8f36b3ec1c4c37dc11b2f1e5dccb4215333f55247acba4c
+  data.tar.gz: 7e9c2d8adc3cfb9cd1c3af33c001b38093260062b2278ae363e536c3a1d52cbb
 SHA512:
-  metadata.gz: e906dc1c79d12a72a7d0e6fb4ca87319095d3b0a39f2da1dbd08b453d19e3215892745c86f80bf9ea26bbf07173d87022aab21b424a881f24744b65396fcd9bc
-  data.tar.gz: 56a0dadcb236f09a1a7d5450456ae343ac8cb6662b65f983c28b4268edad6e7cbecfa47c86ebb0d1da72dcc1b305e7196521811a48838c25beb1119846a2b928
+  metadata.gz: 6d2a9758873a3a40c7968ca15a9d801821afbe426ee7bad43ee1b580ec4097a858c56722c22d7d9c04b7c5f83089fb17317036431016703b6148bfbff8b3cd7b
+  data.tar.gz: e710254af69bb5ac7d48955aa01a4dca5268c071d4a84904798f0a80e7caa9e5bf5cdd9902af9512fd23290233a1e757379ba09db6327dc8b910a7ca4e318803

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 1.6.2 (2023-09-13)
+
+- Fixed foreign key options with `add_reference` and `safe_by_default`
+- Fixed `safety_assured` with `revert`
+
+## 1.6.1 (2023-08-09)
+
+- Fixed `safety_assured` for custom checks with `safe_by_default`
+
 ## 1.6.0 (2023-07-22)
 
 - Added check for `change_column_default`

data/lib/strong_migrations/checker.rb

@@ -5,22 +5,25 @@ module StrongMigrations
 
     attr_accessor :direction, :transaction_disabled, :timeouts_set
 
+    class << self
+      attr_accessor :safe
+    end
+
     def initialize(migration)
       @migration = migration
       @new_tables = []
       @new_columns = []
-      @safe = false
       @timeouts_set = false
       @committed = false
     end
 
-    def safety_assured
-      previous_value = @safe
+    def self.safety_assured
+      previous_value = safe
       begin
-        @safe = true
+        self.safe = true
         yield
       ensure
-        @safe = previous_value
+        self.safe = previous_value
       end
     end
 
@@ -78,9 +81,11 @@ module StrongMigrations
           @committed = true
         end
 
-        # custom checks
-        StrongMigrations.checks.each do |check|
-          @migration.instance_exec(method, args, &check)
+        if !safe?
+          # custom checks
+          StrongMigrations.checks.each do |check|
+            @migration.instance_exec(method, args, &check)
+          end
         end
       end
 
@@ -158,7 +163,7 @@ module StrongMigrations
     end
 
     def safe?
-      @safe || ENV["SAFETY_ASSURED"] || (direction == :down && !StrongMigrations.check_down) || version_safe?
+      self.class.safe || ENV["SAFETY_ASSURED"] || (direction == :down && !StrongMigrations.check_down) || version_safe?
     end
 
     def version_safe?

data/lib/strong_migrations/migration.rb

@@ -21,7 +21,7 @@ module StrongMigrations
     ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
 
     def safety_assured
-      strong_migrations_checker.safety_assured do
+      strong_migrations_checker.class.safety_assured do
         yield
       end
     end

data/lib/strong_migrations/safe_methods.rb

@@ -30,10 +30,11 @@ module StrongMigrations
                 (ActiveRecord::Base.pluralize_table_names ? reference.to_s.pluralize : reference).to_sym
               end
 
+            foreign_key_opts = foreign_key.is_a?(Hash) ? foreign_key.except(:to_table) : {}
             if reference
-              @migration.add_foreign_key(table, name, column: "#{reference}_id")
+              @migration.add_foreign_key(table, name, column: "#{reference}_id", **foreign_key_opts)
             else
-              @migration.add_foreign_key(table, name)
+              @migration.add_foreign_key(table, name, **foreign_key_opts)
             end
           end
         end

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "1.6.0"
+  VERSION = "1.6.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.2
 platform: ruby
 authors:
 - Andrew Kane
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-22 00:00:00.000000000 Z
+date: 2023-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord