strong_migrations 0.6.5 → 0.7.1

data/lib/strong_migrations/railtie.rb

@@ -5,10 +5,6 @@ module StrongMigrations
   class Railtie < Rails::Railtie
     rake_tasks do
       load "tasks/strong_migrations.rake"
-
-      ["db:drop", "db:reset", "db:schema:load", "db:structure:load"].each do |t|
-        Rake::Task[t].enhance ["strong_migrations:safety_assured"]
-      end
     end
   end
 end

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.6.5"
+  VERSION = "0.7.1"
 end

data/lib/tasks/strong_migrations.rake

@@ -1,10 +1,4 @@
-# https://nithinbekal.com/posts/safe-rake-tasks
-
 namespace :strong_migrations do
-  task safety_assured: :environment do
-    raise "Set SAFETY_ASSURED=1 to run this task in production" if Rails.env.production? && !ENV["SAFETY_ASSURED"]
-  end
-
   # https://www.pgrs.net/2008/03/13/alphabetize-schema-rb-columns/
   task :alphabetize_columns do
     $stderr.puts "Dumping schema"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 0.7.1
 platform: ruby
 authors:
 - Andrew Kane
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-06 00:00:00.000000000 Z
+date: 2020-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,12 +108,13 @@ files:
 - CONTRIBUTING.md
 - LICENSE.txt
 - README.md
+- lib/generators/strong_migrations/install_generator.rb
+- lib/generators/strong_migrations/templates/initializer.rb.tt
 - lib/strong_migrations.rb
 - lib/strong_migrations/alphabetize_columns.rb
 - lib/strong_migrations/checker.rb
 - lib/strong_migrations/database_tasks.rb
 - lib/strong_migrations/migration.rb
-- lib/strong_migrations/migration_helpers.rb
 - lib/strong_migrations/railtie.rb
 - lib/strong_migrations/version.rb
 - lib/tasks/strong_migrations.rake

data/lib/strong_migrations/migration_helpers.rb

@@ -1,117 +0,0 @@
-module StrongMigrations
-  module MigrationHelpers
-    def add_foreign_key_safely(from_table, to_table, **options)
-      ensure_postgresql(__method__)
-      ensure_not_in_transaction(__method__)
-
-      reversible do |dir|
-        dir.up do
-          if ActiveRecord::VERSION::STRING >= "5.2"
-            add_foreign_key(from_table, to_table, options.merge(validate: false))
-            validate_foreign_key(from_table, to_table)
-          else
-            options = connection.foreign_key_options(from_table, to_table, options)
-            fk_name, column, primary_key = options.values_at(:name, :column, :primary_key)
-            primary_key ||= "id"
-
-            statement = ["ALTER TABLE %s ADD CONSTRAINT %s FOREIGN KEY (%s) REFERENCES %s (%s)"]
-            statement << on_delete_update_statement(:delete, options[:on_delete]) if options[:on_delete]
-            statement << on_delete_update_statement(:update, options[:on_update]) if options[:on_update]
-            statement << "NOT VALID"
-
-            safety_assured do
-              execute quote_identifiers(statement.join(" "), [from_table, fk_name, column, to_table, primary_key])
-              execute quote_identifiers("ALTER TABLE %s VALIDATE CONSTRAINT %s", [from_table, fk_name])
-            end
-          end
-        end
-
-        dir.down do
-          remove_foreign_key(from_table, to_table)
-        end
-      end
-    end
-
-    def add_null_constraint_safely(table_name, column_name, name: nil)
-      ensure_postgresql(__method__)
-      ensure_not_in_transaction(__method__)
-
-      reversible do |dir|
-        dir.up do
-          name ||= null_constraint_name(table_name, column_name)
-
-          safety_assured do
-            execute quote_identifiers("ALTER TABLE %s ADD CONSTRAINT %s CHECK (%s IS NOT NULL) NOT VALID", [table_name, name, column_name])
-            execute quote_identifiers("ALTER TABLE %s VALIDATE CONSTRAINT %s", [table_name, name])
-          end
-        end
-
-        dir.down do
-          remove_null_constraint_safely(table_name, column_name)
-        end
-      end
-    end
-
-    # removing constraints is safe, but this method is safe to reverse as well
-    def remove_null_constraint_safely(table_name, column_name, name: nil)
-      # could also ensure in transaction so it can be reversed
-      # but that's more of a concern for a reversible migrations check
-      ensure_postgresql(__method__)
-
-      reversible do |dir|
-        dir.up do
-          name ||= null_constraint_name(table_name, column_name)
-
-          safety_assured do
-            execute quote_identifiers("ALTER TABLE %s DROP CONSTRAINT %s", [table_name, name])
-          end
-        end
-
-        dir.down do
-          add_null_constraint_safely(table_name, column_name)
-        end
-      end
-    end
-
-    private
-
-    def ensure_postgresql(method_name)
-      raise StrongMigrations::Error, "`#{method_name}` is intended for Postgres only" unless postgresql?
-    end
-
-    def postgresql?
-      %w(PostgreSQL PostGIS).include?(connection.adapter_name)
-    end
-
-    def ensure_not_in_transaction(method_name)
-      if connection.transaction_open?
-        raise StrongMigrations::Error, "Cannot run `#{method_name}` inside a transaction. Use `disable_ddl_transaction` to disable the transaction."
-      end
-    end
-
-    # match https://github.com/nullobject/rein
-    def null_constraint_name(table_name, column_name)
-      "#{table_name}_#{column_name}_null"
-    end
-
-    def on_delete_update_statement(delete_or_update, action)
-      on = delete_or_update.to_s.upcase
-
-      case action
-      when :nullify
-        "ON #{on} SET NULL"
-      when :cascade
-        "ON #{on} CASCADE"
-      when :restrict
-        "ON #{on} RESTRICT"
-      else
-        # same error message as Active Record
-        raise "'#{action}' is not supported for :on_update or :on_delete.\nSupported values are: :nullify, :cascade, :restrict"
-      end
-    end
-
-    def quote_identifiers(statement, identifiers)
-      statement % identifiers.map { |v| connection.quote_table_name(v) }
-    end
-  end
-end