strong_migrations 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c10a3713f5640ee7249063d3df7236d263cb5a71
-  data.tar.gz: df50932fcd76d06f830bafee7a186ac6a5d14c13
+  metadata.gz: d3bfd4ef03a42fa57d69e5207d20f9e4f7d453ed
+  data.tar.gz: d291ce32c88f47bfb42b1e34013c625cbdf44e8c
 SHA512:
-  metadata.gz: 04b1c12a2dd58c459987a2d3c797cfc225500cb87ece9758b779d049fc62600c1a9b041d35b3e87a0d11000ab05517114ab8960a5003063ad59d7004c5707ba6
-  data.tar.gz: 7ac14054e5d67e60bfb75582c164ba9b3360a4a59f135986a665a7c29da3b39feffb0ee40147f142ab6850cf541f117943499ff0748c11ace7474adde5816185
+  metadata.gz: f10a0f58b62bed953fc0f066bcf032639386ca4db62c1fc0f23c63d849514176e402fc419453d8617232c3b613f907b743ed1b330a4249f6f37c66f634d6af4b
+  data.tar.gz: 64c2d0ab3d3b0bc7cce8a0f7f0bd60f855d1f6e14ee720ce2e1af9a8dd402a72cbc2ecbb6ca99bf0a35b5f85334b4f4cd04daae6057207217e68ab21574c7ea9

data/.travis.yml

@@ -1,11 +1,10 @@
 language: ruby
 rvm:
-  - 2.3.1
+  - 2.4.1
 gemfile:
   - Gemfile
-  - test/gemfiles/activerecord32.gemfile
-  - test/gemfiles/activerecord40.gemfile
-  - test/gemfiles/activerecord41.gemfile
+  - test/gemfiles/activerecord50.gemfile
+  - test/gemfiles/activerecord42.gemfile
 script: bundle exec rake test
 before_script:
   - psql -c 'create database strong_migrations_test;' -U postgres
@@ -18,4 +17,4 @@ matrix:
   include:
     - gemfile: test/gemfiles/mysql2.gemfile
       env: ADAPTER=mysql2
-      rvm: 2.2
+      rvm: 2.4.1

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.7
+
+- Added check for `force` option with `create_table`
+- Added `auto_analyze` option
+
 ## 0.1.6
 
 - Adding an index to a newly created table is now safe

data/Gemfile

@@ -1,4 +1,5 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in strong_migrations.gemspec
 gemspec
+
+gem "activerecord", "~> 5.1.0"

data/README.md

@@ -93,7 +93,13 @@ If you really have to:
 Tell ActiveRecord to ignore the column from its cache.
 
 ```ruby
-class User
+# For Rails 5+
+class User < ActiveRecord::Base
+  self.ignored_columns = %w(some_column)
+end
+
+# For Rails < 5
+class User < ActiveRecord::Base
   def self.columns
     super.reject { |c| c.name == "some_column" }
   end

data/Rakefile

@@ -5,6 +5,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"]
+  t.warning = false
 end
 
 task default: :test

data/lib/strong_migrations/migration.rb

@@ -32,7 +32,7 @@ module StrongMigrations
             raise_error :add_index_columns
           end
           options = args[2]
-          if %w(PostgreSQL PostGIS).include?(connection.adapter_name) && !(options && options[:algorithm] == :concurrently) && !@new_tables.to_a.include?(args[0].to_s)
+          if postgresql? && !(options && options[:algorithm] == :concurrently) && !@new_tables.to_a.include?(args[0].to_s)
             raise_error :add_index
           end
         when :add_column
@@ -43,15 +43,36 @@ module StrongMigrations
         when :change_column
           raise_error :change_column
         when :create_table
-          (@new_tables ||= []) << args[0].to_s
+          options = args[1]
+          raise_error :create_table if options[:force]
+        when :add_reference
+          options = args[2] || {}
+          index_value = options.fetch(:index, ActiveRecord::VERSION::MAJOR >= 5 ? true : false)
+          if postgresql? && index_value
+            raise_error :add_reference
+          end
         end
       end
 
-      super
+      if method == :create_table
+        (@new_tables ||= []) << args[0].to_s
+      end
+
+      result = super
+
+      if StrongMigrations.auto_analyze && postgresql? && method == :add_index
+        connection.execute "ANALYZE VERBOSE #{connection.quote_table_name(args[0])}"
+      end
+
+      result
     end
 
     private
 
+    def postgresql?
+      %w(PostgreSQL PostGIS).include?(connection.adapter_name)
+    end
+
     def raise_error(message_key)
       message =
         case message_key
@@ -111,6 +132,14 @@ Once it's deployed, wrap this step in a safety_assured { ... } block."
 4. Move reads from the old table to the new table
 5. Stop writing to the old table
 6. Drop the old table"
+        when :add_reference
+"Adding a non-concurrent index locks the table. Instead, use:
+
+  def change
+    add_reference :users, :reference, index: false
+    commit_db_transaction
+    add_index :users, :reference_id, algorithm: :concurrently
+  end"
         when :add_index
 "Adding a non-concurrent index locks the table. Instead, use:
 
@@ -126,6 +155,10 @@ If you're sure this is what you want, wrap it in a safety_assured { ... } block.
 "The strong_migrations gem does not support inspecting what happens inside a
 change_table block, so cannot help you here. Please make really sure that what
 you're doing is safe before proceding, then wrap it in a safety_assured { ... } block."
+        when :create_table
+"The force option will destroy existing tables.
+If this is intended, drop the existing table first.
+Otherwise, remove the option."
         end
 
       wait_message = '

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

data/lib/strong_migrations.rb

@@ -4,4 +4,11 @@ require "strong_migrations/unsafe_migration"
 require "strong_migrations/migration"
 require "strong_migrations/railtie" if defined?(Rails)
 
+module StrongMigrations
+  class << self
+    attr_accessor :auto_analyze
+  end
+  self.auto_analyze = false
+end
+
 ActiveRecord::Migration.send(:prepend, StrongMigrations::Migration)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Bob Remeika
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-24 00:00:00.000000000 Z
+date: 2017-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Catch unsafe migrations at dev time