strong_actions 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31fc4f5e9191a56ec48d3f35fdb424deaa0371ae
-  data.tar.gz: 8a4e24d7bb75c0930820a4856b87bfc1f56a6fc2
+  metadata.gz: b1012764428766d50f9c26c61ec9a92a2f3eeaf9
+  data.tar.gz: 0da862ab3795a2e426dd8b7058285cbc1f5f57e2
 SHA512:
-  metadata.gz: d71a0a3d851fdd2b8e7b95706e4a4040849cf4fca180f1fb11d673bcee0f7c04f88a1072a1391b0a2d77ddf39c7a1003107e5cd87fcb5cce7f88ae7bf1d84615
-  data.tar.gz: de3ee53a2db2ee226297b46a1e7dc1b9f54c6117e6992fb69a0d5266d1b13f8d52b3ba8935b657a69e61077cba2d73db55fdc6f38f5993b3800798f305bef44f
+  metadata.gz: b0b8b1ebdbb1ff44ad641b52cfb098b15d4a1b7e44cfcbb04f4824c4a665cccc578c020b80b157ad3148466bc56c632504fa505dcf6096f0aeb0d026782b61a3
+  data.tar.gz: 8301726f828161f264501e15548747dc3d255a3841dddea79d72ccb15b53268892aac272610d1aaa11a84e527438f4eaf4b5b55fc546660c092f36c6a744863e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    strong_actions (0.0.4)
+    strong_actions (0.0.6)
       actionpack (>= 3.2.0, < 5.0.0)
       activesupport (>= 3.2.0, < 5.0.0)
       railties (>= 3.2.0, < 5.0.0)
@@ -9,37 +9,54 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (4.1.6)
-      actionview (= 4.1.6)
-      activesupport (= 4.1.6)
-      rack (~> 1.5.2)
+    actionpack (4.2.1)
+      actionview (= 4.2.1)
+      activesupport (= 4.2.1)
+      rack (~> 1.6)
       rack-test (~> 0.6.2)
-    actionview (4.1.6)
-      activesupport (= 4.1.6)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    actionview (4.2.1)
+      activesupport (= 4.2.1)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activesupport (4.1.6)
-      i18n (~> 0.6, >= 0.6.9)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.1)
+    activesupport (4.2.1)
+      i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.1)
+      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     builder (3.2.2)
     erubis (2.7.0)
-    i18n (0.6.11)
-    json (1.8.1)
-    minitest (5.4.2)
-    rack (1.5.2)
-    rack-test (0.6.2)
+    i18n (0.7.0)
+    json (1.8.2)
+    loofah (2.0.1)
+      nokogiri (>= 1.5.9)
+    mini_portile (0.6.2)
+    minitest (5.6.0)
+    nokogiri (1.6.6.2)
+      mini_portile (~> 0.6.0)
+    rack (1.6.0)
+    rack-test (0.6.3)
       rack (>= 1.0)
-    railties (4.1.6)
-      actionpack (= 4.1.6)
-      activesupport (= 4.1.6)
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.6)
+      activesupport (>= 4.2.0.beta, < 5.0)
+      nokogiri (~> 1.6.0)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.0.2)
+      loofah (~> 2.0)
+    railties (4.2.1)
+      actionpack (= 4.2.1)
+      activesupport (= 4.2.1)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.3.2)
+    rake (10.4.2)
     thor (0.19.1)
-    thread_safe (0.3.4)
+    thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
 

data/HISTORY.md

@@ -1,5 +1,8 @@
 # History
 
+## 0.0.6
+* supprts controller_path
+
 ## 0.0.5
 * do not raise error when role is undefined but not needed.
 

data/config/secrets.yml

@@ -0,0 +1,2 @@
+test:
+  secret_key_base: testtest

data/lib/strong_actions/{controller_extensions.rb → controller.rb}

@@ -1,7 +1,7 @@
 require 'strong_actions/decision'
 
 module StrongActions
-  module ControllerExtensions
+  module Controller
     extend ActiveSupport::Concern
 
     included do
@@ -18,25 +18,30 @@ module StrongActions
 
     def authorize_roles!
       StrongActions.config.roles.each do |role|
-        unless judge(role, controller_name, action_name, params)
-          message = "#{controller_name.capitalize}Controller##{action_name} is not permitted for role #{role}"
+        unless judge(role, controller_path, action_name, params)
+          message = "#{controller_path.capitalize}Controller##{action_name} is not permitted for role #{role}"
           raise StrongActions::ForbiddenAction.new(message)
         end
       end
     end
 
-    def available?(controller_name, action_name = nil, params = {})
+    def available?(controller_path, action_name = nil, params = {})
       StrongActions.config.roles.each do |role|
-        return false unless judge(role, controller_name, action_name, params)
+        return false unless judge(role, controller_path, action_name, params)
       end
 
       true
     end
 
-    def judge(role, controller_name, action_name = nil, params = {})
+    def judge(role, controller_path, action_name = nil, params = {})
+      controller_path = normalize_controller_path(controller_path)
+
       @decision ||= StrongActions::Decision.new(self)
-      @decision.call(role, controller_name, action_name, params)
+      @decision.call(role, controller_path, action_name, params)
     end
 
+    def normalize_controller_path(controller_path)
+      controller_path.start_with?('/') ? controller_path[1..-1] : controller_path 
+    end
   end
 end

data/lib/strong_actions/decision.rb

@@ -5,11 +5,11 @@ module StrongActions
       @target = target
     end
 
-    def call(role, controller_name, action_name = nil, params = {})
+    def call(role, controller_path, action_name = nil, params = {})
       role_definition = StrongActions.config.role_definition(role)
       return true unless role_definition
 
-      controller_value = role_definition[controller_name]
+      controller_value = role_definition[controller_path]
       return true if controller_value.nil?
 
       if controller_value.is_a?(Hash)

data/lib/strong_actions/railtie.rb

@@ -3,7 +3,7 @@ module StrongActions
 
     initializer 'strong_actions' do
       ActiveSupport.on_load :action_controller do
-        include StrongActions::ControllerExtensions
+        include StrongActions::Controller
       end
     end
 

data/lib/strong_actions/version.rb

@@ -1,3 +1,3 @@
 module StrongActions
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/lib/strong_actions.rb

@@ -2,7 +2,7 @@ require 'action_controller'
 require "strong_actions/version"
 require "strong_actions/config"
 require "strong_actions/forbidden_action"
-require 'strong_actions/controller_extensions'
+require 'strong_actions/controller'
 
 module StrongActions
 

data/test/controller_test.rb

@@ -0,0 +1,44 @@
+require 'test_helper'
+
+class WelcomeController < ActionController::Base
+  include StrongActions::Controller
+
+  def index
+    head :ok
+  end
+  
+  def destroy
+    head :ok
+  end
+
+  private
+
+  def current_user
+    unless @current_user
+      @current_user = Object.new
+      @current_user.instance_eval do
+         def admin?
+           false
+         end
+      end
+    end
+    
+    @current_user
+  end
+end
+
+class ControllerTest < ActionController::TestCase
+  tests WelcomeController
+
+  def test_allowed
+    get :index
+    assert_response :ok
+  end
+
+  def test_forbidden
+    assert_raise StrongActions::ForbiddenAction do
+      delete :destroy
+    end
+  end
+
+end

data/test/decision_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 class DecisionTest < Minitest::Test
 
   def setup
-    StrongActions.config.config_files = File.join(File.dirname(__FILE__), 'config', 'acl.yml')
+    StrongActions.config.config_files = File.join('config', 'acl.yml')
   end
 
   def decision

data/test/test_helper.rb

@@ -3,4 +3,29 @@ ENV["RAILS_ENV"] = "test"
 
 require 'minitest/autorun'
 require 'rails'
+
+class FakeApplication < Rails::Application
+end
+
+Rails.application = FakeApplication
+
 require 'strong_actions'
+
+module ActionController
+  SharedTestRoutes = ActionDispatch::Routing::RouteSet.new
+  SharedTestRoutes.draw do
+    get ':controller(/:action)'
+    delete ':controller(/:action)'
+  end
+
+  class Base
+    include ActionController::Testing
+    include SharedTestRoutes.url_helpers
+  end
+  
+  class ActionController::TestCase
+    setup do
+      @routes = SharedTestRoutes
+    end
+  end
+end

metadata

@@ -1,115 +1,115 @@
 --- !ruby/object:Gem::Specification
 name: strong_actions
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - ichy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2015-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: access control for rails controller/action
@@ -119,22 +119,24 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - Gemfile.lock
 - HISTORY.md
 - LICENSE
 - README.md
 - Rakefile
+- config/acl.yml
+- config/secrets.yml
 - lib/strong_actions.rb
 - lib/strong_actions/config.rb
-- lib/strong_actions/controller_extensions.rb
+- lib/strong_actions/controller.rb
 - lib/strong_actions/decision.rb
 - lib/strong_actions/forbidden_action.rb
 - lib/strong_actions/railtie.rb
 - lib/strong_actions/version.rb
 - strong_actions.gemspec
-- test/config/acl.yml
+- test/controller_test.rb
 - test/decision_test.rb
 - test/test_helper.rb
 homepage: https://github.com/hybitz/strong_actions
@@ -147,22 +149,21 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: access control for rails controller/action
 test_files:
-- test/config/acl.yml
+- test/controller_test.rb
 - test/decision_test.rb
 - test/test_helper.rb
-has_rdoc: