stripe_model_callbacks 0.1.7 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba7a4cb71e7f2d449a43ac85eeb6c61f086fdc7858ec55b88cb3a04fdae79af4
-  data.tar.gz: ed0262077e01beaf939e3b42f35e9b2a812b89ab22fa52b1d98c51445bb8d256
+  metadata.gz: 00d4ab8c0fd0b78be1ebca4dae1507afacb17d06812e3cf76d62f1999cee23eb
+  data.tar.gz: 77e3fd6aa86bea4217294b30a8a570747c7688f9e3bf583a21adbe7b3524780e
 SHA512:
-  metadata.gz: db828818fb5d9e4110dd8e4517da60d7e384cbfdc2a945cb0639c31aff8576dc957827b18745dfd1c127cfa070e291c82b45c10e0470ed37defdbf0efece86bd
-  data.tar.gz: 8150383579159ce6f3936ed2b06e38e94d2dd87d5f112c508b6f3634e7a08aae38362c41c4bd89274ce1a70808c8d2894fb0d7625b273bb30e2584d0ed5f94b1
+  metadata.gz: c60062b0347c8c843ea108dda2d871925afd5b644cc0affc2ff8db6945f51b4014c3f82c930be7057dbcc1fb0b37780806188fc407ea257333e6b9adb1e0ef3e
+  data.tar.gz: 93a37540a9c8f7a3ebc1e087a6d777e71a28f977433bb2861828afa63b2120ec4fb55ef56472fa968a96ce936f9a06fc4884a14fca9a279336811bf95d96f5c8

data/README.md

@@ -1,5 +1,5 @@
 # StripeModelCallbacks
-Stripe database models using ActiveRecord, Stripe event webhooks synchronization and PublicActivity.
+Stripe database models using ActiveRecord, Stripe event webhooks synchronization and ActiveRecordAuditable.
 
 This is supposed to make it easier implementing a full blown Stripe implementation into your application,
 so that you can code your app using ActiveRecord and all your favorite gems without having to mess around
@@ -20,11 +20,11 @@ And then execute:
 bundle
 ```
 
-You also need to install and setup the gems `public_activity`, `stripe` and `stripe_event`. Do this:
+You also need to install and setup the gems `active_record_auditable`, `stripe` and `stripe_event`. Do this:
 
 Install the migration for Public Activity, which will provide logging:
 ```bash
-rails g public_activity:migration
+rails active_record_auditable:install:migrations
 ```
 
 You can install the migrations (or update an existing installation) with this command:

data/Rakefile

@@ -20,7 +20,7 @@ load "rails/tasks/statistics.rake"
 
 require "bundler/gem_tasks"
 
-if Rails.env.development? || Rails.env.test?
+if Rails.env.development? || Rails.env.test? # rubocop:disable Rails/EnvLocal
   require "best_practice_project"
   BestPracticeProject.load_tasks
 end

data/app/models/stripe_model_callbacks/application_record.rb

@@ -1,16 +1,31 @@
 class StripeModelCallbacks::ApplicationRecord < ActiveRecord::Base
-  include PublicActivity::Model
-  tracked
-
   self.abstract_class = true
 
-  attr_writer :stripe_object
+  attr_accessor :stripe_object
+
+  def self.inherited(child)
+    super
+    child.include ActiveRecordAuditable::Audited
+    apply_json_attribute_types(child)
+  end
+
+  def self.apply_json_attribute_types(model_class)
+    json_columns = StripeModelCallbacks::AttributesAssignerService::JSON_COLUMNS_BY_TABLE.fetch(
+      model_class.table_name,
+      []
+    )
+    return if json_columns.empty?
+
+    json_columns.each do |column_name|
+      model_class.attribute(column_name, :json)
+    end
+  end
 
   def self.check_object_is_stripe_class(object, allowed = nil)
     raise "'stripe_class' not defined on #{name}" unless respond_to?(:stripe_class)
 
     # Ignore general objects
-    return if object.class.name == "Stripe::StripeObject" # rubocop:disable Style/ClassEqualityComparison:
+    return if object.class.name == "Stripe::StripeObject" # rubocop:disable Style/ClassEqualityComparison
 
     allowed ||= [stripe_class]
 
@@ -45,18 +60,15 @@ class StripeModelCallbacks::ApplicationRecord < ActiveRecord::Base
     save!
   end
 
-  def reload!(*args, &blk)
+  def reload!(*args, &)
     @to_stripe = nil
     super
   end
 
-  def update_on_stripe(attributes)
-    attributes.each do |key, value|
-      to_stripe.__send__("#{key}=", value)
-    end
-
-    to_stripe.save
-    reload_from_stripe!
+  def update_on_stripe(attributes) # rubocop:disable Naming/PredicateMethod
+    updated_object = self.class.stripe_class.update(stripe_id, attributes)
+    assign_from_stripe(updated_object)
+    save!
     true
   end
 
@@ -64,7 +76,9 @@ class StripeModelCallbacks::ApplicationRecord < ActiveRecord::Base
     raise ActiveRecord::RecordInvalid, self unless update_on_stripe(attributes)
   end
 
-  def destroy_on_stripe
+  def destroy_on_stripe # rubocop:disable Naming/PredicateMethod
+    raise "Can't delete #{self.class.name} on Stripe because it isn't supported" unless to_stripe.respond_to?(:delete)
+
     to_stripe.delete
     update!(deleted_at: Time.zone.now) if respond_to?(:deleted_at)
     reload_from_stripe!

data/app/services/stripe_model_callbacks/account/external_account/updated_service.rb

@@ -4,7 +4,7 @@ class StripeModelCallbacks::Account::ExternalAccount::UpdatedService < StripeMod
     bank_account.assign_from_stripe(object)
 
     if bank_account.save
-      bank_account.create_activity :deleted if event.type == "account.external_account.deleted"
+      bank_account.create_audit!(action: :deleted) if event.type == "account.external_account.deleted"
       succeed!
     else
       fail! bank_account.errors.full_messages

data/app/services/stripe_model_callbacks/attributes_assigner_service.rb

@@ -1,6 +1,31 @@
 class StripeModelCallbacks::AttributesAssignerService < ServicePattern::Service
   attr_reader :attributes, :model, :stripe_model
 
+  SKIP_VALUE = Object.new
+  JSON_COLUMNS_BY_TABLE = {
+    "audits" => %w[audited_changes params],
+    "stripe_payment_intents" => %w[
+      amount_details
+      automatic_payment_methods
+      last_payment_error
+      metadata
+      next_action
+      payment_method_options
+      payment_method_types
+      processing
+      shipping
+      transfer_data
+    ],
+    "stripe_payment_methods" => %w[billing_details card metadata],
+    "stripe_setup_intents" => %w[
+      flow_directions
+      mandate
+      payment_method_old
+      payment_method_options
+      payment_method_types
+    ]
+  }.freeze
+
   def initialize(attributes:, model:, stripe_model:)
     @attributes = attributes
     @model = model
@@ -9,15 +34,10 @@ class StripeModelCallbacks::AttributesAssignerService < ServicePattern::Service
 
   def perform
     attributes.each do |attribute|
-      next unless stripe_model.respond_to?(attribute)
-
-      value = stripe_model.__send__(attribute)
+      value = value_for_attribute(attribute)
+      next if value == SKIP_VALUE
 
-      if attribute == "metadata"
-        value = JSON.generate(value)
-      elsif attribute == "created" && value
-        value = Time.zone.at(value)
-      end
+      value = normalize_value(attribute, value)
 
       model.__send__(setter_method(attribute), value)
     end
@@ -25,6 +45,132 @@ class StripeModelCallbacks::AttributesAssignerService < ServicePattern::Service
     succeed!
   end
 
+  def value_for_attribute(attribute)
+    return value_from_stripe(attribute) if stripe_model.respond_to?(attribute)
+
+    return nil if allow_nil_attribute?(attribute)
+    return SKIP_VALUE unless model_value(attribute).nil?
+
+    default_value = default_value_for(attribute)
+    return SKIP_VALUE if default_value.nil?
+
+    default_value
+  end
+
+  def value_from_stripe(attribute)
+    return nil if allow_nil_attribute?(attribute) && stripe_attribute_missing?(attribute)
+
+    value = stripe_model.__send__(attribute)
+    return nil if value.nil? && allow_nil_attribute?(attribute)
+    return default_value_for(attribute) if value.nil?
+
+    value
+  end
+
+  def stripe_attribute_missing?(attribute)
+    return false unless stripe_model.respond_to?(:to_hash)
+
+    values = stripe_model.instance_variable_get(:@values)
+    return !values.key?(attribute.to_sym) && !values.key?(attribute.to_s) if values.is_a?(Hash)
+
+    stripe_values = stripe_model.to_hash
+    !stripe_values.key?(attribute.to_sym) && !stripe_values.key?(attribute.to_s)
+  end
+
+  def normalize_value(attribute, value)
+    if attribute == "created" && value
+      Time.zone.at(value)
+    elsif (converted_value = datetime_column_value(attribute, value))
+      converted_value
+    elsif json_column?(attribute)
+      normalize_json_value(value)
+    elsif attribute == "metadata"
+      JSON.generate(normalize_json_value(value))
+    else
+      value
+    end
+  end
+
+  def model_value(attribute)
+    model.__send__(column_name_for(attribute))
+  end
+
+  def default_value_for(attribute)
+    default_value = model.class.column_defaults[column_name_for(attribute)]
+
+    return default_value unless default_value.nil?
+
+    nil
+  end
+
+  def allow_nil_attribute?(attribute)
+    attribute == "auto_advance"
+  end
+
+  def json_column?(attribute)
+    column_name = column_name_for(attribute)
+    return true if json_columns_for_table.include?(column_name)
+
+    column = model.class.columns_hash[column_name]
+    return false unless column
+    return true if column.type == :json
+
+    false
+  end
+
+  def json_columns_for_table
+    JSON_COLUMNS_BY_TABLE.fetch(model.class.table_name, [])
+  end
+
+  def datetime_column_value(attribute, value)
+    return false unless value
+
+    column = model.class.columns_hash[column_name_for(attribute)]
+    return false unless column&.type == :datetime
+
+    timestamp = numeric_timestamp_value(value)
+    return Time.zone.at(timestamp) if timestamp
+
+    value
+  end
+
+  def numeric_timestamp_value(value)
+    return value.to_i if value.is_a?(Integer) || value.is_a?(Float)
+
+    value.to_i if value.is_a?(String) && value.match?(/\A\d+\z/)
+  end
+
+  def normalize_json_value(value)
+    return value if value.nil?
+
+    return normalize_json_string(value) if value.is_a?(String)
+
+    return value.map { |item| normalize_json_value(item) } if value.is_a?(Array)
+
+    return value.transform_values { |item| normalize_json_value(item) } if value.is_a?(Hash)
+
+    return normalize_json_value(value.to_hash) if value.respond_to?(:to_hash)
+
+    value
+  end
+
+  def normalize_json_string(value)
+    sanitized_value = value.tr("\u00A0", " ")
+    stripped_value = sanitized_value.strip
+    return value unless stripped_value.start_with?("{", "[")
+
+    begin
+      parsed_value = JSON.parse(sanitized_value)
+      normalize_json_value(parsed_value)
+    rescue JSON::ParserError
+      value
+    end
+  end
+
+  def column_name_for(attribute)
+    attribute == "id" ? "stripe_id" : attribute
+  end
+
   def setter_method(attribute)
     if attribute == "id"
       "stripe_id="

data/app/services/stripe_model_callbacks/base_service.rb

@@ -1,7 +1,7 @@
 class StripeModelCallbacks::BaseService < ServicePattern::Service
-  def self.reported_execute!(*args, **opts, &blk)
+  def self.reported_execute!(...)
     with_exception_notifications do
-      response = execute(*args, **opts, &blk)
+      response = execute(...)
       raise response.errors.join(". ") unless response.success?
 
       response
@@ -25,13 +25,16 @@ class StripeModelCallbacks::BaseService < ServicePattern::Service
     raise e
   end
 
-  def self.execute_with_advisory_lock!(*args, **opts, &blk)
-    # The difference between the stripe events is about a few milliseconds - with advisory_lock
+  def self.execute_with_advisory_lock!(*, **, &)
+    # The difference between the Stripe events is about a few milliseconds - with advisory_lock
     # we will prevent from creating duplicated objects due to race condition.
     # https://stripe.com/docs/webhooks/best-practices#event-ordering
     with_exception_notifications do
-      StripeModelCallbacks::ApplicationRecord.with_advisory_lock(advisory_lock_name(*args, **opts)) do
-        response = execute(*args, **opts, &blk)
+      StripeModelCallbacks::ApplicationRecord.with_advisory_lock!(
+        advisory_lock_name(*, **),
+        timeout_seconds: 10
+      ) do
+        response = execute(*, **, &)
         raise response.errors.join(". ") unless response.success?
 
         response

data/app/services/stripe_model_callbacks/charge/dispute_updated_service.rb

@@ -19,11 +19,11 @@ private
   def create_activity
     case event.type
     when "charge.dispute.closed"
-      dispute.create_activity :closed
+      dispute.create_audit!(action: :closed)
     when "charge.dispute.funds_reinstated"
-      dispute.create_activity :funds_reinstated
+      dispute.create_audit!(action: :funds_reinstated)
     when "charge.dispute.funds_withdrawn"
-      dispute.create_activity :funds_withdrawn
+      dispute.create_audit!(action: :funds_withdrawn)
     end
   end
 end

data/app/services/stripe_model_callbacks/charge/updated_service.rb

@@ -19,15 +19,15 @@ private
   def create_activity
     case event.type
     when "charge.captured"
-      charge.create_activity :captured
+      charge.create_audit!(action: :captured)
     when "charge.failed"
-      charge.create_activity :failed
+      charge.create_audit!(action: :failed)
     when "charge.pending"
-      charge.create_activity :pending
+      charge.create_audit!(action: :pending)
     when "charge.refunded"
-      charge.create_activity :refunded
+      charge.create_audit!(action: :refunded)
     when "charge.succeeded"
-      charge.create_activity :succeeded
+      charge.create_audit!(action: :succeeded)
     end
   end
 end

data/app/services/stripe_model_callbacks/configure_service.rb

@@ -20,12 +20,15 @@ class StripeModelCallbacks::ConfigureService < StripeModelCallbacks::BaseEventSe
     invoice_events
     order_events
     recipient_events
+    payment_intent_events
+    payment_method_events
     payout_events
     plan_events
     price_events
     product_events
     refund_events
     review_events
+    setup_intent_events
     sku_events
     source_events
     subscription_events
@@ -41,35 +44,35 @@ private
   def account_external_account_events
     %w[created deleted updated].each do |external_account_event|
       subscribe "account.external_account.#{external_account_event}" do |event|
-        StripeModelCallbacks::Account::ExternalAccount::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Account::ExternalAccount::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
 
   def all_events
     events.all do |event|
-      StripeModelCallbacks::NotifierService.execute_with_advisory_lock!(event: event)
+      StripeModelCallbacks::NotifierService.execute_with_advisory_lock!(event:)
     end
   end
 
   def charge_events
     %w[captured failed pending refunded updated succeeded].each do |charge_event|
       subscribe "charge.#{charge_event}" do |event|
-        StripeModelCallbacks::Charge::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Charge::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
 
   def charge_refund_events
     subscribe "charge.refund.updated" do |event|
-      StripeModelCallbacks::Refund::UpdatedService.execute_with_advisory_lock!(event: event)
+      StripeModelCallbacks::Refund::UpdatedService.execute_with_advisory_lock!(event:)
     end
   end
 
   def charge_dispute_events
     %w[closed created funds_reinstated funds_withdrawn updated].each do |charge_event|
       subscribe "charge.dispute.#{charge_event}" do |event|
-        StripeModelCallbacks::Charge::DisputeUpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Charge::DisputeUpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -77,21 +80,21 @@ private
   def coupon_events
     %w[created deleted updated].each do |coupon_event|
       subscribe "coupon.#{coupon_event}" do |event|
-        StripeModelCallbacks::Coupon::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Coupon::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
 
   def customer_bank_account_events
     subscribe "customer.bank_account.deleted" do |event|
-      StripeModelCallbacks::Customer::BankAccount::DeletedService.execute_with_advisory_lock!(event: event)
+      StripeModelCallbacks::Customer::BankAccount::DeletedService.execute_with_advisory_lock!(event:)
     end
   end
 
   def customer_discount_events
     %w[created deleted updated].each do |customer_event|
       subscribe "customer.discount.#{customer_event}" do |event|
-        StripeModelCallbacks::Customer::DiscountUpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Customer::DiscountUpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -99,7 +102,7 @@ private
   def customer_events
     %w[created deleted updated].each do |customer_event|
       subscribe "customer.#{customer_event}" do |event|
-        StripeModelCallbacks::Customer::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Customer::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -107,7 +110,7 @@ private
   def customer_source_events
     %w[created deleted expiring updated].each do |customer_event|
       subscribe "customer.source.#{customer_event}" do |event|
-        StripeModelCallbacks::Customer::SourceUpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Customer::SourceUpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -119,7 +122,7 @@ private
     # https://stripe.com/docs/billing/invoices/overview#invoice-status-transition-endpoints-and-webhooks
     %w[created deleted marked_uncollectible payment_failed payment_succeeded sent updated voided].each do |invoice_event|
       subscribe "invoice.#{invoice_event}" do |event|
-        StripeModelCallbacks::Invoice::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Invoice::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -127,7 +130,7 @@ private
   def invoice_item_events
     %w[created deleted updated].each do |event_type|
       subscribe "invoiceitem.#{event_type}" do |event|
-        StripeModelCallbacks::InvoiceItem::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::InvoiceItem::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -135,7 +138,7 @@ private
   def order_events
     %w[created updated].each do |order_event|
       subscribe "order.#{order_event}" do |event|
-        StripeModelCallbacks::Order::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Order::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -143,7 +146,7 @@ private
   def payout_events
     %w[canceled created failed paid updated].each do |payout_event|
       subscribe "payout.#{payout_event}" do |event|
-        StripeModelCallbacks::Payout::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Payout::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -151,7 +154,7 @@ private
   def recipient_events
     %w[created deleted updated].each do |recipient_event|
       subscribe "recipient.#{recipient_event}" do |event|
-        StripeModelCallbacks::Recipient::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Recipient::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -159,7 +162,23 @@ private
   def refund_events
     %w[created updated].each do |refund_event|
       subscribe "refund.#{refund_event}" do |event|
-        StripeModelCallbacks::Refund::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Refund::UpdatedService.execute_with_advisory_lock!(event:)
+      end
+    end
+  end
+
+  def payment_intent_events
+    %w[amount_capturable_updated canceled created partially_funded payment_failed processing requires_action succeeded].each do |plan_event|
+      subscribe "payment_intent.#{plan_event}" do |event|
+        StripeModelCallbacks::PaymentIntent::UpdatedService.execute_with_advisory_lock!(event:)
+      end
+    end
+  end
+
+  def payment_method_events
+    %w[attached automatically_updated card_automatically_updated detached updated].each do |plan_event|
+      subscribe "payment_method.#{plan_event}" do |event|
+        StripeModelCallbacks::PaymentMethod::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -167,7 +186,7 @@ private
   def plan_events
     %w[created deleted updated].each do |plan_event|
       subscribe "plan.#{plan_event}" do |event|
-        StripeModelCallbacks::Plan::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Plan::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -175,7 +194,7 @@ private
   def sku_events
     %w[created deleted updated].each do |sku_event|
       subscribe "sku.#{sku_event}" do |event|
-        StripeModelCallbacks::Sku::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Sku::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -183,7 +202,7 @@ private
   def price_events
     %w[created deleted updated].each do |price_event|
       subscribe "price.#{price_event}" do |event|
-        StripeModelCallbacks::Price::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Price::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -191,7 +210,7 @@ private
   def product_events
     %w[created deleted updated].each do |product_event|
       subscribe "product.#{product_event}" do |event|
-        StripeModelCallbacks::Product::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Product::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -199,7 +218,15 @@ private
   def review_events
     %w[opened closed].each do |review_event|
       subscribe "review.#{review_event}" do |event|
-        StripeModelCallbacks::Review::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Review::UpdatedService.execute_with_advisory_lock!(event:)
+      end
+    end
+  end
+
+  def setup_intent_events
+    %w[created updated].each do |product_event|
+      subscribe "setup_intent.#{product_event}" do |event|
+        StripeModelCallbacks::SetupIntent::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -207,14 +234,18 @@ private
   def source_events
     %w[canceled chargeable failed mandate_notification].each do |source_event|
       subscribe "source.#{source_event}" do |event|
-        StripeModelCallbacks::Source::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Source::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
+
+    subscribe "source.transaction.created" do |event|
+      StripeModelCallbacks::Source::TransactionCreatedService.execute_with_advisory_lock!(event:)
+    end
   end
 
   def subscribe(event_name)
     events.subscribe(event_name) do |event|
-      StripeModelCallbacks::Configuration.current.with_error_handling(args: {event: event}) do
+      StripeModelCallbacks::Configuration.current.with_error_handling(args: {event:}) do
         yield event
       end
     end
@@ -223,7 +254,7 @@ private
   def subscription_events
     %w[created deleted trial_will_end updated].each do |subscription_event|
       subscribe "customer.subscription.#{subscription_event}" do |event|
-        StripeModelCallbacks::Customer::Subscription::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Customer::Subscription::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -231,7 +262,7 @@ private
   def subscription_schedule_events
     %w[canceled created updated].each do |subscription_event|
       subscribe "subscription_schedule.#{subscription_event}" do |event|
-        StripeModelCallbacks::SubscriptionSchedule::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::SubscriptionSchedule::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -239,7 +270,7 @@ private
   def tax_rate_events
     %w[created updated].each do |transfer_event|
       subscribe "tax_rate.#{transfer_event}" do |event|
-        StripeModelCallbacks::TaxRate::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::TaxRate::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end
@@ -247,7 +278,7 @@ private
   def transfer_events
     %w[created reversed updated].each do |transfer_event|
       subscribe "transfer.#{transfer_event}" do |event|
-        StripeModelCallbacks::Transfer::UpdatedService.execute_with_advisory_lock!(event: event)
+        StripeModelCallbacks::Transfer::UpdatedService.execute_with_advisory_lock!(event:)
       end
     end
   end

data/app/services/stripe_model_callbacks/customer/bank_account/deleted_service.rb

@@ -4,7 +4,7 @@ class StripeModelCallbacks::Customer::BankAccount::DeletedService < StripeModelC
     bank_account.assign_from_stripe(object)
 
     if bank_account.save
-      bank_account.create_activity :customer_bank_account_deleted if event.type == "customer.bank_account.deleted"
+      bank_account.create_audit!(action: :customer_bank_account_deleted) if event.type == "customer.bank_account.deleted"
       succeed!
     else
       fail! bank_account.errors.full_messages

data/app/services/stripe_model_callbacks/customer/discount_updated_service.rb

@@ -14,7 +14,7 @@ class StripeModelCallbacks::Customer::DiscountUpdatedService < StripeModelCallba
 private
 
   def create_activity
-    discount.create_activity :deleted if event&.type == "customer.discount.deleted"
+    discount.create_audit!(action: :deleted) if event&.type == "customer.discount.deleted"
   end
 
   def coupon_id_look_up_by