stripe_event 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90d6d19afa81645efcadb2d980a9d8279d00686e33cc101283a07faaebb76afd
-  data.tar.gz: 338d0f8196af2c086cfb2df0bdc2350ac8577d8d45e9db19a9f032191df24161
+  metadata.gz: 9e8bf3dc8abec723bb2c3278c725f754bbe7cd991f868a8854ff04bac7bc778f
+  data.tar.gz: 46b48dae96008e8e9f27c8d7e39aa5a022614d322f2a60845b249dd862cec82b
 SHA512:
-  metadata.gz: 91789378fbba4beeb4e0245d5f980fdaa27136043ba0e53bb9e4478e57e1e397317fc4069989dd48dfee01eed64c34856294f2b5b3d66681377f0178955dee76
-  data.tar.gz: 9289a39f3f459f6a048d252e0803af0a1dd77c559e90f5f6cc261e060ea006de892b96c2a4b50039302936cc11a830fb7a1dc069addcaac989cbdfd566aa591a
+  metadata.gz: 56defdead871efd3c089a19db8382ded54786d7c899a39b6245e4b6c69e3a0a8379e792794aeb7bdbc9615f82ce107a528ea8953ac6c9a8d86c8ccd27a0e80a4
+  data.tar.gz: a91a63ef969c4e7cebac2ce7c083923a6d74cd3cfc166ea914c0956a3108edfc7591be179b44aa8fd10ce43dd8a4ec57119545f745f6a910f492b7c9ffcc98eb

data/.github/workflows/ci.yml

@@ -0,0 +1,37 @@
+name: CI
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ["2.5", "2.6", "2.7"]
+        bundler: [default]
+        gemfile:
+          - rails5.1
+          - rails5.2
+          - rails6.0
+          - rails6.1
+          - stripe3
+          - stripe4
+          - stripe5
+        include:
+          - { ruby: "2.3", gemfile: "rails3.2", bundler: "1" }
+          - { ruby: "2.3", gemfile: "rails4.2", bundler: "1" }
+          - { ruby: "2.4", gemfile: "rails4.2", bundler: "1" }
+
+    env:
+      BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
+    steps:
+      # https://github.com/marketplace/actions/checkout
+      - uses: actions/checkout@v2
+      # https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler: ${{ matrix.bundler }}
+          bundler-cache: true # runs `bundle install` and caches gems automatically
+      - name: Run tests
+        run: bundle exec rake

data/Appraisals

@@ -19,6 +19,10 @@ appraise "rails6.0" do
   gem "rails", "~> 6.0.0"
 end
 
+appraise "rails6.1" do
+  gem "rails", "~> 6.1.0"
+end
+
 appraise "stripe3" do
   gem "stripe", "~> 3.0"
 end

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 2.3.2 (February 21, 2022)
+
+- Fix signature validation error if the first signing secret is nil (#146)
+- Update README (#143)
+- Setup github actions for CI (#147)
+
 ### 2.3.1 (May 12, 2020)
 
 - Fix deprecation warning in Ruby 2.7 (#130)

data/README.md

@@ -1,6 +1,6 @@
 # StripeEvent
 
-[![Build Status](https://secure.travis-ci.org/integrallis/stripe_event.svg)](http://travis-ci.org/integrallis/stripe_event)
+[![Build Status](https://github.com/integrallis/stripe_event/workflows/CI/badge.svg)](https://github.com/integrallis/stripe_event/actions?query=workflow%3ACI)
 [![Gem Version](https://badge.fury.io/rb/stripe_event.svg)](http://badge.fury.io/rb/stripe_event)
 [![Code Climate](https://codeclimate.com/github/integrallis/stripe_event.svg)](https://codeclimate.com/github/integrallis/stripe_event)
 [![Coverage Status](https://coveralls.io/repos/integrallis/stripe_event/badge.svg)](https://coveralls.io/r/integrallis/stripe_event)
@@ -169,7 +169,7 @@ Handling webhooks is a critical piece of modern billing systems. Verifying the b
 
 ```ruby
 # spec/requests/billing_events_spec.rb
-require 'spec_helper'
+require 'rails_helper'
 
 describe "Billing Events" do
   def bypass_event_signature(payload)
@@ -178,12 +178,12 @@ describe "Billing Events" do
   end
 
   describe "customer.created" do
-    let(:payload) { File.read("spec/support/fixtures/evt_customer_created.json") }
-    before(:each) { bypass_event_signature payload }
+    let(:payload) { file_fixture('evt_customer_created.json').read }
+    before(:each) { bypass_event_signature(payload) }
 
     it "is successful" do
-      post '/_billing_events', body: payload
-      expect(response.code).to eq "200"
+      post '/_billing_events', params: payload
+      expect(response).to have_http_status(:success)
       # Additional expectations...
     end
   end

data/gemfiles/rails6.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 6.1.0"
+
+gemspec path: "../"

data/lib/stripe_event/version.rb

@@ -1,3 +1,3 @@
 module StripeEvent
-  VERSION = "2.3.1"
+  VERSION = "2.3.2"
 end

data/lib/stripe_event.rb

@@ -34,7 +34,7 @@ module StripeEvent
     end
 
     def signing_secret=(value)
-      @signing_secrets = Array(value)
+      @signing_secrets = Array(value).compact
     end
     alias signing_secrets= signing_secret=
 

data/spec/controllers/webhook_controller_spec.rb

@@ -132,4 +132,18 @@ describe StripeEvent::WebhookController, type: :controller do
       expect(response.code).to eq '200'
     end
   end
+
+  context "with multiple signing secrets first of which is nil" do
+    before(:each) { StripeEvent.signing_secrets = [nil, secret1, secret2] }
+
+    it "succeeds with valid signature from first secret" do
+      webhook_with_signature charge_succeeded, secret1
+      expect(response.code).to eq '200'
+    end
+
+    it "succeeds with valid signature from second secret" do
+      webhook_with_signature charge_succeeded, secret2
+      expect(response.code).to eq '200'
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe_event
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Danny Whalen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-12 00:00:00.000000000 Z
+date: 2022-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -134,9 +134,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -151,6 +151,7 @@ files:
 - gemfiles/rails5.1.gemfile
 - gemfiles/rails5.2.gemfile
 - gemfiles/rails6.0.gemfile
+- gemfiles/rails6.1.gemfile
 - gemfiles/rails_master.gemfile
 - gemfiles/stripe3.gemfile
 - gemfiles/stripe4.gemfile
@@ -215,7 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Stripe webhook integration for Rails applications.
@@ -226,6 +227,7 @@ test_files:
 - gemfiles/rails5.1.gemfile
 - gemfiles/rails5.2.gemfile
 - gemfiles/rails6.0.gemfile
+- gemfiles/rails6.1.gemfile
 - gemfiles/rails_master.gemfile
 - gemfiles/stripe3.gemfile
 - gemfiles/stripe4.gemfile

data/.travis.yml

@@ -1,33 +0,0 @@
-language: ruby
-cache: bundler
-
-rvm:
-  - 2.5
-  - 2.6
-  - 2.7
-
-gemfile:
-  - gemfiles/rails5.1.gemfile
-  - gemfiles/rails5.2.gemfile
-  - gemfiles/rails6.0.gemfile
-  - gemfiles/stripe3.gemfile
-  - gemfiles/stripe4.gemfile
-  - gemfiles/stripe5.gemfile
-
-matrix:
-  include:
-    - rvm: 2.3
-      gemfile: gemfiles/rails3.2.gemfile
-    - rvm: 2.3
-      gemfile: gemfiles/rails4.2.gemfile
-    - rvm: 2.4
-      gemfile: gemfiles/rails4.2.gemfile
-    - rvm: ruby
-      gemfile: gemfiles/rails_master.gemfile
-  allow_failures:
-    - gemfile: gemfiles/rails_master.gemfile
-  fast_finish: true
-
-notifications:
-  email:
-    - daniel.r.whalen+travis-ci@gmail.com