stripe_event 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f9463bf4cf0ff40f3d50526e98d6167dc77dbbd1
-  data.tar.gz: 5822f4e55cbc6ca4bc6f0870ac76055ff858cfbf
+SHA256:
+  metadata.gz: 154ef1f07846c2b1a26499b02ed2119c3057636737d61ba6b9bcb234bc897782
+  data.tar.gz: ac4ea8924d5b8c037115131ae9d8e71f1f78a3dbd42da45b916e2584a76f4cdd
 SHA512:
-  metadata.gz: 48ece33350c3b997dfc8008bb406e702f53e4c4f343d1789edc4e69b2d491b14652a6016604481a0682a1c639b71885de7128e9d8635481f9dde636359dc9711
-  data.tar.gz: 4cc3051021fbfb1cc71c3feb0116a40d79739f5e2ddeb3646edbce592d343af60430d3bfe5deae60fcd026b298187a545618827dd9ec25c0bf18a4673ded85d4
+  metadata.gz: aaff93b989d0ecbf55748c01f029f824802b323966bf2ce78e1dc2b7b607a88585bf76ff45b36eb309a3d00f261cc8c7f36643633d4b58e81332ccb0db9de5b2
+  data.tar.gz: 2afffbfd031029657a1ba839d6dd56c4c809d2e7ba639db27ef5a9c320a533011c93d8163dbe6c353e57db6b3219dc78716c8fc892b89ec04ed1acb6f6ef997f

data/.gitignore

@@ -8,3 +8,5 @@ spec/dummy/.sass-cache
 Gemfile.lock
 gemfiles/*.lock
 coverage/*
+.ruby-version
+.ruby-gemset

data/.travis.yml

@@ -3,17 +3,21 @@ cache: bundler
 sudo: false
 
 rvm:
-  - 2.2.7
-  - 2.3.4
+  - 2.2.8
+  - 2.3.5
 
 gemfile:
   - gemfiles/rails4.1.gemfile
   - gemfiles/rails4.2.gemfile
+  - gemfiles/rails5.0.gemfile
+  - gemfiles/rails5.1.gemfile
 
 matrix:
   include:
-    - rvm: 2.1.9
+    - rvm: 2.1.10
       gemfile: gemfiles/rails3.2.gemfile
+    - rvm: 2.4.2
+      gemfile: gemfiles/rails5.1.gemfile
   fast_finish: true
 
 notifications:

data/Appraisals

@@ -1,5 +1,6 @@
 appraise "rails3.2" do
   gem "rails", "~> 3.2.0"
+  gem "test-unit", "~> 3.0"
 end
 
 appraise "rails4.1" do
@@ -9,3 +10,11 @@ end
 appraise "rails4.2" do
   gem "rails", "~> 4.2.0"
 end
+
+appraise "rails5.0" do
+  gem "rails", "~> 5.0.0"
+end
+
+appraise "rails5.1" do
+  gem "rails", "~> 5.1.0"
+end

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+### 1.9.0 (November 30, 2017)
+
+  * Support for Rails 5.1 (#94, Thanks @krasnoukhov and @simplepractice!
+
+### 1.8.0 (August 29, 2017)
+
+  * Support for [Stripe's Webhook Signature Verification](https://stripe.com/docs/webhooks#signatures) (#83, #90, Thanks @mikeycgto!)
+  * Secure compare during basic authentication check (#91, Thanks @mikeycgto!)
+
 ### 1.7.0 (July 5, 2017)
 
   * Support stripe v3 gem as a dependency (#87)

data/gemfiles/rails3.2.gemfile

@@ -3,5 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~> 3.2.0"
+gem "test-unit", "~> 3.0"
 
-gemspec :path => "../"
+gemspec path: "../"

data/gemfiles/rails4.1.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "rails", "~> 4.1.0"
 
-gemspec :path => "../"
+gemspec path: "../"

data/gemfiles/rails4.2.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "rails", "~> 4.2.0"
 
-gemspec :path => "../"
+gemspec path: "../"

data/gemfiles/rails5.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+
+gemspec path: "../"

data/gemfiles/rails5.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.1.0"
+
+gemspec path: "../"

data/lib/stripe_event.rb

@@ -17,6 +17,10 @@ module StripeEvent
         event = event_retriever.call(params)
       rescue Stripe::AuthenticationError => e
         if params[:type] == "account.application.deauthorized"
+          if defined?(ActionController::Parameters) && params.is_a?(ActionController::Parameters)
+            params = params.permit!.to_h
+          end
+
           event = Stripe::Event.construct_from(params.deep_symbolize_keys)
         else
           raise UnauthorizedError.new(e)

data/lib/stripe_event/version.rb

@@ -1,3 +1,3 @@
 module StripeEvent
-  VERSION = "1.8.0"
+  VERSION = "1.9.0"
 end

data/spec/controllers/webhook_controller_spec.rb

@@ -1,14 +1,20 @@
 require 'rails_helper'
 require 'spec_helper'
 
-describe StripeEvent::WebhookController do
+describe StripeEvent::WebhookController, type: :controller do
   def stub_event(identifier, status = 200)
     stub_request(:get, "https://api.stripe.com/v1/events/#{identifier}").
       to_return(status: status, body: File.read("spec/support/fixtures/#{identifier}.json"))
   end
 
   def webhook(params)
-    post :event, params
+    data = if Rails::VERSION::MAJOR > 4
+      { params: params }
+    else
+      params
+    end
+
+    post :event, data
   end
 
   routes { StripeEvent::Engine.routes }
@@ -53,33 +59,33 @@ describe StripeEvent::WebhookController do
 
     expect { webhook id: 'evt_charge_succeeded' }.to raise_error(Stripe::StripeError, /testing/)
   end
-  
+
   context "with an authentication secret" do
     def webhook_with_secret(secret, params)
       request.env['HTTP_AUTHORIZATION'] = ActionController::HttpAuthentication::Basic.encode_credentials('user', secret)
       webhook params
     end
-    
+
     before(:each) { StripeEvent.authentication_secret = "secret" }
     after(:each) { StripeEvent.authentication_secret = nil }
-  
+
     it "rejects requests with no secret" do
       stub_event('evt_charge_succeeded')
-    
+
       webhook id: 'evt_charge_succeeded'
       expect(response.code).to eq '401'
     end
-  
+
     it "rejects requests with incorrect secret" do
       stub_event('evt_charge_succeeded')
-    
+
       webhook_with_secret 'incorrect', id: 'evt_charge_succeeded'
       expect(response.code).to eq '401'
     end
-  
+
     it "accepts requests with correct secret" do
       stub_event('evt_charge_succeeded')
-    
+
       webhook_with_secret 'secret', id: 'evt_charge_succeeded'
       expect(response.code).to eq '200'
     end

data/spec/dummy/config/application.rb

@@ -54,11 +54,12 @@ module Dummy
     # parameters by using an attr_accessible or attr_protected declaration.
     # config.active_record.whitelist_attributes = true
 
-    # Enable the asset pipeline
-    config.assets.enabled = true
+    if config.respond_to?(:assets)
+      # Enable the asset pipeline
+      config.assets.enabled = true
 
-    # Version of your assets, change this if you want to expire all your assets
-    config.assets.version = '1.0'
+      # Version of your assets, change this if you want to expire all your assets
+      config.assets.version = '1.0'
+    end
   end
 end
-

data/spec/lib/stripe_event_spec.rb

@@ -83,6 +83,24 @@ describe StripeEvent do
         expect(events.first[:type]).to  eq 'account.application.deauthorized'
       end
     end
+
+    # Rails 5.1 uses ActionController::Parameters which is not inherited from
+    # ActiveSupport::HashWithIndifferentAccess anymore
+    if Rails::VERSION::MAJOR > 3
+      context "with a subscriber params with indifferent access (controller params)" do
+        it "calls the subscriber with the retrieved event" do
+          StripeEvent.subscribe('account.application.deauthorized', subscriber)
+
+          StripeEvent.instrument(ActionController::Parameters.new(
+            id: 'evt_account_application_deauthorized',
+            type: 'account.application.deauthorized'
+          ))
+
+          expect(events.first.type).to    eq 'account.application.deauthorized'
+          expect(events.first[:type]).to  eq 'account.application.deauthorized'
+        end
+      end
+    end
   end
 
   describe "subscribing to a namespace of event types" do

data/stripe_event.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rails", [">= 3.1"]
   s.add_development_dependency "rake", "< 11.0"
-  s.add_development_dependency "rspec-rails", "~> 2.12"
+  s.add_development_dependency "rspec-rails", "~> 3.7"
   s.add_development_dependency "webmock", "~> 1.9"
   s.add_development_dependency "appraisal"
   s.add_development_dependency "coveralls"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe_event
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Danny Whalen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-29 00:00:00.000000000 Z
+date: 2017-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,14 +78,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -149,6 +149,8 @@ files:
 - gemfiles/rails3.2.gemfile
 - gemfiles/rails4.1.gemfile
 - gemfiles/rails4.2.gemfile
+- gemfiles/rails5.0.gemfile
+- gemfiles/rails5.1.gemfile
 - lib/stripe_event.rb
 - lib/stripe_event/engine.rb
 - lib/stripe_event/version.rb
@@ -210,7 +212,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.0
 signing_key: 
 specification_version: 4
 summary: Stripe webhook integration for Rails applications.
@@ -219,6 +221,8 @@ test_files:
 - gemfiles/rails3.2.gemfile
 - gemfiles/rails4.1.gemfile
 - gemfiles/rails4.2.gemfile
+- gemfiles/rails5.0.gemfile
+- gemfiles/rails5.1.gemfile
 - spec/controllers/webhook_controller_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile