stripe_event 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ea02ffe131e7f8b5fe2ffa94ba2c889a7b4eb00
-  data.tar.gz: 4c6c8d779fbedd63815d37a62f2cc23310fe5aa4
+  metadata.gz: b0d6619841f7069b8c12f167ffec6895a0d08fac
+  data.tar.gz: ee91d70a34cffef31c804be916a55287789b0f66
 SHA512:
-  metadata.gz: 77221858fe9843e705b89859f6a6d4c38c6e0106c0f01c7ce9ad2a83dd11927f275629feda73fb0cef500d60020e5ad888246f9df1c43441bafad958813585d3
-  data.tar.gz: 669c28fb841f16fb81b3421ca8f2cc9af14325407bb1db9d88cacaac2053c142027ff824d66ea873301aec773424329928c12117a61aa4e6bee1ad870213f615
+  metadata.gz: 746742414aab41ff384d07e1aaf4f9e548bf59f607b1a40adcfcbd4c09387810692bc3ff5f6df2b8a99d46083026ca3681c58054a5bed8ac63ac382326a38803
+  data.tar.gz: b5691cb85b28b407594a058461886ac01d8db96b4413f651cc8c3491e9488910722d57d47d485a57f43282b7642e18424614fc57420e4db0068e6494acf9e6fb

data/.travis.yml

@@ -3,6 +3,7 @@ rvm:
   - 1.9.2
   - 1.9.3
   - 2.0.0
+  - 2.1.0
   - jruby-19mode
   - jruby-head
 gemfile:

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### 1.2.0 (June 17, 2014)
+  * Gracefully authenticate `account.application.deauthorized` events. Thank you to [Ryan McGeary](https://github.com/rmm5t) for the pull request and for taking the time to test the change in a live environment.
+
 ### 1.1.0 (January 8, 2014)
   * Deprecate `StripeEvent.setup` in favor of `StripeEvent.configure`. Remove `setup` at next major release.
   * `StripeEvent.configure` yields the module to the block for configuration.

data/LICENSE.md

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright 2012-2013 Integrallis Software
+Copyright 2012-2014 Integrallis Software
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,7 +1,7 @@
 # StripeEvent
 [![Build Status](https://secure.travis-ci.org/integrallis/stripe_event.png?branch=master)](http://travis-ci.org/integrallis/stripe_event) [![Dependency Status](https://gemnasium.com/integrallis/stripe_event.png)](https://gemnasium.com/integrallis/stripe_event) [![Gem Version](https://badge.fury.io/rb/stripe_event.png)](http://badge.fury.io/rb/stripe_event) [![Code Climate](https://codeclimate.com/github/integrallis/stripe_event.png)](https://codeclimate.com/github/integrallis/stripe_event) [![Coverage Status](https://coveralls.io/repos/integrallis/stripe_event/badge.png)](https://coveralls.io/r/integrallis/stripe_event)
 
-StripeEvent is built on the [ActiveSupport::Notifications API](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html). Incoming webhook requests are authenticated by [retrieving the event object](https://stripe.com/docs/api?lang=ruby#retrieve_event) from Stripe. Define subscribers to handle a single event type or all event types. Subscribers can be a block or any object that responds to `#call`.
+StripeEvent is built on the [ActiveSupport::Notifications API](http://api.rubyonrails.org/classes/ActiveSupport/Notifications.html). Incoming webhook requests are authenticated by [retrieving the event object](https://stripe.com/docs/api?lang=ruby#retrieve_event) from Stripe. Define subscribers to handle specific event types. Subscribers can be a block or an object that responds to `#call`.
 
 ## Install
 
@@ -33,9 +33,11 @@ StripeEvent.configure do |events|
     # Handle all event types - logging, etc.
   end
 end
+```
 
-# Subscriber objects that respond to #call
+### Subscriber objects that respond to #call
 
+```ruby
 class CustomerCreated
   def call(event)
     # Event handling
@@ -43,25 +45,26 @@ class CustomerCreated
 end
 
 class BillingEventLogger
-  def initialize(logger = nil)
-    @logger = logger || begin
-      require 'logger'
-      Logger.new($stdout)
-    end
+  def initialize(logger)
+    @logger = logger
   end
 
   def call(event)
-    @logger.info "BILLING-EVENT: #{event.type} #{event.id}"
+    @logger.info "BILLING:#{event.type}:#{event.id}"
   end
 end
+```
 
+```ruby
 StripeEvent.configure do |events|
   events.all BillingEventLogger.new(Rails.logger)
   events.subscribe 'customer.created', CustomerCreated.new
 end
+```
 
-# Subscribing to a namespace of event types
+### Subscribing to a namespace of event types
 
+```ruby
 StripeEvent.subscribe 'customer.card.' do |event|
   # Will be triggered for any customer.card.* events
 end
@@ -76,9 +79,9 @@ StripeEvent.event_retriever = lambda do |params|
   api_key = Account.find_by!(stripe_user_id: params[:user_id]).api_key
   Stripe::Event.retrieve(params[:id], api_key)
 end
+```
 
-# Or use any object that responds to #call
-
+```ruby
 class EventRetriever
   def call(params)
     api_key = retrieve_api_key(params[:user_id])
@@ -119,7 +122,7 @@ end
 
 ## Testing
 
-Handling webhooks is a critical piece of modern billing systems. Verifying the behavior of StripeEvent subscribers can be done fairly easily by stubbing out the HTTP request used to authenticate the webhook request. Tools like [Webmock](https://github.com/bblimke/webmock) and [VCR](https://github.com/vcr/vcr) work well. [RequestBin](http://requestb.in/) is great for collecting the payloads. For exploratory phases of development, [UltraHook](http://www.ultrahook.com/) and other tools can forward webhook requests directly to localhost. You can check out [test-hooks](https://github.com/invisiblefunnel/test-hooks), and example Rails application to see how to test StripeEvent subscribers with RSpec request specs and Webmock. A quick look:
+Handling webhooks is a critical piece of modern billing systems. Verifying the behavior of StripeEvent subscribers can be done fairly easily by stubbing out the HTTP request used to authenticate the webhook request. Tools like [Webmock](https://github.com/bblimke/webmock) and [VCR](https://github.com/vcr/vcr) work well. [RequestBin](http://requestb.in/) is great for collecting the payloads. For exploratory phases of development, [UltraHook](http://www.ultrahook.com/) and other tools can forward webhook requests directly to localhost. You can check out [test-hooks](https://github.com/invisiblefunnel/test-hooks), an example Rails application to see how to test StripeEvent subscribers with RSpec request specs and Webmock. A quick look:
 
 ```ruby
 # spec/requests/billing_events_spec.rb
@@ -151,4 +154,4 @@ This button sends an example event to your webhook urls, including an `id` of `e
 
 ### License
 
-[MIT License](https://github.com/integrallis/stripe_event/blob/master/LICENSE.md). Copyright 2012-2013 Integrallis Software.
+[MIT License](https://github.com/integrallis/stripe_event/blob/master/LICENSE.md). Copyright 2012-2014 Integrallis Software.

data/gemfiles/rails3.1.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "rails", "~> 3.1.0"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails3.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    stripe_event (1.1.0)
+    stripe_event (1.2.0)
       activesupport (>= 3.1)
       stripe (~> 1.6)
 
@@ -113,9 +113,9 @@ GEM
       hike (~> 1.2)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    stripe (1.9.9)
+    stripe (1.11.0)
+      json (~> 1.8.1)
       mime-types (~> 1.25)
-      multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     term-ansicolor (1.2.2)
       tins (~> 0.8)

data/gemfiles/rails3.2.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "rails", "~> 3.2.0"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails3.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    stripe_event (1.1.0)
+    stripe_event (1.2.0)
       activesupport (>= 3.1)
       stripe (~> 1.6)
 
@@ -111,9 +111,9 @@ GEM
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    stripe (1.9.9)
+    stripe (1.11.0)
+      json (~> 1.8.1)
       mime-types (~> 1.25)
-      multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     term-ansicolor (1.2.2)
       tins (~> 0.8)

data/gemfiles/rails4.0.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "rails", "~> 4.0.0"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails4.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    stripe_event (1.1.0)
+    stripe_event (1.2.0)
       activesupport (>= 3.1)
       stripe (~> 1.6)
 
@@ -52,6 +52,7 @@ GEM
     erubis (2.7.0)
     hike (1.2.3)
     i18n (0.6.9)
+    json (1.8.1)
     mail (2.5.4)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
@@ -104,9 +105,9 @@ GEM
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (~> 2.8)
-    stripe (1.9.9)
+    stripe (1.11.0)
+      json (~> 1.8.1)
       mime-types (~> 1.25)
-      multi_json (>= 1.0.4, < 2)
       rest-client (~> 1.4)
     term-ansicolor (1.2.2)
       tins (~> 0.8)

data/lib/stripe_event.rb

@@ -15,6 +15,12 @@ module StripeEvent
     def instrument(params)
       begin
         event = event_retriever.call(params)
+      rescue Stripe::AuthenticationError => e
+        if params[:type] == "account.application.deauthorized"
+          event = Stripe::Event.construct_from(params.deep_symbolize_keys)
+        else
+          raise UnauthorizedError.new(e)
+        end
       rescue Stripe::StripeError => e
         raise UnauthorizedError.new(e)
       end

data/lib/stripe_event/version.rb

@@ -1,3 +1,3 @@
 module StripeEvent
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/lib/stripe_event_spec.rb

@@ -53,6 +53,38 @@ describe StripeEvent do
     end
   end
 
+  describe "subscribing to the 'account.application.deauthorized' event type" do
+    before do
+      expect(Stripe::Event).to receive(:retrieve).with('evt_account_application_deauthorized').and_raise(Stripe::AuthenticationError)
+    end
+
+    context "with a subscriber params with symbolized keys" do
+      it "calls the subscriber with the retrieved event" do
+        StripeEvent.subscribe('account.application.deauthorized', subscriber)
+
+        StripeEvent.instrument(id: 'evt_account_application_deauthorized', type: 'account.application.deauthorized')
+
+        expect(events.first.type).to    eq 'account.application.deauthorized'
+        expect(events.first[:type]).to  eq 'account.application.deauthorized'
+      end
+    end
+
+    # The Stripe api expects params to be passed into their StripeObject's
+    # with symbolized keys, but the params that we pass through from a
+    # accont.application.deauthorized webhook are a HashWithIndifferentAccess
+    # (keys stored as strings always.
+    context "with a subscriber params with indifferent access (stringified keys)" do
+      it "calls the subscriber with the retrieved event" do
+        StripeEvent.subscribe('account.application.deauthorized', subscriber)
+
+        StripeEvent.instrument({ id: 'evt_account_application_deauthorized', type: 'account.application.deauthorized' }.with_indifferent_access)
+
+        expect(events.first.type).to    eq 'account.application.deauthorized'
+        expect(events.first[:type]).to  eq 'account.application.deauthorized'
+      end
+    end
+  end
+
   describe "subscribing to a namespace of event types" do
     let(:card_created) { double('card created') }
     let(:card_updated) { double('card updated') }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe_event
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Danny Whalen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-08 00:00:00.000000000 Z
+date: 2014-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Stripe webhook integration for Rails applications.
@@ -241,4 +241,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/fixtures/evt_charge_succeeded.json
 - spec/support/fixtures/evt_invalid_id.json
-has_rdoc: