stripe 4.18.0 → 4.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa4fff8f85be6e986db2d71a6bc50c8cfaf9fd64ad838c8538d0af66e0fddf31
-  data.tar.gz: '0494e9d502030d6c2410ccc3fc921cf465a7c2863307b74e33fe7ea842666cf7'
+  metadata.gz: 9d2bc94a670bcbb6341ce794ad5415d30aece0177fc50a6a176c7a5a33083664
+  data.tar.gz: e45ad1040e1ebe11e4493a8b77c35cbe7b25bda4511a23d4c655a1a2ef3f0a0a
 SHA512:
-  metadata.gz: '07383793b058de60012ced7bebdcaee1b75a2ad6dff5df55c5cfefd933fffbdf18e1b332d7c40aaf8702067eedc41f62256daedf269d4d519f46c9b8005f7df5'
-  data.tar.gz: f7a5b758f8821c39c782c56a9472c46a104bd118af4aebd951bcef7edbe67aebd0eef779ca1fbb33fdc42de8e7f41a127d233cb48ae208e3b84d66c9e0de3178
+  metadata.gz: b4aa8383711814c62576ff737c40fb8f83e40c9c4b60753d54f7cbf42fa3d652083373d5f2d587850e9e76c8d6090ce6fa2e2408157860e108e4a6d72526fe15
+  data.tar.gz: daf904e718c62170c2f8a4da0be10b29d5c040d9a9fbbcb95ad8a57bdd91a862a6cd21aff54fa7de46aa62c9bd79097f801d6b768d4083b7dd24e34e96f6e630

data/.rubocop.yml

@@ -13,6 +13,10 @@ Layout/IndentArray:
 Layout/IndentHash:
   EnforcedStyle: consistent
 
+Metrics/LineLength:
+  Exclude:
+    - "test/**/*.rb"
+
 Metrics/MethodLength:
   # There's ~2 long methods in `StripeClient`. If we want to truncate those a
   # little, we could move this to be closer to ~30 (but the default of 10 is
@@ -22,11 +26,17 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Enabled: false
 
+Style/AccessModifierDeclarations:
+  EnforcedStyle: inline
+
 Style/FrozenStringLiteralComment:
   EnforcedStyle: always
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-03-25 18:32:26 -0700 using RuboCop version 0.50.0.
+# on 2019-05-24 10:18:48 -0700 using RuboCop version 0.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -15,7 +15,7 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Max: 498
 
-# Offense count: 9
+# Offense count: 11
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 673
@@ -24,12 +24,6 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 15
 
-# Offense count: 364
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 310
-
 # Offense count: 6
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
@@ -39,12 +33,6 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 17
 
-# Offense count: 2
-Style/ClassVars:
-  Exclude:
-    - 'lib/stripe/stripe_object.rb'
-    - 'test/stripe/api_resource_test.rb'
-
-# Offense count: 78
+# Offense count: 84
 Style/Documentation:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.18.1 - 2019-05-27
+* [#789](https://github.com/stripe/stripe-ruby/pull/789) Allow `Order#pay` to be called without arguments
+
 ## 4.18.0 - 2019-05-23
 * [#783](https://github.com/stripe/stripe-ruby/pull/783) Add support for `radar.early_fraud_warning` resource
 

data/Gemfile

@@ -18,7 +18,9 @@ group :development do
   # `Gemfile.lock` checked in, so to prevent good builds from suddenly going
   # bad, pin to a specific version number here. Try to keep this relatively
   # up-to-date, but it's not the end of the world if it's not.
-  gem "rubocop", "0.50.0"
+  # Note that 0.57.2 is the most recent version we can use until we drop
+  # support for Ruby 2.1.
+  gem "rubocop", "0.57.2"
 
   # Rack 2.0+ requires Ruby >= 2.2.2 which is problematic for the test suite on
   # older Ruby versions. Check Ruby the version here and put a maximum

data/VERSION

@@ -1 +1 @@
-4.18.0
+4.18.1

data/lib/stripe.rb

@@ -116,7 +116,7 @@ require "stripe/webhook_endpoint"
 require "stripe/oauth"
 
 module Stripe
-  DEFAULT_CA_BUNDLE_PATH = ::File.dirname(__FILE__) + "/data/ca-certificates.crt"
+  DEFAULT_CA_BUNDLE_PATH = __dir__ + "/data/ca-certificates.crt"
 
   @app_info = nil
 
@@ -143,7 +143,8 @@ module Stripe
   @enable_telemetry = false
 
   class << self
-    attr_accessor :stripe_account, :api_key, :api_base, :verify_ssl_certs, :api_version, :client_id, :connect_base, :uploads_base,
+    attr_accessor :stripe_account, :api_key, :api_base, :verify_ssl_certs,
+                  :api_version, :client_id, :connect_base, :uploads_base,
                   :open_timeout, :read_timeout, :proxy
 
     attr_reader :max_network_retry_delay, :initial_network_retry_delay
@@ -215,7 +216,8 @@ module Stripe
     end
 
     if !val.nil? && ![LEVEL_DEBUG, LEVEL_ERROR, LEVEL_INFO].include?(val)
-      raise ArgumentError, "log_level should only be set to `nil`, `debug` or `info`"
+      raise ArgumentError,
+            "log_level should only be set to `nil`, `debug` or `info`"
     end
     @log_level = val
   end

data/lib/stripe/account.rb

@@ -18,10 +18,12 @@ module Stripe
                                   operations: %i[retrieve update list],
                                   resource_plural: "capabilities"
     nested_resource_class_methods :external_account,
-                                  operations: %i[create retrieve update delete list]
+                                  operations: %i[create retrieve update delete
+                                                 list]
     nested_resource_class_methods :login_link, operations: %i[create]
     nested_resource_class_methods :person,
-                                  operations: %i[create retrieve update delete list]
+                                  operations: %i[create retrieve update delete
+                                                 list]
 
     # This method is deprecated. Please use `#external_account=` instead.
     save_nested_resource :bank_account
@@ -37,13 +39,18 @@ module Stripe
 
     # @override To make id optional
     def self.retrieve(id = ARGUMENT_NOT_PROVIDED, opts = {})
-      id = id.equal?(ARGUMENT_NOT_PROVIDED) ? nil : Util.check_string_argument!(id)
+      id = if id.equal?(ARGUMENT_NOT_PROVIDED)
+             nil
+           else
+             Util.check_string_argument!(id)
+           end
 
       # Account used to be a singleton, where this method's signature was
       # `(opts={})`. For the sake of not breaking folks who pass in an OAuth
       # key in opts, let's lurkily string match for it.
       if opts == {} && id.is_a?(String) && id.start_with?("sk_")
-        # `super` properly assumes a String opts is the apiKey and normalizes as expected.
+        # `super` properly assumes a String opts is the apiKey and normalizes
+        # as expected.
         opts = id
         id = nil
       end
@@ -55,8 +62,9 @@ module Stripe
       Util.convert_to_stripe_object(resp.data, opts)
     end
 
-    # We are not adding a helper for capabilities here as the Account object already has a
-    # capabilities property which is a hash and not the sub-list of capabilities.
+    # We are not adding a helper for capabilities here as the Account object
+    # already has a capabilities property which is a hash and not the sub-list
+    # of capabilities.
 
     def reject(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/reject", params, opts)
@@ -114,8 +122,11 @@ module Stripe
       self["legal_entity"]
     end
 
-    def legal_entity=(_)
-      raise NoMethodError, 'Overriding legal_entity can cause serious issues. Instead, set the individual fields of legal_entity like blah.legal_entity.first_name = \'Blah\''
+    def legal_entity=(_legal_entity)
+      raise NoMethodError,
+            "Overriding legal_entity can cause serious issues. Instead, set " \
+            "the individual fields of legal_entity like " \
+            "`account.legal_entity.first_name = 'Blah'`"
     end
 
     def deauthorize(client_id = nil, opts = {})
@@ -128,15 +139,17 @@ module Stripe
 
     ARGUMENT_NOT_PROVIDED = Object.new
 
-    private
-
-    def serialize_additional_owners(legal_entity, additional_owners)
-      original_value = legal_entity.instance_variable_get(:@original_values)[:additional_owners]
+    private def serialize_additional_owners(legal_entity, additional_owners)
+      original_value =
+        legal_entity
+        .instance_variable_get(:@original_values)[:additional_owners]
       if original_value && original_value.length > additional_owners.length
         # url params provide no mechanism for deleting an item in an array,
         # just overwriting the whole array or adding new items. So let's not
         # allow deleting without a full overwrite until we have a solution.
-        raise ArgumentError, "You cannot delete an item from an array, you must instead set a new array"
+        raise ArgumentError,
+              "You cannot delete an item from an array, you must instead " \
+              "set a new array"
       end
 
       update_hash = {}
@@ -148,10 +161,11 @@ module Stripe
         # StripeObject.
         update = v.is_a?(StripeObject) ? v.serialize_params : v
 
-        if update != {} && (!original_value ||
-          update != legal_entity.serialize_params_value(original_value[i], nil, false, true))
-          update_hash[i.to_s] = update
-        end
+        next unless update != {} && (!original_value ||
+          update != legal_entity.serialize_params_value(original_value[i], nil,
+                                                        false, true))
+
+        update_hash[i.to_s] = update
       end
       update_hash
     end

data/lib/stripe/alipay_account.rb

@@ -13,15 +13,22 @@ module Stripe
               "Alipay accounts cannot be accessed without a customer ID."
       end
 
-      "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
+      "#{Customer.resource_url}/#{CGI.escape(customer)}/sources" \
+      "/#{CGI.escape(id)}"
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Alipay accounts cannot be updated without a customer ID. Update an Alipay account by `a = customer.sources.retrieve('alipay_account_id'); a.save`"
+      raise NotImplementedError,
+            "Alipay accounts cannot be updated without a customer ID. " \
+            "Update an Alipay account using `Customer.update_source(" \
+            "'customer_id', 'alipay_account_id', update_params)`"
     end
 
     def self.retrieve(_id, _opts = nil)
-      raise NotImplementedError, "Alipay accounts cannot be retrieved without a customer ID. Retrieve an Alipay account using customer.sources.retrieve('alipay_account_id')"
+      raise NotImplementedError,
+            "Alipay accounts cannot be retrieved without a customer ID. " \
+            "Retrieve an Alipay account using `Customer.retrieve_source(" \
+            "'customer_id', 'alipay_account_id')`"
     end
   end
 end

data/lib/stripe/api_operations/nested_resource.rb

@@ -10,7 +10,8 @@ module Stripe
     # methods `.create_reversal`, `.retrieve_reversal`, `.update_reversal`,
     # etc. all become available.
     module NestedResource
-      def nested_resource_class_methods(resource, path: nil, operations: nil, resource_plural: nil)
+      def nested_resource_class_methods(resource, path: nil, operations: nil,
+                                        resource_plural: nil)
         resource_plural ||= "#{resource}s"
         path ||= resource_plural
         raise ArgumentError, "operations array required" if operations.nil?
@@ -25,31 +26,36 @@ module Stripe
         operations.each do |operation|
           case operation
           when :create
-            define_singleton_method(:"create_#{resource}") do |id, params = {}, opts = {}|
+            define_singleton_method(:"create_#{resource}") \
+                do |id, params = {}, opts = {}|
               url = send(resource_url_method, id)
               resp, opts = request(:post, url, params, opts)
               Util.convert_to_stripe_object(resp.data, opts)
             end
           when :retrieve
-            define_singleton_method(:"retrieve_#{resource}") do |id, nested_id, opts = {}|
+            define_singleton_method(:"retrieve_#{resource}") \
+                do |id, nested_id, opts = {}|
               url = send(resource_url_method, id, nested_id)
               resp, opts = request(:get, url, {}, opts)
               Util.convert_to_stripe_object(resp.data, opts)
             end
           when :update
-            define_singleton_method(:"update_#{resource}") do |id, nested_id, params = {}, opts = {}|
+            define_singleton_method(:"update_#{resource}") \
+                do |id, nested_id, params = {}, opts = {}|
               url = send(resource_url_method, id, nested_id)
               resp, opts = request(:post, url, params, opts)
               Util.convert_to_stripe_object(resp.data, opts)
             end
           when :delete
-            define_singleton_method(:"delete_#{resource}") do |id, nested_id, params = {}, opts = {}|
+            define_singleton_method(:"delete_#{resource}") \
+                do |id, nested_id, params = {}, opts = {}|
               url = send(resource_url_method, id, nested_id)
               resp, opts = request(:delete, url, params, opts)
               Util.convert_to_stripe_object(resp.data, opts)
             end
           when :list
-            define_singleton_method(:"list_#{resource_plural}") do |id, params = {}, opts = {}|
+            define_singleton_method(:"list_#{resource_plural}") \
+                do |id, params = {}, opts = {}|
               url = send(resource_url_method, id)
               resp, opts = request(:get, url, params, opts)
               Util.convert_to_stripe_object(resp.data, opts)

data/lib/stripe/api_operations/request.rb

@@ -31,12 +31,10 @@ module Stripe
           [resp, opts_to_persist]
         end
 
-        private
-
-        def warn_on_opts_in_params(params)
+        private def warn_on_opts_in_params(params)
           Util::OPTS_USER_SPECIFIED.each do |opt|
             if params.key?(opt)
-              $stderr.puts("WARNING: #{opt} should be in opts instead of params.")
+              warn("WARNING: #{opt} should be in opts instead of params.")
             end
           end
         end
@@ -46,9 +44,7 @@ module Stripe
         base.extend(ClassMethods)
       end
 
-      protected
-
-      def request(method, url, params = {}, opts = {})
+      protected def request(method, url, params = {}, opts = {})
         opts = @opts.merge(Util.normalize_opts(opts))
         self.class.request(method, url, params, opts)
       end

data/lib/stripe/api_operations/save.rb

@@ -76,9 +76,7 @@ module Stripe
         base.extend(ClassMethods)
       end
 
-      private
-
-      def save_url
+      private def save_url
         # This switch essentially allows us "upsert"-like functionality. If the
         # API resource doesn't have an ID set (suggesting that it's new) and
         # its class responds to .create (which comes from

data/lib/stripe/api_resource.rb

@@ -17,7 +17,9 @@ module Stripe
 
     def self.resource_url
       if self == APIResource
-        raise NotImplementedError, "APIResource is an abstract class.  You should perform actions on its subclasses (Charge, Customer, etc.)"
+        raise NotImplementedError,
+              "APIResource is an abstract class. You should perform actions " \
+              "on its subclasses (Charge, Customer, etc.)"
       end
       # Namespaces are separated in object names with periods (.) and in URLs
       # with forward slashes (/), so replace the former with the latter.
@@ -62,7 +64,9 @@ module Stripe
     # will send a POST request to `/v1/<object_name>/capture`.
     def self.custom_method(name, http_verb:, http_path: nil)
       unless %i[get post delete].include?(http_verb)
-        raise ArgumentError, "Invalid http_verb value: #{http_verb.inspect}. Should be one of :get, :post or :delete."
+        raise ArgumentError,
+              "Invalid http_verb value: #{http_verb.inspect}. Should be one " \
+              "of :get, :post or :delete."
       end
       http_path ||= name.to_s
       define_singleton_method(name) do |id, params = {}, opts = {}|
@@ -74,7 +78,11 @@ module Stripe
 
     def resource_url
       unless (id = self["id"])
-        raise InvalidRequestError.new("Could not determine which URL to request: #{self.class} instance has invalid ID: #{id.inspect}", "id")
+        raise InvalidRequestError.new(
+          "Could not determine which URL to request: #{self.class} instance " \
+          "has invalid ID: #{id.inspect}",
+          "id"
+        )
       end
       "#{self.class.resource_url}/#{CGI.escape(id)}"
     end

data/lib/stripe/application_fee.rb

@@ -7,7 +7,8 @@ module Stripe
 
     OBJECT_NAME = "application_fee".freeze
 
-    nested_resource_class_methods :refund, operations: %i[create retrieve update list]
+    nested_resource_class_methods :refund,
+                                  operations: %i[create retrieve update list]
 
     # If you don't need access to an updated fee object after the refund, it's
     # more performant to just call `fee.refunds.create` directly.

data/lib/stripe/application_fee_refund.rb

@@ -8,15 +8,23 @@ module Stripe
     OBJECT_NAME = "fee_refund".freeze
 
     def resource_url
-      "#{ApplicationFee.resource_url}/#{CGI.escape(fee)}/refunds/#{CGI.escape(id)}"
+      "#{ApplicationFee.resource_url}/#{CGI.escape(fee)}/refunds" \
+      "/#{CGI.escape(id)}"
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Refunds cannot be updated without an application fee ID. Update a refund by using `a = appfee.refunds.retrieve('refund_id'); a.save`"
+      raise NotImplementedError,
+            "Application fee refunds cannot be updated without an " \
+            "application fee ID. Update an application fee refund using " \
+            "`ApplicationFee.update_refund('fee_id', 'refund_id', " \
+            "update_params)`"
     end
 
     def self.retrieve(_id, _api_key = nil)
-      raise NotImplementedError, "Refunds cannot be retrieved without an application fee ID. Retrieve a refund using appfee.refunds.retrieve('refund_id')"
+      raise NotImplementedError,
+            "Application fee refunds cannot be retrieved without an " \
+            "application fee ID. Retrieve an application fee refund using " \
+            "`ApplicationFee.retrieve_refund('fee_id', 'refund_id')`"
     end
   end
 end

data/lib/stripe/bank_account.rb

@@ -15,18 +15,30 @@ module Stripe
 
     def resource_url
       if respond_to?(:customer)
-        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
+        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources" \
+        "/#{CGI.escape(id)}"
       elsif respond_to?(:account)
-        "#{Account.resource_url}/#{CGI.escape(account)}/external_accounts/#{CGI.escape(id)}"
+        "#{Account.resource_url}/#{CGI.escape(account)}/external_accounts" \
+        "/#{CGI.escape(id)}"
       end
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Bank accounts cannot be updated without an account ID. Update a bank account by using `a = account.external_accounts.retrieve('card_id'); a.save`"
+      raise NotImplementedError,
+            "Bank accounts cannot be updated without a customer ID or an " \
+            " account ID. Update a bank account using " \
+            "`Customer.update_source('customer_id', 'bank_account_id', " \
+            "update_params)` or `Account.update_external_account(" \
+            "'account_id', 'bank_account_id', update_params)`"
     end
 
     def self.retrieve(_id, _opts = nil)
-      raise NotImplementedError, "Bank accounts cannot be retrieved without an account ID. Retrieve a bank account using account.external_accounts.retrieve('card_id')"
+      raise NotImplementedError,
+            "Bank accounts cannot be retrieve without a customer ID or an " \
+            "account ID. Retrieve a bank account using " \
+            "`Customer.retrieve_source('customer_id', 'bank_account_id')` " \
+            "or `Account.retrieve_external_account('account_id', " \
+            "'bank_account_id')`"
     end
   end
 end