stripe 4.18.0 → 4.18.1

data/lib/stripe/bitcoin_receiver.rb

@@ -14,7 +14,8 @@ module Stripe
 
     def resource_url
       if respond_to?(:customer) && !customer.nil? && customer != ""
-        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
+        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources" \
+        "/#{CGI.escape(id)}"
       else
         "#{self.class.resource_url}/#{CGI.escape(id)}"
       end

data/lib/stripe/capability.rb

@@ -12,15 +12,22 @@ module Stripe
         raise NotImplementedError,
               "Capabilities cannot be accessed without an account ID."
       end
-      "#{Account.resource_url}/#{CGI.escape(account)}/capabilities/#{CGI.escape(id)}"
+      "#{Account.resource_url}/#{CGI.escape(account)}/capabilities" \
+      "/#{CGI.escape(id)}"
     end
 
     def self.retrieve(_id, _opts = {})
-      raise NotImplementedError, "Capabilities cannot be retrieved without an account ID. Retrieve a capability using account.retrieve_capability('acct_123', 'acap_123')"
+      raise NotImplementedError,
+            "Capabilities cannot be retrieve without an account ID. " \
+            "Retrieve a capability using Account.retrieve_capability(" \
+            "'account_id', 'capability_id')`"
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Capabilities cannot be updated without an account ID. Update a capability using `p = account.update_capability('acct_123', 'acap_123', params)"
+      raise NotImplementedError,
+            "Capabilities cannot be updated without an account ID. Update a " \
+            "capability using Account.update_capability('account_id', " \
+            "'capability_id', update_params)`"
     end
   end
 end

data/lib/stripe/card.rb

@@ -10,20 +10,31 @@ module Stripe
 
     def resource_url
       if respond_to?(:recipient) && !recipient.nil? && !recipient.empty?
-        "#{Recipient.resource_url}/#{CGI.escape(recipient)}/cards/#{CGI.escape(id)}"
+        "#{Recipient.resource_url}/#{CGI.escape(recipient)}/cards" \
+        "/#{CGI.escape(id)}"
       elsif respond_to?(:customer) && !customer.nil? && !customer.empty?
-        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
+        "#{Customer.resource_url}/#{CGI.escape(customer)}/sources" \
+        "/#{CGI.escape(id)}"
       elsif respond_to?(:account) && !account.nil? && !account.empty?
-        "#{Account.resource_url}/#{CGI.escape(account)}/external_accounts/#{CGI.escape(id)}"
+        "#{Account.resource_url}/#{CGI.escape(account)}/external_accounts" \
+        "/#{CGI.escape(id)}"
       end
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Cards cannot be updated without a customer ID. Update a card using `c = customer.sources.retrieve('card_id'); c.save`"
+      raise NotImplementedError,
+            "Card cannot be updated without a customer ID or an account ID. " \
+            "Update a card using `Customer.update_source('customer_id', " \
+            "'card_id', update_params)` or `Account.update_external_account(" \
+            "'account_id', 'card_id', update_params)`"
     end
 
     def self.retrieve(_id, _opts = nil)
-      raise NotImplementedError, "Cards cannot be retrieved without a customer ID. Retrieve a card using customer.sources.retrieve('card_id')"
+      raise NotImplementedError,
+            "Card cannot be retrieved without a customer ID or an account " \
+            "ID. Retrieve a card using `Customer.retrieve_source(" \
+            "'customer_id', 'card_id')` or " \
+            "`Account.retrieve_external_account('account_id', 'card_id')`"
     end
   end
 end

data/lib/stripe/charge.rb

@@ -63,23 +63,21 @@ module Stripe
       initialize_from(resp.data, opts)
     end
 
-    private
-
-    def capture_url
+    private def capture_url
       resource_url + "/capture"
     end
 
-    def dispute_url
+    private def dispute_url
       resource_url + "/dispute"
     end
 
-    def close_dispute_url
+    private def close_dispute_url
       resource_url + "/dispute/close"
     end
 
     # Note that this is actually the *old* refund URL and its use is no longer
     # preferred.
-    def refund_url
+    private def refund_url
       resource_url + "/refund"
     end
   end

data/lib/stripe/customer.rb

@@ -14,8 +14,8 @@ module Stripe
 
     save_nested_resource :source
     nested_resource_class_methods :source,
-                                  operations: %i[create retrieve update delete list]
-
+                                  operations: %i[create retrieve update delete
+                                                 list]
     nested_resource_class_methods :tax_id,
                                   operations: %i[create retrieve delete list]
 
@@ -78,17 +78,15 @@ module Stripe
       initialize_from({ discount: nil }, opts, true)
     end
 
-    private
-
-    def discount_url
+    private def discount_url
       resource_url + "/discount"
     end
 
-    def subscription_url
+    private def subscription_url
       resource_url + "/subscription"
     end
 
-    def subscriptions_url
+    private def subscriptions_url
       resource_url + "/subscriptions"
     end
   end

data/lib/stripe/ephemeral_key.rb

@@ -9,7 +9,10 @@ module Stripe
 
     def self.create(params = {}, opts = {})
       opts = Util.normalize_opts(opts)
-      raise ArgumentError, "stripe_version must be specified to create an ephemeral key" unless opts[:stripe_version]
+      unless opts[:stripe_version]
+        raise ArgumentError,
+              "stripe_version must be specified to create an ephemeral key"
+      end
       super
     end
   end

data/lib/stripe/errors.rb

@@ -18,8 +18,8 @@ module Stripe
     attr_reader :request_id
 
     # Initializes a StripeError.
-    def initialize(message = nil, http_status: nil, http_body: nil, json_body: nil,
-                   http_headers: nil, code: nil)
+    def initialize(message = nil, http_status: nil, http_body: nil,
+                   json_body: nil, http_headers: nil, code: nil)
       @message = message
       @http_status = http_status
       @http_body = http_body
@@ -60,8 +60,8 @@ module Stripe
     attr_reader :param
 
     # TODO: make code a keyword arg in next major release
-    def initialize(message, param, code, http_status: nil, http_body: nil, json_body: nil,
-                   http_headers: nil)
+    def initialize(message, param, code, http_status: nil, http_body: nil,
+                   json_body: nil, http_headers: nil)
       super(message, http_status: http_status, http_body: http_body,
                      json_body: json_body, http_headers: http_headers,
                      code: code)
@@ -79,8 +79,8 @@ module Stripe
   class InvalidRequestError < StripeError
     attr_accessor :param
 
-    def initialize(message, param, http_status: nil, http_body: nil, json_body: nil,
-                   http_headers: nil, code: nil)
+    def initialize(message, param, http_status: nil, http_body: nil,
+                   json_body: nil, http_headers: nil, code: nil)
       super(message, http_status: http_status, http_body: http_body,
                      json_body: json_body, http_headers: http_headers,
                      code: code)
@@ -113,8 +113,8 @@ module Stripe
   module OAuth
     # OAuthError is raised when the OAuth API returns an error.
     class OAuthError < StripeError
-      def initialize(code, description, http_status: nil, http_body: nil, json_body: nil,
-                     http_headers: nil)
+      def initialize(code, description, http_status: nil, http_body: nil,
+                     json_body: nil, http_headers: nil)
         super(description, http_status: http_status, http_body: http_body,
                            json_body: json_body, http_headers: http_headers,
                            code: code)

data/lib/stripe/invoice.rb

@@ -21,7 +21,8 @@ module Stripe
     end
 
     def mark_uncollectible(params = {}, opts = {})
-      resp, opts = request(:post, resource_url + "/mark_uncollectible", params, opts)
+      resp, opts = request(:post, resource_url + "/mark_uncollectible", params,
+                           opts)
       initialize_from(resp.data, opts)
     end
 

data/lib/stripe/list_object.rb

@@ -26,12 +26,16 @@ module Stripe
       self.filters = {}
     end
 
-    def [](k)
-      case k
+    def [](key)
+      case key
       when String, Symbol
         super
       else
-        raise ArgumentError, "You tried to access the #{k.inspect} index, but ListObject types only support String keys. (HINT: List calls return an object with a 'data' (which is the data array). You likely want to call #data[#{k.inspect}])"
+        raise ArgumentError,
+              "You tried to access the #{key.inspect} index, but ListObject " \
+              "types only support String keys. (HINT: List calls return an " \
+              "object with a 'data' (which is the data array). You likely " \
+              "want to call #data[#{key.inspect}])"
       end
     end
 
@@ -68,7 +72,8 @@ module Stripe
 
     def retrieve(id, opts = {})
       id, retrieve_params = Util.normalize_id(id)
-      resp, opts = request(:get, "#{resource_url}/#{CGI.escape(id)}", retrieve_params, opts)
+      resp, opts = request(:get, "#{resource_url}/#{CGI.escape(id)}",
+                           retrieve_params, opts)
       Util.convert_to_stripe_object(resp.data, opts)
     end
 

data/lib/stripe/login_link.rb

@@ -5,7 +5,10 @@ module Stripe
     OBJECT_NAME = "login_link".freeze
 
     def self.retrieve(_id, _opts = nil)
-      raise NotImplementedError, "Login links do not have IDs and cannot be retrieved. They can only be created using accounts.login_links.create"
+      raise NotImplementedError,
+            "Login links do not have IDs and cannot be retrieved. They can " \
+            "only be created using `Account.create_login_link('account_id', " \
+            "create_params)`"
     end
   end
 end

data/lib/stripe/order.rb

@@ -11,7 +11,7 @@ module Stripe
     custom_method :pay, http_verb: :post
     custom_method :return_order, http_verb: :post, http_path: "returns"
 
-    def pay(params, opts = {})
+    def pay(params = {}, opts = {})
       resp, opts = request(:post, pay_url, params, opts)
       initialize_from(resp.data, opts)
     end
@@ -21,13 +21,11 @@ module Stripe
       Util.convert_to_stripe_object(resp.data, opts)
     end
 
-    private
-
-    def pay_url
+    private def pay_url
       resource_url + "/pay"
     end
 
-    def returns_url
+    private def returns_url
       resource_url + "/returns"
     end
   end

data/lib/stripe/person.rb

@@ -16,11 +16,16 @@ module Stripe
     end
 
     def self.retrieve(_id, _opts = {})
-      raise NotImplementedError, "Persons cannot be retrieved without an account ID. Retrieve a person using account.persons.retrieve('person_id')"
+      raise NotImplementedError,
+            "Persons cannot be retrieved without an account ID. Retrieve a " \
+            "person using `Account.retrieve_person('account_id', 'person_id')`"
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Persons cannot be updated without an account ID. Update a person using `p = account.persons.retrieve('person_id'); p.save`"
+      raise NotImplementedError,
+            "Persons cannot be updated without an account ID. Update a " \
+            "person using `Account.update_person('account_id', 'person_id', " \
+            "update_params)`"
     end
   end
 end

data/lib/stripe/reversal.rb

@@ -8,15 +8,22 @@ module Stripe
     OBJECT_NAME = "transfer_reversal".freeze
 
     def resource_url
-      "#{Transfer.resource_url}/#{CGI.escape(transfer)}/reversals/#{CGI.escape(id)}"
+      "#{Transfer.resource_url}/#{CGI.escape(transfer)}/reversals" \
+      "/#{CGI.escape(id)}"
     end
 
     def self.update(_id, _params = nil, _opts = nil)
-      raise NotImplementedError, "Reversals cannot be updated without a transfer ID. Update a reversal using `r = transfer.reversals.retrieve('reversal_id'); r.save`"
+      raise NotImplementedError,
+            "Reversals cannot be updated without a transfer ID. Update a " \
+            "reversal using `r = Transfer.update_reversal('transfer_id', " \
+            "'reversal_id', update_params)`"
     end
 
     def self.retrieve(_id, _opts = {})
-      raise NotImplementedError, "Reversals cannot be retrieved without a transfer ID. Retrieve a reversal using transfer.reversals.retrieve('reversal_id')"
+      raise NotImplementedError,
+            "Reversals cannot be retrieved without a transfer ID. Retrieve " \
+             "a reversal using `Transfer.retrieve_reversal('transfer_id', " \
+             "'reversal_id')`"
     end
   end
 end

data/lib/stripe/singleton_api_resource.rb

@@ -4,7 +4,9 @@ module Stripe
   class SingletonAPIResource < APIResource
     def self.resource_url
       if self == SingletonAPIResource
-        raise NotImplementedError, "SingletonAPIResource is an abstract class.  You should perform actions on its subclasses (Account, etc.)"
+        raise NotImplementedError,
+              "SingletonAPIResource is an abstract class. You should " \
+              "perform actions on its subclasses (Balance, etc.)"
       end
       # Namespaces are separated in object names with periods (.) and in URLs
       # with forward slashes (/), so replace the former with the latter.

data/lib/stripe/source.rb

@@ -16,7 +16,8 @@ module Stripe
               "to a customer object."
       end
 
-      url = "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
+      url = "#{Customer.resource_url}/#{CGI.escape(customer)}/sources" \
+            "/#{CGI.escape(id)}"
       resp, opts = request(:delete, url, params, opts)
       initialize_from(resp.data, opts)
     end
@@ -28,7 +29,8 @@ module Stripe
     deprecate :delete, "#detach", 2017, 10
 
     def source_transactions(params = {}, opts = {})
-      resp, opts = request(:get, resource_url + "/source_transactions", params, opts)
+      resp, opts = request(:get, resource_url + "/source_transactions", params,
+                           opts)
       Util.convert_to_stripe_object(resp.data, opts)
     end
 

data/lib/stripe/stripe_client.rb

@@ -20,7 +20,8 @@ module Stripe
     end
 
     def self.default_client
-      Thread.current[:stripe_client_default_client] ||= StripeClient.new(default_conn)
+      Thread.current[:stripe_client_default_client] ||=
+        StripeClient.new(default_conn)
     end
 
     # A default Faraday connection to be used when one isn't configured. This
@@ -55,9 +56,10 @@ module Stripe
 
           unless @verify_ssl_warned
             @verify_ssl_warned = true
-            $stderr.puts("WARNING: Running without SSL cert verification. " \
+            warn("WARNING: Running without SSL cert verification. " \
               "You should never do this in production. " \
-              "Execute 'Stripe.verify_ssl_certs = true' to enable verification.")
+              "Execute `Stripe.verify_ssl_certs = true` to enable " \
+              "verification.")
           end
         end
 
@@ -65,23 +67,23 @@ module Stripe
       end
     end
 
-    # Checks if an error is a problem that we should retry on. This includes both
-    # socket errors that may represent an intermittent problem and some special
-    # HTTP statuses.
-    def self.should_retry?(e, num_retries)
+    # Checks if an error is a problem that we should retry on. This includes
+    # both socket errors that may represent an intermittent problem and some
+    # special HTTP statuses.
+    def self.should_retry?(error, num_retries)
       return false if num_retries >= Stripe.max_network_retries
 
       # Retry on timeout-related problems (either on open or read).
-      return true if e.is_a?(Faraday::TimeoutError)
+      return true if error.is_a?(Faraday::TimeoutError)
 
       # Destination refused the connection, the connection was reset, or a
       # variety of other connection failures. This could occur from a single
       # saturated server, so retry in case it's intermittent.
-      return true if e.is_a?(Faraday::ConnectionFailed)
+      return true if error.is_a?(Faraday::ConnectionFailed)
 
-      if e.is_a?(Faraday::ClientError) && e.response
+      if error.is_a?(Faraday::ClientError) && error.response
         # 409 conflict
-        return true if e.response[:status] == 409
+        return true if error.response[:status] == 409
       end
 
       false
@@ -89,12 +91,15 @@ module Stripe
 
     def self.sleep_time(num_retries)
       # Apply exponential backoff with initial_network_retry_delay on the
-      # number of num_retries so far as inputs. Do not allow the number to exceed
-      # max_network_retry_delay.
-      sleep_seconds = [Stripe.initial_network_retry_delay * (2**(num_retries - 1)), Stripe.max_network_retry_delay].min
-
-      # Apply some jitter by randomizing the value in the range of (sleep_seconds
-      # / 2) to (sleep_seconds).
+      # number of num_retries so far as inputs. Do not allow the number to
+      # exceed max_network_retry_delay.
+      sleep_seconds = [
+        Stripe.initial_network_retry_delay * (2**(num_retries - 1)),
+        Stripe.max_network_retry_delay,
+      ].min
+
+      # Apply some jitter by randomizing the value in the range of
+      # (sleep_seconds / 2) to (sleep_seconds).
       sleep_seconds *= (0.5 * (1 + rand))
 
       # But never sleep less than the base sleep seconds.
@@ -170,7 +175,9 @@ module Stripe
       context.idempotency_key = headers["Idempotency-Key"]
       context.method          = method
       context.path            = path
-      context.query_params    = query_params ? params_encoder.encode(query_params) : nil
+      context.query_params    = if query_params
+                                  params_encoder.encode(query_params)
+                                end
 
       # note that both request body and query params will be passed through
       # `FaradayStripeEncoder`
@@ -194,8 +201,6 @@ module Stripe
       [resp, api_key]
     end
 
-    private
-
     # Used to workaround buggy behavior in Faraday: the library will try to
     # reshape anything that we pass to `req.params` with one of its default
     # encoders. I don't think this process is supposed to be lossy, but it is
@@ -227,21 +232,22 @@ module Stripe
 
       # We should never need to do this so it's not implemented.
       def decode(_str)
-        raise NotImplementedError, "#{self.class.name} does not implement #decode"
+        raise NotImplementedError,
+              "#{self.class.name} does not implement #decode"
       end
     end
 
-    def api_url(url = "", api_base = nil)
+    private def api_url(url = "", api_base = nil)
       (api_base || Stripe.api_base) + url
     end
 
-    def check_api_key!(api_key)
+    private def check_api_key!(api_key)
       unless api_key
         raise AuthenticationError, "No API key provided. " \
           'Set your API key using "Stripe.api_key = <API-KEY>". ' \
           "You can generate API keys from the Stripe web interface. " \
-          "See https://stripe.com/api for details, or email support@stripe.com " \
-          "if you have any questions."
+          "See https://stripe.com/api for details, or email " \
+          "support@stripe.com if you have any questions."
       end
 
       return unless api_key =~ /\s/
@@ -252,7 +258,7 @@ module Stripe
         "email support@stripe.com if you have any questions.)"
     end
 
-    def execute_request_with_rescues(api_base, context)
+    private def execute_request_with_rescues(api_base, context)
       num_retries = 0
       begin
         request_start = Time.now
@@ -263,12 +269,13 @@ module Stripe
 
         if Stripe.enable_telemetry? && context.request_id
           request_duration_ms = ((Time.now - request_start) * 1000).to_int
-          @last_request_metrics = StripeRequestMetrics.new(context.request_id, request_duration_ms)
+          @last_request_metrics =
+            StripeRequestMetrics.new(context.request_id, request_duration_ms)
         end
 
       # We rescue all exceptions from a request so that we have an easy spot to
-      # implement our retry logic across the board. We'll re-raise if it's a type
-      # of exception that we didn't expect to handle.
+      # implement our retry logic across the board. We'll re-raise if it's a
+      # type of exception that we didn't expect to handle.
       rescue StandardError => e
         # If we modify context we copy it into a new variable so as not to
         # taint the original on a retry.
@@ -306,7 +313,7 @@ module Stripe
       resp
     end
 
-    def general_api_error(status, body)
+    private def general_api_error(status, body)
       APIError.new("Invalid response object from API: #{body.inspect} " \
                    "(HTTP response code was #{status})",
                    http_status: status, http_body: body)
@@ -316,14 +323,14 @@ module Stripe
     # end of a User-Agent string where it'll be fairly prominent in places like
     # the Dashboard. Note that this formatting has been implemented to match
     # other libraries, and shouldn't be changed without universal consensus.
-    def format_app_info(info)
+    private def format_app_info(info)
       str = info[:name]
       str = "#{str}/#{info[:version]}" unless info[:version].nil?
       str = "#{str} (#{info[:url]})" unless info[:url].nil?
       str
     end
 
-    def handle_error_response(http_resp, context)
+    private def handle_error_response(http_resp, context)
       begin
         resp = StripeResponse.from_faraday_hash(http_resp)
         error_data = resp.data[:error]
@@ -343,7 +350,7 @@ module Stripe
       raise(error)
     end
 
-    def specific_api_error(resp, error_data, context)
+    private def specific_api_error(resp, error_data, context)
       Util.log_error("Stripe API error",
                      status: resp.http_status,
                      error_code: error_data[:code],
@@ -395,7 +402,7 @@ module Stripe
 
     # Attempts to look at a response's error code and return an OAuth error if
     # one matches. Will return `nil` if the code isn't recognized.
-    def specific_oauth_error(resp, error_code, context)
+    private def specific_oauth_error(resp, error_code, context)
       description = resp.data[:error_description] || error_code
 
       Util.log_error("Stripe OAuth error",
@@ -411,12 +418,18 @@ module Stripe
       },]
 
       case error_code
-      when "invalid_client"            then OAuth::InvalidClientError.new(*args)
-      when "invalid_grant"             then OAuth::InvalidGrantError.new(*args)
-      when "invalid_request"           then OAuth::InvalidRequestError.new(*args)
-      when "invalid_scope"             then OAuth::InvalidScopeError.new(*args)
-      when "unsupported_grant_type"    then OAuth::UnsupportedGrantTypeError.new(*args)
-      when "unsupported_response_type" then OAuth::UnsupportedResponseTypeError.new(*args)
+      when "invalid_client"
+        OAuth::InvalidClientError.new(*args)
+      when "invalid_grant"
+        OAuth::InvalidGrantError.new(*args)
+      when "invalid_request"
+        OAuth::InvalidRequestError.new(*args)
+      when "invalid_scope"
+        OAuth::InvalidScopeError.new(*args)
+      when "unsupported_grant_type"
+        OAuth::UnsupportedGrantTypeError.new(*args)
+      when "unsupported_response_type"
+        OAuth::UnsupportedResponseTypeError.new(*args)
       else
         # We'd prefer that all errors are typed, but we create a generic
         # OAuthError in case we run into a code that we don't recognize.
@@ -424,30 +437,33 @@ module Stripe
       end
     end
 
-    def handle_network_error(e, context, num_retries, api_base = nil)
+    private def handle_network_error(error, context, num_retries,
+                                     api_base = nil)
       Util.log_error("Stripe network error",
-                     error_message: e.message,
+                     error_message: error.message,
                      idempotency_key: context.idempotency_key,
                      request_id: context.request_id)
 
-      case e
+      case error
       when Faraday::ConnectionFailed
-        message = "Unexpected error communicating when trying to connect to Stripe. " \
-          "You may be seeing this message because your DNS is not working. " \
-          "To check, try running 'host stripe.com' from the command line."
+        message = "Unexpected error communicating when trying to connect to " \
+          "Stripe. You may be seeing this message because your DNS is not" \
+          "working.  To check, try running `host stripe.com` from the " \
+          "command line."
 
       when Faraday::SSLError
-        message = "Could not establish a secure connection to Stripe, you may " \
-                  "need to upgrade your OpenSSL version. To check, try running " \
-                  "'openssl s_client -connect api.stripe.com:443' from the " \
-                  "command line."
+        message = "Could not establish a secure connection to Stripe, you " \
+          "may need to upgrade your OpenSSL version. To check, try running " \
+          "`openssl s_client -connect api.stripe.com:443` from the command " \
+          "line."
 
       when Faraday::TimeoutError
         api_base ||= Stripe.api_base
         message = "Could not connect to Stripe (#{api_base}). " \
           "Please check your internet connection and try again. " \
-          "If this problem persists, you should check Stripe's service status at " \
-          "https://twitter.com/stripestatus, or let us know at support@stripe.com."
+          "If this problem persists, you should check Stripe's service " \
+          "status at https://status.stripe.com, or let us know at " \
+          "support@stripe.com."
 
       else
         message = "Unexpected error communicating with Stripe. " \
@@ -457,10 +473,11 @@ module Stripe
 
       message += " Request was retried #{num_retries} times." if num_retries > 0
 
-      raise APIConnectionError, message + "\n\n(Network error: #{e.message})"
+      raise APIConnectionError,
+            message + "\n\n(Network error: #{error.message})"
     end
 
-    def request_headers(api_key, method)
+    private def request_headers(api_key, method)
       user_agent = "Stripe/v1 RubyBindings/#{Stripe::VERSION}"
       unless Stripe.app_info.nil?
         user_agent += " " + format_app_info(Stripe.app_info)
@@ -473,7 +490,9 @@ module Stripe
       }
 
       if Stripe.enable_telemetry? && !@last_request_metrics.nil?
-        headers["X-Stripe-Client-Telemetry"] = JSON.generate(last_request_metrics: @last_request_metrics.payload)
+        headers["X-Stripe-Client-Telemetry"] = JSON.generate(
+          last_request_metrics: @last_request_metrics.payload
+        )
       end
 
       # It is only safe to retry network failures on post and delete
@@ -500,7 +519,7 @@ module Stripe
       headers
     end
 
-    def log_request(context, num_retries)
+    private def log_request(context, num_retries)
       Util.log_info("Request to Stripe API",
                     account: context.account,
                     api_version: context.api_version,
@@ -513,9 +532,8 @@ module Stripe
                      idempotency_key: context.idempotency_key,
                      query_params: context.query_params)
     end
-    private :log_request
 
-    def log_response(context, request_start, status, body)
+    private def log_response(context, request_start, status, body)
       Util.log_info("Response from Stripe API",
                     account: context.account,
                     api_version: context.api_version,
@@ -535,19 +553,18 @@ module Stripe
       Util.log_debug("Dashboard link for request",
                      idempotency_key: context.idempotency_key,
                      request_id: context.request_id,
-                     url: Util.request_id_dashboard_url(context.request_id, context.api_key))
+                     url: Util.request_id_dashboard_url(context.request_id,
+                                                        context.api_key))
     end
-    private :log_response
 
-    def log_response_error(context, request_start, e)
+    private def log_response_error(context, request_start, error)
       Util.log_error("Request error",
                      elapsed: Time.now - request_start,
-                     error_message: e.message,
+                     error_message: error.message,
                      idempotency_key: context.idempotency_key,
                      method: context.method,
                      path: context.path)
     end
-    private :log_response_error
 
     # RequestLogContext stores information about a request that's begin made so
     # that we can log certain information. It's useful because it means that we
@@ -630,7 +647,8 @@ module Stripe
       end
 
       def user_agent
-        lang_version = "#{RUBY_VERSION} p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE})"
+        lang_version = "#{RUBY_VERSION} p#{RUBY_PATCHLEVEL} " \
+                       "(#{RUBY_RELEASE_DATE})"
 
         {
           application: Stripe.app_info,
@@ -646,7 +664,8 @@ module Stripe
       end
     end
 
-    # StripeRequestMetrics tracks metadata to be reported to stripe for metrics collection
+    # StripeRequestMetrics tracks metadata to be reported to stripe for metrics
+    # collection
     class StripeRequestMetrics
       # The Stripe request ID of the response.
       attr_accessor :request_id