stripe 5.18.0 → 5.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d22d41c56bb85d7b5712eaf36c274b8636f6a5a27b767d344d766ca59b6be4dc
-  data.tar.gz: ec876e8fcf530e645e4a26bd8dee1c635dee466248d31e7746c33aa4e6373c0e
+  metadata.gz: 339246c958404a761dbafcfbd76acfcf7f2223838e41efd928babd1624f1f173
+  data.tar.gz: 8d7385cfe0066b9dd4ad53a2f3d3ebcace2b22f77b27cd8fe252bfb7f58118e4
 SHA512:
-  metadata.gz: 69cdb2b0263d577512d77892a3229b4a8112ccd5c6eae8fb6d38510901981da05d93062dd514a6fa9976d54927f5208a6fdc8f5c2bf6f5db072eaac0089f66a0
-  data.tar.gz: c681fc11a7566635cdf094ad1bbe1c90db63887ed019d65a25f4eb52efe39411786c370c47403bd2b26f8d5df62f588ba951cf4d59bb12d6f4d3f02cda36a5cf
+  metadata.gz: 3170fd6a145e41cc69b25ddbeb20cc88064fb4011ee89438d07362c745c2990523c1ea25c319c25910e5670bba7f27d97b2453462fc441c31d0db3b0ff761c46
+  data.tar.gz: bc2ae7b487bfd0a7957e360862188bcda79f9f851504162ec9c30ecf3c0a824a2050e73a0e5d3ceb3840511b8585b4710e3a97864b3eb7e0ddcb315b79f60a8d

data/.travis.yml

@@ -17,7 +17,7 @@ sudo: false
 env:
   global:
     # If changing this number, please also change it in `test/test_helper.rb`.
-    - STRIPE_MOCK_VERSION=0.88.0
+    - STRIPE_MOCK_VERSION=0.95.0
 
 cache:
   directories:

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 5.23.0 - 2020-08-05
+* [#937](https://github.com/stripe/stripe-ruby/pull/937) Add support for the `PromotionCode` resource and APIs
+
+## 5.22.0 - 2020-05-11
+* [#918](https://github.com/stripe/stripe-ruby/pull/918) Add support for the `LineItem` resource and APIs
+
+## 5.21.0 - 2020-04-29
+* [#917](https://github.com/stripe/stripe-ruby/pull/917) Add support for the `Price` resource and APIs
+
+## 5.20.0 - 2020-04-27
+* [#916](https://github.com/stripe/stripe-ruby/pull/916) Add new `.generate_header` method for webhooks
+
+## 5.19.0 - 2020-04-24
+* [#915](https://github.com/stripe/stripe-ruby/pull/915) Expose `Stripe::Webhook.compute_signature` publicly
+
 ## 5.18.0 - 2020-04-22
 * [#911](https://github.com/stripe/stripe-ruby/pull/911) Add support for `BillingPortal` namespace and `Session` resource and APIs
 

data/VERSION

@@ -1 +1 @@
-5.18.0
+5.23.0

data/lib/stripe/object_types.rb

@@ -49,6 +49,7 @@ module Stripe
         Issuing::Cardholder::OBJECT_NAME => Issuing::Cardholder,
         Issuing::Dispute::OBJECT_NAME => Issuing::Dispute,
         Issuing::Transaction::OBJECT_NAME => Issuing::Transaction,
+        LineItem::OBJECT_NAME => LineItem,
         LoginLink::OBJECT_NAME => LoginLink,
         Mandate::OBJECT_NAME => Mandate,
         Order::OBJECT_NAME => Order,
@@ -58,7 +59,9 @@ module Stripe
         Payout::OBJECT_NAME => Payout,
         Person::OBJECT_NAME => Person,
         Plan::OBJECT_NAME => Plan,
+        Price::OBJECT_NAME => Price,
         Product::OBJECT_NAME => Product,
+        PromotionCode::OBJECT_NAME => PromotionCode,
         Radar::EarlyFraudWarning::OBJECT_NAME => Radar::EarlyFraudWarning,
         Radar::ValueList::OBJECT_NAME => Radar::ValueList,
         Radar::ValueListItem::OBJECT_NAME => Radar::ValueListItem,

data/lib/stripe/resources.rb

@@ -38,6 +38,7 @@ require "stripe/resources/issuing/card_details"
 require "stripe/resources/issuing/cardholder"
 require "stripe/resources/issuing/dispute"
 require "stripe/resources/issuing/transaction"
+require "stripe/resources/line_item"
 require "stripe/resources/login_link"
 require "stripe/resources/mandate"
 require "stripe/resources/order"
@@ -47,7 +48,9 @@ require "stripe/resources/payment_method"
 require "stripe/resources/payout"
 require "stripe/resources/person"
 require "stripe/resources/plan"
+require "stripe/resources/price"
 require "stripe/resources/product"
+require "stripe/resources/promotion_code"
 require "stripe/resources/radar/early_fraud_warning"
 require "stripe/resources/radar/value_list"
 require "stripe/resources/radar/value_list_item"

data/lib/stripe/resources/account.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/account_link.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/apple_pay_domain.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/application_fee.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/balance.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/balance_transaction.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/bank_account.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/billing_portal/session.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/bitcoin_receiver.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/card.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/charge.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/checkout/session.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe
@@ -5,8 +6,11 @@ module Stripe
     class Session < APIResource
       extend Stripe::APIOperations::Create
       extend Stripe::APIOperations::List
+      extend Stripe::APIOperations::NestedResource
 
       OBJECT_NAME = "checkout.session"
+
+      nested_resource_class_methods :line_item, operations: %i[list]
     end
   end
 end

data/lib/stripe/resources/country_spec.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/coupon.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/credit_note.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/customer.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/dispute.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/ephemeral_key.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/event.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/exchange_rate.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/file.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/file_link.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/invoice.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/invoice_item.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/issuing/authorization.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/issuing/card.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/issuing/cardholder.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/issuing/dispute.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/issuing/transaction.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/line_item.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Stripe
+  class LineItem < APIResource
+    OBJECT_NAME = "item"
+  end
+end

data/lib/stripe/resources/mandate.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/order.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/order_return.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/payment_intent.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/payment_method.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/payout.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/plan.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/price.rb

@@ -0,0 +1,12 @@
+# File generated from our OpenAPI spec
+# frozen_string_literal: true
+
+module Stripe
+  class Price < APIResource
+    extend Stripe::APIOperations::Create
+    extend Stripe::APIOperations::List
+    include Stripe::APIOperations::Save
+
+    OBJECT_NAME = "price"
+  end
+end

data/lib/stripe/resources/product.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/promotion_code.rb

@@ -0,0 +1,12 @@
+# File generated from our OpenAPI spec
+# frozen_string_literal: true
+
+module Stripe
+  class PromotionCode < APIResource
+    extend Stripe::APIOperations::Create
+    extend Stripe::APIOperations::List
+    include Stripe::APIOperations::Save
+
+    OBJECT_NAME = "promotion_code"
+  end
+end

data/lib/stripe/resources/radar/early_fraud_warning.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/radar/value_list.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/radar/value_list_item.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/recipient.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/refund.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/reporting/report_run.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/reporting/report_type.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/review.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/setup_intent.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/sigma/scheduled_query_run.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/sku.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/source.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/subscription.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/subscription_item.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/subscription_schedule.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/tax_rate.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/terminal/connection_token.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/terminal/location.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/terminal/reader.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/three_d_secure.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/token.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/topup.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/transfer.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/resources/webhook_endpoint.rb

@@ -1,3 +1,4 @@
+# File generated from our OpenAPI spec
 # frozen_string_literal: true
 
 module Stripe

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "5.18.0"
+  VERSION = "5.23.0"
 end

data/lib/stripe/webhook.rb

@@ -24,10 +24,37 @@ module Stripe
     module Signature
       EXPECTED_SCHEME = "v1"
 
-      def self.compute_signature(payload, secret)
-        OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new("sha256"), secret, payload)
+      # Computes a webhook signature given a time (probably the current time),
+      # a payload, and a signing secret.
+      def self.compute_signature(timestamp, payload, secret)
+        raise ArgumentError, "timestamp should be an instance of Time" \
+          unless timestamp.is_a?(Time)
+        raise ArgumentError, "payload should be a string" \
+          unless payload.is_a?(String)
+        raise ArgumentError, "secret should be a string" \
+          unless secret.is_a?(String)
+
+        timestamped_payload = "#{timestamp.to_i}.#{payload}"
+        OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new("sha256"), secret,
+                                timestamped_payload)
+      end
+
+      # Generates a value that would be added to a `Stripe-Signature` for a
+      # given webhook payload.
+      #
+      # Note that this isn't needed to verify webhooks in any way, and is
+      # mainly here for use in test cases (those that are both within this
+      # project and without).
+      def self.generate_header(timestamp, signature, scheme: EXPECTED_SCHEME)
+        raise ArgumentError, "timestamp should be an instance of Time" \
+          unless timestamp.is_a?(Time)
+        raise ArgumentError, "signature should be a string" \
+          unless signature.is_a?(String)
+        raise ArgumentError, "scheme should be a string" \
+          unless scheme.is_a?(String)
+
+        "t=#{timestamp.to_i},#{scheme}=#{signature}"
       end
-      private_class_method :compute_signature
 
       # Extracts the timestamp and the signature(s) with the desired scheme
       # from the header
@@ -35,7 +62,7 @@ module Stripe
         list_items = header.split(/,\s*/).map { |i| i.split("=", 2) }
         timestamp = Integer(list_items.select { |i| i[0] == "t" }[0][1])
         signatures = list_items.select { |i| i[0] == scheme }.map { |i| i[1] }
-        [timestamp, signatures]
+        [Time.at(timestamp), signatures]
       end
       private_class_method :get_timestamp_and_signatures
 
@@ -53,6 +80,11 @@ module Stripe
         begin
           timestamp, signatures =
             get_timestamp_and_signatures(header, EXPECTED_SCHEME)
+
+        # TODO: Try to knock over this blanket rescue as it can unintentionally
+        # swallow many valid errors. Instead, try to validate an incoming
+        # header one piece at a time, and error with a known exception class if
+        # any part is found to be invalid. Rescue that class here.
         rescue StandardError
           raise SignatureVerificationError.new(
             "Unable to extract timestamp and signatures from header",
@@ -67,8 +99,7 @@ module Stripe
           )
         end
 
-        signed_payload = "#{timestamp}.#{payload}"
-        expected_sig = compute_signature(signed_payload, secret)
+        expected_sig = compute_signature(timestamp, payload, secret)
         unless signatures.any? { |s| Util.secure_compare(expected_sig, s) }
           raise SignatureVerificationError.new(
             "No signatures found matching the expected signature for payload",
@@ -76,7 +107,7 @@ module Stripe
           )
         end
 
-        if tolerance && timestamp < Time.now.to_f - tolerance
+        if tolerance && timestamp < Time.now - tolerance
           raise SignatureVerificationError.new(
             "Timestamp outside the tolerance zone (#{Time.at(timestamp)})",
             header, http_body: payload

data/test/stripe/account_link_test.rb

@@ -7,9 +7,9 @@ module Stripe
     should "be creatable" do
       link = Stripe::AccountLink.create(
         account: "acct_123",
-        failure_url: "https://stripe.com/failure",
-        success_url: "https://stripe.com/success",
-        type: "custom_account_verification"
+        refresh_url: "https://stripe.com/refresh",
+        return_url: "https://stripe.com/return",
+        type: "account_onboarding"
       )
       assert_requested :post, "#{Stripe.api_base}/v1/account_links"
       assert link.is_a?(Stripe::AccountLink)

data/test/stripe/checkout/session_test.rb

@@ -36,6 +36,18 @@ module Stripe
         assert_requested :get, "#{Stripe.api_base}/v1/checkout/sessions/cs_123"
         assert charge.is_a?(Stripe::Checkout::Session)
       end
+
+      context "#list_line_items" do
+        should "list the session's line items" do
+          sources = Stripe::Checkout::Session.list_line_items(
+            "cs_123"
+          )
+          assert_requested :get, "#{Stripe.api_base}/v1/checkout/sessions/cs_123/line_items"
+          assert sources.is_a?(Stripe::ListObject)
+          assert sources.data.is_a?(Array)
+          assert sources.data[0].is_a?(Stripe::LineItem)
+        end
+      end
     end
   end
 end

data/test/stripe/price_test.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require ::File.expand_path("../test_helper", __dir__)
+
+module Stripe
+  class PriceTest < Test::Unit::TestCase
+    should "be listable" do
+      prices = Stripe::Price.list
+      assert_requested :get, "#{Stripe.api_base}/v1/prices"
+      assert prices.data.is_a?(Array)
+      assert prices.data[0].is_a?(Stripe::Price)
+    end
+
+    should "be retrievable" do
+      price = Stripe::Price.retrieve("price_123")
+      assert_requested :get, "#{Stripe.api_base}/v1/prices/price_123"
+      assert price.is_a?(Stripe::Price)
+    end
+
+    should "be creatable" do
+      price = Stripe::Price.create(
+        unit_amount: 5000,
+        currency: "usd",
+        recurring: {
+          interval: "month",
+        },
+        product_data: {
+          name: "Product name",
+        }
+      )
+      assert_requested :post, "#{Stripe.api_base}/v1/prices"
+      assert price.is_a?(Stripe::Price)
+    end
+
+    should "be saveable" do
+      price = Stripe::Price.retrieve("price_123")
+      price.metadata["key"] = "value"
+      price.save
+      assert_requested :post, "#{Stripe.api_base}/v1/prices/#{price.id}"
+    end
+
+    should "be updateable" do
+      price = Stripe::Price.update("price_123", metadata: { foo: "bar" })
+      assert_requested :post, "#{Stripe.api_base}/v1/prices/price_123"
+      assert price.is_a?(Stripe::Price)
+    end
+  end
+end

data/test/stripe/promotion_code_test.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require ::File.expand_path("../test_helper", __dir__)
+
+module Stripe
+  class PromotionCodeTest < Test::Unit::TestCase
+    should "be listable" do
+      promotion_codes = Stripe::PromotionCode.list
+      assert_requested :get, "#{Stripe.api_base}/v1/promotion_codes"
+      assert promotion_codes.data.is_a?(Array)
+      assert promotion_codes.first.is_a?(Stripe::PromotionCode)
+    end
+
+    should "be retrievable" do
+      coupon = Stripe::PromotionCode.retrieve("PROMO_123")
+      assert_requested :get, "#{Stripe.api_base}/v1/promotion_codes/PROMO_123"
+      assert coupon.is_a?(Stripe::PromotionCode)
+    end
+
+    should "be creatable" do
+      coupon = Stripe::PromotionCode.create(
+        coupon: "co_123",
+        code: "MYCODE"
+      )
+      assert_requested :post, "#{Stripe.api_base}/v1/promotion_codes"
+      assert coupon.is_a?(Stripe::PromotionCode)
+    end
+
+    should "be saveable" do
+      coupon = Stripe::PromotionCode.retrieve("PROMO_123")
+      coupon.metadata["key"] = "value"
+      coupon.save
+      assert_requested :post, "#{Stripe.api_base}/v1/promotion_codes/#{coupon.id}"
+    end
+
+    should "be updateable" do
+      coupon = Stripe::PromotionCode.update("PROMO_123", metadata: { key: "value" })
+      assert_requested :post, "#{Stripe.api_base}/v1/promotion_codes/PROMO_123"
+      assert coupon.is_a?(Stripe::PromotionCode)
+    end
+  end
+end

data/test/stripe/subscription_item_test.rb

@@ -22,7 +22,7 @@ module Stripe
 
     should "be creatable" do
       item = Stripe::SubscriptionItem.create(
-        plan: "sapphire-elite",
+        price: "sapphire-elite",
         quantity: 3,
         subscription: "sub_123"
       )

data/test/stripe/webhook_test.rb

@@ -13,12 +13,51 @@ module Stripe
     SECRET = "whsec_test_secret"
 
     def generate_header(opts = {})
-      opts[:timestamp] ||= Time.now.to_i
+      opts[:timestamp] ||= Time.now
       opts[:payload] ||= EVENT_PAYLOAD
       opts[:secret] ||= SECRET
       opts[:scheme] ||= Stripe::Webhook::Signature::EXPECTED_SCHEME
-      opts[:signature] ||= Stripe::Webhook::Signature.send(:compute_signature, "#{opts[:timestamp]}.#{opts[:payload]}", opts[:secret])
-      "t=#{opts[:timestamp]},#{opts[:scheme]}=#{opts[:signature]}"
+      opts[:signature] ||= Stripe::Webhook::Signature.compute_signature(
+        opts[:timestamp],
+        opts[:payload],
+        opts[:secret]
+      )
+      Stripe::Webhook::Signature.generate_header(
+        opts[:timestamp],
+        opts[:signature],
+        scheme: opts[:scheme]
+      )
+    end
+
+    context ".compute_signature" do
+      should "compute a signature which can then be verified" do
+        timestamp = Time.now
+        signature = Stripe::Webhook::Signature.compute_signature(
+          timestamp,
+          EVENT_PAYLOAD,
+          SECRET
+        )
+        header = generate_header(timestamp: timestamp, signature: signature)
+        assert(Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, SECRET))
+      end
+    end
+
+    context ".generate_header" do
+      should "generate a header in valid format" do
+        timestamp = Time.now
+        signature = Stripe::Webhook::Signature.compute_signature(
+          timestamp,
+          EVENT_PAYLOAD,
+          SECRET
+        )
+        scheme = "v1"
+        header = Stripe::Webhook::Signature.generate_header(
+          timestamp,
+          signature,
+          scheme: scheme
+        )
+        assert_equal("t=#{timestamp.to_i},#{scheme}=#{signature}", header)
+      end
     end
 
     context ".construct_event" do
@@ -70,7 +109,7 @@ module Stripe
       end
 
       should "raise a SignatureVerificationError when the timestamp is not within the tolerance" do
-        header = generate_header(timestamp: Time.now.to_i - 15)
+        header = generate_header(timestamp: Time.now - 15)
         e = assert_raises(Stripe::SignatureVerificationError) do
           Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, SECRET, tolerance: 10)
         end
@@ -88,7 +127,7 @@ module Stripe
       end
 
       should "return true when the header contains a valid signature and the timestamp is off but no tolerance is provided" do
-        header = generate_header(timestamp: 12_345)
+        header = generate_header(timestamp: Time.at(12_345))
         assert(Stripe::Webhook::Signature.verify_header(EVENT_PAYLOAD, header, SECRET))
       end
     end

data/test/test_helper.rb

@@ -16,7 +16,7 @@ require ::File.expand_path("test_data", __dir__)
 require ::File.expand_path("stripe_mock", __dir__)
 
 # If changing this number, please also change it in `.travis.yml`.
-MOCK_MINIMUM_VERSION = "0.88.0"
+MOCK_MINIMUM_VERSION = "0.95.0"
 MOCK_PORT = Stripe::StripeMock.start
 
 # Disable all real network connections except those that are outgoing to

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 5.18.0
+  version: 5.23.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-22 00:00:00.000000000 Z
+date: 2020-08-05 00:00:00.000000000 Z
 dependencies: []
 description: Stripe is the easiest way to accept payments online.  See https://stripe.com
   for details.
@@ -93,6 +93,7 @@ files:
 - lib/stripe/resources/issuing/cardholder.rb
 - lib/stripe/resources/issuing/dispute.rb
 - lib/stripe/resources/issuing/transaction.rb
+- lib/stripe/resources/line_item.rb
 - lib/stripe/resources/login_link.rb
 - lib/stripe/resources/mandate.rb
 - lib/stripe/resources/order.rb
@@ -102,7 +103,9 @@ files:
 - lib/stripe/resources/payout.rb
 - lib/stripe/resources/person.rb
 - lib/stripe/resources/plan.rb
+- lib/stripe/resources/price.rb
 - lib/stripe/resources/product.rb
+- lib/stripe/resources/promotion_code.rb
 - lib/stripe/resources/radar/early_fraud_warning.rb
 - lib/stripe/resources/radar/value_list.rb
 - lib/stripe/resources/radar/value_list_item.rb
@@ -191,7 +194,9 @@ files:
 - test/stripe/payout_test.rb
 - test/stripe/person_test.rb
 - test/stripe/plan_test.rb
+- test/stripe/price_test.rb
 - test/stripe/product_test.rb
+- test/stripe/promotion_code_test.rb
 - test/stripe/radar/early_fraud_warning_test.rb
 - test/stripe/radar/value_list_item_test.rb
 - test/stripe/radar/value_list_test.rb
@@ -307,7 +312,9 @@ test_files:
 - test/stripe/payout_test.rb
 - test/stripe/person_test.rb
 - test/stripe/plan_test.rb
+- test/stripe/price_test.rb
 - test/stripe/product_test.rb
+- test/stripe/promotion_code_test.rb
 - test/stripe/radar/early_fraud_warning_test.rb
 - test/stripe/radar/value_list_item_test.rb
 - test/stripe/radar/value_list_test.rb