stripe 5.13.0 → 5.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7924a6c0f1c0e2d9ca240993b1c712ba67cffe7ffd2b0d7cc6583d15458d1dd8
-  data.tar.gz: 2218883f89ec0cbfd2e7e70b7811df20157bc6bb0767d2a633d04673e206205b
+  metadata.gz: 47a1fda0057d116729cd70477218913ecf097898f633952d287327ecfaf99133
+  data.tar.gz: ed37e7cb7f025d48a11d075bc507cb6e84f92a36fc542f8d8bcff1bc8729dc50
 SHA512:
-  metadata.gz: df0af80373f9e1b1fbc3f2fd071dd69eb1c0de845af2e1ea445fc2ceb1d6b277acc6548407680b123074a9c6a9c9a2b585875104391b3cb5c6bb154313faac7d
-  data.tar.gz: '0325253693ccd991bfb19afb2c2f8acb7cfbe1ffbe51f2488bba98faf6c21d5646f11b27ee1460462363717963b66e2191ec294eed1cee9b555f82d0281fa8cc'
+  metadata.gz: 84dda96e1a4da56d9643b13ae8bb6c6352f90baae770de860834461c73f3489501a81a03c3f98e4f0d0da9e6284c66111df743b9c907fbc82774979ab4f009d0
+  data.tar.gz: 4d166d7eded67674487f2f1e678e86d11a6cb54f88848e185a55a4bca93831307f2dca9f8cc2b8608f1305d7193715ddba48e3bbe3baa0e5245b582fe3bd9090

data/.rubocop.yml

@@ -13,18 +13,23 @@ AllCops:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-Layout/IndentFirstArrayElement:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 # This can be re-enabled once we're 2.3+ only and can use the squiggly heredoc
 # operator. Prior to that, Rubocop recommended bringing in a library like
 # ActiveSupport to get heredoc indentation, which is just terrible.
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
+Layout/LineLength:
+  Exclude:
+    - "lib/stripe/resources/**/*.rb"
+    - "test/**/*.rb"
+
 Metrics/BlockLength:
   Max: 40
   Exclude:
@@ -38,11 +43,6 @@ Metrics/ClassLength:
     # to adhere to this rule.
     - "test/**/*.rb"
 
-Metrics/LineLength:
-  Exclude:
-    - "lib/stripe/resources/**/*.rb"
-    - "test/**/*.rb"
-
 Metrics/MethodLength:
   # There's ~2 long methods in `StripeClient`. If we want to truncate those a
   # little, we could move this to be closer to ~30 (but the default of 10 is

data/.travis.yml

@@ -17,7 +17,7 @@ sudo: false
 env:
   global:
     # If changing this number, please also change it in `test/test_helper.rb`.
-    - STRIPE_MOCK_VERSION=0.76.0
+    - STRIPE_MOCK_VERSION=0.79.0
 
 cache:
   directories:

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 5.14.0 - 2020-01-14
+* [#896](https://github.com/stripe/stripe-ruby/pull/896) Add support for `CreditNoteLineItem`
+* [#894](https://github.com/stripe/stripe-ruby/pull/894) Clean up test output by capturing `$stderr` when we expect warnings
+* [#892](https://github.com/stripe/stripe-ruby/pull/892) Explicitly pass a parameter as hash to be more ruby 2.7 friendly
+* [#893](https://github.com/stripe/stripe-ruby/pull/893) Upgrade Rubocop to 0.79
+
 ## 5.13.0 - 2020-01-08
 * [#891](https://github.com/stripe/stripe-ruby/pull/891) Fix most Ruby 2.7 warnings
 

data/Gemfile

@@ -18,7 +18,7 @@ group :development do
   # `Gemfile.lock` checked in, so to prevent good builds from suddenly going
   # bad, pin to a specific version number here. Try to keep this relatively
   # up-to-date, but it's not the end of the world if it's not.
-  gem "rubocop", "0.73"
+  gem "rubocop", "0.79"
 
   platforms :mri do
     gem "byebug"

data/VERSION

@@ -1 +1 @@
-5.13.0
+5.14.0

data/lib/stripe/object_types.rb

@@ -28,6 +28,7 @@ module Stripe
         CountrySpec::OBJECT_NAME => CountrySpec,
         Coupon::OBJECT_NAME => Coupon,
         CreditNote::OBJECT_NAME => CreditNote,
+        CreditNoteLineItem::OBJECT_NAME => CreditNoteLineItem,
         Customer::OBJECT_NAME => Customer,
         CustomerBalanceTransaction::OBJECT_NAME => CustomerBalanceTransaction,
         Discount::OBJECT_NAME => Discount,

data/lib/stripe/resources.rb

@@ -18,6 +18,7 @@ require "stripe/resources/checkout/session"
 require "stripe/resources/country_spec"
 require "stripe/resources/coupon"
 require "stripe/resources/credit_note"
+require "stripe/resources/credit_note_line_item"
 require "stripe/resources/customer"
 require "stripe/resources/customer_balance_transaction"
 require "stripe/resources/discount"

data/lib/stripe/resources/credit_note.rb

@@ -23,5 +23,10 @@ module Stripe
       resp, opts = request(:get, resource_url + "/preview", params, opts)
       Util.convert_to_stripe_object(resp.data, opts)
     end
+
+    def self.list_preview_line_items(params, opts = {})
+      resp, opts = request(:get, resource_url + "/preview/lines", params, opts)
+      Util.convert_to_stripe_object(resp.data, opts)
+    end
   end
 end

data/lib/stripe/resources/credit_note_line_item.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Stripe
+  class CreditNoteLineItem < StripeObject
+    OBJECT_NAME = "credit_note_line_item"
+  end
+end

data/lib/stripe/stripe_object.rb

@@ -135,7 +135,8 @@ module Stripe
     # ==== Attributes
     #
     # * +values+ - Hash of values to use to update the current attributes of
-    #   the object.
+    #   the object. If you are on ruby 2.7 or higher make sure to wrap in curly
+    #   braces to be ruby 3 compatible.
     # * +opts+ - Options for +StripeObject+ like an API key that will be reused
     #   on subsequent API calls.
     #

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "5.13.0"
+  VERSION = "5.14.0"
 end

data/test/stripe/credit_note_test.rb

@@ -72,5 +72,19 @@ module Stripe
         assert credit_note.is_a?(Stripe::CreditNote)
       end
     end
+
+    context ".list_preview_line_items" do
+      should "list_preview_line_items" do
+        line_items = Stripe::CreditNote.list_preview_line_items(
+          invoice: "in_123"
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/credit_notes/preview/lines",
+                         query: {
+                           invoice: "in_123",
+                         }
+        assert line_items.data.is_a?(Array)
+        assert line_items.data[0].is_a?(Stripe::CreditNoteLineItem)
+      end
+    end
   end
 end

data/test/stripe/source_test.rb

@@ -99,10 +99,20 @@ module Stripe
 
     context "#source_transactions" do
       should "list source transactions" do
-        source = Stripe::Source.construct_from(id: "src_123",
-                                               object: "source")
-        source.source_transactions
-        assert_requested :get, "#{Stripe.api_base}/v1/sources/src_123/source_transactions"
+        old_stderr = $stderr
+        $stderr = StringIO.new
+
+        begin
+          source = Stripe::Source.construct_from(id: "src_123",
+                                                 object: "source")
+          source.source_transactions
+          assert_requested :get, "#{Stripe.api_base}/v1/sources/src_123/source_transactions"
+
+          assert_include $stderr.string,
+                         "use Source.list_source_transactions instead"
+        ensure
+          $stderr = old_stderr
+        end
       end
     end
   end

data/test/stripe/stripe_object_test.rb

@@ -212,26 +212,29 @@ module Stripe
 
     should "mass assign values with #update_attributes" do
       obj = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
-      obj.update_attributes(name: "STRIPE")
+
+      obj.update_attributes({ name: "STRIPE" }) # rubocop:disable Style/BracesAroundHashParameters
+
       assert_equal "STRIPE", obj.name
 
       # unfortunately, we even assign unknown properties to duplicate the
       # behavior that we currently have via magic accessors with
       # method_missing
-      obj.update_attributes(unknown: "foo")
+      obj.update_attributes({ unknown: "foo" }) # rubocop:disable Style/BracesAroundHashParameters
+
       assert_equal "foo", obj.unknown
     end
 
     should "#update_attributes with a hash" do
       obj = Stripe::StripeObject.construct_from({})
-      obj.update_attributes(metadata: { foo: "bar" })
+      obj.update_attributes({ metadata: { foo: "bar" } }) # rubocop:disable Style/BracesAroundHashParameters
       assert_equal Stripe::StripeObject, obj.metadata.class
     end
 
     should "create accessors when #update_attributes is called" do
       obj = Stripe::StripeObject.construct_from({})
       assert_equal false, obj.send(:metaclass).method_defined?(:foo)
-      obj.update_attributes(foo: "bar")
+      obj.update_attributes({ foo: "bar" }) # rubocop:disable Style/BracesAroundHashParameters
       assert_equal true, obj.send(:metaclass).method_defined?(:foo)
     end
 
@@ -268,7 +271,7 @@ module Stripe
 
     should "#serialize_params on a basic object" do
       obj = Stripe::StripeObject.construct_from(foo: nil)
-      obj.update_attributes(foo: "bar")
+      obj.update_attributes({ foo: "bar" }) # rubocop:disable Style/BracesAroundHashParameters
       assert_equal({ foo: "bar" }, obj.serialize_params)
     end
 

data/test/stripe/usage_record_summary_test.rb

@@ -9,11 +9,21 @@ module Stripe
     end
 
     should "be listable" do
-      transactions = @sub_item.usage_record_summaries
+      old_stderr = $stderr
+      $stderr = StringIO.new
 
-      assert_requested :get, "#{Stripe.api_base}/v1/subscription_items/#{@sub_item.id}/usage_record_summaries"
-      assert transactions.data.is_a?(Array)
-      assert transactions.first.is_a?(Stripe::UsageRecordSummary)
+      begin
+        transactions = @sub_item.usage_record_summaries
+
+        assert_requested :get, "#{Stripe.api_base}/v1/subscription_items/#{@sub_item.id}/usage_record_summaries"
+        assert transactions.data.is_a?(Array)
+        assert transactions.first.is_a?(Stripe::UsageRecordSummary)
+
+        assert_include $stderr.string,
+                       "use SubscriptionItem.list_usage_record_summaries instead"
+      ensure
+        $stderr = old_stderr
+      end
     end
   end
 end

data/test/test_helper.rb

@@ -16,7 +16,7 @@ require ::File.expand_path("test_data", __dir__)
 require ::File.expand_path("stripe_mock", __dir__)
 
 # If changing this number, please also change it in `.travis.yml`.
-MOCK_MINIMUM_VERSION = "0.76.0"
+MOCK_MINIMUM_VERSION = "0.79.0"
 MOCK_PORT = Stripe::StripeMock.start
 
 # Disable all real network connections except those that are outgoing to

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 5.13.0
+  version: 5.14.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-08 00:00:00.000000000 Z
+date: 2020-01-14 00:00:00.000000000 Z
 dependencies: []
 description: Stripe is the easiest way to accept payments online.  See https://stripe.com
   for details.
@@ -73,6 +73,7 @@ files:
 - lib/stripe/resources/country_spec.rb
 - lib/stripe/resources/coupon.rb
 - lib/stripe/resources/credit_note.rb
+- lib/stripe/resources/credit_note_line_item.rb
 - lib/stripe/resources/customer.rb
 - lib/stripe/resources/customer_balance_transaction.rb
 - lib/stripe/resources/discount.rb