stripe 5.0.1 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85172888973b3726ad9e22512ff8b2568306b70d1627c5ee3adafb29c9626e07
-  data.tar.gz: 89344233f7ba4423b5fbc35b30152dec1b5f798931a5b69710d244ea05146b98
+  metadata.gz: 52049216e773c7f0f33c6c1b99ab895927df85cc1a818086af835e6f4ae7e3b7
+  data.tar.gz: a44404e74a7fa7834672a71aeb2ff6b56f49f1def42f9cca984fe7cc2edc486e
 SHA512:
-  metadata.gz: e48a09594870a21082733d2b9a7ef9eb9bc27d757de666bb1fbab25b1aa9143c3ad1c2e610a13199395efd36f8d3b71f1d601dd3e03da1a69911e5be46074c5a
-  data.tar.gz: 1d376a59eb9072debb80e3c17b1fb6961d766f780c5d81b2771773018616ce4a8e049933537a9ba5a334df774b9307fbf0105af790bbc2ee7a0089d54441ee98
+  metadata.gz: 1f68b7b4fecb087800254fdcb9346be6c0d56fbe1494e4882f273802ab571d27f2b01d87b2466a9899ba0cb2566f209d93142883c073dda2aaecccb3e6372632
+  data.tar.gz: 97e07a834fbc3d2ecdb04f88aaa6198221aa030db6637f5404545e33d007fcb80bb23a426dbbca96eef2ed64e61167a86db671062adf58a0189ab2cccfbba410

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 5.1.0 - 2019-08-27
+* [#841](https://github.com/stripe/stripe-ruby/pull/841) Retry requests on a 429 that's a lock timeout
+
 ## 5.0.1 - 2019-08-20
 * [#836](https://github.com/stripe/stripe-ruby/pull/836) Increase connection keep alive timeout to 30 seconds
 

data/VERSION

@@ -1 +1 @@
-5.0.1
+5.1.0

data/lib/stripe/connection_manager.rb

@@ -109,14 +109,7 @@ module Stripe
         connection.cert_store = Stripe.ca_store
       else
         connection.verify_mode = OpenSSL::SSL::VERIFY_NONE
-
-        unless @verify_ssl_warned
-          @verify_ssl_warned = true
-          warn("WARNING: Running without SSL cert verification. " \
-            "You should never do this in production. " \
-            "Execute `Stripe.verify_ssl_certs = true` to enable " \
-            "verification.")
-        end
+        warn_ssl_verify_none
       end
 
       connection
@@ -134,5 +127,15 @@ module Stripe
         [u.host, u.port, u.user, u.password]
       end
     end
+
+    private def warn_ssl_verify_none
+      return if @verify_ssl_warned
+
+      @verify_ssl_warned = true
+      warn("WARNING: Running without SSL cert verification. " \
+        "You should never do this in production. " \
+        "Execute `Stripe.verify_ssl_certs = true` to enable " \
+        "verification.")
+    end
   end
 end

data/lib/stripe/stripe_client.rb

@@ -88,6 +88,16 @@ module Stripe
         # 409 Conflict
         return true if error.http_status == 409
 
+        # 429 Too Many Requests
+        #
+        # There are a few different problems that can lead to a 429. The most
+        # common is rate limiting, on which we *don't* want to retry because
+        # that'd likely contribute to more contention problems. However, some
+        # 429s are lock timeouts, which is when a request conflicted with
+        # another request or an internal process on some particular object.
+        # These 429s are safe to retry.
+        return true if error.http_status == 429 && error.code == "lock_timeout"
+
         # 500 Internal Server Error
         #
         # We only bother retrying these for non-POST requests. POSTs end up

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "5.0.1"
+  VERSION = "5.1.0"
 end

data/test/stripe/stripe_client_test.rb

@@ -122,6 +122,12 @@ module Stripe
                                           method: :post, num_retries: 0)
       end
 
+      should "retry on a 429 Too Many Requests when lock timeout" do
+        assert StripeClient.should_retry?(Stripe::StripeError.new(http_status: 429,
+                                                                  code: "lock_timeout"),
+                                          method: :post, num_retries: 0)
+      end
+
       should "retry on a 500 Internal Server Error when non-POST" do
         assert StripeClient.should_retry?(Stripe::StripeError.new(http_status: 500),
                                           method: :get, num_retries: 0)
@@ -142,6 +148,12 @@ module Stripe
                                           method: :post, num_retries: 0)
       end
 
+      should "not retry on a 429 Too Many Requests when not lock timeout" do
+        refute StripeClient.should_retry?(Stripe::StripeError.new(http_status: 429,
+                                                                  code: "rate_limited"),
+                                          method: :post, num_retries: 0)
+      end
+
       should "not retry on a 500 Internal Server Error when POST" do
         refute StripeClient.should_retry?(Stripe::StripeError.new(http_status: 500),
                                           method: :post, num_retries: 0)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.1.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-20 00:00:00.000000000 Z
+date: 2019-08-27 00:00:00.000000000 Z
 dependencies: []
 description: Stripe is the easiest way to accept payments online.  See https://stripe.com
   for details.