stripe 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa015ad0ee6a063db43580f0234ec2738fe5670c82cfa4843ed3bc91d8eb4670
-  data.tar.gz: f987cba3323dbac56c0121fd0d89d5c282a2b3cab9d46f9284cae99b0093d534
+  metadata.gz: 85172888973b3726ad9e22512ff8b2568306b70d1627c5ee3adafb29c9626e07
+  data.tar.gz: 89344233f7ba4423b5fbc35b30152dec1b5f798931a5b69710d244ea05146b98
 SHA512:
-  metadata.gz: 9b5d25d67c8ade84275d3187988de8660df98d1b2323fa231bc4e1a5ef6dfc9edb2ffcbe71bff404f7a473f4cdde0c5644ec379c625f9a45ea62606792f29871
-  data.tar.gz: ede395b847a59fba4fc3200f174d212c79fa0781222def2323d27cfdec626f3ff869147c2dfc3639206ce9b4d5ff0a282ec92059d04b8ff6b26d619d81655acd
+  metadata.gz: e48a09594870a21082733d2b9a7ef9eb9bc27d757de666bb1fbab25b1aa9143c3ad1c2e610a13199395efd36f8d3b71f1d601dd3e03da1a69911e5be46074c5a
+  data.tar.gz: 1d376a59eb9072debb80e3c17b1fb6961d766f780c5d81b2771773018616ce4a8e049933537a9ba5a334df774b9307fbf0105af790bbc2ee7a0089d54441ee98

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 5.0.1 - 2019-08-20
+* [#836](https://github.com/stripe/stripe-ruby/pull/836) Increase connection keep alive timeout to 30 seconds
+
 ## 5.0.0 - 2019-08-20
 Major version release. The [migration guide](https://github.com/stripe/stripe-ruby/wiki/Migration-guide-for-v5) contains a detailed list of backwards-incompatible changes with upgrade instructions.
 

data/VERSION

@@ -1 +1 @@
-5.0.0
+5.0.1

data/lib/stripe/connection_manager.rb

@@ -11,10 +11,10 @@ module Stripe
   # instantiated once per thread.
   #
   # Note also that this class doesn't currently clean up after itself because
-  # it expects to only ever have a few connections. It'd be possible to tank
-  # memory by constantly changing the value of `Stripe.api_base` or the like. A
-  # possible improvement might be to detect and prune old connections whenever
-  # a request is executed.
+  # it expects to only ever have a few connections (unless `.clear` is called
+  # manually). It'd be possible to tank memory by constantly changing the value
+  # of `Stripe.api_base` or the like. A possible improvement might be to detect
+  # and prune old connections whenever a request is executed.
   class ConnectionManager
     def initialize
       @active_connections = {}
@@ -40,8 +40,6 @@ module Stripe
 
       if connection.nil?
         connection = create_connection(u)
-
-        # TODO: what happens after TTL?
         connection.start
 
         @active_connections[[u.host, u.port]] = connection
@@ -92,6 +90,15 @@ module Stripe
                                  proxy_host, proxy_port,
                                  proxy_user, proxy_pass)
 
+      # Time in seconds within which Net::HTTP will try to reuse an already
+      # open connection when issuing a new operation. Outside this window, Ruby
+      # will transparently close and re-open the connection without trying to
+      # reuse it.
+      #
+      # Ruby's default of 2 seconds is almost certainly too short. Here I've
+      # reused Go's default for `DefaultTransport`.
+      connection.keep_alive_timeout = 30
+
       connection.open_timeout = Stripe.open_timeout
       connection.read_timeout = Stripe.read_timeout
 

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "5.0.0"
+  VERSION = "5.0.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Stripe