stripe 4.8.0 → 4.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f7c24b1f5de9f966aeec73391ac6153cb4c3b44f720c89839b163b3a2d46c4e
-  data.tar.gz: 79ec62aece03a2a98858749d1aaff4fc198b130dbd409a18fd7ba2903322d7c8
+  metadata.gz: baed7f5a4af8684a495ed940bf5759afd72cda87bb1f7f719e76875652aba184
+  data.tar.gz: 21626dd749b9eae3f53018b66de821fc5a2729add10e2a2d6851da54ec237582
 SHA512:
-  metadata.gz: 53be26caee7e296440f78b10e83b87d7ab5e7346932a670b35a92be9bcba9e436812f47e32fc098db76edaada9acde75dcfdc8547d51769a2679609578d32ef5
-  data.tar.gz: f1787c95d33004299cf40f469e793ca8af8072b7243ece7addb581056250f15dba338d8f000b2116623075382b031e79c08d4645fb478d7a9d1df342c27683bd
+  metadata.gz: 4a8be012acf3fe08ceea6e9efe93af0b2f51642d3cddde1eecff86c3a1be869ab2799b9e2e5b25e45dc0e4c4ec39200b3ac83013b0cb17012a400e52ac4c50c2
+  data.tar.gz: 3695f27294ca3f2e423bfc60c067feb4e52a3bc617a36767715f685a66a6411254453010b4594043fb97eedd24d82d7ed1db45aaa37f4ae8d4d89e12e745d1e6

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.8.1 - 2019-02-11
+* [#743](https://github.com/stripe/stripe-ruby/pull/743) Fix bug in file uploading introduced in #741
+
 ## 4.8.0 - 2019-02-03
 * [#741](https://github.com/stripe/stripe-ruby/pull/741) Use `FaradayStripeEncoder` to encode all parameter styles
 

data/VERSION

@@ -1 +1 @@
-4.8.0
+4.8.1

data/lib/stripe/stripe_client.rb

@@ -219,7 +219,7 @@ module Stripe
       # will throw away the result of this encoder and build its body.
       def encode(hash)
         @cache.fetch(hash) do |k|
-          @cache[k] = Util.encode_parameters(replace_faraday_io(hash))
+          @cache[k] = Util.encode_parameters(hash)
         end
       end
 
@@ -227,26 +227,6 @@ module Stripe
       def decode(_str)
         raise NotImplementedError, "#{self.class.name} does not implement #decode"
       end
-
-      # Replaces instances of `Faraday::UploadIO` with a simple string
-      # representation so that they'll log a little better. Faraday won't use
-      # these parameters, so it's okay that we did this.
-      #
-      # Unfortunately the string representation still doesn't look very nice
-      # because we still URL-encode special symbols in the final value. It's
-      # possible we could stop doing this and just leave it to Faraday to do
-      # the right thing.
-      private def replace_faraday_io(value)
-        if value.is_a?(Array)
-          value.each_with_index { |v, i| value[i] = replace_faraday_io(v) }
-        elsif value.is_a?(Hash)
-          value.each { |k, v| value[k] = replace_faraday_io(v) }
-        elsif value.is_a?(Faraday::UploadIO)
-          "FILE:#{value.original_filename}"
-        else
-          value
-        end
-      end
     end
 
     def api_url(url = "", api_base = nil)

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "4.8.0".freeze
+  VERSION = "4.8.1".freeze
 end

data/test/stripe/stripe_client_test.rb

@@ -794,16 +794,6 @@ module Stripe
         assert(!trace_payload["last_request_metrics"]["request_duration_ms"].nil?)
       end
     end
-
-    context "FaradayStripeEncoder" do
-      should "replace Faraday::UploadIO instances in parameters" do
-        encoder = StripeClient::FaradayStripeEncoder.new
-        encoded = encoder.encode(foo: [
-          { file: Faraday::UploadIO.new(::File.new(__FILE__), nil) },
-        ])
-        assert_equal "foo[0][file]=FILE%3Astripe_client_test.rb", encoded
-      end
-    end
   end
 
   class SystemProfilerTest < Test::Unit::TestCase

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 4.8.0
+  version: 4.8.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-03 00:00:00.000000000 Z
+date: 2019-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday