stripe 4.7.0 → 4.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b17c2d9db8be7ccd4a37eb6ad3b17ab7ee1ec20610b390953f0735547c5dc81
-  data.tar.gz: c38f3a4b02c97cbe2f2f9121e1c50fd2bcbe0abd760f7509fbdd48a19d544b37
+  metadata.gz: 7c8260e6865f7cede359b5b5ed870afa289df71b22ec9cb54ee2fd4d2ad7180f
+  data.tar.gz: 7e34b13f458beb6da7efe8860733163e097cb7a0b186ef18aacdf558ec25993d
 SHA512:
-  metadata.gz: 03b19f6e689b28d628b043fa2afadbcb77a22c762062a41537563cb3abc9b5cb037c7b4ee58ac64bd34bef9fcef1f466abe00a47002b8d10b95643c9c9880ad7
-  data.tar.gz: d363f4dd535118bf0759e24efd5c7124fd0c633bfcd83deb5b704e5cbeba3ba8c0d910a14ed35c5206b83cec4751daa5decb6c518ed781703539b07562ce840b
+  metadata.gz: 23733735e3c7835e743208ee72aff1c0c71bc9c424feace8995d3691f86efb9ce61773adb349b18060bfdb32893dd157c37bffdf7f83785cbec920d9f1520453
+  data.tar.gz: e63472b1c8a9a16a0c6974c65fae0d5c664a9c7e9ef53c99285641bd95532b5da0de8007946b0490d96f920fa8af7dbd5707505c3af7611f31b8fbd77b80e97a

data/.rubocop_todo.yml

@@ -8,7 +8,7 @@
 
 # Offense count: 19
 Metrics/AbcSize:
-  Max: 52
+  Max: 53.26
 
 # Offense count: 27
 # Configuration parameters: CountComments, ExcludedMethods.

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 4.7.1 - 2019-02-01
+* [#740](https://github.com/stripe/stripe-ruby/pull/740) Fix query encoding for integer-indexed maps
+
 ## 4.7.0 - 2019-01-23
 * [#735](https://github.com/stripe/stripe-ruby/pull/735) Rename `CheckoutSession` to `Session` and move it under the `Checkout` namespace. This is a breaking change, but we've reached out to affected merchants and all new merchants would use the new approach.
 

data/VERSION

@@ -1 +1 @@
-4.7.0
+4.7.1

data/lib/stripe/stripe_client.rb

@@ -178,7 +178,10 @@ module Stripe
       http_resp = execute_request_with_rescues(api_base, context) do
         conn.run_request(method, url, body, headers) do |req|
           req.options.open_timeout = Stripe.open_timeout
+          req.options.params_encoder = FaradayStripeEncoder
           req.options.timeout = Stripe.read_timeout
+
+          # note that these will be passed through `FaradayStripeEncoder`
           req.params = query_params unless query_params.nil?
         end
       end
@@ -196,6 +199,24 @@ module Stripe
 
     private
 
+    # Used to workaround buggy behavior in Faraday: the library will try to
+    # reshape anything that we pass to `req.params` with one of its default
+    # encoders. I don't think this process is supposed to be lossy, but it is
+    # -- in particular when we send our integer-indexed maps (i.e. arrays),
+    # Faraday ends up stripping out the integer indexes.
+    #
+    # We work around the problem by implementing our own simplified decoder and
+    # telling Faraday to use that.
+    class FaradayStripeEncoder
+      def self.encode(hash)
+        Util.encode_parameters(hash)
+      end
+
+      def self.decode(_str)
+        raise NotImplementedError, "#{self.class.name} does not implement #decode"
+      end
+    end
+
     def api_url(url = "", api_base = nil)
       (api_base || Stripe.api_base) + url
     end

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "4.7.0".freeze
+  VERSION = "4.7.1".freeze
 end

data/test/stripe/invoice_test.rb

@@ -113,10 +113,10 @@ module Stripe
       end
 
       should "retrieve upcoming invoices with items" do
-        items = [{
-          plan: "gold",
-          quantity: 2,
-        },]
+        items = [
+          { plan: "gold", quantity: 2 },
+          { id: "si_123", deleted: true },
+        ]
 
         invoice = Stripe::Invoice.upcoming(
           customer: "cus_123",
@@ -128,6 +128,7 @@ module Stripe
                            customer: "cus_123",
                            subscription_items: [
                              { plan: "gold", quantity: "2" },
+                             { id: "si_123", deleted: true },
                            ],
                          }
         assert invoice.is_a?(Stripe::Invoice)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.7.1
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-23 00:00:00.000000000 Z
+date: 2019-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday