stripe 4.21.2 → 5.0.0

data/test/stripe/connection_manager_test.rb

@@ -0,0 +1,138 @@
+# frozen_string_literal: true
+
+require ::File.expand_path("../test_helper", __dir__)
+
+module Stripe
+  class ConnectionManagerTest < Test::Unit::TestCase
+    setup do
+      @manager = Stripe::ConnectionManager.new
+    end
+
+    context "#clear" do
+      should "clear any active connections" do
+        stub_request(:post, "#{Stripe.api_base}/path")
+          .to_return(body: JSON.generate(object: "account"))
+
+        # Making a request lets us know that at least one connection is open.
+        @manager.execute_request(:post, "#{Stripe.api_base}/path")
+
+        # Now clear the manager.
+        @manager.clear
+
+        # This check isn't great, but it's otherwise difficult to tell that
+        # anything happened with just the public-facing API.
+        assert_equal({}, @manager.instance_variable_get(:@active_connections))
+      end
+    end
+
+    context "#connection_for" do
+      should "correctly initialize a connection" do
+        old_proxy = Stripe.proxy
+
+        old_open_timeout = Stripe.open_timeout
+        old_read_timeout = Stripe.read_timeout
+
+        begin
+          # Make sure any global initialization here is undone in the `ensure`
+          # block below.
+          Stripe.proxy = "http://user:pass@localhost:8080"
+
+          Stripe.open_timeout = 123
+          Stripe.read_timeout = 456
+
+          conn = @manager.connection_for("https://stripe.com")
+
+          # Host/port
+          assert_equal "stripe.com", conn.address
+          assert_equal 443, conn.port
+
+          # Proxy
+          assert_equal "localhost", conn.proxy_address
+          assert_equal 8080, conn.proxy_port
+          assert_equal "user", conn.proxy_user
+          assert_equal "pass", conn.proxy_pass
+
+          # Timeouts
+          assert_equal 123, conn.open_timeout
+          assert_equal 456, conn.read_timeout
+
+          assert_equal true, conn.use_ssl?
+          assert_equal OpenSSL::SSL::VERIFY_PEER, conn.verify_mode
+          assert_equal Stripe.ca_store, conn.cert_store
+        ensure
+          Stripe.proxy = old_proxy
+
+          Stripe.open_timeout = old_open_timeout
+          Stripe.read_timeout = old_read_timeout
+        end
+      end
+
+      should "produce the same connection multiple times" do
+        conn1 = @manager.connection_for("https://stripe.com")
+        conn2 = @manager.connection_for("https://stripe.com")
+
+        assert_equal conn1, conn2
+      end
+
+      should "produce different connections for different hosts" do
+        conn1 = @manager.connection_for("https://example.com")
+        conn2 = @manager.connection_for("https://stripe.com")
+
+        refute_equal conn1, conn2
+      end
+
+      should "produce different connections for different ports" do
+        conn1 = @manager.connection_for("https://stripe.com:80")
+        conn2 = @manager.connection_for("https://stripe.com:443")
+
+        refute_equal conn1, conn2
+      end
+    end
+
+    context "#execute_request" do
+      should "make a request" do
+        stub_request(:post, "#{Stripe.api_base}/path?query=bar")
+          .with(
+            body: "body=foo",
+            headers: { "Stripe-Account" => "bar" }
+          )
+          .to_return(body: JSON.generate(object: "account"))
+
+        @manager.execute_request(:post, "#{Stripe.api_base}/path",
+                                 body: "body=foo",
+                                 headers: { "Stripe-Account" => "bar" },
+                                 query: "query=bar")
+      end
+
+      should "perform basic argument validation" do
+        e = assert_raises ArgumentError do
+          @manager.execute_request("POST", "#{Stripe.api_base}/path")
+        end
+        assert_equal e.message, "method should be a symbol"
+
+        e = assert_raises ArgumentError do
+          @manager.execute_request(:post, :uri)
+        end
+        assert_equal e.message, "uri should be a string"
+
+        e = assert_raises ArgumentError do
+          @manager.execute_request(:post, "#{Stripe.api_base}/path",
+                                   body: {})
+        end
+        assert_equal e.message, "body should be a string"
+
+        e = assert_raises ArgumentError do
+          @manager.execute_request(:post, "#{Stripe.api_base}/path",
+                                   headers: "foo")
+        end
+        assert_equal e.message, "headers should be a hash"
+
+        e = assert_raises ArgumentError do
+          @manager.execute_request(:post, "#{Stripe.api_base}/path",
+                                   query: {})
+        end
+        assert_equal e.message, "query should be a string"
+      end
+    end
+  end
+end

data/test/stripe/customer_test.rb

@@ -53,50 +53,6 @@ module Stripe
       end
     end
 
-    context "#create_subscription" do
-      should "create a new subscription" do
-        customer = Stripe::Customer.retrieve("cus_123")
-        subscription = customer.create_subscription(items: [{ plan: "silver" }])
-        assert_requested :post, "#{Stripe.api_base}/v1/customers/#{customer.id}/subscriptions"
-        assert subscription.is_a?(Stripe::Subscription)
-      end
-    end
-
-    context "#create_upcoming_invoice" do
-      should "create a new invoice" do
-        customer = Stripe::Customer.retrieve("cus_123")
-        invoice = customer.create_upcoming_invoice
-        assert_requested :post, "#{Stripe.api_base}/v1/invoices"
-        assert invoice.is_a?(Stripe::Invoice)
-      end
-    end
-
-    context "#update_subscription" do
-      should "update a subscription" do
-        customer = Stripe::Customer.retrieve("cus_123")
-
-        # deprecated API and not in schema
-        stub_request(:post, "#{Stripe.api_base}/v1/customers/#{customer.id}/subscription")
-          .with(body: { plan: "silver" })
-          .to_return(body: JSON.generate(object: "subscription"))
-        subscription = customer.update_subscription(plan: "silver")
-        assert subscription.is_a?(Stripe::Subscription)
-      end
-    end
-
-    context "#cancel_subscription" do
-      should "cancel a subscription" do
-        customer = Stripe::Customer.retrieve("cus_123")
-
-        # deprecated API and not in schema
-        stub_request(:delete, "#{Stripe.api_base}/v1/customers/#{customer.id}/subscription")
-          .with(query: { at_period_end: "true" })
-          .to_return(body: JSON.generate(object: "subscription"))
-        subscription = customer.cancel_subscription(at_period_end: "true")
-        assert subscription.is_a?(Stripe::Subscription)
-      end
-    end
-
     context "#delete_discount" do
       should "delete a discount" do
         customer = Stripe::Customer.retrieve("cus_123")
@@ -113,6 +69,7 @@ module Stripe
         assert discount.is_a?(Stripe::Discount)
       end
     end
+
     context "#create_source" do
       should "create a source" do
         Stripe::Customer.create_source(

data/test/stripe/errors_test.rb

@@ -4,16 +4,37 @@ require ::File.expand_path("../test_helper", __dir__)
 
 module Stripe
   class StripeErrorTest < Test::Unit::TestCase
-    context "#to_s" do
-      should "convert to string" do
-        e = StripeError.new("message")
-        assert_equal "message", e.to_s
+    context "StripeError" do
+      context "#initialize" do
+        should "initialize error if json_body is set" do
+          e = StripeError.new("message", json_body: { error: { code: "some_error" } })
+          assert_not_nil e.error
+          assert_equal "some_error", e.error.code
+          assert_nil e.error.charge
+        end
+      end
+
+      context "#to_s" do
+        should "convert to string" do
+          e = StripeError.new("message")
+          assert_equal "message", e.to_s
+
+          e = StripeError.new("message", http_status: 200)
+          assert_equal "(Status 200) message", e.to_s
 
-        e = StripeError.new("message", http_status: 200)
-        assert_equal "(Status 200) message", e.to_s
+          e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { request_id: "request-id" })
+          assert_equal "(Request request-id) message", e.to_s
+        end
+      end
+    end
 
-        e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { request_id: "request-id" })
-        assert_equal "(Request request-id) message", e.to_s
+    context "OAuth::OAuthError" do
+      context "#initialize" do
+        should "initialize error if json_body is set" do
+          e = OAuth::OAuthError.new("message", "description", json_body: { error: "some_oauth_error" })
+          assert_not_nil e.error
+          assert_equal "some_oauth_error", e.error.error
+        end
       end
     end
   end

data/test/stripe/file_test.rb

@@ -52,16 +52,6 @@ module Stripe
         assert file.is_a?(Stripe::File)
       end
 
-      should "be creatable with Faraday::UploadIO" do
-        file = Stripe::File.create(
-          purpose: "dispute_evidence",
-          file: Faraday::UploadIO.new(::File.new(__FILE__), nil),
-          file_link_data: { create: true }
-        )
-        assert_requested :post, "#{Stripe.uploads_base}/v1/files"
-        assert file.is_a?(Stripe::File)
-      end
-
       should "be creatable with a string" do
         file = Stripe::File.create(
           purpose: "dispute_evidence",

data/test/stripe/invoice_test.rb

@@ -142,7 +142,7 @@ module Stripe
       end
     end
 
-    context "#upcoming" do
+    context ".upcoming" do
       should "retrieve upcoming invoices" do
         invoice = Stripe::Invoice.upcoming(
           customer: "cus_123",
@@ -192,6 +192,22 @@ module Stripe
       end
     end
 
+    context ".list_upcoming_line_items" do
+      should "retrieve upcoming invoices" do
+        line_items = Stripe::Invoice.list_upcoming_line_items(
+          customer: "cus_123",
+          subscription: "sub_123"
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/invoices/upcoming/lines",
+                         query: {
+                           customer: "cus_123",
+                           subscription: "sub_123",
+                         }
+        assert line_items.data.is_a?(Array)
+        assert line_items.data[0].is_a?(Stripe::InvoiceLineItem)
+      end
+    end
+
     context "#void_invoice" do
       should "void invoice" do
         invoice = Stripe::Invoice.retrieve("in_123")

data/test/stripe/list_object_test.rb

@@ -132,22 +132,6 @@ module Stripe
       next_list = list.previous_page
       assert_equal({ expand: ["data.source"], limit: 3 }, next_list.filters)
     end
-
-    #
-    # backward compatibility
-    #
-
-    # note that the name #all is deprecated, as is using it fetch the next page
-    # in a list
-    should "be able to retrieve full lists given a listobject" do
-      c = Stripe::Charge.all
-      assert c.is_a?(Stripe::ListObject)
-      assert_equal("/v1/charges", c.resource_url)
-      all = c.all
-      assert all.is_a?(Stripe::ListObject)
-      assert_equal("/v1/charges", all.resource_url)
-      assert all.data.is_a?(Array)
-    end
   end
 end
 

data/test/stripe/login_link_test.rb

@@ -12,7 +12,7 @@ module Stripe
           "data" => [],
           "has_more" => false,
           "object" => "list",
-          "url" =>  "/v1/accounts/acct_123/login_links",
+          "url" => "/v1/accounts/acct_123/login_links",
         },
       }
       @account = Stripe::Account.construct_from(account_fixture)

data/test/stripe/multipart_encoder_test.rb

@@ -0,0 +1,130 @@
+# frozen_string_literal: true
+
+require ::File.expand_path("../test_helper", __dir__)
+
+module Stripe
+  class MultipartEncoderTest < Test::Unit::TestCase
+    should "multipart encode parameters" do
+      Tempfile.create("image.jpg") do |f|
+        f.write "file-content"
+        f.flush
+        f.rewind
+
+        encoder = MultipartEncoder.new
+        encoder.encode(
+          file: f,
+          other_param: "other-param-content"
+        )
+        encoder.close
+        body = encoder.body
+
+        assert_equal <<~BODY.rstrip, body
+          --#{encoder.boundary}\r
+          Content-Disposition: form-data; name="file"; filename="#{::File.basename(f.path)}"\r
+          Content-Type: application/octet-stream\r
+          \r
+          file-content\r
+          --#{encoder.boundary}\r
+          Content-Disposition: form-data; name="other_param"\r
+          \r
+          other-param-content\r
+          --#{encoder.boundary}--
+        BODY
+      end
+    end
+
+    should "encode file-like objects" do
+      klass = Class.new do
+        def read
+          "klass-read-content"
+        end
+      end
+
+      encoder = MultipartEncoder.new
+      encoder.encode(
+        file_like: klass.new
+      )
+      encoder.close
+      body = encoder.body
+
+      assert_equal <<~BODY.rstrip, body
+        --#{encoder.boundary}\r
+        Content-Disposition: form-data; name="file_like"; filename="blob"\r
+        Content-Type: application/octet-stream\r
+        \r
+        klass-read-content\r
+        --#{encoder.boundary}--
+      BODY
+    end
+
+    should "escape quotes and line break characters in parameter names" do
+      encoder = MultipartEncoder.new
+      encoder.encode(
+        %("quoted\n\r") => "content"
+      )
+      encoder.close
+      body = encoder.body
+
+      assert_equal <<~BODY.rstrip, body
+        --#{encoder.boundary}\r
+        Content-Disposition: form-data; name="%22quoted  %22"\r
+        \r
+        content\r
+        --#{encoder.boundary}--
+      BODY
+    end
+
+    context ".encode" do
+      should "provide an easy encoding shortcut" do
+        body, content_type = MultipartEncoder.encode(
+          param: "content"
+        )
+        assert_include body, %(Content-Disposition: form-data; name="param")
+        assert_include content_type, "#{MultipartEncoder::MULTIPART_FORM_DATA}; boundary="
+      end
+    end
+
+    context "#body" do
+      should "error if not yet closed" do
+        encoder = MultipartEncoder.new
+
+        e = assert_raises RuntimeError do
+          encoder.body
+        end
+        assert_equal "object must be closed before getting body", e.message
+      end
+    end
+
+    context "#close" do
+      should "error if closed twice" do
+        encoder = MultipartEncoder.new
+        encoder.close
+
+        e = assert_raises RuntimeError do
+          encoder.close
+        end
+        assert_equal "object already closed", e.message
+      end
+    end
+
+    context "#content_type" do
+      should "produce a content type containing boundary" do
+        encoder = MultipartEncoder.new
+        assert_equal "#{MultipartEncoder::MULTIPART_FORM_DATA}; boundary=#{encoder.boundary}",
+                     encoder.content_type
+      end
+    end
+
+    context "#encode" do
+      should "error if already closed" do
+        encoder = MultipartEncoder.new
+        encoder.close
+
+        e = assert_raises RuntimeError do
+          encoder.encode(param: "content")
+        end
+        assert_equal "no more parameters can be written to closed object", e.message
+      end
+    end
+  end
+end

data/test/stripe/payment_intent_test.rb

@@ -4,7 +4,7 @@ require ::File.expand_path("../test_helper", __dir__)
 
 module Stripe
   class PaymentIntentTest < Test::Unit::TestCase
-    TEST_RESOURCE_ID = "pi_123".freeze
+    TEST_RESOURCE_ID = "pi_123"
 
     should "be listable" do
       payment_intents = Stripe::PaymentIntent.list

data/test/stripe/setup_intent_test.rb

@@ -4,7 +4,7 @@ require ::File.expand_path("../test_helper", __dir__)
 
 module Stripe
   class SetupIntentTest < Test::Unit::TestCase
-    TEST_RESOURCE_ID = "seti_123".freeze
+    TEST_RESOURCE_ID = "seti_123"
 
     should "be listable" do
       setup_intents = Stripe::SetupIntent.list

data/test/stripe/source_test.rb

@@ -51,24 +51,6 @@ module Stripe
       end
     end
 
-    context "#delete" do
-      should "warn that #delete is deprecated" do
-        old_stderr = $stderr
-        $stderr = StringIO.new
-        begin
-          source = Stripe::Source.construct_from(customer: "cus_123",
-                                                 id: "src_123",
-                                                 object: "source")
-          source.delete
-          message = "NOTE: Stripe::Source#delete is " \
-                    "deprecated; use #detach instead"
-          assert_match Regexp.new(message), $stderr.string
-        ensure
-          $stderr = old_stderr
-        end
-      end
-    end
-
     should "not be listable" do
       assert_raises NoMethodError do
         Stripe::Source.list