stripe 3.8.2 → 3.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d454a76d37a56cc1ac7249b7b1d6130db55fa1fe
-  data.tar.gz: fa2a235117656908deb0ea747295ef63ae8b92b9
+  metadata.gz: eaa933a4f88560dfadd280faf2e4d1ec83aebd10
+  data.tar.gz: dfcd075aebb73a0cfa1ac9ec67285ecfa7455c7c
 SHA512:
-  metadata.gz: 3e34f48148db809fc089c73bdbdec2481135d3c60a9494959563657e5ddfeeed496a771982c0f56b5c97024aa821ff321afabeac33a9da15d4af99d11342c95b
-  data.tar.gz: 94c23e01ebcb044b4042fd305345a1d962ccd1d5eb9fa67849941c6e8f4079921b1a3ec770175fd89e50be0b0fa0b4940a12c83b79bf507687f791f5fb3673eb
+  metadata.gz: 17ca14c655082ca4e391f0e0b0c9df06bc0055ba4ac28a97d071bff03ffed4b24b72240dcb5851f8bfbca30d3ed5a1211fad99f0af75a64f93b300976573abc3
+  data.tar.gz: f598845295dfeff3ac84cff079d98a62410815b72169182bddbceb81b092725dddf47451c6fe9e77fa448aead3d41dd9bbf348e2f6c0080f20dd829f6f086982

data/.rubocop_todo.yml

@@ -13,12 +13,12 @@ Metrics/AbcSize:
 # Offense count: 27
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 455
+  Max: 467
 
 # Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 583
+  Max: 595
 
 # Offense count: 10
 Metrics/CyclomaticComplexity:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 3.9.0 - 2017-12-08
+* [#613](https://github.com/stripe/stripe-ruby/pull/613) Introduce new `IdempotencyError` type for idempotency-specific failures
+
 ## 3.8.2 - 2017-12-07
 * [#612](https://github.com/stripe/stripe-ruby/pull/612) Fix integer-indexed array encoding when sent as query parameter (subscription items can now be used when fetching an upcoming invoice)
 

data/VERSION

@@ -1 +1 @@
-3.8.2
+3.9.0

data/lib/stripe/errors.rb

@@ -66,6 +66,11 @@ module Stripe
     end
   end
 
+  # IdempotencyError is raised in cases where an idempotency key was used
+  # improperly.
+  class IdempotencyError < StripeError
+  end
+
   # InvalidRequestError is raised when a request is initiated with invalid
   # parameters.
   class InvalidRequestError < StripeError

data/lib/stripe/stripe_client.rb

@@ -280,53 +280,47 @@ module Stripe
     def specific_api_error(resp, error_data, context)
       Util.log_error("Stripe API error",
                      status: resp.http_status,
-                     error_code: error_data["code"],
-                     error_message: error_data["message"],
-                     error_param: error_data["param"],
-                     error_type: error_data["type"],
+                     error_code: error_data[:code],
+                     error_message: error_data[:message],
+                     error_param: error_data[:param],
+                     error_type: error_data[:type],
                      idempotency_key: context.idempotency_key,
                      request_id: context.request_id)
 
+      # The standard set of arguments that can be used to initialize most of
+      # the exceptions.
+      opts = {
+        http_body: resp.http_body,
+        http_headers: resp.http_headers,
+        http_status: resp.http_status,
+        json_body: resp.data,
+      }
+
       case resp.http_status
       when 400, 404
-        error = InvalidRequestError.new(
-          error_data[:message], error_data[:param],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
-        )
+        case error_data[:type]
+        when "idempotency_error"
+          IdempotencyError.new(error_data[:message], opts)
+        else
+          InvalidRequestError.new(
+            error_data[:message], error_data[:param],
+            opts
+          )
+        end
       when 401
-        error = AuthenticationError.new(
-          error_data[:message],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
-        )
+        AuthenticationError.new(error_data[:message], opts)
       when 402
-        error = CardError.new(
+        CardError.new(
           error_data[:message], error_data[:param], error_data[:code],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
+          opts
         )
       when 403
-        error = PermissionError.new(
-          error_data[:message],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
-        )
+        PermissionError.new(error_data[:message], opts)
       when 429
-        error = RateLimitError.new(
-          error_data[:message],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
-        )
+        RateLimitError.new(error_data[:message], opts)
       else
-        error = APIError.new(
-          error_data[:message],
-          http_status: resp.http_status, http_body: resp.http_body,
-          json_body: resp.data, http_headers: resp.http_headers
-        )
+        APIError.new(error_data[:message], opts)
       end
-
-      error
     end
 
     # Attempts to look at a response's error code and return an OAuth error if

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.8.2".freeze
+  VERSION = "3.9.0".freeze
 end

data/test/stripe/stripe_client_test.rb

@@ -242,10 +242,10 @@ module Stripe
           }
           Util.expects(:log_error).with("Stripe API error",
                                         status: 500,
-                                        error_code: error["code"],
-                                        error_message: error["message"],
-                                        error_param: error["param"],
-                                        error_type: error["type"],
+                                        error_code: error[:code],
+                                        error_message: error[:message],
+                                        error_param: error[:param],
+                                        error_type: error[:type],
                                         idempotency_key: nil,
                                         request_id: nil)
 
@@ -411,7 +411,22 @@ module Stripe
           assert_equal 'Invalid response object from API: "{\"bar\":\"foo\"}" (HTTP response code was 500)', e.message
         end
 
-        should "raise InvalidRequestError on 400" do
+        should "raise IdempotencyError on 400 of type idempotency_error" do
+          data = make_missing_id_error
+          data[:error][:type] = "idempotency_error"
+
+          stub_request(:post, "#{Stripe.api_base}/v1/charges")
+            .to_return(body: JSON.generate(data), status: 400)
+          client = StripeClient.new
+
+          e = assert_raises Stripe::IdempotencyError do
+            client.execute_request(:post, "/v1/charges")
+          end
+          assert_equal(400, e.http_status)
+          assert_equal(true, e.json_body.is_a?(Hash))
+        end
+
+        should "raise InvalidRequestError on other 400s" do
           stub_request(:post, "#{Stripe.api_base}/v1/charges")
             .to_return(body: JSON.generate(make_missing_id_error), status: 400)
           client = StripeClient.new

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.8.2
+  version: 3.9.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-07 00:00:00.000000000 Z
+date: 2017-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday