stripe 3.5.3 → 3.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31bc202ae773c518a1f9d9382b08c76df41d4252
-  data.tar.gz: 0a8007b7d10c5c4a7cc4f8721553f58042e7ee9b
+  metadata.gz: fce7c416687a674cc3e18f9bce163fc7d0b33ade
+  data.tar.gz: c0029ea90f92b4efb77a3364d2aa515c3340ed36
 SHA512:
-  metadata.gz: 82412fadaa6d945c754cd1712eebad95cb6fc5ab35564ae7878e1c3d7095e4794821fc44119a45c0bd15c52818301c110b33964665c6fb741c2affd5d08237f1
-  data.tar.gz: cd2a601d172ae2a1eabf23616832d40716eebdea2c00e101a51419e9f06021463aa4abdb6776e6089df47d163ac87bd9659028e198d8da1e2bd2fb0495e5ba2a
+  metadata.gz: 54bc6830f3379c2ed2391ec15fe640af867f2aaf2dfd317b926a059d19aa8539c71387c852a30fdd0724e36d885b01bb43740fed307b7b5cd4a56cf105ceaad0
+  data.tar.gz: ea69c31f24db48ed9a7d37ce133805be8004fa82a92c9deddf6aaad6127fa4d4326d12892f40fe73d60f16ca404e31646a2d896f36f6dae0edd94a8064f325b9

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 3.6.0 - 2017-10-17
+* [#597](https://github.com/stripe/stripe-ruby#597) Add static methods to manipulate resources from parent
+    * `Account` gains methods for external accounts and login links (e.g. `.create_account`, `create_login_link`)
+    * `ApplicationFee` gains methods for refunds
+    * `Customer` gains methods for sources
+    * `Transfer` gains methods for reversals
+
 ## 3.5.3 - 2017-10-16
 * [#594](https://github.com/stripe/stripe-ruby#594) Make sure that `StripeObject`'s `#deep_copy` maintains original class
 * [#595](https://github.com/stripe/stripe-ruby#595) Allow `Object#method` to be called on `StripeObject` even if it conflicts with an accessor

data/VERSION

@@ -1 +1 @@
-3.5.3
+3.6.0

data/lib/stripe.rb

@@ -16,10 +16,11 @@ require "stripe/version"
 
 # API operations
 require "stripe/api_operations/create"
-require "stripe/api_operations/save"
 require "stripe/api_operations/delete"
 require "stripe/api_operations/list"
+require "stripe/api_operations/nested_resource"
 require "stripe/api_operations/request"
+require "stripe/api_operations/save"
 
 # API resource support classes
 require "stripe/errors"

data/lib/stripe/account.rb

@@ -5,10 +5,13 @@ module Stripe
     extend Stripe::APIOperations::List
     include Stripe::APIOperations::Delete
     include Stripe::APIOperations::Save
+    extend Stripe::APIOperations::NestedResource
 
     OBJECT_NAME = "account".freeze
 
     save_nested_resource :external_account
+    nested_resource_class_methods :external_account
+    nested_resource_class_methods :login_link, operations: %i[create]
 
     # This method is deprecated. Please use `#external_account=` instead.
     save_nested_resource :bank_account

data/lib/stripe/api_operations/nested_resource.rb

@@ -0,0 +1,61 @@
+module Stripe
+  module APIOperations
+    # Adds methods to help manipulate a subresource from its parent resource so
+    # that it's possible to do so from a static context (i.e. without a
+    # pre-existing collection of subresources on the parent). 
+    #
+    # For examle, a transfer gains the static methods for reversals so that the
+    # methods `.create_reversal`, `.retrieve_reversal`, `.update_reversal`,
+    # etc. all become available.
+    module NestedResource
+      def nested_resource_class_methods(resource, path: nil, operations: nil)
+        path ||= "#{resource}s"
+        operations ||= %i[create retrieve update delete list]
+
+        resource_url_method = :"#{resource}s_url"
+        define_singleton_method(resource_url_method) do |id, nested_id = nil|
+          url = "#{resource_url}/#{CGI.escape(id)}/#{CGI.escape(path)}"
+          url += "/#{CGI.escape(nested_id)}" unless nested_id.nil?
+          url
+        end
+
+        operations.each do |operation|
+          case operation
+          when :create
+            define_singleton_method(:"create_#{resource}") do |id, params = {}, opts = {}|
+              url = send(resource_url_method, id)
+              resp, opts = request(:post, url, params, opts)
+              Util.convert_to_stripe_object(resp.data, opts)
+            end
+          when :retrieve
+            define_singleton_method(:"retrieve_#{resource}") do |id, nested_id, opts = {}|
+              url = send(resource_url_method, id, nested_id)
+              resp, opts = request(:get, url, {}, opts)
+              Util.convert_to_stripe_object(resp.data, opts)
+            end
+          when :update
+            define_singleton_method(:"update_#{resource}") do |id, nested_id, params = {}, opts = {}|
+              url = send(resource_url_method, id, nested_id)
+              resp, opts = request(:post, url, params, opts)
+              Util.convert_to_stripe_object(resp.data, opts)
+            end
+          when :delete
+            define_singleton_method(:"delete_#{resource}") do |id, nested_id, params = {}, opts = {}|
+              url = send(resource_url_method, id, nested_id)
+              resp, opts = request(:delete, url, params, opts)
+              Util.convert_to_stripe_object(resp.data, opts)
+            end
+          when :list
+            define_singleton_method(:"list_#{resource}s") do |id, params = {}, opts = {}|
+              url = send(resource_url_method, id)
+              resp, opts = request(:get, url, params, opts)
+              Util.convert_to_stripe_object(resp.data, opts)
+            end
+          else
+            raise ArgumentError, "Unknown operation: #{operation.inspect}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/stripe/application_fee.rb

@@ -1,9 +1,12 @@
 module Stripe
   class ApplicationFee < APIResource
     extend Stripe::APIOperations::List
+    extend Stripe::APIOperations::NestedResource
 
     OBJECT_NAME = "application_fee".freeze
 
+    nested_resource_class_methods :refund, operations: %i[create retrieve update list]
+
     def self.resource_url
       "/v1/application_fees"
     end

data/lib/stripe/customer.rb

@@ -4,10 +4,18 @@ module Stripe
     include Stripe::APIOperations::Delete
     include Stripe::APIOperations::Save
     extend Stripe::APIOperations::List
+    extend Stripe::APIOperations::NestedResource
 
     OBJECT_NAME = "customer".freeze
 
     save_nested_resource :source
+    nested_resource_class_methods :source
+
+    # The API request for deleting a card or bank account and for detaching a
+    # source object are the same.
+    class << self
+      alias detach_source delete_source
+    end
 
     def add_invoice_item(params, opts = {})
       opts = @opts.merge(Util.normalize_opts(opts))

data/lib/stripe/transfer.rb

@@ -3,9 +3,12 @@ module Stripe
     extend Stripe::APIOperations::List
     extend Stripe::APIOperations::Create
     include Stripe::APIOperations::Save
+    extend Stripe::APIOperations::NestedResource
 
     OBJECT_NAME = "transfer".freeze
 
+    nested_resource_class_methods :reversal, operations: %i[create retrieve update list]
+
     def cancel
       resp, api_key = request(:post, cancel_url)
       initialize_from(resp.data, api_key)

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.5.3".freeze
+  VERSION = "3.6.0".freeze
 end

data/test/stripe/account_external_accounts_operations_test.rb

@@ -0,0 +1,66 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+module Stripe
+  class AccountExternalAccountsOperationsTest < Test::Unit::TestCase
+    setup do
+      @account_id = "acct_123"
+      @external_account_id = "ba_123"
+    end
+
+    context "#create_external_account" do
+      should "create an external account" do
+        external_account = Stripe::Account.create_external_account(
+          @account_id,
+          external_account: "btok_123"
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/accounts/#{@account_id}/external_accounts"
+        assert external_account.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#retrieve_external_account" do
+      should "retrieve an external account" do
+        external_account = Stripe::Account.retrieve_external_account(
+          @account_id,
+          @external_account_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/accounts/#{@account_id}/external_accounts/#{@external_account_id}"
+        assert external_account.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#update_external_account" do
+      should "update an external account" do
+        external_account = Stripe::Account.update_external_account(
+          @account_id,
+          @external_account_id,
+          metadata: { foo: "bar" }
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/accounts/#{@account_id}/external_accounts/#{@external_account_id}"
+        assert external_account.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#delete_external_account" do
+      should "delete an external_account" do
+        external_account = Stripe::Account.delete_external_account(
+          @account_id,
+          @external_account_id
+        )
+        assert_requested :delete, "#{Stripe.api_base}/v1/accounts/#{@account_id}/external_accounts/#{@external_account_id}"
+        assert external_account.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#list_external_accounts" do
+      should "list the account's external accounts" do
+        external_accounts = Stripe::Account.list_external_accounts(
+          @account_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/accounts/#{@account_id}/external_accounts"
+        assert external_accounts.is_a?(Stripe::ListObject)
+        assert external_accounts.data.is_a?(Array)
+      end
+    end
+  end
+end

data/test/stripe/account_login_links_operations_test.rb

@@ -0,0 +1,19 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+module Stripe
+  class AccountLoginLinksOperationsTest < Test::Unit::TestCase
+    setup do
+      @account_id = "acct_123"
+    end
+
+    context "#create_login_link" do
+      should "create a login link" do
+        login_link = Stripe::Account.create_login_link(
+          @account_id
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/accounts/#{@account_id}/login_links"
+        assert login_link.is_a?(Stripe::LoginLink)
+      end
+    end
+  end
+end

data/test/stripe/api_operations_test.rb

@@ -27,5 +27,49 @@ module Stripe
         assert_equal "Cannot update protected field: protected", e.message
       end
     end
+
+    context ".nested_resource_class_methods" do
+      class MainResource < APIResource
+        extend Stripe::APIOperations::NestedResource
+        nested_resource_class_methods :nested
+      end
+
+      should "define a create method" do
+        stub_request(:post, "#{Stripe.api_base}/v1/mainresources/id/nesteds")
+          .with(body: { foo: "bar" })
+          .to_return(body: JSON.generate(id: "nested_id", object: "nested", foo: "bar"))
+        nested_resource = MainResource.create_nested("id", foo: "bar")
+        assert_equal "bar", nested_resource.foo
+      end
+
+      should "define a retrieve method" do
+        stub_request(:get, "#{Stripe.api_base}/v1/mainresources/id/nesteds/nested_id")
+          .to_return(body: JSON.generate(id: "nested_id", object: "nested", foo: "bar"))
+        nested_resource = MainResource.retrieve_nested("id", "nested_id")
+        assert_equal "bar", nested_resource.foo
+      end
+
+      should "define an update method" do
+        stub_request(:post, "#{Stripe.api_base}/v1/mainresources/id/nesteds/nested_id")
+          .with(body: { foo: "baz" })
+          .to_return(body: JSON.generate(id: "nested_id", object: "nested", foo: "baz"))
+        nested_resource = MainResource.update_nested("id", "nested_id", foo: "baz")
+        assert_equal "baz", nested_resource.foo
+      end
+
+      should "define a delete method" do
+        stub_request(:delete, "#{Stripe.api_base}/v1/mainresources/id/nesteds/nested_id")
+          .to_return(body: JSON.generate(id: "nested_id", object: "nested", deleted: true))
+        nested_resource = MainResource.delete_nested("id", "nested_id")
+        assert_equal true, nested_resource.deleted
+      end
+
+      should "define a list method" do
+        stub_request(:get, "#{Stripe.api_base}/v1/mainresources/id/nesteds")
+          .to_return(body: JSON.generate(object: "list", data: []))
+        nested_resources = MainResource.list_nesteds("id")
+        assert nested_resources.data.is_a?(Array)
+      end
+    end
   end
 end

data/test/stripe/application_fee_refunds_operations_test.rb

@@ -0,0 +1,54 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+module Stripe
+  class ApplicationFeeRefundsOperationsTest < Test::Unit::TestCase
+    setup do
+      @application_fee_id = "fee_123"
+      @refund_id = "fr_123"
+    end
+
+    context "#create_refund" do
+      should "create a refund" do
+        refund = Stripe::ApplicationFee.create_refund(
+          @application_fee_id
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/application_fees/#{@application_fee_id}/refunds"
+        assert refund.is_a?(Stripe::ApplicationFeeRefund)
+      end
+    end
+
+    context "#retrieve_refund" do
+      should "retrieve a refund" do
+        refund = Stripe::ApplicationFee.retrieve_refund(
+          @application_fee_id,
+          @refund_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/application_fees/#{@application_fee_id}/refunds/#{@refund_id}"
+        assert refund.is_a?(Stripe::ApplicationFeeRefund)
+      end
+    end
+
+    context "#update_refund" do
+      should "update a refund" do
+        refund = Stripe::ApplicationFee.update_refund(
+          @application_fee_id,
+          @refund_id,
+          metadata: { foo: "bar" }
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/application_fees/#{@application_fee_id}/refunds/#{@refund_id}"
+        assert refund.is_a?(Stripe::ApplicationFeeRefund)
+      end
+    end
+
+    context "#list_refunds" do
+      should "list the application fee's refuns" do
+        refunds = Stripe::ApplicationFee.list_refunds(
+          @application_fee_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/application_fees/#{@application_fee_id}/refunds"
+        assert refunds.is_a?(Stripe::ListObject)
+        assert refunds.data.is_a?(Array)
+      end
+    end
+  end
+end

data/test/stripe/customer_sources_operations_test.rb

@@ -0,0 +1,66 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+module Stripe
+  class CustomerSourcesOperationsTest < Test::Unit::TestCase
+    setup do
+      @customer_id = "cus_123"
+      @source_id = "ba_123"
+    end
+
+    context "#create_source" do
+      should "create a source" do
+        source = Stripe::Customer.create_source(
+          @customer_id,
+          source: "tok_123"
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/customers/#{@customer_id}/sources"
+        assert source.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#retrieve_source" do
+      should "retrieve a source" do
+        source = Stripe::Customer.retrieve_source(
+          @customer_id,
+          @source_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/customers/#{@customer_id}/sources/#{@source_id}"
+        assert source.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#update_source" do
+      should "update a source" do
+        source = Stripe::Customer.update_source(
+          @customer_id,
+          @source_id,
+          metadata: { foo: "bar" }
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/customers/#{@customer_id}/sources/#{@source_id}"
+        assert source.is_a?(Stripe::Card)
+      end
+    end
+
+    context "#delete_source" do
+      should "delete a source" do
+        source = Stripe::Customer.delete_source(
+          @customer_id,
+          @source_id
+        )
+        assert_requested :delete, "#{Stripe.api_base}/v1/customers/#{@customer_id}/sources/#{@source_id}"
+        assert source.is_a?(Stripe::BankAccount)
+      end
+    end
+
+    context "#list_sources" do
+      should "list the customer's sources" do
+        sources = Stripe::Customer.list_sources(
+          @customer_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/customers/#{@customer_id}/sources"
+        assert sources.is_a?(Stripe::ListObject)
+        assert sources.data.is_a?(Array)
+      end
+    end
+  end
+end

data/test/stripe/transfer_reversals_operations_test.rb

@@ -0,0 +1,55 @@
+require File.expand_path("../../test_helper", __FILE__)
+
+module Stripe
+  class TransferReversalsOperationsTest < Test::Unit::TestCase
+    setup do
+      @transfer_id = "tr_123"
+      @reversal_id = "trr_123"
+    end
+
+    context "#create_reversal" do
+      should "create a reversal" do
+        reversal = Stripe::Transfer.create_reversal(
+          @transfer_id,
+          amount: 100
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/transfers/#{@transfer_id}/reversals"
+        assert reversal.is_a?(Stripe::Reversal)
+      end
+    end
+
+    context "#retrieve_reversal" do
+      should "retrieve a reversal" do
+        reversal = Stripe::Transfer.retrieve_reversal(
+          @transfer_id,
+          @reversal_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/transfers/#{@transfer_id}/reversals/#{@reversal_id}"
+        assert reversal.is_a?(Stripe::Reversal)
+      end
+    end
+
+    context "#update_reversal" do
+      should "update a reversal" do
+        reversal = Stripe::Transfer.update_reversal(
+          @transfer_id,
+          @reversal_id,
+          metadata: { foo: "bar" }
+        )
+        assert_requested :post, "#{Stripe.api_base}/v1/transfers/#{@transfer_id}/reversals/#{@reversal_id}"
+        assert reversal.is_a?(Stripe::Reversal)
+      end
+    end
+
+    context "#list_reversals" do
+      should "list the transfer's reversals" do
+        reversals = Stripe::Transfer.list_reversals(
+          @transfer_id
+        )
+        assert_requested :get, "#{Stripe.api_base}/v1/transfers/#{@transfer_id}/reversals"
+        assert reversals.is_a?(Stripe::ListObject)
+        assert reversals.data.is_a?(Array)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.5.3
+  version: 3.6.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-16 00:00:00.000000000 Z
+date: 2017-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -54,6 +54,7 @@ files:
 - lib/stripe/api_operations/create.rb
 - lib/stripe/api_operations/delete.rb
 - lib/stripe/api_operations/list.rb
+- lib/stripe/api_operations/nested_resource.rb
 - lib/stripe/api_operations/request.rb
 - lib/stripe/api_operations/save.rb
 - lib/stripe/api_resource.rb
@@ -106,12 +107,15 @@ files:
 - lib/stripe/webhook.rb
 - stripe.gemspec
 - test/api_stub_helpers.rb
+- test/stripe/account_external_accounts_operations_test.rb
+- test/stripe/account_login_links_operations_test.rb
 - test/stripe/account_test.rb
 - test/stripe/alipay_account_test.rb
 - test/stripe/api_operations_test.rb
 - test/stripe/api_resource_test.rb
 - test/stripe/apple_pay_domain_test.rb
 - test/stripe/application_fee_refund_test.rb
+- test/stripe/application_fee_refunds_operations_test.rb
 - test/stripe/application_fee_test.rb
 - test/stripe/balance_test.rb
 - test/stripe/bank_account_test.rb
@@ -119,6 +123,7 @@ files:
 - test/stripe/country_spec_test.rb
 - test/stripe/coupon_test.rb
 - test/stripe/customer_card_test.rb
+- test/stripe/customer_sources_operations_test.rb
 - test/stripe/customer_test.rb
 - test/stripe/dispute_test.rb
 - test/stripe/ephemeral_key_test.rb
@@ -146,6 +151,7 @@ files:
 - test/stripe/subscription_item_test.rb
 - test/stripe/subscription_test.rb
 - test/stripe/three_d_secure_test.rb
+- test/stripe/transfer_reversals_operations_test.rb
 - test/stripe/transfer_test.rb
 - test/stripe/util_test.rb
 - test/stripe/webhook_test.rb
@@ -178,12 +184,15 @@ specification_version: 4
 summary: Ruby bindings for the Stripe API
 test_files:
 - test/api_stub_helpers.rb
+- test/stripe/account_external_accounts_operations_test.rb
+- test/stripe/account_login_links_operations_test.rb
 - test/stripe/account_test.rb
 - test/stripe/alipay_account_test.rb
 - test/stripe/api_operations_test.rb
 - test/stripe/api_resource_test.rb
 - test/stripe/apple_pay_domain_test.rb
 - test/stripe/application_fee_refund_test.rb
+- test/stripe/application_fee_refunds_operations_test.rb
 - test/stripe/application_fee_test.rb
 - test/stripe/balance_test.rb
 - test/stripe/bank_account_test.rb
@@ -191,6 +200,7 @@ test_files:
 - test/stripe/country_spec_test.rb
 - test/stripe/coupon_test.rb
 - test/stripe/customer_card_test.rb
+- test/stripe/customer_sources_operations_test.rb
 - test/stripe/customer_test.rb
 - test/stripe/dispute_test.rb
 - test/stripe/ephemeral_key_test.rb
@@ -218,6 +228,7 @@ test_files:
 - test/stripe/subscription_item_test.rb
 - test/stripe/subscription_test.rb
 - test/stripe/three_d_secure_test.rb
+- test/stripe/transfer_reversals_operations_test.rb
 - test/stripe/transfer_test.rb
 - test/stripe/util_test.rb
 - test/stripe/webhook_test.rb