stripe 3.4.1 → 3.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce403b39d687753c9cf663b0288dfa87c0d42587
-  data.tar.gz: c070e94e6a67f23ba5c0cdcc4f20cf8b48003a56
+  metadata.gz: 318be0fcbe32bab36c77a9390c936aba1735106a
+  data.tar.gz: b060b65d599adf9a51cb6c0d9f1ba81b3a6acc5c
 SHA512:
-  metadata.gz: ae59948a1870bddb75f90057936a65903157625ee4dc42d00b72aad628d0dbe0ee92e81a9dbe9efd55c12b57a7b5dd7f7988fdb282862a8fcd204c927574148a
-  data.tar.gz: 45fd78747f6151a4fa74b64c0bdf6f89e6d68fc9735e1a694fa75c0df46812032b41ac82589bff93ae6fb68022d57089c420ff929ab202a9699d287679b650ab
+  metadata.gz: 83a649dc5dcdb5c62511afcad9367fb4368078950de40ad1e0472250eb4d1521034f27dd98740a759e4694937bf648aac692d2d6546687537e8bf9934fe0e17a
+  data.tar.gz: 8695ec3cf4e68d269c5e9826af93a50f2e61db554d4f2898035aacdf178240f7ed3ccd4f8fc4cd408a398f72d3ea428ed6bbd115d8e323357c41cb05d384b192

data/History.txt

@@ -1,3 +1,7 @@
+=== 3.5.0 2017-10-11
+
+* [#589] Add support for detaching sources fromm customers
+
 === 3.4.1 2017-10-05
 
 * [#586] Log query strings as well as form bodies with STRIPE_LOG

data/VERSION

@@ -1 +1 @@
-3.4.1
+3.5.0

data/lib/stripe/source.rb

@@ -5,12 +5,11 @@ module Stripe
 
     OBJECT_NAME = "source".freeze
 
-    def delete(params = {}, opts = {})
+    def detach(params = {}, opts = {})
       if !respond_to?(:customer) || customer.nil? || customer.empty?
         raise NotImplementedError,
-              "Source objects cannot be deleted, they can only be detached " \
-              "from customer objects. This source object does not appear to " \
-              "be currently attached to a customer object."
+              "This source object does not appear to be currently attached " \
+              "to a customer object."
       end
 
       url = "#{Customer.resource_url}/#{CGI.escape(customer)}/sources/#{CGI.escape(id)}"
@@ -18,6 +17,12 @@ module Stripe
       initialize_from(resp.data, opts)
     end
 
+    def delete(params = {}, opts = {})
+      detach(params, opts)
+    end
+    extend Gem::Deprecate
+    deprecate :delete, "#detach", 2017, 10
+
     def verify(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/verify", params, Util.normalize_opts(opts))
       initialize_from(resp.data, opts)

data/lib/stripe/version.rb

@@ -1,3 +1,3 @@
 module Stripe
-  VERSION = "3.4.1".freeze
+  VERSION = "3.5.0".freeze
 end

data/test/stripe/source_test.rb

@@ -30,12 +30,12 @@ module Stripe
       assert source.is_a?(Stripe::Source)
     end
 
-    context "#delete" do
+    context "#detach" do
       should "not be deletable when unattached" do
         source = Stripe::Source.retrieve("src_123")
 
         assert_raises NotImplementedError do
-          source.delete
+          source.detach
         end
       end
 
@@ -43,12 +43,30 @@ module Stripe
         source = Stripe::Source.construct_from(customer: "cus_123",
                                                id: "src_123",
                                                object: "source")
-        source = source.delete
+        source = source.detach
         assert_requested :delete, "#{Stripe.api_base}/v1/customers/cus_123/sources/src_123"
         assert source.is_a?(Stripe::Source)
       end
     end
 
+    context "#delete" do
+      should "warn that #delete is deprecated" do
+        old_stderr = $stderr
+        $stderr = StringIO.new
+        begin
+          source = Stripe::Source.construct_from(customer: "cus_123",
+                                                 id: "src_123",
+                                                 object: "source")
+          source.delete
+          message = "NOTE: Stripe::Source#delete is " \
+                    "deprecated; use #detach instead"
+          assert_match Regexp.new(message), $stderr.string
+        ensure
+          $stderr = old_stderr
+        end
+      end
+    end
+
     should "not be listable" do
       assert_raises NoMethodError do
         Stripe::Source.list

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 3.5.0
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-05 00:00:00.000000000 Z
+date: 2017-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday