stripe 3.31.1 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25ebfbf84bcee0acb6cab757e949ab8654b7e41d
-  data.tar.gz: '09546cf8adf0ad0dbfabd54675e256edfabdfab5'
+  metadata.gz: d48581c1171216fe7ef9531bec2b538d86c9efa3
+  data.tar.gz: 52b3b1afca13937918ba3e18b3bbdceeece78119
 SHA512:
-  metadata.gz: c10a085b2465b5da8ba4490d6c34cd25be875fa5bdb0de22e4e02c25b457d7d57bf8476c8126c0a2f1c7df9d4f0b4a401f0341b0bc2b230cd3cc535b40e40f9d
-  data.tar.gz: 6779c4a2e3561ec53bc52a929cb51c17d9b17b2eea2ffb35f511924a84a8690be9f32022055de581d165a34d45adb2e74598583ae532cd13a5e47db3277e0ef4
+  metadata.gz: 23ed293fa6fe762582cb8eb6fc544324e15d414775a7cd7c7ccd43ab2d0eef8b1686a1d2acdd65c31a90b94c503e6a29212df7fd61a2b0ddbb5b8fa6a8a2da15
+  data.tar.gz: 8682b7258691c520754931d7a3e09b4c9cb2291c96f01753f8fbcbb81f307aa8fedcdc64272a312be50b0675499a6c6f59028899070b5193bc050612d4393c12

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 
 rvm:
-  - 2.0
   - 2.1
   - 2.2
   - 2.3

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 4.0.3 - 2018-11-19
+* [#703](https://github.com/stripe/stripe-ruby/pull/703) Don't use `Net::HTTP::Persistent` on Windows where it's not well supported
+
+## 4.0.2 - 2018-11-16
+* [#701](https://github.com/stripe/stripe-ruby/pull/701) Require minimum Faraday 0.13 for proper support of persistent connections
+
+## 4.0.1 - 2018-11-15
+* [#699](https://github.com/stripe/stripe-ruby/pull/699) Only send telemetry if `Request-Id` was present in the response
+
+## 4.0.0 - 2018-11-15
+* [#698](https://github.com/stripe/stripe-ruby/pull/698) Use persistent connections by default through `Net::HTTP::Persistent`
+* [#698](https://github.com/stripe/stripe-ruby/pull/698) Drop support for Ruby 2.0 (which we consider a breaking change here)
+
 ## 3.31.1 - 2018-11-12
 * [#697](https://github.com/stripe/stripe-ruby/pull/697) Send telemetry in milliseconds specifically
 

data/Gemfile

@@ -24,18 +24,14 @@ group :development do
   # older Ruby versions. Check Ruby the version here and put a maximum
   # constraint on Rack if necessary.
   if RUBY_VERSION >= "2.2.2"
-    gem "rack", ">= 1.5"
+    gem "rack", ">= 2.0.6"
   else
-    gem "rack", ">= 1.5", "< 2.0" # rubocop:disable Bundler/DuplicatedGem
+    gem "rack", ">= 1.6.11", "< 2.0" # rubocop:disable Bundler/DuplicatedGem
   end
 
   platforms :mri do
-    # to avoid problems, bring Byebug in on just versions of Ruby under which
-    # it's known to work well
-    if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new("2.0.0")
-      gem "byebug"
-      gem "pry"
-      gem "pry-byebug"
-    end
+    gem "byebug"
+    gem "pry"
+    gem "pry-byebug"
   end
 end

data/VERSION

@@ -1 +1 @@
-3.31.1
+4.0.3

data/lib/stripe/stripe_client.rb

@@ -31,11 +31,18 @@ module Stripe
       # of connection re-use, so make sure that we have a separate connection
       # object per thread.
       Thread.current[:stripe_client_default_conn] ||= begin
-        conn = Faraday.new do |c|
-          c.use Faraday::Request::Multipart
-          c.use Faraday::Request::UrlEncoded
-          c.use Faraday::Response::RaiseError
-          c.adapter Faraday.default_adapter
+        conn = Faraday.new do |builder|
+          builder.use Faraday::Request::Multipart
+          builder.use Faraday::Request::UrlEncoded
+          builder.use Faraday::Response::RaiseError
+
+          # Net::HTTP::Persistent doesn't seem to do well on Windows or JRuby,
+          # so fall back to default there.
+          if Gem.win_platform? || RUBY_PLATFORM == "java"
+            builder.adapter :net_http
+          else
+            builder.adapter :net_http_persistent
+          end
         end
 
         if Stripe.verify_ssl_certs
@@ -218,7 +225,8 @@ module Stripe
         resp = yield
         context = context.dup_from_response(resp)
         log_response(context, request_start, resp.status, resp.body)
-        if Stripe.enable_telemetry?
+
+        if Stripe.enable_telemetry? && context.request_id
           request_duration_ms = ((Time.now - request_start) * 1000).to_int
           @last_request_metrics = StripeRequestMetrics.new(context.request_id, request_duration_ms)
         end

data/lib/stripe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Stripe
-  VERSION = "3.31.1".freeze
+  VERSION = "4.0.3".freeze
 end

data/stripe.gemspec

@@ -7,7 +7,7 @@ require "stripe/version"
 Gem::Specification.new do |s|
   s.name = "stripe"
   s.version = Stripe::VERSION
-  s.required_ruby_version = ">= 2.0.0"
+  s.required_ruby_version = ">= 2.1.0"
   s.summary = "Ruby bindings for the Stripe API"
   s.description = "Stripe is the easiest way to accept payments online.  See https://stripe.com for details."
   s.author = "Stripe"
@@ -15,7 +15,8 @@ Gem::Specification.new do |s|
   s.homepage = "https://stripe.com/docs/api/ruby"
   s.license = "MIT"
 
-  s.add_dependency("faraday", "~> 0.10")
+  s.add_dependency("faraday", "~> 0.13")
+  s.add_dependency("net-http-persistent", "~> 3.0")
 
   s.files = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- test/*`.split("\n")

data/test/test_helper.rb

@@ -27,7 +27,8 @@ WebMock.disable_net_connect!(allow: "localhost:#{MOCK_PORT}")
 # we can print one error and fail fast so that it's more clear to the user how
 # they should fix the problem.
 begin
-  resp = Faraday.get("http://localhost:#{MOCK_PORT}/")
+  conn = Faraday::Connection.new("http://localhost:#{MOCK_PORT}")
+  resp = conn.get("/")
   version = resp.headers["Stripe-Mock-Version"]
   if version != "master" &&
      Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stripe
 version: !ruby/object:Gem::Version
-  version: 3.31.1
+  version: 4.0.3
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-13 00:00:00.000000000 Z
+date: 2018-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.13'
+- !ruby/object:Gem::Dependency
+  name: net-http-persistent
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: Stripe is the easiest way to accept payments online.  See https://stripe.com
   for details.
 email: support@stripe.com
@@ -215,7 +229,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="